[{"id":27489,"web_url":"https://patchwork.libcamera.org/comment/27489/","msgid":"<20230706074823.GD11949@pendragon.ideasonboard.com>","date":"2023-07-06T07:48:23","subject":"Re: [libcamera-devel] [PATCH] meson: Fix space around colon issues","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jul 06, 2023 at 10:30:04AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The meson style, which libcamera follows, mandates a space before\n> colons. Fix the style violations through the project.\n\nThe meson style isn't as coherent and universally enforced as this\nimplies. I'll rewrite the commit message as\n\nThe meson style, which libcamera follows, recommends a space before\ncolons in function parameters. Fix the style violations through the\nproject.\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  Documentation/meson.build              |  8 ++++----\n>  include/libcamera/base/meson.build     |  2 +-\n>  include/libcamera/internal/meson.build |  6 +++---\n>  include/libcamera/ipa/meson.build      |  2 +-\n>  meson.build                            | 12 ++++++------\n>  meson_options.txt                      |  4 ++--\n>  src/apps/qcam/meson.build              |  4 ++--\n>  src/gstreamer/meson.build              |  2 +-\n>  src/libcamera/meson.build              |  4 ++--\n>  src/py/libcamera/meson.build           |  4 ++--\n>  test/gstreamer/meson.build             |  2 +-\n>  test/stream/meson.build                |  2 +-\n>  12 files changed, 26 insertions(+), 26 deletions(-)\n> \n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index d675f368cf79..b2a5bf15e6ea 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -92,8 +92,8 @@ if sphinx.found()\n>                    install_dir : doc_install_dir)\n>  \n>      custom_target('documentation-linkcheck',\n> -                  command: [sphinx, '-W', '-b', 'linkcheck', meson.current_source_dir(), '@OUTPUT@'],\n> -                  build_always_stale: true,\n> -                  input: docs_sources,\n> -                  output: 'linkcheck')\n> +                  command : [sphinx, '-W', '-b', 'linkcheck', meson.current_source_dir(), '@OUTPUT@'],\n> +                  build_always_stale : true,\n> +                  input : docs_sources,\n> +                  output : 'linkcheck')\n>  endif\n> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> index 872de211d4a8..bace25d56b13 100644\n> --- a/include/libcamera/base/meson.build\n> +++ b/include/libcamera/base/meson.build\n> @@ -37,4 +37,4 @@ libcamera_base_headers = [\n>  ]\n>  \n>  install_headers(libcamera_base_public_headers,\n> -                subdir: libcamera_base_include_dir)\n> +                subdir : libcamera_base_include_dir)\n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index 4b2756a4a251..7f1f344014c4 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -4,9 +4,9 @@ subdir('tracepoints')\n>  \n>  libcamera_tracepoint_header = custom_target(\n>      'tp_header',\n> -    input: ['tracepoints.h.in', tracepoint_files],\n> -    output: 'tracepoints.h',\n> -    command: [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> +    input : ['tracepoints.h.in', tracepoint_files],\n> +    output : 'tracepoints.h',\n> +    command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n>  )\n>  \n>  libcamera_internal_headers = files([\n> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n> index 6a5ae68633d7..e72803b4e243 100644\n> --- a/include/libcamera/ipa/meson.build\n> +++ b/include/libcamera/ipa/meson.build\n> @@ -9,7 +9,7 @@ libcamera_ipa_headers = files([\n>  ])\n>  \n>  install_headers(libcamera_ipa_headers,\n> -                subdir: libcamera_ipa_include_dir)\n> +                subdir : libcamera_ipa_include_dir)\n>  \n>  libcamera_generated_ipa_headers = []\n>  \n> diff --git a/meson.build b/meson.build\n> index 62db8ed8105d..29777529a0d9 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -20,7 +20,7 @@ project('libcamera', 'c', 'cpp',\n>  libcamera_git_version = run_command('utils/gen-version.sh',\n>                                      meson.project_build_root(),\n>                                      meson.project_source_root(),\n> -                                    check: false).stdout().strip()\n> +                                    check : false).stdout().strip()\n>  \n>  # If the source tree isn't under git control, set libcamera_git_version to the\n>  # meson project version.\n> @@ -49,7 +49,7 @@ if libcamera_version != project_version\n>                                          meson.project_build_root(),\n>                                          meson.project_source_root(),\n>                                          project_version,\n> -                                        check: false).stdout().strip()\n> +                                        check : false).stdout().strip()\n>      libcamera_version = project_version\n>  \n>      # Append a marker to show we have modified this version string.\n> @@ -109,7 +109,7 @@ if cc.get_id() == 'clang'\n>  \n>      # Use libc++ by default if available instead of libstdc++ when compiling\n>      # with clang.\n> -    if cc.find_library('libc++', required: false).found()\n> +    if cc.find_library('libc++', required : false).found()\n>          cpp_arguments += [\n>              '-stdlib=libc++',\n>          ]\n> @@ -236,7 +236,7 @@ subdir('test')\n>  \n>  if not meson.is_cross_build()\n>      kernel_version_req = '>= 5.0.0'\n> -    kernel_version = run_command('uname', '-r', check: true).stdout().strip()\n> +    kernel_version = run_command('uname', '-r', check : true).stdout().strip()\n>      if not kernel_version.version_compare(kernel_version_req)\n>          warning('The current running kernel version @0@ is too old to run libcamera.'\n>                  .format(kernel_version))\n> @@ -249,13 +249,13 @@ endif\n>  # running libcamera from the build directory to locate resources in the source\n>  # directory (such as IPA configuration files).\n>  run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source',\n> -            check: true)\n> +            check : true)\n>  \n>  configure_file(output : 'config.h', configuration : config_h)\n>  \n>  # Check for python installation and modules.\n>  py_mod = import('python')\n> -py_mod.find_installation('python3', modules: py_modules)\n> +py_mod.find_installation('python3', modules : py_modules)\n>  \n>  ## Summarise Configurations\n>  summary({\n> diff --git a/meson_options.txt b/meson_options.txt\n> index c8cd53b49ba1..4405b401d7d3 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -59,12 +59,12 @@ option('qcam',\n>  option('test',\n>          type : 'boolean',\n>          value : false,\n> -        description: 'Compile and include the tests')\n> +        description : 'Compile and include the tests')\n>  \n>  option('tracing',\n>          type : 'feature',\n>          value : 'auto',\n> -        description: 'Enable tracing (based on lttng)')\n> +        description : 'Enable tracing (based on lttng)')\n>  \n>  option('v4l2',\n>          type : 'boolean',\n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index eb0712d91351..2e77146cf73c 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -57,9 +57,9 @@ if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n>      qt5_cpp_args += ['-Wno-deprecated-copy']\n>  endif\n>  \n> -resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> +resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n>                             qresources : qcam_resources,\n> -                           dependencies: qt5_dep)\n> +                           dependencies : qt5_dep)\n>  \n>  qcam  = executable('qcam', qcam_sources, resources,\n>                     install : true,\n> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> index 77c79140eb37..20784b71883d 100644\n> --- a/src/gstreamer/meson.build\n> +++ b/src/gstreamer/meson.build\n> @@ -43,6 +43,6 @@ libcamera_gst = shared_library('gstlibcamera',\n>      libcamera_gst_sources,\n>      cpp_args : libcamera_gst_cpp_args,\n>      dependencies : [libcamera_public, gstvideo_dep, gstallocator_dep],\n> -    install: true,\n> +    install : true,\n>      install_dir : '@0@/gstreamer-1.0'.format(get_option('libdir')),\n>  )\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 3cd424779395..38fbb41e7d6c 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -93,9 +93,9 @@ endif\n>  if not libcrypto.found()\n>      warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')\n>      summary({'IPA modules signed with': 'None (modules will run isolated)'},\n> -            section: 'Configuration')\n> +            section : 'Configuration')\n>  else\n> -    summary({'IPA modules signed with': libcrypto.name()}, section: 'Configuration')\n> +    summary({'IPA modules signed with' : libcrypto.name()}, section : 'Configuration')\n>  endif\n>  \n>  if liblttng.found()\n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index b38a57d73c85..f58c7198ee9e 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -93,11 +93,11 @@ pycamera = shared_module('_libcamera',\n>  \n>  run_command('ln', '-fsrT', files('__init__.py'),\n>              meson.current_build_dir() / '__init__.py',\n> -            check: true)\n> +            check : true)\n>  \n>  run_command('ln', '-fsrT', meson.current_source_dir() / 'utils',\n>              meson.current_build_dir() / 'utils',\n> -            check: true)\n> +            check : true)\n>  \n>  install_data(['__init__.py'], install_dir : destdir)\n>  \n> diff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build\n> index 745725864eef..64a632df8a37 100644\n> --- a/test/gstreamer/meson.build\n> +++ b/test/gstreamer/meson.build\n> @@ -8,7 +8,7 @@ gstreamer_tests = [\n>      {'name': 'single_stream_test', 'sources': ['gstreamer_single_stream_test.cpp']},\n>      {'name': 'multi_stream_test', 'sources': ['gstreamer_multi_stream_test.cpp']},\n>  ]\n> -gstreamer_dep = dependency('gstreamer-1.0', required: true)\n> +gstreamer_dep = dependency('gstreamer-1.0', required : true)\n>  \n>  foreach test : gstreamer_tests\n>      exe = executable(test['name'], test['sources'], 'gstreamer_test.cpp',\n> diff --git a/test/stream/meson.build b/test/stream/meson.build\n> index a3b19bf592a5..dd77f2f7195b 100644\n> --- a/test/stream/meson.build\n> +++ b/test/stream/meson.build\n> @@ -10,5 +10,5 @@ foreach test : stream_tests\n>                       dependencies : libcamera_public,\n>                       link_with : test_libraries,\n>                       include_directories : test_includes_internal)\n> -    test(test['name'], exe, suite: 'stream')\n> +    test(test['name'], exe, suite : 'stream')\n>  endforeach\n> \n> base-commit: d06ed87d49ca3d734fd1c2f1409280abb499c625","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C3EFC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  6 Jul 2023 07:48:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B11A4628C0;\n\tThu,  6 Jul 2023 09:48:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57F1561E33\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  6 Jul 2023 09:48:24 +0200 (CEST)","from pendragon.ideasonboard.com (85-160-25-222.reb.o2.cz\n\t[85.160.25.222])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D84E46C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  6 Jul 2023 09:47:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688629705;\n\tbh=r42D2T7iQwwgSYXhJoR9jZbZW0P5zG5fEuGc6ppa1TQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ak8hdkQRTaqtsioJRp75dzyLESvRahi99VA93ZE9MVdu2n3FcHqO2DNUnbyBrLkrH\n\ti5oIZYbawyVuzFm79OxqQRQW2/VvIG8X0M7obL4DrTUPU8mkqadwy5hg392MKqAOnw\n\t57jcBzvrwJt9ENvnDGuCxXGNg34OtYbeuNG+YTD/MbpjgaFJPDp3H//faGdKad1dlC\n\t6AZeKVKtEmAQZE20LznY1slFf0bkv73bFxkPPrm0ERe4zYArn78pE5G/631eqsn7Tc\n\tM+l60TUBT+7hKnndYTmnfK1/xjJBC9ltWZ6dNuLb7m4sKb3uu0BlX/1tlLzJwk3RLg\n\t3PQg8IE98HtCw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688629659;\n\tbh=r42D2T7iQwwgSYXhJoR9jZbZW0P5zG5fEuGc6ppa1TQ=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=AfdCbDz1s/yTiQIDptTh4iGGzx+OiUKbBD8lEx1CdmPH4Wvg+1HIhTScIl/Ex48Pc\n\ts2HD3k1N5HeNm6XMzVps8g1coHiL8QItw1aNoSJ51/RTvk/1OlLKKqHd0SPcXAyON9\n\tovXAK/M/H9zxaX64tt7xlkW8K6uVEYdzkay48JRg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AfdCbDz1\"; dkim-atps=neutral","Date":"Thu, 6 Jul 2023 10:48:23 +0300","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20230706074823.GD11949@pendragon.ideasonboard.com>","References":"<20230706073004.984-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230706073004.984-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] meson: Fix space around colon issues","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27492,"web_url":"https://patchwork.libcamera.org/comment/27492/","msgid":"<ae1e5333-4feb-f872-03d7-8b615f3274f3@ideasonboard.com>","date":"2023-07-06T09:03:22","subject":"Re: [libcamera-devel] [PATCH] meson: Fix space around colon issues","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 7/6/23 9:48 AM, Laurent Pinchart via libcamera-devel wrote:\n> On Thu, Jul 06, 2023 at 10:30:04AM +0300, Laurent Pinchart via libcamera-devel wrote:\n>> The meson style, which libcamera follows, mandates a space before\n>> colons. Fix the style violations through the project.\n> The meson style isn't as coherent and universally enforced as this\n> implies. I'll rewrite the commit message as\n>\n> The meson style, which libcamera follows, recommends a space before\n> colons in function parameters. Fix the style violations through the\n> project.\n\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n\n>\n>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>> ---\n>>   Documentation/meson.build              |  8 ++++----\n>>   include/libcamera/base/meson.build     |  2 +-\n>>   include/libcamera/internal/meson.build |  6 +++---\n>>   include/libcamera/ipa/meson.build      |  2 +-\n>>   meson.build                            | 12 ++++++------\n>>   meson_options.txt                      |  4 ++--\n>>   src/apps/qcam/meson.build              |  4 ++--\n>>   src/gstreamer/meson.build              |  2 +-\n>>   src/libcamera/meson.build              |  4 ++--\n>>   src/py/libcamera/meson.build           |  4 ++--\n>>   test/gstreamer/meson.build             |  2 +-\n>>   test/stream/meson.build                |  2 +-\n>>   12 files changed, 26 insertions(+), 26 deletions(-)\n>>\n>> diff --git a/Documentation/meson.build b/Documentation/meson.build\n>> index d675f368cf79..b2a5bf15e6ea 100644\n>> --- a/Documentation/meson.build\n>> +++ b/Documentation/meson.build\n>> @@ -92,8 +92,8 @@ if sphinx.found()\n>>                     install_dir : doc_install_dir)\n>>   \n>>       custom_target('documentation-linkcheck',\n>> -                  command: [sphinx, '-W', '-b', 'linkcheck', meson.current_source_dir(), '@OUTPUT@'],\n>> -                  build_always_stale: true,\n>> -                  input: docs_sources,\n>> -                  output: 'linkcheck')\n>> +                  command : [sphinx, '-W', '-b', 'linkcheck', meson.current_source_dir(), '@OUTPUT@'],\n>> +                  build_always_stale : true,\n>> +                  input : docs_sources,\n>> +                  output : 'linkcheck')\n>>   endif\n>> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n>> index 872de211d4a8..bace25d56b13 100644\n>> --- a/include/libcamera/base/meson.build\n>> +++ b/include/libcamera/base/meson.build\n>> @@ -37,4 +37,4 @@ libcamera_base_headers = [\n>>   ]\n>>   \n>>   install_headers(libcamera_base_public_headers,\n>> -                subdir: libcamera_base_include_dir)\n>> +                subdir : libcamera_base_include_dir)\n>> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n>> index 4b2756a4a251..7f1f344014c4 100644\n>> --- a/include/libcamera/internal/meson.build\n>> +++ b/include/libcamera/internal/meson.build\n>> @@ -4,9 +4,9 @@ subdir('tracepoints')\n>>   \n>>   libcamera_tracepoint_header = custom_target(\n>>       'tp_header',\n>> -    input: ['tracepoints.h.in', tracepoint_files],\n>> -    output: 'tracepoints.h',\n>> -    command: [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n>> +    input : ['tracepoints.h.in', tracepoint_files],\n>> +    output : 'tracepoints.h',\n>> +    command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n>>   )\n>>   \n>>   libcamera_internal_headers = files([\n>> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n>> index 6a5ae68633d7..e72803b4e243 100644\n>> --- a/include/libcamera/ipa/meson.build\n>> +++ b/include/libcamera/ipa/meson.build\n>> @@ -9,7 +9,7 @@ libcamera_ipa_headers = files([\n>>   ])\n>>   \n>>   install_headers(libcamera_ipa_headers,\n>> -                subdir: libcamera_ipa_include_dir)\n>> +                subdir : libcamera_ipa_include_dir)\n>>   \n>>   libcamera_generated_ipa_headers = []\n>>   \n>> diff --git a/meson.build b/meson.build\n>> index 62db8ed8105d..29777529a0d9 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -20,7 +20,7 @@ project('libcamera', 'c', 'cpp',\n>>   libcamera_git_version = run_command('utils/gen-version.sh',\n>>                                       meson.project_build_root(),\n>>                                       meson.project_source_root(),\n>> -                                    check: false).stdout().strip()\n>> +                                    check : false).stdout().strip()\n>>   \n>>   # If the source tree isn't under git control, set libcamera_git_version to the\n>>   # meson project version.\n>> @@ -49,7 +49,7 @@ if libcamera_version != project_version\n>>                                           meson.project_build_root(),\n>>                                           meson.project_source_root(),\n>>                                           project_version,\n>> -                                        check: false).stdout().strip()\n>> +                                        check : false).stdout().strip()\n>>       libcamera_version = project_version\n>>   \n>>       # Append a marker to show we have modified this version string.\n>> @@ -109,7 +109,7 @@ if cc.get_id() == 'clang'\n>>   \n>>       # Use libc++ by default if available instead of libstdc++ when compiling\n>>       # with clang.\n>> -    if cc.find_library('libc++', required: false).found()\n>> +    if cc.find_library('libc++', required : false).found()\n>>           cpp_arguments += [\n>>               '-stdlib=libc++',\n>>           ]\n>> @@ -236,7 +236,7 @@ subdir('test')\n>>   \n>>   if not meson.is_cross_build()\n>>       kernel_version_req = '>= 5.0.0'\n>> -    kernel_version = run_command('uname', '-r', check: true).stdout().strip()\n>> +    kernel_version = run_command('uname', '-r', check : true).stdout().strip()\n>>       if not kernel_version.version_compare(kernel_version_req)\n>>           warning('The current running kernel version @0@ is too old to run libcamera.'\n>>                   .format(kernel_version))\n>> @@ -249,13 +249,13 @@ endif\n>>   # running libcamera from the build directory to locate resources in the source\n>>   # directory (such as IPA configuration files).\n>>   run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source',\n>> -            check: true)\n>> +            check : true)\n>>   \n>>   configure_file(output : 'config.h', configuration : config_h)\n>>   \n>>   # Check for python installation and modules.\n>>   py_mod = import('python')\n>> -py_mod.find_installation('python3', modules: py_modules)\n>> +py_mod.find_installation('python3', modules : py_modules)\n>>   \n>>   ## Summarise Configurations\n>>   summary({\n>> diff --git a/meson_options.txt b/meson_options.txt\n>> index c8cd53b49ba1..4405b401d7d3 100644\n>> --- a/meson_options.txt\n>> +++ b/meson_options.txt\n>> @@ -59,12 +59,12 @@ option('qcam',\n>>   option('test',\n>>           type : 'boolean',\n>>           value : false,\n>> -        description: 'Compile and include the tests')\n>> +        description : 'Compile and include the tests')\n>>   \n>>   option('tracing',\n>>           type : 'feature',\n>>           value : 'auto',\n>> -        description: 'Enable tracing (based on lttng)')\n>> +        description : 'Enable tracing (based on lttng)')\n>>   \n>>   option('v4l2',\n>>           type : 'boolean',\n>> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n>> index eb0712d91351..2e77146cf73c 100644\n>> --- a/src/apps/qcam/meson.build\n>> +++ b/src/apps/qcam/meson.build\n>> @@ -57,9 +57,9 @@ if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n>>       qt5_cpp_args += ['-Wno-deprecated-copy']\n>>   endif\n>>   \n>> -resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n>> +resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n>>                              qresources : qcam_resources,\n>> -                           dependencies: qt5_dep)\n>> +                           dependencies : qt5_dep)\n>>   \n>>   qcam  = executable('qcam', qcam_sources, resources,\n>>                      install : true,\n>> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n>> index 77c79140eb37..20784b71883d 100644\n>> --- a/src/gstreamer/meson.build\n>> +++ b/src/gstreamer/meson.build\n>> @@ -43,6 +43,6 @@ libcamera_gst = shared_library('gstlibcamera',\n>>       libcamera_gst_sources,\n>>       cpp_args : libcamera_gst_cpp_args,\n>>       dependencies : [libcamera_public, gstvideo_dep, gstallocator_dep],\n>> -    install: true,\n>> +    install : true,\n>>       install_dir : '@0@/gstreamer-1.0'.format(get_option('libdir')),\n>>   )\n>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>> index 3cd424779395..38fbb41e7d6c 100644\n>> --- a/src/libcamera/meson.build\n>> +++ b/src/libcamera/meson.build\n>> @@ -93,9 +93,9 @@ endif\n>>   if not libcrypto.found()\n>>       warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')\n>>       summary({'IPA modules signed with': 'None (modules will run isolated)'},\n>> -            section: 'Configuration')\n>> +            section : 'Configuration')\n>>   else\n>> -    summary({'IPA modules signed with': libcrypto.name()}, section: 'Configuration')\n>> +    summary({'IPA modules signed with' : libcrypto.name()}, section : 'Configuration')\n>>   endif\n>>   \n>>   if liblttng.found()\n>> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n>> index b38a57d73c85..f58c7198ee9e 100644\n>> --- a/src/py/libcamera/meson.build\n>> +++ b/src/py/libcamera/meson.build\n>> @@ -93,11 +93,11 @@ pycamera = shared_module('_libcamera',\n>>   \n>>   run_command('ln', '-fsrT', files('__init__.py'),\n>>               meson.current_build_dir() / '__init__.py',\n>> -            check: true)\n>> +            check : true)\n>>   \n>>   run_command('ln', '-fsrT', meson.current_source_dir() / 'utils',\n>>               meson.current_build_dir() / 'utils',\n>> -            check: true)\n>> +            check : true)\n>>   \n>>   install_data(['__init__.py'], install_dir : destdir)\n>>   \n>> diff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build\n>> index 745725864eef..64a632df8a37 100644\n>> --- a/test/gstreamer/meson.build\n>> +++ b/test/gstreamer/meson.build\n>> @@ -8,7 +8,7 @@ gstreamer_tests = [\n>>       {'name': 'single_stream_test', 'sources': ['gstreamer_single_stream_test.cpp']},\n>>       {'name': 'multi_stream_test', 'sources': ['gstreamer_multi_stream_test.cpp']},\n>>   ]\n>> -gstreamer_dep = dependency('gstreamer-1.0', required: true)\n>> +gstreamer_dep = dependency('gstreamer-1.0', required : true)\n>>   \n>>   foreach test : gstreamer_tests\n>>       exe = executable(test['name'], test['sources'], 'gstreamer_test.cpp',\n>> diff --git a/test/stream/meson.build b/test/stream/meson.build\n>> index a3b19bf592a5..dd77f2f7195b 100644\n>> --- a/test/stream/meson.build\n>> +++ b/test/stream/meson.build\n>> @@ -10,5 +10,5 @@ foreach test : stream_tests\n>>                        dependencies : libcamera_public,\n>>                        link_with : test_libraries,\n>>                        include_directories : test_includes_internal)\n>> -    test(test['name'], exe, suite: 'stream')\n>> +    test(test['name'], exe, suite : 'stream')\n>>   endforeach\n>>\n>> base-commit: d06ed87d49ca3d734fd1c2f1409280abb499c625","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8D61BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  6 Jul 2023 09:03:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F3C5628C1;\n\tThu,  6 Jul 2023 11:03:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1188661E33\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  6 Jul 2023 11:03:26 +0200 (CEST)","from [192.168.0.136] (85-160-25-222.reb.o2.cz [85.160.25.222])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FC256C8;\n\tThu,  6 Jul 2023 11:02:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688634207;\n\tbh=Oj+Ju1e0QaJcH4ED7dC7jZZo4zOPWmJ3Hg7Lc19gzZk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0x9TZ+9V2Ppzk9nWPjlwMpW8SDDGeHdWPSU+teTPXaGFGwftABdMrNUtHuyM2XNNQ\n\tqcnYrAN0L8ExvRClQGIB5YDLsHKsDEOqnBut+mFWjIMd6uVsE/fhDMd/JV7M7mUL40\n\t6y6dKNhQNkEvwKZ9UDFhK9zRYjEsvWe33SUtK92Wy5auLhj5syle6viLNFkZbeel/A\n\tydU1c61x9kpiiAZ4uJJ7E6xAjUjyFaEQ4gGVeJhAtWSQuDwVbDV7sNT5Ys+2pvG9tR\n\tPKtQQDHczsSVfqgn701/RmIpX7VEiy4Mvvk4iIjl7QIl4vtmFWpwvhUgO9IuLR759P\n\tG2k6b0wlB0YoA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688634160;\n\tbh=Oj+Ju1e0QaJcH4ED7dC7jZZo4zOPWmJ3Hg7Lc19gzZk=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=jVMFbzvZzJtORQdFe2m7r/aYm0XEVUJiADWQvV0bzPygfUdm/Kdu1dMqHT16oB3Z7\n\t7JLz8Zo+QVIx6VSrBnmQPQE7nLmXTKaMjKU0FBWpQJzbj9VvRjQBIX/EQTxMh5Iz2Z\n\tJZxXzD3haRe+rJQb9QC76zjoRt8rFIsLvzE1BIhs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jVMFbzvZ\"; dkim-atps=neutral","Message-ID":"<ae1e5333-4feb-f872-03d7-8b615f3274f3@ideasonboard.com>","Date":"Thu, 6 Jul 2023 11:03:22 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230706073004.984-1-laurent.pinchart@ideasonboard.com>\n\t<20230706074823.GD11949@pendragon.ideasonboard.com>","In-Reply-To":"<20230706074823.GD11949@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] meson: Fix space around colon issues","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Umang Jain <umang.jain@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27510,"web_url":"https://patchwork.libcamera.org/comment/27510/","msgid":"<168872811393.1588163.1015229794107966430@Monstersaurus>","date":"2023-07-07T11:08:33","subject":"Re: [libcamera-devel] [PATCH] meson: Fix space around colon issues","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain via libcamera-devel (2023-07-06 10:03:22)\n> Hi Laurent,\n> \n> Thank you for the patch.\n> \n> On 7/6/23 9:48 AM, Laurent Pinchart via libcamera-devel wrote:\n> > On Thu, Jul 06, 2023 at 10:30:04AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> >> The meson style, which libcamera follows, mandates a space before\n> >> colons. Fix the style violations through the project.\n> > The meson style isn't as coherent and universally enforced as this\n> > implies. I'll rewrite the commit message as\n> >\n> > The meson style, which libcamera follows, recommends a space before\n> > colons in function parameters. Fix the style violations through the\n> > project.\n\nI wonder if we'd get any false positives with a small regex in\ncheckstyle for this:\n\n/([A-Z][a-z]):/\\1 :/ or such.\n\nAnyway, no objection for this:\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> \n> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n> \n> >\n> >> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >> ---\n> >>   Documentation/meson.build              |  8 ++++----\n> >>   include/libcamera/base/meson.build     |  2 +-\n> >>   include/libcamera/internal/meson.build |  6 +++---\n> >>   include/libcamera/ipa/meson.build      |  2 +-\n> >>   meson.build                            | 12 ++++++------\n> >>   meson_options.txt                      |  4 ++--\n> >>   src/apps/qcam/meson.build              |  4 ++--\n> >>   src/gstreamer/meson.build              |  2 +-\n> >>   src/libcamera/meson.build              |  4 ++--\n> >>   src/py/libcamera/meson.build           |  4 ++--\n> >>   test/gstreamer/meson.build             |  2 +-\n> >>   test/stream/meson.build                |  2 +-\n> >>   12 files changed, 26 insertions(+), 26 deletions(-)\n> >>\n> >> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> >> index d675f368cf79..b2a5bf15e6ea 100644\n> >> --- a/Documentation/meson.build\n> >> +++ b/Documentation/meson.build\n> >> @@ -92,8 +92,8 @@ if sphinx.found()\n> >>                     install_dir : doc_install_dir)\n> >>   \n> >>       custom_target('documentation-linkcheck',\n> >> -                  command: [sphinx, '-W', '-b', 'linkcheck', meson.current_source_dir(), '@OUTPUT@'],\n> >> -                  build_always_stale: true,\n> >> -                  input: docs_sources,\n> >> -                  output: 'linkcheck')\n> >> +                  command : [sphinx, '-W', '-b', 'linkcheck', meson.current_source_dir(), '@OUTPUT@'],\n> >> +                  build_always_stale : true,\n> >> +                  input : docs_sources,\n> >> +                  output : 'linkcheck')\n> >>   endif\n> >> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> >> index 872de211d4a8..bace25d56b13 100644\n> >> --- a/include/libcamera/base/meson.build\n> >> +++ b/include/libcamera/base/meson.build\n> >> @@ -37,4 +37,4 @@ libcamera_base_headers = [\n> >>   ]\n> >>   \n> >>   install_headers(libcamera_base_public_headers,\n> >> -                subdir: libcamera_base_include_dir)\n> >> +                subdir : libcamera_base_include_dir)\n> >> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> >> index 4b2756a4a251..7f1f344014c4 100644\n> >> --- a/include/libcamera/internal/meson.build\n> >> +++ b/include/libcamera/internal/meson.build\n> >> @@ -4,9 +4,9 @@ subdir('tracepoints')\n> >>   \n> >>   libcamera_tracepoint_header = custom_target(\n> >>       'tp_header',\n> >> -    input: ['tracepoints.h.in', tracepoint_files],\n> >> -    output: 'tracepoints.h',\n> >> -    command: [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> >> +    input : ['tracepoints.h.in', tracepoint_files],\n> >> +    output : 'tracepoints.h',\n> >> +    command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> >>   )\n> >>   \n> >>   libcamera_internal_headers = files([\n> >> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n> >> index 6a5ae68633d7..e72803b4e243 100644\n> >> --- a/include/libcamera/ipa/meson.build\n> >> +++ b/include/libcamera/ipa/meson.build\n> >> @@ -9,7 +9,7 @@ libcamera_ipa_headers = files([\n> >>   ])\n> >>   \n> >>   install_headers(libcamera_ipa_headers,\n> >> -                subdir: libcamera_ipa_include_dir)\n> >> +                subdir : libcamera_ipa_include_dir)\n> >>   \n> >>   libcamera_generated_ipa_headers = []\n> >>   \n> >> diff --git a/meson.build b/meson.build\n> >> index 62db8ed8105d..29777529a0d9 100644\n> >> --- a/meson.build\n> >> +++ b/meson.build\n> >> @@ -20,7 +20,7 @@ project('libcamera', 'c', 'cpp',\n> >>   libcamera_git_version = run_command('utils/gen-version.sh',\n> >>                                       meson.project_build_root(),\n> >>                                       meson.project_source_root(),\n> >> -                                    check: false).stdout().strip()\n> >> +                                    check : false).stdout().strip()\n> >>   \n> >>   # If the source tree isn't under git control, set libcamera_git_version to the\n> >>   # meson project version.\n> >> @@ -49,7 +49,7 @@ if libcamera_version != project_version\n> >>                                           meson.project_build_root(),\n> >>                                           meson.project_source_root(),\n> >>                                           project_version,\n> >> -                                        check: false).stdout().strip()\n> >> +                                        check : false).stdout().strip()\n> >>       libcamera_version = project_version\n> >>   \n> >>       # Append a marker to show we have modified this version string.\n> >> @@ -109,7 +109,7 @@ if cc.get_id() == 'clang'\n> >>   \n> >>       # Use libc++ by default if available instead of libstdc++ when compiling\n> >>       # with clang.\n> >> -    if cc.find_library('libc++', required: false).found()\n> >> +    if cc.find_library('libc++', required : false).found()\n> >>           cpp_arguments += [\n> >>               '-stdlib=libc++',\n> >>           ]\n> >> @@ -236,7 +236,7 @@ subdir('test')\n> >>   \n> >>   if not meson.is_cross_build()\n> >>       kernel_version_req = '>= 5.0.0'\n> >> -    kernel_version = run_command('uname', '-r', check: true).stdout().strip()\n> >> +    kernel_version = run_command('uname', '-r', check : true).stdout().strip()\n> >>       if not kernel_version.version_compare(kernel_version_req)\n> >>           warning('The current running kernel version @0@ is too old to run libcamera.'\n> >>                   .format(kernel_version))\n> >> @@ -249,13 +249,13 @@ endif\n> >>   # running libcamera from the build directory to locate resources in the source\n> >>   # directory (such as IPA configuration files).\n> >>   run_command('ln', '-fsT', meson.project_source_root(), meson.project_build_root() / 'source',\n> >> -            check: true)\n> >> +            check : true)\n> >>   \n> >>   configure_file(output : 'config.h', configuration : config_h)\n> >>   \n> >>   # Check for python installation and modules.\n> >>   py_mod = import('python')\n> >> -py_mod.find_installation('python3', modules: py_modules)\n> >> +py_mod.find_installation('python3', modules : py_modules)\n> >>   \n> >>   ## Summarise Configurations\n> >>   summary({\n> >> diff --git a/meson_options.txt b/meson_options.txt\n> >> index c8cd53b49ba1..4405b401d7d3 100644\n> >> --- a/meson_options.txt\n> >> +++ b/meson_options.txt\n> >> @@ -59,12 +59,12 @@ option('qcam',\n> >>   option('test',\n> >>           type : 'boolean',\n> >>           value : false,\n> >> -        description: 'Compile and include the tests')\n> >> +        description : 'Compile and include the tests')\n> >>   \n> >>   option('tracing',\n> >>           type : 'feature',\n> >>           value : 'auto',\n> >> -        description: 'Enable tracing (based on lttng)')\n> >> +        description : 'Enable tracing (based on lttng)')\n> >>   \n> >>   option('v4l2',\n> >>           type : 'boolean',\n> >> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> >> index eb0712d91351..2e77146cf73c 100644\n> >> --- a/src/apps/qcam/meson.build\n> >> +++ b/src/apps/qcam/meson.build\n> >> @@ -57,9 +57,9 @@ if ((cc.get_id() == 'gcc' and cc.version().version_compare('>=9.0') and\n> >>       qt5_cpp_args += ['-Wno-deprecated-copy']\n> >>   endif\n> >>   \n> >> -resources = qt5.preprocess(moc_headers: qcam_moc_headers,\n> >> +resources = qt5.preprocess(moc_headers : qcam_moc_headers,\n> >>                              qresources : qcam_resources,\n> >> -                           dependencies: qt5_dep)\n> >> +                           dependencies : qt5_dep)\n> >>   \n> >>   qcam  = executable('qcam', qcam_sources, resources,\n> >>                      install : true,\n> >> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> >> index 77c79140eb37..20784b71883d 100644\n> >> --- a/src/gstreamer/meson.build\n> >> +++ b/src/gstreamer/meson.build\n> >> @@ -43,6 +43,6 @@ libcamera_gst = shared_library('gstlibcamera',\n> >>       libcamera_gst_sources,\n> >>       cpp_args : libcamera_gst_cpp_args,\n> >>       dependencies : [libcamera_public, gstvideo_dep, gstallocator_dep],\n> >> -    install: true,\n> >> +    install : true,\n> >>       install_dir : '@0@/gstreamer-1.0'.format(get_option('libdir')),\n> >>   )\n> >> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> >> index 3cd424779395..38fbb41e7d6c 100644\n> >> --- a/src/libcamera/meson.build\n> >> +++ b/src/libcamera/meson.build\n> >> @@ -93,9 +93,9 @@ endif\n> >>   if not libcrypto.found()\n> >>       warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')\n> >>       summary({'IPA modules signed with': 'None (modules will run isolated)'},\n> >> -            section: 'Configuration')\n> >> +            section : 'Configuration')\n> >>   else\n> >> -    summary({'IPA modules signed with': libcrypto.name()}, section: 'Configuration')\n> >> +    summary({'IPA modules signed with' : libcrypto.name()}, section : 'Configuration')\n> >>   endif\n> >>   \n> >>   if liblttng.found()\n> >> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> >> index b38a57d73c85..f58c7198ee9e 100644\n> >> --- a/src/py/libcamera/meson.build\n> >> +++ b/src/py/libcamera/meson.build\n> >> @@ -93,11 +93,11 @@ pycamera = shared_module('_libcamera',\n> >>   \n> >>   run_command('ln', '-fsrT', files('__init__.py'),\n> >>               meson.current_build_dir() / '__init__.py',\n> >> -            check: true)\n> >> +            check : true)\n> >>   \n> >>   run_command('ln', '-fsrT', meson.current_source_dir() / 'utils',\n> >>               meson.current_build_dir() / 'utils',\n> >> -            check: true)\n> >> +            check : true)\n> >>   \n> >>   install_data(['__init__.py'], install_dir : destdir)\n> >>   \n> >> diff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build\n> >> index 745725864eef..64a632df8a37 100644\n> >> --- a/test/gstreamer/meson.build\n> >> +++ b/test/gstreamer/meson.build\n> >> @@ -8,7 +8,7 @@ gstreamer_tests = [\n> >>       {'name': 'single_stream_test', 'sources': ['gstreamer_single_stream_test.cpp']},\n> >>       {'name': 'multi_stream_test', 'sources': ['gstreamer_multi_stream_test.cpp']},\n> >>   ]\n> >> -gstreamer_dep = dependency('gstreamer-1.0', required: true)\n> >> +gstreamer_dep = dependency('gstreamer-1.0', required : true)\n> >>   \n> >>   foreach test : gstreamer_tests\n> >>       exe = executable(test['name'], test['sources'], 'gstreamer_test.cpp',\n> >> diff --git a/test/stream/meson.build b/test/stream/meson.build\n> >> index a3b19bf592a5..dd77f2f7195b 100644\n> >> --- a/test/stream/meson.build\n> >> +++ b/test/stream/meson.build\n> >> @@ -10,5 +10,5 @@ foreach test : stream_tests\n> >>                        dependencies : libcamera_public,\n> >>                        link_with : test_libraries,\n> >>                        include_directories : test_includes_internal)\n> >> -    test(test['name'], exe, suite: 'stream')\n> >> +    test(test['name'], exe, suite : 'stream')\n> >>   endforeach\n> >>\n> >> base-commit: d06ed87d49ca3d734fd1c2f1409280abb499c625\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E5DFBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  7 Jul 2023 11:08:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E5B7628C0;\n\tFri,  7 Jul 2023 13:08:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 197DD61E34\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  7 Jul 2023 13:08:37 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0A3E56D;\n\tFri,  7 Jul 2023 13:07:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688728118;\n\tbh=oTyxeCzonzT5nXEuAAkOfnuAtQU+972+zQ9oeSI66SM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=bjr+Ftxw2ya3SXk8ufiksFB2bpoXrClWDqEGiLCLPpGf7uvtmJFtuMdazPp/GSQ3I\n\tBciFvRB7ku4RLWoLn9BOoYePdlWCgiqj2A3YR4iEALit2MYrQy7nVzWONPKfpO+Avy\n\t1GrwzeeLrYRoeooS1mvDUbAQbjepQfEDAUUq4c05uMiKLaKuBfdIN6fbeAqsG6GpCJ\n\tPzRj+/yOVkIjFhOELkXHHexotBGK5eJV4osYpHjrXiUjjTTNz7ZH4RsM+rYIOqWdf2\n\tWklbAbJcv8zdJiJmJzkoEFteQZvF74/rTdihCcw69jaV29CoqJcF+8Ut+Xoizxz2fl\n\tN9MXU+S5RWENg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688728071;\n\tbh=oTyxeCzonzT5nXEuAAkOfnuAtQU+972+zQ9oeSI66SM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=dOMuEOI/zc2F+6QrohMuRmKKwe54ND71fBvio5i7x3yUKhgq6s5hPF251lZHY7pZB\n\tJfLAXmH7baAsmVsgnVnTlXnuGIt0N3oxpDH1pyKGJ+cFqhoNaoVPeEMP7dDxgvocKB\n\ta9phACS+HoCNsNd8MiISGWl2zzyLHgS4lFqSBeW0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dOMuEOI/\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<ae1e5333-4feb-f872-03d7-8b615f3274f3@ideasonboard.com>","References":"<20230706073004.984-1-laurent.pinchart@ideasonboard.com>\n\t<20230706074823.GD11949@pendragon.ideasonboard.com>\n\t<ae1e5333-4feb-f872-03d7-8b615f3274f3@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 07 Jul 2023 12:08:33 +0100","Message-ID":"<168872811393.1588163.1015229794107966430@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: Fix space around colon issues","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]