[{"id":27470,"web_url":"https://patchwork.libcamera.org/comment/27470/","msgid":"<20230704191600.GC7148@pendragon.ideasonboard.com>","date":"2023-07-04T19:16:00","subject":"Re: [libcamera-devel] [PATCH] libcamera: base: Move\n\tthread_annotations to private","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jul 04, 2023 at 08:08:49PM +0100, Kieran Bingham via libcamera-devel wrote:\n> The libcamera thread annotations are for internal use only and are\n> not part of any public api. Mark the header accordingly by including the\n\ns/api/API/\n\n> private.h header guard.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/thread_annotations.h | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/libcamera/base/thread_annotations.h b/include/libcamera/base/thread_annotations.h\n> index e81929f674d7..25b3c7b6cf92 100644\n> --- a/include/libcamera/base/thread_annotations.h\n> +++ b/include/libcamera/base/thread_annotations.h\n> @@ -7,6 +7,8 @@\n> \n> #pragma once\n> \n> +#include \n> +\n> /*\n> * Enable thread safety attributes only with clang.\n> * The attributes can be safely erased when compiling with other compilers.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AD4BBE175\n\tfor ;\n\tTue, 4 Jul 2023 19:16:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E770628C0;\n\tTue, 4 Jul 2023 21:16:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D799660384\n\tfor ;\n\tTue, 4 Jul 2023 21:16:01 +0200 (CEST)","from pendragon.ideasonboard.com (85-160-42-71.reb.o2.cz\n\t[85.160.42.71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D37C8C1;\n\tTue, 4 Jul 2023 21:15:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688498163;\n\tbh=M+kvWszAjP5p4T4UvOq+7+6zDzT0fAfoHiz1bwC4qFA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fHz7JQc0Itu/1lMRXZtuXppoVnE72w2p5IDxpf58M9snJlRkzhr9ebiH6KvjawMgL\n\tswrWLY3cXgvRHj0FpP/9li8ygbuKaGevvWFe1DVcTOC3PfvH62BM1VF1KANi5W/AEm\n\tGm321MS0ua1PxTKsQ2BIUpd2Wyuu6O6ba46hQ622d58k54vEwXYyIgLYGMtEuJZWBk\n\t5sJ/sHB/GiZj0ssYOZRMB76P0EuL58jp+37YEx7KU4mwYLn8a5b0O10PASQh9FOzuJ\n\tJimyqKlo/y0nFsw2rAo9Hd+VyuyFd7BQREwGJW0qtLsYqHdfyaYSUVoQ+ztdNunEG9\n\teqG1wbJjJw2NQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688498117;\n\tbh=M+kvWszAjP5p4T4UvOq+7+6zDzT0fAfoHiz1bwC4qFA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=S//+hZOjoOvWhP8J4DAHamDmH0y4f5qSsf4VA/ffenPmezJEtOK6NusHvZebHbxJc\n\thYujioHgQcdtcknTh9mE8fSJ5sdXBjBolMx61EkYbYlk1MnRpq0fL9IRBABW30+sMv\n\t66yYVl7667imD+kS1ujnq0oZ7yAQdkVX4rX0uTCc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"S//+hZOj\"; dkim-atps=neutral","Date":"Tue, 4 Jul 2023 22:16:00 +0300","To":"Kieran Bingham ","Message-ID":"<20230704191600.GC7148@pendragon.ideasonboard.com>","References":"<20230704190849.3650613-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230704190849.3650613-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: base: Move\n\tthread_annotations to private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27471,"web_url":"https://patchwork.libcamera.org/comment/27471/","msgid":"","date":"2023-07-04T19:17:12","subject":"Re: [libcamera-devel] [PATCH] libcamera: base: Move\n\tthread_annotations to private","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 7/4/23 9:08 PM, Kieran Bingham via libcamera-devel wrote:\n> The libcamera thread annotations are for internal use only and are\n> not part of any public api. Mark the header accordingly by including the\n> private.h header guard.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/base/thread_annotations.h | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/include/libcamera/base/thread_annotations.h b/include/libcamera/base/thread_annotations.h\n> index e81929f674d7..25b3c7b6cf92 100644\n> --- a/include/libcamera/base/thread_annotations.h\n> +++ b/include/libcamera/base/thread_annotations.h\n> @@ -7,6 +7,8 @@\n> \n> #pragma once\n> \n> +#include \n> +\n> /*\n> * Enable thread safety attributes only with clang.\n> * The attributes can be safely erased when compiling with other compilers.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5817CBE175\n\tfor ;\n\tTue, 4 Jul 2023 19:17:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D608628C0;\n\tTue, 4 Jul 2023 21:17:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70D2660384\n\tfor ;\n\tTue, 4 Jul 2023 21:17:15 +0200 (CEST)","from [192.168.0.136] (85-160-42-71.reb.o2.cz [85.160.42.71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 101468C1;\n\tTue, 4 Jul 2023 21:16:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688498237;\n\tbh=uIZz0e57FZBDHCpmI/2PP8M13rqfrGHrAe3GD+K3pFA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=oD5fv9sDUeXT7KGhnlXM0yMIRtgwZc/JduhIxTZVsT74y2eX+u3LTI5djgVzzoNP4\n\t9KL6yxmkPbd5DG3IoEWhYfXBiTOE0zzq9V78LubYRXL+tiHr433InEvQCGvBLrcr6D\n\tTHQqsei4WQe3MtyzDqcZcSnXyTALSYKF0YRzhs+vkCi/dsaHNsNugnMZfnZ3h7MWkF\n\tjcv7DiU4WbxRtN68k4/jgXwawqJ3prChz00p+f8Kqm8W5w4g9hsRYZTx5vtFu9pU3G\n\tqlmKNY/ibbmzc3ZX5BLCa67Kk8Rg9BxFMFzxAJo/qrrpOKGH6hzufh7W8u7m0+2N1a\n\tcvrAl2JOBuSDw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688498191;\n\tbh=uIZz0e57FZBDHCpmI/2PP8M13rqfrGHrAe3GD+K3pFA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=KEvjWCOybHoGXMtmw/cWU5ZGxWAdS/jln9FahXGE4USV1BVsLpzYeh0AJvINZHPA9\n\t+rvBPUiotu3fZvkYRwz1yRvUjWI/SH63wcPzxPPj9vy1pryYKJN3xglaFwcqmXoCT+\n\tNZKlvZuwzVPrpNYEWcwvOXG6lLtwodRMbLAP90RI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KEvjWCOy\"; dkim-atps=neutral","Message-ID":"","Date":"Tue, 4 Jul 2023 21:17:12 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20230704190849.3650613-1-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20230704190849.3650613-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: base: Move\n\tthread_annotations to private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]