[{"id":27461,"web_url":"https://patchwork.libcamera.org/comment/27461/","msgid":"<20230704143646.GB7148@pendragon.ideasonboard.com>","date":"2023-07-04T14:36:46","subject":"Re: [libcamera-devel] [PATCH v3 2/3] utils: ABI Compatibility\n\tchecker","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jul 04, 2023 at 03:24:34PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Provide support to compare ABI compatibility between any two git commits\n> or by a commit and the most recent ancestral tag of that commit.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> ---\n> v3\n>   - use '--force' for git worktree add to prevent issues on cancelled\n>     builds\n> \n>   - define 'libdir' and 'prefix' explicitly to prevent reliance on\n>     system defaults.\n> \n>   - many fixups thanks to Laurents review.\n> \n>   - abi-compat now fails correctly in case of error. (This means it can\n>     only run on trees that have the patch 1/3 of this series applied).\n> \n> \n>  utils/abi-compat.sh | 212 ++++++++++++++++++++++++++++++++++++++++++++\n>  1 file changed, 212 insertions(+)\n>  create mode 100755 utils/abi-compat.sh\n> \n> diff --git a/utils/abi-compat.sh b/utils/abi-compat.sh\n> new file mode 100755\n> index 000000000000..785d081d6e1c\n> --- /dev/null\n> +++ b/utils/abi-compat.sh\n> @@ -0,0 +1,212 @@\n> +#!/bin/bash\n> +\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> +# Generate and compare the ABI compatibilty of two libcamera versions\n> +\n> +name=$(basename \"$0\")\n> +\n> +usage() {\n> +\tcat << EOF\n> +$name: Determine the ABI/API compatibility of two build versions\n> +\n> +  $name [--help] [--abi-dir=<PATH>] [--tmp-dir=<PATH>] ARGS\n> +\n> +The positional arguments (ARGS) determine the versions that will be compared and\n> +take three variants:\n> +\n> +  - No positional arguments:\n> +      $name [optional arguments]\n> +\n> +      It is assumed to compare the current git HEAD against the most recent TAG\n> +\n> +  - One positional argument:\n> +      $name [optional aguments] COMMITISH\n> +\n> +      The given COMMITISH is compared against it's most recent TAG\n> +\n> +  - Two positional arguments:\n> +      $name [optional aguments] BASE COMMITISH\n> +\n> +      The given COMMITISH is compared against the given BASE.\n> +\n> +Optional Arguments:\n> +  --abi-dir <path> Use <path> for storing (or retrieving existing) ABI data\n> +                   files\n> +\n> +  --tmp-dir <path> Specify temporary build location for building ABI data.\n> +                   This could be a tmpfs/RAM disk to save on disk writes.\n> +EOF\n> +}\n> +\n> +dbg () {\n> +\techo \"$@\" >> /dev/stderr\n\n\techo \"$@\" >&2\n\nSame below.\n\n> +}\n> +\n> +die () {\n> +\techo \"$name: $*\" >> /dev/stderr\n> +\texit 128\n\nThe usual exit code in case of failure is 1.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> +}\n> +\n> +describe () {\n> +\tgit describe --tags \"$1\" \\\n> +\t\t|| die \"Failed to describe $1\"\n> +}\n> +\n> +prev_release () {\n> +\tgit describe --tags --abbrev=0 \"$1\"^ \\\n> +\t\t|| die \"Failed to identify previous release tag from $1\"\n> +}\n> +\n> +# Make sure we exit on errors during argument parsing.\n> +set -Eeuo pipefail\n> +\n> +positional=()\n> +while [[ $# -gt 0 ]] ; do\n> +\toption=\"$1\"\n> +\tshift\n> +\n> +\tcase $option in\n> +\t-h|--help)\n> +\t\tusage\n> +\t\texit 0 \n> +\t        ;;\n> +\n> +\t--abi-dir)\n> +\t\tabi_dir=$1\n> +\t\tshift\n> +\t\t;;\n> +\n> +\t--tmp-dir)\n> +\t\ttmp=$1\n> +\t\tshift\n> +\t\t;;\n> +\n> +\t-*)\n> +\t\tdie \"Unrecognised argument $option\"\n> +\t\t;;\n> +\n> +\t*) # Parse unidentified arguments based on position.\n> +\t\tpositional+=(\"$option\")\n> +\t\t;;\n> +\tesac\n> +done\n> +set -- \"${positional[@]}\" # restore positional parameters.\n> +\n> +# Parse positional arguments.\n> +case $# in\n> +\t0) \t# Check HEAD against previous 'release'.\n> +\t\tfrom=$(prev_release HEAD)\n> +\t\tto=$(describe HEAD)\n> +\t\t;;\n> +\n> +\t1)\t# Check COMMIT against previous release.\n> +\t\tfrom=$(prev_release \"$1\")\n> +\t\tto=$(describe \"$1\")\n> +\t\t;;\n> +\n> +\t2)\t# Check ABI between FROM and TO explicitly.\n> +\t\tfrom=$(describe \"$1\")\n> +\t\tto=$(describe \"$2\")\n> +\t\t;;\n> +\n> +\t*)\n> +\t\tdie \"Invalid arguments\"\n> +\t\t;;\n> +esac\n> +\n> +if ! which abi-compliance-checker; then\n> +\tdie \"This tool requires 'abi-compliance-checker' to be installed.\"\n> +fi\n> +\n> +\n> +abi_dir=${abi_dir:-abi}\n> +tmp=${tmp:-\"$abi_dir/tmp/\"}\n> +\n> +echo \"Validating ABI compatibility between $from and $to\"\n> +\n> +mkdir -p \"$abi_dir\"\n> +mkdir -p \"$tmp\"\n> +\n> +# Generate an abi-compliance-checker xml description file.\n> +create_xml() {\n> +\tlocal output=\"$1\"\n> +\tlocal version=\"$2\"\n> +\tlocal root=\"$3\"\n> +\n> +\techo \"<version>$version</version>\" > \"$output\"\n> +\techo \"<headers>$root/usr/local/include/</headers>\" >> \"$output\"\n> +\techo \"<libs>$root/usr/local/lib/</libs>\" >> \"$output\"\n> +}\n> +\n> +# Check if an ABI dump file exists, and if not create one by building a minimal\n> +# configuration of libcamera at the specified version using a clean worktree.\n> +create_abi_dump() {\n> +\tlocal version=\"$1\"\n> +\tlocal abi_file=\"$abi_dir/$version.abi.dump\"\n> +\tlocal worktree=\"$tmp/$version\"\n> +\tlocal build=\"$tmp/$version-build\"\n> +\n> +\t# Use a fully qualified path when calling ninja -C.\n> +\tinstall=$(realpath \"$tmp/$version-install\")\n> +\n> +\tif [[ ! -e \"$abi_file\" ]] ; then\n> +\t\tdbg \"Creating ABI dump for $version in $abi_dir\"\n> +\t\tgit worktree add --force \"$worktree\" \"$version\"\n> +\n> +\t\t# Generate a minimal libcamera build. \"lib\" and \"prefix\" are\n> +\t\t# defined explicitly to avoid system default ambiguities. \n> +\t\tmeson setup \"$build\" \"$worktree\" \\\n> +\t\t\t-Dlibdir=lib \\\n> +\t\t\t-Dprefix=/usr/local/ \\\n> +\t\t\t-Ddocumentation=disabled \\\n> +\t\t\t-Dcam=disabled \\\n> +\t\t\t-Dqcam=disabled \\\n> +\t\t\t-Dgstreamer=disabled \\\n> +\t\t\t-Dlc-compliance=disabled \\\n> +\t\t\t-Dtracing=disabled \\\n> +\t\t\t-Dpipelines=\n> +\n> +\t\tninja -C \"$build\"\n> +\t\tDESTDIR=\"$install\" ninja -C \"$build\" install\n> +\n> +\t\t# Create an xml descriptor with parameters to generate the dump file.\n> +\t\tcreate_xml \\\n> +\t\t\t\"$install/libcamera-abi-dump.xml\" \\\n> +\t\t\t\"$version\" \\\n> +\t\t\t\"$install\"\n> +\n> +\t\tabi-compliance-checker \\\n> +\t\t\t-lib libcamera \\\n> +\t\t\t-v1 \"$version\" \\\n> +\t\t\t-dump \"$install/libcamera-abi-dump.xml\" \\\n> +\t\t\t-dump-path \"$abi_file\"\n> +\n> +\t\tdbg Created \"$abi_file\"\n> +\n> +\t\tdbg Removing Worktree \"$worktree\"\n> +\t\tgit worktree remove -f \"$worktree\"\n> +\n> +\t\tdbg Removing \"$build\"\n> +\t\trm -r \"$build\"\n> +\n> +\t\tdbg Removing \"$install\"\n> +\t\trm -r \"$install\"\n> +\tfi\n> +}\n> +\n> +# Create the requested ABI dump files if they don't yet exist.\n> +create_abi_dump \"$from\"\n> +create_abi_dump \"$to\"\n> +\n> +# TODO: Future iterations and extensions here could add \"-stdout -xml\" and\n> +# parse the results automatically.\n> +abi-compliance-checker -l libcamera \\\n> +\t-old \"$abi_dir/$from.abi.dump\" \\\n> +\t-new \"$abi_dir/$to.abi.dump\"\n> +\n> +# On (far too many) occasions, the tools keep running leaving a cpu core @ 100%\n> +# CPU usage. Perhaps some subprocess gets launched but never rejoined. Stop\n> +# them all.\n> +#\n> +# TODO: Investigate this and report upstream.\n> +killall abi-compliance-checker 2>/dev/null","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BAB3BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 Jul 2023 14:36:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA41E61E38;\n\tTue,  4 Jul 2023 16:36:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB84060384\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Jul 2023 16:36:45 +0200 (CEST)","from pendragon.ideasonboard.com (85-160-42-71.reb.o2.cz\n\t[85.160.42.71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67868D4A;\n\tTue,  4 Jul 2023 16:36:01 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688481407;\n\tbh=IwDllGeuf1QLt6fAng0j8Rlly7K+4m6UsNLu1KMXMHo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tKRwAhnInD3oQqjAgsyje6QA24DJNU/yaZ9ZZyGlrYGWo5QIpKqS3oveXJnjDQDKf\n\tT8pcj4WNzB6CF8tsY9Ym6jcmF2L1EH6pBx7schMttBfVZYU00r6B6ngeFNvwLnwtBU\n\tmPYtZHL4IMqCNA/GEILBWtrHF08iKnU9JHOVsCGi2A6KIgkkBYMK88vyNc3J+uhRmq\n\trTHufLSPHjRnIvcCQ7/rL9YjamtM0HhffYTRpia5L2k5Lt0PcOI0CyknGfOtFvSaX5\n\tnwRs5tMpw0E8SfM35esdudTJ8eRuKXyz6Ad3y9sR2sP4Iu7D0S9U1YVHD890ur1pbk\n\tvca/7inK5sAFQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688481361;\n\tbh=IwDllGeuf1QLt6fAng0j8Rlly7K+4m6UsNLu1KMXMHo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R0uPObi75r2fCMMvn3Hx+3gt6PnVr2uFPHcAbbdRLBmgnwOZna7B21colvmwZu/oq\n\tH0PwH74VByGud483ysSJFkkWfpkzY2Jut0D5Ju/42UIvXtWbgt+vIC7nAGBciX9kGY\n\taLvL4RfmfXq9B/oOq5Y4zUd2CAdy8ecihg078UW4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R0uPObi7\"; dkim-atps=neutral","Date":"Tue, 4 Jul 2023 17:36:46 +0300","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20230704143646.GB7148@pendragon.ideasonboard.com>","References":"<20230704142435.3490823-1-kieran.bingham@ideasonboard.com>\n\t<20230704142435.3490823-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230704142435.3490823-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/3] utils: ABI Compatibility\n\tchecker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27467,"web_url":"https://patchwork.libcamera.org/comment/27467/","msgid":"<9b7b0de4-6e65-87b1-0ea0-c1a41e64d520@ideasonboard.com>","date":"2023-07-04T18:48:00","subject":"Re: [libcamera-devel] [PATCH v3 2/3] utils: ABI Compatibility\n\tchecker","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 7/4/23 4:24 PM, Kieran Bingham via libcamera-devel wrote:\n> Provide support to compare ABI compatibility between any two git commits\n> or by a commit and the most recent ancestral tag of that commit.\n>\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nTested-by: Umang Jain <umang.jain@ideasonboard.com>\n\n>\n> ---\n> v3\n>    - use '--force' for git worktree add to prevent issues on cancelled\n>      builds\n>\n>    - define 'libdir' and 'prefix' explicitly to prevent reliance on\n>      system defaults.\n>\n>    - many fixups thanks to Laurents review.\n>\n>    - abi-compat now fails correctly in case of error. (This means it can\n>      only run on trees that have the patch 1/3 of this series applied).\n>\n>\n>   utils/abi-compat.sh | 212 ++++++++++++++++++++++++++++++++++++++++++++\n>   1 file changed, 212 insertions(+)\n>   create mode 100755 utils/abi-compat.sh\n>\n> diff --git a/utils/abi-compat.sh b/utils/abi-compat.sh\n> new file mode 100755\n> index 000000000000..785d081d6e1c\n> --- /dev/null\n> +++ b/utils/abi-compat.sh\n> @@ -0,0 +1,212 @@\n> +#!/bin/bash\n> +\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> +# Generate and compare the ABI compatibilty of two libcamera versions\n> +\n> +name=$(basename \"$0\")\n> +\n> +usage() {\n> +\tcat << EOF\n> +$name: Determine the ABI/API compatibility of two build versions\n> +\n> +  $name [--help] [--abi-dir=<PATH>] [--tmp-dir=<PATH>] ARGS\n> +\n> +The positional arguments (ARGS) determine the versions that will be compared and\n> +take three variants:\n> +\n> +  - No positional arguments:\n> +      $name [optional arguments]\n> +\n> +      It is assumed to compare the current git HEAD against the most recent TAG\n> +\n> +  - One positional argument:\n> +      $name [optional aguments] COMMITISH\n> +\n> +      The given COMMITISH is compared against it's most recent TAG\n> +\n> +  - Two positional arguments:\n> +      $name [optional aguments] BASE COMMITISH\n> +\n> +      The given COMMITISH is compared against the given BASE.\n> +\n> +Optional Arguments:\n> +  --abi-dir <path> Use <path> for storing (or retrieving existing) ABI data\n> +                   files\n> +\n> +  --tmp-dir <path> Specify temporary build location for building ABI data.\n> +                   This could be a tmpfs/RAM disk to save on disk writes.\n> +EOF\n> +}\n> +\n> +dbg () {\n> +\techo \"$@\" >> /dev/stderr\n> +}\n> +\n> +die () {\n> +\techo \"$name: $*\" >> /dev/stderr\n> +\texit 128\n> +}\n> +\n> +describe () {\n> +\tgit describe --tags \"$1\" \\\n> +\t\t|| die \"Failed to describe $1\"\n> +}\n> +\n> +prev_release () {\n> +\tgit describe --tags --abbrev=0 \"$1\"^ \\\n> +\t\t|| die \"Failed to identify previous release tag from $1\"\n> +}\n> +\n> +# Make sure we exit on errors during argument parsing.\n> +set -Eeuo pipefail\n> +\n> +positional=()\n> +while [[ $# -gt 0 ]] ; do\n> +\toption=\"$1\"\n> +\tshift\n> +\n> +\tcase $option in\n> +\t-h|--help)\n> +\t\tusage\n> +\t\texit 0\n> +\t        ;;\n> +\n> +\t--abi-dir)\n> +\t\tabi_dir=$1\n> +\t\tshift\n> +\t\t;;\n> +\n> +\t--tmp-dir)\n> +\t\ttmp=$1\n> +\t\tshift\n> +\t\t;;\n> +\n> +\t-*)\n> +\t\tdie \"Unrecognised argument $option\"\n> +\t\t;;\n> +\n> +\t*) # Parse unidentified arguments based on position.\n> +\t\tpositional+=(\"$option\")\n> +\t\t;;\n> +\tesac\n> +done\n> +set -- \"${positional[@]}\" # restore positional parameters.\n> +\n> +# Parse positional arguments.\n> +case $# in\n> +\t0) \t# Check HEAD against previous 'release'.\n> +\t\tfrom=$(prev_release HEAD)\n> +\t\tto=$(describe HEAD)\n> +\t\t;;\n> +\n> +\t1)\t# Check COMMIT against previous release.\n> +\t\tfrom=$(prev_release \"$1\")\n> +\t\tto=$(describe \"$1\")\n> +\t\t;;\n> +\n> +\t2)\t# Check ABI between FROM and TO explicitly.\n> +\t\tfrom=$(describe \"$1\")\n> +\t\tto=$(describe \"$2\")\n> +\t\t;;\n> +\n> +\t*)\n> +\t\tdie \"Invalid arguments\"\n> +\t\t;;\n> +esac\n> +\n> +if ! which abi-compliance-checker; then\n> +\tdie \"This tool requires 'abi-compliance-checker' to be installed.\"\n> +fi\n> +\n> +\n> +abi_dir=${abi_dir:-abi}\n> +tmp=${tmp:-\"$abi_dir/tmp/\"}\n> +\n> +echo \"Validating ABI compatibility between $from and $to\"\n> +\n> +mkdir -p \"$abi_dir\"\n> +mkdir -p \"$tmp\"\n> +\n> +# Generate an abi-compliance-checker xml description file.\n> +create_xml() {\n> +\tlocal output=\"$1\"\n> +\tlocal version=\"$2\"\n> +\tlocal root=\"$3\"\n> +\n> +\techo \"<version>$version</version>\" > \"$output\"\n> +\techo \"<headers>$root/usr/local/include/</headers>\" >> \"$output\"\n> +\techo \"<libs>$root/usr/local/lib/</libs>\" >> \"$output\"\n> +}\n> +\n> +# Check if an ABI dump file exists, and if not create one by building a minimal\n> +# configuration of libcamera at the specified version using a clean worktree.\n> +create_abi_dump() {\n> +\tlocal version=\"$1\"\n> +\tlocal abi_file=\"$abi_dir/$version.abi.dump\"\n> +\tlocal worktree=\"$tmp/$version\"\n> +\tlocal build=\"$tmp/$version-build\"\n> +\n> +\t# Use a fully qualified path when calling ninja -C.\n> +\tinstall=$(realpath \"$tmp/$version-install\")\n> +\n> +\tif [[ ! -e \"$abi_file\" ]] ; then\n> +\t\tdbg \"Creating ABI dump for $version in $abi_dir\"\n> +\t\tgit worktree add --force \"$worktree\" \"$version\"\n> +\n> +\t\t# Generate a minimal libcamera build. \"lib\" and \"prefix\" are\n> +\t\t# defined explicitly to avoid system default ambiguities.\n> +\t\tmeson setup \"$build\" \"$worktree\" \\\n> +\t\t\t-Dlibdir=lib \\\n> +\t\t\t-Dprefix=/usr/local/ \\\n> +\t\t\t-Ddocumentation=disabled \\\n> +\t\t\t-Dcam=disabled \\\n> +\t\t\t-Dqcam=disabled \\\n> +\t\t\t-Dgstreamer=disabled \\\n> +\t\t\t-Dlc-compliance=disabled \\\n> +\t\t\t-Dtracing=disabled \\\n> +\t\t\t-Dpipelines=\n> +\n> +\t\tninja -C \"$build\"\n> +\t\tDESTDIR=\"$install\" ninja -C \"$build\" install\n> +\n> +\t\t# Create an xml descriptor with parameters to generate the dump file.\n> +\t\tcreate_xml \\\n> +\t\t\t\"$install/libcamera-abi-dump.xml\" \\\n> +\t\t\t\"$version\" \\\n> +\t\t\t\"$install\"\n> +\n> +\t\tabi-compliance-checker \\\n> +\t\t\t-lib libcamera \\\n> +\t\t\t-v1 \"$version\" \\\n> +\t\t\t-dump \"$install/libcamera-abi-dump.xml\" \\\n> +\t\t\t-dump-path \"$abi_file\"\n> +\n> +\t\tdbg Created \"$abi_file\"\n> +\n> +\t\tdbg Removing Worktree \"$worktree\"\n> +\t\tgit worktree remove -f \"$worktree\"\n> +\n> +\t\tdbg Removing \"$build\"\n> +\t\trm -r \"$build\"\n> +\n> +\t\tdbg Removing \"$install\"\n> +\t\trm -r \"$install\"\n> +\tfi\n> +}\n> +\n> +# Create the requested ABI dump files if they don't yet exist.\n> +create_abi_dump \"$from\"\n> +create_abi_dump \"$to\"\n> +\n> +# TODO: Future iterations and extensions here could add \"-stdout -xml\" and\n> +# parse the results automatically.\n> +abi-compliance-checker -l libcamera \\\n> +\t-old \"$abi_dir/$from.abi.dump\" \\\n> +\t-new \"$abi_dir/$to.abi.dump\"\n> +\n> +# On (far too many) occasions, the tools keep running leaving a cpu core @ 100%\n> +# CPU usage. Perhaps some subprocess gets launched but never rejoined. Stop\n> +# them all.\n> +#\n> +# TODO: Investigate this and report upstream.\n> +killall abi-compliance-checker 2>/dev/null","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDADEBE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 Jul 2023 18:48:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41ABB628C0;\n\tTue,  4 Jul 2023 20:48:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A24BF60384\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Jul 2023 20:48:03 +0200 (CEST)","from [192.168.0.136] (85-160-42-71.reb.o2.cz [85.160.42.71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 177906DF;\n\tTue,  4 Jul 2023 20:47:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688496485;\n\tbh=sbEvdzzi91zfb6/MoAJ49qB6oqn6VnEiVpUaOL6qlZw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wRIt2UR7iTdmD5qrlQNiMpnGfFMvk9VGwv7ckXv4vjYrmpvF2ANcNwQ89U0mLpXlr\n\txwKTTcEs6w8FNx8J2N7hWW4PQtXqpDVLwDo591tkovII6NMVmc47gbtRXIdVQxz5D/\n\tNCqT/oK73Kr4KWSrZTSjSWaGMaGz76vEF0qYJUcejnZ0TLGIuj8OB6l6BNcQ6sW/fQ\n\tk91kdH28BGbvIx9UCQyAZl/6HolIdm2wfLwwVPxpMzciYnjmH9l2lIb7u4ybNOE9ff\n\ttB/qV4dWFdasv0Pi9LV9KVd4QetCUBPsdTYC6cSzWUVBBwXPqAL3wkDSESnEk5MlZx\n\tZCqpc3LRIk1OA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688496439;\n\tbh=sbEvdzzi91zfb6/MoAJ49qB6oqn6VnEiVpUaOL6qlZw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=fwY733w6NmyCTTZdcjWxJX0FlebEQ9Fjp58/yMiGymtd1TtzOjfe6iktFRrkZpuku\n\thftOujnYFDDm/+UJJ31YTEzuMrogXiwcLCLF4cw+O5aiAfK9zlTpALk8caUsJSkkIR\n\tSycdD3UXvdbSGcZZxjjnW31ck9H0vsKrEove9ZuU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fwY733w6\"; dkim-atps=neutral","Message-ID":"<9b7b0de4-6e65-87b1-0ea0-c1a41e64d520@ideasonboard.com>","Date":"Tue, 4 Jul 2023 20:48:00 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","References":"<20230704142435.3490823-1-kieran.bingham@ideasonboard.com>\n\t<20230704142435.3490823-3-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20230704142435.3490823-3-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 2/3] utils: ABI Compatibility\n\tchecker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Umang Jain <umang.jain@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]