[{"id":27466,"web_url":"https://patchwork.libcamera.org/comment/27466/","msgid":"<9f22e48e-06a3-74fc-d469-f12bc326397d@ideasonboard.com>","date":"2023-07-04T18:33:59","subject":"Re: [libcamera-devel] [PATCH v3 3/3] meson: Use x.y soname\n\tversioning","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch .\n\nOn 7/4/23 4:24 PM, Kieran Bingham via libcamera-devel wrote:\n> Now that we identify ABI breakages, provide incremental releases which\n> can support backwards compatible linkage across release points that have\n> a compatible ABI.\n>\n> Introduction of this commit does not convey that libcamera now has a\n> stable API, but that patch releases with a common minor number\n> (0.minor.patch) may potentially be used by applications without\n> recompilation and linkage against new releases.\n>\n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> meson.build | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n>\n> diff --git a/meson.build b/meson.build\n> index e1fd924307f7..9c1e708131eb 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -56,15 +56,13 @@ if libcamera_version != project_version\n> libcamera_git_version += '-nvm'\n> endif\n> \n> -# Until we make ABI compatible releases, the full libcamera version is used as\n> -# the soname. No ABI/API compatibility is guaranteed between releases (x.y.z).\n> -#\n> -# When automatic ABI based detection is used to increment the version, this\n> -# will bump the minor number (x.y).\n> +# The major and minor libcamera version components are used as the soname.\n> +# No ABI/API compatibility is guaranteed between releases (x.y).\n> #\n> # When we declare a stable ABI/API we will provide a 1.0 release and the\n> # soversion at that point will be the 'major' release value (x).\n> -libcamera_soversion = libcamera_version\n> +semver = libcamera_version.split('.')\n> +libcamera_soversion = semver[0] + '.' + semver[1]\n> \n> summary({ 'Sources': libcamera_git_version, }, section : 'Versions')\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5654FBDC71\n\tfor ;\n\tTue, 4 Jul 2023 18:34:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0D60628BD;\n\tTue, 4 Jul 2023 20:34:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22C9760384\n\tfor ;\n\tTue, 4 Jul 2023 20:34:03 +0200 (CEST)","from [192.168.0.136] (85-160-42-71.reb.o2.cz [85.160.42.71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 690976DF;\n\tTue, 4 Jul 2023 20:33:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688495644;\n\tbh=ODMVKRsAEYoPkSg+7VauUfO+Cay7lj1SQwyAzXwM5vU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Rrft7iqzonwk4VCgSuYpWPHC7M74AXNMWQ/bwStgMLlWDR8LwoobYz/ediFaG0184\n\tb5qwQe1HaHa0U3aEpqgM1VlxAU4aXqGYkvy8Xiyq5rMKcVnTD4Wx7Nn2zbWWqKeo/R\n\t11WY5bLz0siZ1QTLfd6U7uMCKzi8MRO/+OCa0M1cJvBNqA6iH1Ah81CfiH11O/BbW5\n\tY+ey6Lr50IAImO6jdLHYze2cHVuPM0telcYDjaBAh7VfvqeM86toBQ70BSpq1QhBW+\n\tNKccSvbklinzZafCoTUBW73K0QOXy3B4X7PijT03OHma1rOgLKd09J9OIoew3ddutZ\n\tqCVKpYjUTqasA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688495598;\n\tbh=ODMVKRsAEYoPkSg+7VauUfO+Cay7lj1SQwyAzXwM5vU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=d8QGK4ihbrb6/iCAMNiOvTmJJ1VJYBZyZFORRDJL8vjgpHwQjZsfhPWadFVFDwzrL\n\tNDtPkNK394Oax8hhb8cXKUQErEAYKaeMbQse/Z/qJc3xhi1wu+4herIImhGMJz4sOg\n\t6v/Qd+PtvKK/1RBd/hm/GgUSp1j3WDKk9lhPCKZc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"d8QGK4ih\"; dkim-atps=neutral","Message-ID":"<9f22e48e-06a3-74fc-d469-f12bc326397d@ideasonboard.com>","Date":"Tue, 4 Jul 2023 20:33:59 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20230704142435.3490823-1-kieran.bingham@ideasonboard.com>\n\t<20230704142435.3490823-4-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20230704142435.3490823-4-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 3/3] meson: Use x.y soname\n\tversioning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]