[{"id":27460,"web_url":"https://patchwork.libcamera.org/comment/27460/","msgid":"<20230704142934.GA7148@pendragon.ideasonboard.com>","date":"2023-07-04T14:29:34","subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: base: Do not install\n\tprivate headers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jul 04, 2023 at 03:24:33PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Split the public and private headers from the base library and stop installing\n> private headers as part of the install process.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/meson.build | 28 ++++++++++++++++++----------\n> 1 file changed, 18 insertions(+), 10 deletions(-)\n> \n> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> index 4410aba8181a..ee91bd1e0071 100644\n> --- a/include/libcamera/base/meson.build\n> +++ b/include/libcamera/base/meson.build\n> @@ -2,31 +2,39 @@\n> \n> libcamera_base_include_dir = libcamera_include_dir / 'base'\n> \n> -libcamera_base_headers = files([\n> - 'backtrace.h',\n> +libcamera_base_public_headers = files([\n> 'bound_method.h',\n> 'class.h',\n> 'compiler.h',\n> + 'flags.h',\n> + 'object.h',\n> + 'shared_fd.h',\n> + 'signal.h',\n> + 'span.h',\n> + 'thread_annotations.h',\n> + 'unique_fd.h',\n> +])\n> +\n> +libcamera_base_private_headers = files([\n> + 'backtrace.h',\n> 'event_dispatcher.h',\n> 'event_dispatcher_poll.h',\n> 'event_notifier.h',\n> 'file.h',\n> - 'flags.h',\n> 'log.h',\n> 'message.h',\n> 'mutex.h',\n> - 'object.h',\n> 'private.h',\n> 'semaphore.h',\n> - 'shared_fd.h',\n> - 'signal.h',\n> - 'span.h',\n> 'thread.h',\n> - 'thread_annotations.h',\n> 'timer.h',\n> - 'unique_fd.h',\n> 'utils.h',\n> ])\n> \n> -install_headers(libcamera_base_headers,\n> +libcamera_base_headers = [\n> + libcamera_base_public_headers,\n> + libcamera_base_private_headers,\n> +]\n> +\n> +install_headers(libcamera_base_public_headers,\n> subdir: libcamera_base_include_dir)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59657BDC71\n\tfor ;\n\tTue, 4 Jul 2023 14:29:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3F9861E38;\n\tTue, 4 Jul 2023 16:29:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B83260384\n\tfor ;\n\tTue, 4 Jul 2023 16:29:34 +0200 (CEST)","from pendragon.ideasonboard.com (85-160-42-71.reb.o2.cz\n\t[85.160.42.71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1345D6DF;\n\tTue, 4 Jul 2023 16:28:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688480975;\n\tbh=NlLXxVLJqe1uai9Cdg05yVAV86aNBOxN6gqkpPDq+9w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JOwsHp83d5T4y5XsG03GiYg2BJgJ4/PD0LrtYTRUAV/LogJuFIXrfrIE3zo21GDGP\n\tKjl/Mniek9Rw9BG5LuRILe2n4/w5PQUGKLJgi9Jyj6+SPO+B3qtHq8BG2ebdTrxsIm\n\t3iXBtzbpKuuEnuEiiHVl0ghaZir3HjaUd/HL/bRlm48uLZjpsK+TYcGwULhg8y3zyM\n\t7diJM83cCDLgzTeoWRXI7iZnVYPisesh8E6FBHdDZK3yHvBawHna2D16NdwiAb7rXl\n\ttHbDbtvp8YfXHpALYe/9ZmiTKZY4C9tDpBuwgRUkx3CsaP4tuwJweklbTFarDndDnc\n\tYYYJq630AQuZA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688480930;\n\tbh=NlLXxVLJqe1uai9Cdg05yVAV86aNBOxN6gqkpPDq+9w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hRqL2N5q74YqLy55K14NwvlI/dZYH5IWJxlqJe7tSTzWNw+KKqagIAVyHQ3XFTDDq\n\tNo+9cV6q6jfnO09wFfUsiiQ1DnJFBm5nIHl1LQSdPzLXwShk9ebngzrzG4x01Mgicz\n\tS5QQ6AqFX2dfCrRTOlh4j3+6MvNrNWfvEIPG4KRY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hRqL2N5q\"; dkim-atps=neutral","Date":"Tue, 4 Jul 2023 17:29:34 +0300","To":"Kieran Bingham ","Message-ID":"<20230704142934.GA7148@pendragon.ideasonboard.com>","References":"<20230704142435.3490823-1-kieran.bingham@ideasonboard.com>\n\t<20230704142435.3490823-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230704142435.3490823-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: base: Do not install\n\tprivate headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27465,"web_url":"https://patchwork.libcamera.org/comment/27465/","msgid":"<68f683de-072f-4eac-1450-cf15c1918bfb@ideasonboard.com>","date":"2023-07-04T18:32:06","subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: base: Do not install\n\tprivate headers","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 7/4/23 4:24 PM, Kieran Bingham via libcamera-devel wrote:\n> Split the public and private headers from the base library and stop installing\n> private headers as part of the install process.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/base/meson.build | 28 ++++++++++++++++++----------\n> 1 file changed, 18 insertions(+), 10 deletions(-)\n>\n> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> index 4410aba8181a..ee91bd1e0071 100644\n> --- a/include/libcamera/base/meson.build\n> +++ b/include/libcamera/base/meson.build\n> @@ -2,31 +2,39 @@\n> \n> libcamera_base_include_dir = libcamera_include_dir / 'base'\n> \n> -libcamera_base_headers = files([\n> - 'backtrace.h',\n> +libcamera_base_public_headers = files([\n> 'bound_method.h',\n> 'class.h',\n> 'compiler.h',\n> + 'flags.h',\n> + 'object.h',\n> + 'shared_fd.h',\n> + 'signal.h',\n> + 'span.h',\n> + 'thread_annotations.h',\n\nDoes thread annotation should go public ?\n\nOther than it,\n\nReviewed-by: Umang Jain \n> + 'unique_fd.h',\n> +])\n> +\n> +libcamera_base_private_headers = files([\n> + 'backtrace.h',\n> 'event_dispatcher.h',\n> 'event_dispatcher_poll.h',\n> 'event_notifier.h',\n> 'file.h',\n> - 'flags.h',\n> 'log.h',\n> 'message.h',\n> 'mutex.h',\n> - 'object.h',\n> 'private.h',\n> 'semaphore.h',\n> - 'shared_fd.h',\n> - 'signal.h',\n> - 'span.h',\n> 'thread.h',\n> - 'thread_annotations.h',\n> 'timer.h',\n> - 'unique_fd.h',\n> 'utils.h',\n> ])\n> \n> -install_headers(libcamera_base_headers,\n> +libcamera_base_headers = [\n> + libcamera_base_public_headers,\n> + libcamera_base_private_headers,\n> +]\n> +\n> +install_headers(libcamera_base_public_headers,\n> subdir: libcamera_base_include_dir)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F194BDC71\n\tfor ;\n\tTue, 4 Jul 2023 18:32:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 238A961E38;\n\tTue, 4 Jul 2023 20:32:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0A9D60384\n\tfor ;\n\tTue, 4 Jul 2023 20:32:10 +0200 (CEST)","from [192.168.0.136] (85-160-42-71.reb.o2.cz [85.160.42.71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4239B6DF;\n\tTue, 4 Jul 2023 20:31:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688495532;\n\tbh=aagChbQRE+U+y9Smu4DrhGHmUQ46AiPZvbaGQ7N233w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Ll/N6fFbDNpWeYuH/7mIV7E1f7tm0lbNpyh+gOZjs2sNDpqw38xR5DuNVGv6OUHo9\n\ti6qBi+EOicOf+Bx4YXeAJTNGMoFOIZvJeTkD0z45LEUkaLDQUeqtZVkfQTr3lQKVzY\n\tsSnCkyxQQ3WBUXXYoeOS6GzFYkWqZsEEZiG+judnpg+CMpWzyYE//Ah+XO292Oq4jP\n\tP6rfT0ULE4QO1MLDVHKTeLjGbCRnyrmr944YjWOz2UCM0j0DW/07T/S/hVQ0LrT89v\n\t7vOtYgCh4K+Q3vCZ6zsuA1oolHkYULy3lKOJIyDYtsl8/yLJyBfW+xuJD7BBWZu0wa\n\tLJW9BGVV6LD8w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688495486;\n\tbh=aagChbQRE+U+y9Smu4DrhGHmUQ46AiPZvbaGQ7N233w=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=MSX60V5PyohSG3jESfMY6dN42mGbT8zaF5l16q3L2RuiZ/uhYOKxu2JIjgkwHseXY\n\tvf78jZjB9bpc/LCChnPDO2uOS3Fp5A0oi7wQV88m33Fz5k1HYK+YlSy4L5c0L95zeR\n\tQw2+NePNPFFylUqBa5l3FqX/7d6TFT36Qwrt8doU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MSX60V5P\"; dkim-atps=neutral","Message-ID":"<68f683de-072f-4eac-1450-cf15c1918bfb@ideasonboard.com>","Date":"Tue, 4 Jul 2023 20:32:06 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20230704142435.3490823-1-kieran.bingham@ideasonboard.com>\n\t<20230704142435.3490823-2-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20230704142435.3490823-2-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: base: Do not install\n\tprivate headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]