[{"id":27444,"web_url":"https://patchwork.libcamera.org/comment/27444/","msgid":"","date":"2023-06-30T12:58:46","subject":"Re: [libcamera-devel] [RFC PATCH 3/5] ipa: rpi: cam_helper_imx708:\n\tOnly pass embedded buffer in parseEmbeddedData()","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Umang,\n\nThank you for your work.\n\nOn Fri, 30 Jun 2023 at 13:03, Umang Jain wrote:\n>\n> Only the embedded data section should be passed while parsing the\n> embedded data through parseEmbeddedData().\n>\n> Signed-off-by: Umang Jain \n> ---\n> src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> index d0382d63..6c3b54ed 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> @@ -40,6 +40,8 @@ constexpr std::initializer_list registerList =\n> { expHiReg, expLoReg, gainHiReg, gainLoReg, lineLengthHiReg,\n> lineLengthLoReg, frameLengthHiReg, frameLengthLoReg, temperatureReg };\n>\n> +/* No. of lines of embedded data on IMX708. */\n> +constexpr uint32_t embeddedDataLinesImx708 = 2;\n> /* PDAF data is expect to occupy the third scanline of embedded data. */\n> constexpr uint32_t pdafLineOffsetImx708 = 2;\n\nYou only need one of these const values correct?\nPerhaps these should be private members in the class like the other consts.\nAlso you can remove the imx708 suffix.\n\n>\n> @@ -109,10 +111,13 @@ void CamHelperImx708::prepare(libcamera::Span buffer, Metadata &m\n> return;\n> }\n>\n> - parseEmbeddedData(buffer, metadata);\n> + size_t bytesPerLine = (mode_.width * mode_.bitdepth) >> 3;\n> +\n> + libcamera::Span embeddedData{ buffer.data(),\n> + embeddedDataLinesImx708 * bytesPerLine };\n> + parseEmbeddedData(embeddedData, metadata);\n>\n> /* Parse sensor-specific PDAF data. */\n> - size_t bytesPerLine = (mode_.width * mode_.bitdepth) >> 3;\n> size_t pdafDataOffset = pdafLineOffsetImx708 * bytesPerLine;\n>\n> if (buffer.size() > pdafDataOffset) {\n> --\n> 2.39.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DF66BDB1D\n\tfor ;\n\tFri, 30 Jun 2023 12:59:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8386D628BE;\n\tFri, 30 Jun 2023 14:59:04 +0200 (CEST)","from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com\n\t[IPv6:2607:f8b0:4864:20::1131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECB3A628BD\n\tfor ;\n\tFri, 30 Jun 2023 14:59:02 +0200 (CEST)","by mail-yw1-x1131.google.com with SMTP id\n\t00721157ae682-5700401acbeso19452247b3.0\n\tfor ;\n\tFri, 30 Jun 2023 05:59:02 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688129944;\n\tbh=3e0eSZKE6xsvM44DAkQ7uajWbfGFiRXngqpWlGj/sKA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3LEmAFaNrA1L0l9Mq0dutxeOR8h2cJGnmWtZDKtnxdhGE3UOkmHLUMDZ6OOfXv6O3\n\tPQVH/mtJLf/gqMjkhjHv+8TBHIPsQ8wVJSLlU/3TdIWJgJdGGsXeWGdqLlc58l+PhX\n\t6Ct8882O5/ljeH7dMArlQ8kio7ELngCE5L7HgHZnQByPXG1tzA7jchYKABM2LDGPxC\n\tCPue094Lee3xIXC+XnA947gsNFm1Nbxt6cUA5/Xed8ehrEKfp2GLerscQ1jVs4XrK8\n\twP33nUs2RfOtRMOYuUd/oZ0j35GOvTiZZo31ZKlByu/aZ7H9JTUydGjPwy9d/jOKDf\n\tgOVFSO0VunRYA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1688129942; x=1690721942;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=vnANiRenqNV+9A0QTOvAULGl+/rgo40H5OEeTdqYWpI=;\n\tb=LsdBUjGo5KnhLLfoywH62m3d1Z1NDXRvsuelw9eIl009+u9PlrZPGpKRo4bMTbXcQm\n\t2lEpJPE/tvoYuMPtihSTj0SeKxWFB/GSdYGXh57hShiJoS1zqhqbFkkrmvveHgWFthgL\n\tRSV1h84V7Q4fecRLbtwNZXPM+WYGfltolN403Um7qCR4DI+ALquTga9rPv34pN4rmIwW\n\tffKzh0dYI1rD9Mtsn3DbQ7eLNntpTbi2BzWjJFTgpznqRiB0gDM4cy0+XH22pguQDeTR\n\ttI2X+NYzh24JENJ69i3eDIFSGYp261tj+AGRDk6jbXFc15bozRxueiHYeNnYIAJHuVSc\n\t38iA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"LsdBUjGo\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1688129942; x=1690721942;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=vnANiRenqNV+9A0QTOvAULGl+/rgo40H5OEeTdqYWpI=;\n\tb=XBjgjNwAy4HG4MG0x7UrRyZawk5Dm30+3/cTQQggk0yE782A790hoWxGdJSU6taVfs\n\t4Wap92vHD39TJhUpb+duCRvTiIm23YhijUmkUreXKE7BkYM6pwQdhV2HLTA2x91o1g7a\n\tmecDMkGKaFmzOuFY7PU1oMCz8EDv4Q1N9oumF8hnof2HArDWO9zksizkY1ixyKp6GSLu\n\tszyzCOao/XwID+SQgfnqOkznTXS2wMVqFWUQ2z67piKkocRWX73nKO6+8ZTNQz4/IhgX\n\tzSXnTVu31JTEySEON6CFd2Ihqu8eaouiqO91oVGHkjoxCHd8K1gpzGrh2RovTj7dwXGx\n\tyBHw==","X-Gm-Message-State":"ABy/qLYzk5qL3UmpRnKScXfDv2fRcCYLaeH8KNun1QhuHndWtvjMn3+X\n\tmtMI1uM9yvpWPusp+w9cP+wLipsj7QtyYRJmwiq48A==","X-Google-Smtp-Source":"APBJJlFJbfObWCg9hAPsyn8jNJ9wn3+DWw5BzMcUwSWGfqxWYp6h7Sjl05cZuy6sPntCALhmCrvrUruxqDiBokikIZQ=","X-Received":"by 2002:a0d:cb86:0:b0:562:1060:f2c9 with SMTP id\n\tn128-20020a0dcb86000000b005621060f2c9mr2156104ywd.13.1688129941808;\n\tFri, 30 Jun 2023 05:59:01 -0700 (PDT)","MIME-Version":"1.0","References":"<20230630120303.33023-1-umang.jain@ideasonboard.com>\n\t<20230630120303.33023-4-umang.jain@ideasonboard.com>","In-Reply-To":"<20230630120303.33023-4-umang.jain@ideasonboard.com>","Date":"Fri, 30 Jun 2023 13:58:46 +0100","Message-ID":"","To":"Umang Jain ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [RFC PATCH 3/5] ipa: rpi: cam_helper_imx708:\n\tOnly pass embedded buffer in parseEmbeddedData()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]