[{"id":27434,"web_url":"https://patchwork.libcamera.org/comment/27434/","msgid":"<168799315201.3298351.12832975601489450592@Monstersaurus>","date":"2023-06-28T22:59:12","subject":"Re: [libcamera-devel] [PATCH v3] gstreamer: Maintain a control list\n\tto track libcamerasrc control properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain via libcamera-devel (2023-06-28 22:34:52)\n> As more and more libcamera controls get plumbed, more member variables\n> get introduced in struct GstLibcameraSrc. Instead of doing that, now\n> maintain a single ControlList which is more appropriate to keep track\n> of controls that get sets on libcamerasrc.\n> \n> This also brings easy validation of controls set on libcamerasrc. If\n> the controls are not supported by camera, fail negotiation and report\n> what is not supported.\n> \n> The current patch migrates previously introduced control,\n> auto-focus-mode, to be set directly in control list.\n> \n> Signed-off-by: Umang Jain \n> ---\n> Changes in v3: \n> - Rebase over \"[PATCH] gstreamer: Drop libcamera_private dependency\"\n> \n> Changes in v2:\n> - Edit commit message \n> - Drop a break; so that all unsupported user-provided controls are\n> reported at once.\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 44 ++++++++++++++++++++++---------\n> src/gstreamer/gstlibcamerasrc.h | 6 ++---\n> 2 files changed, 35 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index f764a87a..b5c6e9ab 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -142,7 +142,7 @@ struct _GstLibcameraSrc {\n> GstTask *task;\n> \n> gchar *camera_name;\n> - controls::AfModeEnum auto_focus_mode = controls::AfModeManual;\n> + ControlList *controls;\n> \n> GstLibcameraSrcState *state;\n> GstLibcameraAllocator *allocator;\n> @@ -458,7 +458,9 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n> GstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> GLibRecLocker lock(&self->stream_lock);\n> GstLibcameraSrcState *state = self->state;\n> + const ControlInfoMap &info_map = state->cam_->controls();\n> GstFlowReturn flow_ret = GST_FLOW_OK;\n> + gboolean supported_ctrl = true;\n> gint ret;\n> \n> g_autoptr(GstStructure) element_caps = gst_structure_new_empty(\"caps\");\n> @@ -575,18 +577,30 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n> gst_flow_combiner_add_pad(self->flow_combiner, srcpad);\n> }\n> \n> - if (self->auto_focus_mode != controls::AfModeManual) {\n> - const ControlInfoMap &infoMap = state->cam_->controls();\n> - if (infoMap.find(&controls::AfMode) != infoMap.end()) {\n> - state->initControls_.set(controls::AfMode, self->auto_focus_mode);\n> - } else {\n> + /*\n> + * Check the controls set on libcamerasrc is supported by the camera.\n> + * This can be easily done by CameraControlValidator but it is an internal\n> + * libcamera class. Hence avoid adding a internal header even though\n> + * gstreamer links with libcamera-private.\n\nI think we can remove this comment now or simplify it.\n\nNo point mentioning anything to do with libcamera-private.\n\nOther than that, this seems like a good step forwards for getting more\ncontrols in.\n\n--\nKieran\n\n\n\n> + */\n> + for (auto iter = self->controls->begin(); iter != self->controls->end(); iter++) {\n> + if (info_map.find(iter->first) == info_map.end()) {\n> + const ControlIdMap *id_map = self->controls->idMap();\n> GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n> - (\"Failed to enable auto focus\"),\n> - (\"AfMode not supported by this camera, \"\n> - \"please retry with 'auto-focus-mode=AfModeManual'\"));\n> + (\"Failed to set %s\", id_map->at(iter->first)->name().c_str()),\n> + (\"%s not supported by this camera, \", id_map->at(iter->first)->name().c_str()));\n> + supported_ctrl = false;\n> }\n> }\n> \n> + if (!supported_ctrl) {\n> + gst_task_stop(task);\n> + flow_ret = GST_FLOW_NOT_NEGOTIATED;\n> + goto done;\n> + }\n> +\n> + state->initControls_.merge(*self->controls);\n> +\n> ret = state->cam_->start(&state->initControls_);\n> if (ret) {\n> GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n> @@ -670,7 +684,8 @@ gst_libcamera_src_set_property(GObject *object, guint prop_id,\n> self->camera_name = g_value_dup_string(value);\n> break;\n> case PROP_AUTO_FOCUS_MODE:\n> - self->auto_focus_mode = static_cast(g_value_get_enum(value));\n> + self->controls->set(controls::AfMode,\n> + static_cast(g_value_get_enum(value)));\n> break;\n> default:\n> G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n> @@ -689,9 +704,11 @@ gst_libcamera_src_get_property(GObject *object, guint prop_id, GValue *value,\n> case PROP_CAMERA_NAME:\n> g_value_set_string(value, self->camera_name);\n> break;\n> - case PROP_AUTO_FOCUS_MODE:\n> - g_value_set_enum(value, static_cast(self->auto_focus_mode));\n> + case PROP_AUTO_FOCUS_MODE: {\n> + auto auto_focus_mode = self->controls->get(controls::AfMode).value_or(controls::AfModeManual);\n> + g_value_set_enum(value, auto_focus_mode);\n> break;\n> + }\n> default:\n> G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n> break;\n> @@ -757,6 +774,7 @@ gst_libcamera_src_finalize(GObject *object)\n> g_clear_object(&self->task);\n> g_mutex_clear(&self->state->lock_);\n> g_free(self->camera_name);\n> + delete self->controls;\n> delete self->state;\n> \n> return klass->finalize(object);\n> @@ -782,6 +800,8 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n> /* C-style friend. */\n> state->src_ = self;\n> self->state = state;\n> +\n> + self->controls = new ControlList(controls::controls, nullptr);\n> }\n> \n> static GstPad *\n> diff --git a/src/gstreamer/gstlibcamerasrc.h b/src/gstreamer/gstlibcamerasrc.h\n> index 0a88ba02..2e6d74cb 100644\n> --- a/src/gstreamer/gstlibcamerasrc.h\n> +++ b/src/gstreamer/gstlibcamerasrc.h\n> @@ -26,17 +26,17 @@ gst_libcamera_auto_focus_get_type()\n> static GType type = 0;\n> static const GEnumValue values[] = {\n> {\n> - static_cast(libcamera::controls::AfModeManual),\n> + libcamera::controls::AfModeManual,\n> \"AfModeManual\",\n> \"manual-focus\",\n> },\n> {\n> - static_cast(libcamera::controls::AfModeAuto),\n> + libcamera::controls::AfModeAuto,\n> \"AfModeAuto\",\n> \"automatic-auto-focus\",\n> },\n> {\n> - static_cast(libcamera::controls::AfModeContinuous),\n> + libcamera::controls::AfModeContinuous,\n> \"AfModeContinuous\",\n> \"continuous-auto-focus\",\n> },\n> -- \n> 2.39.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB3ECBE175\n\tfor ;\n\tWed, 28 Jun 2023 22:59:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E849628C0;\n\tThu, 29 Jun 2023 00:59:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC49C61E3F\n\tfor ;\n\tThu, 29 Jun 2023 00:59:14 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 436A0289;\n\tThu, 29 Jun 2023 00:58:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1687993157;\n\tbh=VoR4CMEcV7qR8TkobDfvvNVsFoQLdiYj6aMiJQ8qC0s=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TN9At9yAHN2P9wqV75eIXq9eur3gEqRX8QbPsUzMit342XpOver4SzrRWizDxfVaH\n\tElJGsebJuAwI/SDR7kkdZAPceyjPnSdPMUD29AhkLnWuhgQmxW1IxBQZY1VyJnMRXD\n\toyFqcpHlVDfYihGtp80o35JYu7k5AOg9TPr9OaCFlO2Cux0g2sbG4F2gsURjhB55Z0\n\tp4sxnbUint5I5tv83C3ViOEeGjI8sasOe/l6NeY0Eo5qToDypj7+s+jdyDA5T9QmHf\n\t6SPmynNp1wwsp+TAfiB8v8O4xPVCb8wutADKrbvxZ1cOL86s67NP09i8iHEZbhRvKj\n\t3VDrGQcIi0AvQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1687993114;\n\tbh=VoR4CMEcV7qR8TkobDfvvNVsFoQLdiYj6aMiJQ8qC0s=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ATj3uMAAKJV4w/ia9eDIxOSTwrOQZ0RHmw0lPpzm2bRo4C/ASAPA10cKafSK3RJX3\n\t279v97OLmcSf7J8k+C7naKHF3czT+DQrtPgj8zcbTBat9u9NdjtwkNAFvk5aBDHwI1\n\tKC1qS2u1pI+jYjfzGScXdtq7S1DP62goeCU91o54="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ATj3uMAA\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230628213452.15531-1-umang.jain@ideasonboard.com>","References":"<20230628213452.15531-1-umang.jain@ideasonboard.com>","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 28 Jun 2023 23:59:12 +0100","Message-ID":"<168799315201.3298351.12832975601489450592@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3] gstreamer: Maintain a control list\n\tto track libcamerasrc control properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Cedric Nugteren ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27436,"web_url":"https://patchwork.libcamera.org/comment/27436/","msgid":"<0979aef0-2e78-788a-8b0f-1389fc719fd7@ideasonboard.com>","date":"2023-06-29T07:01:32","subject":"Re: [libcamera-devel] [PATCH v3] gstreamer: Maintain a control list\n\tto track libcamerasrc control properties","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"On 6/29/23 12:59 AM, Kieran Bingham wrote:\n> Quoting Umang Jain via libcamera-devel (2023-06-28 22:34:52)\n>> As more and more libcamera controls get plumbed, more member variables\n>> get introduced in struct GstLibcameraSrc. Instead of doing that, now\n>> maintain a single ControlList which is more appropriate to keep track\n>> of controls that get sets on libcamerasrc.\n>>\n>> This also brings easy validation of controls set on libcamerasrc. If\n>> the controls are not supported by camera, fail negotiation and report\n>> what is not supported.\n>>\n>> The current patch migrates previously introduced control,\n>> auto-focus-mode, to be set directly in control list.\n>>\n>> Signed-off-by: Umang Jain \n>> ---\n>> Changes in v3:\n>> - Rebase over \"[PATCH] gstreamer: Drop libcamera_private dependency\"\n>>\n>> Changes in v2:\n>> - Edit commit message\n>> - Drop a break; so that all unsupported user-provided controls are\n>> reported at once.\n>> ---\n>> src/gstreamer/gstlibcamerasrc.cpp | 44 ++++++++++++++++++++++---------\n>> src/gstreamer/gstlibcamerasrc.h | 6 ++---\n>> 2 files changed, 35 insertions(+), 15 deletions(-)\n>>\n>> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n>> index f764a87a..b5c6e9ab 100644\n>> --- a/src/gstreamer/gstlibcamerasrc.cpp\n>> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n>> @@ -142,7 +142,7 @@ struct _GstLibcameraSrc {\n>> GstTask *task;\n>> \n>> gchar *camera_name;\n>> - controls::AfModeEnum auto_focus_mode = controls::AfModeManual;\n>> + ControlList *controls;\n>> \n>> GstLibcameraSrcState *state;\n>> GstLibcameraAllocator *allocator;\n>> @@ -458,7 +458,9 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n>> GstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n>> GLibRecLocker lock(&self->stream_lock);\n>> GstLibcameraSrcState *state = self->state;\n>> + const ControlInfoMap &info_map = state->cam_->controls();\n>> GstFlowReturn flow_ret = GST_FLOW_OK;\n>> + gboolean supported_ctrl = true;\n>> gint ret;\n>> \n>> g_autoptr(GstStructure) element_caps = gst_structure_new_empty(\"caps\");\n>> @@ -575,18 +577,30 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n>> gst_flow_combiner_add_pad(self->flow_combiner, srcpad);\n>> }\n>> \n>> - if (self->auto_focus_mode != controls::AfModeManual) {\n>> - const ControlInfoMap &infoMap = state->cam_->controls();\n>> - if (infoMap.find(&controls::AfMode) != infoMap.end()) {\n>> - state->initControls_.set(controls::AfMode, self->auto_focus_mode);\n>> - } else {\n>> + /*\n>> + * Check the controls set on libcamerasrc is supported by the camera.\n>> + * This can be easily done by CameraControlValidator but it is an internal\n>> + * libcamera class. Hence avoid adding a internal header even though\n>> + * gstreamer links with libcamera-private.\n> I think we can remove this comment now or simplify it.\n\nv3 was specifically sent to remove this comment, but apparently I send \nthe old .patch file :-/\n>\n> No point mentioning anything to do with libcamera-private.\n>\n> Other than that, this seems like a good step forwards for getting more\n> controls in.\n>\n> --\n> Kieran\n>\n>\n>\n>> + */\n>> + for (auto iter = self->controls->begin(); iter != self->controls->end(); iter++) {\n>> + if (info_map.find(iter->first) == info_map.end()) {\n>> + const ControlIdMap *id_map = self->controls->idMap();\n>> GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n>> - (\"Failed to enable auto focus\"),\n>> - (\"AfMode not supported by this camera, \"\n>> - \"please retry with 'auto-focus-mode=AfModeManual'\"));\n>> + (\"Failed to set %s\", id_map->at(iter->first)->name().c_str()),\n>> + (\"%s not supported by this camera, \", id_map->at(iter->first)->name().c_str()));\n>> + supported_ctrl = false;\n>> }\n>> }\n>> \n>> + if (!supported_ctrl) {\n>> + gst_task_stop(task);\n>> + flow_ret = GST_FLOW_NOT_NEGOTIATED;\n>> + goto done;\n>> + }\n>> +\n>> + state->initControls_.merge(*self->controls);\n>> +\n>> ret = state->cam_->start(&state->initControls_);\n>> if (ret) {\n>> GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n>> @@ -670,7 +684,8 @@ gst_libcamera_src_set_property(GObject *object, guint prop_id,\n>> self->camera_name = g_value_dup_string(value);\n>> break;\n>> case PROP_AUTO_FOCUS_MODE:\n>> - self->auto_focus_mode = static_cast(g_value_get_enum(value));\n>> + self->controls->set(controls::AfMode,\n>> + static_cast(g_value_get_enum(value)));\n>> break;\n>> default:\n>> G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n>> @@ -689,9 +704,11 @@ gst_libcamera_src_get_property(GObject *object, guint prop_id, GValue *value,\n>> case PROP_CAMERA_NAME:\n>> g_value_set_string(value, self->camera_name);\n>> break;\n>> - case PROP_AUTO_FOCUS_MODE:\n>> - g_value_set_enum(value, static_cast(self->auto_focus_mode));\n>> + case PROP_AUTO_FOCUS_MODE: {\n>> + auto auto_focus_mode = self->controls->get(controls::AfMode).value_or(controls::AfModeManual);\n>> + g_value_set_enum(value, auto_focus_mode);\n>> break;\n>> + }\n>> default:\n>> G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n>> break;\n>> @@ -757,6 +774,7 @@ gst_libcamera_src_finalize(GObject *object)\n>> g_clear_object(&self->task);\n>> g_mutex_clear(&self->state->lock_);\n>> g_free(self->camera_name);\n>> + delete self->controls;\n>> delete self->state;\n>> \n>> return klass->finalize(object);\n>> @@ -782,6 +800,8 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n>> /* C-style friend. */\n>> state->src_ = self;\n>> self->state = state;\n>> +\n>> + self->controls = new ControlList(controls::controls, nullptr);\n>> }\n>> \n>> static GstPad *\n>> diff --git a/src/gstreamer/gstlibcamerasrc.h b/src/gstreamer/gstlibcamerasrc.h\n>> index 0a88ba02..2e6d74cb 100644\n>> --- a/src/gstreamer/gstlibcamerasrc.h\n>> +++ b/src/gstreamer/gstlibcamerasrc.h\n>> @@ -26,17 +26,17 @@ gst_libcamera_auto_focus_get_type()\n>> static GType type = 0;\n>> static const GEnumValue values[] = {\n>> {\n>> - static_cast(libcamera::controls::AfModeManual),\n>> + libcamera::controls::AfModeManual,\n>> \"AfModeManual\",\n>> \"manual-focus\",\n>> },\n>> {\n>> - static_cast(libcamera::controls::AfModeAuto),\n>> + libcamera::controls::AfModeAuto,\n>> \"AfModeAuto\",\n>> \"automatic-auto-focus\",\n>> },\n>> {\n>> - static_cast(libcamera::controls::AfModeContinuous),\n>> + libcamera::controls::AfModeContinuous,\n>> \"AfModeContinuous\",\n>> \"continuous-auto-focus\",\n>> },\n>> -- \n>> 2.39.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C198ABE175\n\tfor ;\n\tThu, 29 Jun 2023 07:01:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0AF75628C0;\n\tThu, 29 Jun 2023 09:01:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AB4C60576\n\tfor ;\n\tThu, 29 Jun 2023 09:01:36 +0200 (CEST)","from [192.168.0.136] (85-160-58-109.reb.o2.cz [85.160.58.109])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63FA3A4C;\n\tThu, 29 Jun 2023 09:00:55 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688022097;\n\tbh=kkNOuMdFA7ujb9Mzatlwryx9iaDOWyLen3qIcGoCbCo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0lz9SIwlfS1MjE2c46CeXafI6J/fXXws1+HsQUCFcoezcnN4M71dFieZpJzTDZZyY\n\tXn4YYUIURuoKtRhnxQmw8+oARvLaR9IWOSNqI6EXwPYYNykyvsMQkI96MB8kx72QMy\n\tbuG8GReRxzPeSVJcunPHIEIRcxKQvzNkrNatM+55Jkiy5Dx4Hc4MauVG19SEifQ+gw\n\tgF85Gn/vVWurTGo5bqZBDxidumK50IIp3CxoCMH2Oq7XQAEp2B5VH4q5TDbZxmXPXI\n\t4+/KGA2bDYIhOK8Iaev3u4ZLmGwDuKG3wfG7PUy6S0UhwpEtWiP5eqjXROI8BgQQU2\n\ttumq5ADX8tlKw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688022055;\n\tbh=kkNOuMdFA7ujb9Mzatlwryx9iaDOWyLen3qIcGoCbCo=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=BEkO8/Y4NrtCgAMIjhvyvy7LOkPREI0K5HVRv+w/mI3CmoSQ46OnIvTKf3n8YU+hq\n\tmwp7ooXkeT4tTa6rSC+YVJfBy2mmJBZsja5AMqQuzNNq8BgL65I9JMuV8Pl34FqagA\n\tvMvNRoj9jBxmeT7XqaEWJtZIUOKg78+Eq5Y8zCm0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BEkO8/Y4\"; dkim-atps=neutral","Message-ID":"<0979aef0-2e78-788a-8b0f-1389fc719fd7@ideasonboard.com>","Date":"Thu, 29 Jun 2023 09:01:32 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230628213452.15531-1-umang.jain@ideasonboard.com>\n\t<168799315201.3298351.12832975601489450592@Monstersaurus>","Content-Language":"en-US","In-Reply-To":"<168799315201.3298351.12832975601489450592@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3] gstreamer: Maintain a control list\n\tto track libcamerasrc control properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"Cedric Nugteren ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]