[{"id":27396,"web_url":"https://patchwork.libcamera.org/comment/27396/","msgid":"<69127b93-23db-8f90-63ff-9c8a7bb3553d@ideasonboard.com>","date":"2023-06-21T05:34:48","subject":"Re: [libcamera-devel] [RFC 4/4] apps: cam: Add option to set stream\n\torientation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn 6/20/23 7:59 PM, Jacopo Mondi via libcamera-devel wrote:\n> Add a '--orientation|-o' option to the cam test application to set\n> an orientation to the image stream.\n>\n> Supported values are the ones obtained by applying flips to the camera\n> sensor:\n> - rot180: Rotate 180 degrees\n> - flip: vertical flip\n> - mirror: horizontal flip\n\n From an application PoV, it should be able to set every possible \nrotation defined in enum Orientation, I think.\n>\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/apps/cam/camera_session.cpp | 17 +++++++++++++++++\n> src/apps/cam/main.cpp | 5 +++++\n> src/apps/cam/main.h | 1 +\n> 3 files changed, 23 insertions(+)\n>\n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index 8fcec6304d66..2d6a1440cde2 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -65,6 +65,23 @@ CameraSession::CameraSession(CameraManager *cm,\n> \t\treturn;\n> \t}\n>\n> +\tif (options_.isSet(OptOrientation)) {\n> +\t\tstd::string orient = options_[OptOrientation].toString();\n> +\t\tif (orient == \"rot180\") {\n> +\t\t\tconfig->orientation =\n> +\t\t\t\tlibcamera::CameraConfiguration::rotate180;\n> +\t\t} else if (orient == \"mirror\") {\n> +\t\t\tconfig->orientation =\n> +\t\t\t\tlibcamera::CameraConfiguration::flipRotate0;\n> +\t\t} else if (orient == \"flip\") {\n> +\t\t\tconfig->orientation =\n> +\t\t\t\tlibcamera::CameraConfiguration::flipRotate180;\n> +\t\t} else {\n> +\t\t\tstd::cerr << \"Invalid orientation \" << orient << std::endl;\n> +\t\t\treturn;\n\nIf we want to restrict the orientation not supported by libcamera, we \nshould restrict them at libcamera level itself.\n\nRestricting them at application level doesn't make sense to me.\n> +\t\t}\n> +\t}\n> +\n> \t/* Apply configuration if explicitly requested. */\n> \tif (StreamKeyValueParser::updateConfiguration(config.get(),\n> \t\t\t\t\t\t options_[OptStream])) {\n> diff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\n> index 5d8a57bc14e5..8698d5eedcf8 100644\n> --- a/src/apps/cam/main.cpp\n> +++ b/src/apps/cam/main.cpp\n> @@ -133,6 +133,11 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \t\t\t \"Capture until interrupted by user or until frames captured\",\n> \t\t\t \"capture\", ArgumentOptional, \"count\", false,\n> \t\t\t OptCamera);\n> +\n> +\tparser.addOption(OptOrientation, OptionString,\n> +\t\t\t \"The camera stream image orientation (rot180, mirror, flip)\",\n> +\t\t\t \"orientation\", ArgumentRequired, \"orientation\", false,\n> +\t\t\t OptCamera);\n> #ifdef HAVE_KMS\n> \tparser.addOption(OptDisplay, OptionString,\n> \t\t\t \"Display viewfinder through DRM/KMS on specified connector\",\n> diff --git a/src/apps/cam/main.h b/src/apps/cam/main.h\n> index 526aecece3f3..4aa959b32e13 100644\n> --- a/src/apps/cam/main.h\n> +++ b/src/apps/cam/main.h\n> @@ -17,6 +17,7 @@ enum {\n> \tOptList = 'l',\n> \tOptListProperties = 'p',\n> \tOptMonitor = 'm',\n> +\tOptOrientation = 'o',\n> \tOptSDL = 'S',\n> \tOptStream = 's',\n> \tOptListControls = 256,\n> --\n> 2.40.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A38CCC3237\n\tfor ;\n\tWed, 21 Jun 2023 05:34:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC6F8628BB;\n\tWed, 21 Jun 2023 07:34:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45B3961E3C\n\tfor ;\n\tWed, 21 Jun 2023 07:34:53 +0200 (CEST)","from [192.168.1.108] (unknown [103.86.18.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D6D1BC;\n\tWed, 21 Jun 2023 07:34:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1687325694;\n\tbh=TawnWan2H2Hi/Upk3ECO9jTerSMrrB2I6Mk6kNpgSjE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hi0BeU4jf10mBOlNi10u9mV/m/tXxhAyML1DVic9k+Veq80HeblDo5Mho/szSpEtI\n\t+jjlqjpJlwgjJQlgoVCY+gbq58+6OoY7NcTEUiLD9GudLNkL29HFSm6tfS4U+hXHMi\n\tt/p3Bwt2k3PJmJ3VaSpWLmfZDLJ6xYQYa7cirt6gUrF7RnQ69HDx+bxnYbXH9c1ZXc\n\tShhT0K6QCwhcHiDgdtiJvLQ7X3voU75QuoGiDfxHB3JqhxYLW+nB5uE2EY+n1GvYrq\n\t6niFg0EEmxeL7gM/COWPfD1gw1rXC9mM5O6iyXst5S+egqpE3/kaeWFnngXPaq7LqN\n\teEhIvhLWILEyw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1687325658;\n\tbh=TawnWan2H2Hi/Upk3ECO9jTerSMrrB2I6Mk6kNpgSjE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=pWVOd/tzzQiA3xN00o6iZXLy1T3+2u8HIozuzuocCnj5kFsDxVkFM46YCoghsRK5W\n\t41WAlYNmeccao6ic8Z23+3W88DUSW8h4adsRcT6KzlqO04XOXU4c8du4zbNDElWHKD\n\ta7X448VMLGOYs6GGX9GDS9yca9ypeP12u29NSaXQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pWVOd/tz\"; dkim-atps=neutral","Message-ID":"<69127b93-23db-8f90-63ff-9c8a7bb3553d@ideasonboard.com>","Date":"Wed, 21 Jun 2023 11:04:48 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230620142904.72600-1-jacopo.mondi@ideasonboard.com>\n\t<20230620142904.72600-5-jacopo.mondi@ideasonboard.com>","In-Reply-To":"<20230620142904.72600-5-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC 4/4] apps: cam: Add option to set stream\n\torientation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27399,"web_url":"https://patchwork.libcamera.org/comment/27399/","msgid":"","date":"2023-06-21T07:41:47","subject":"Re: [libcamera-devel] [RFC 4/4] apps: cam: Add option to set stream\n\torientation","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Umang\n\nOn Wed, Jun 21, 2023 at 11:04:48AM +0530, Umang Jain wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On 6/20/23 7:59 PM, Jacopo Mondi via libcamera-devel wrote:\n> > Add a '--orientation|-o' option to the cam test application to set\n> > an orientation to the image stream.\n> >\n> > Supported values are the ones obtained by applying flips to the camera\n> > sensor:\n> > - rot180: Rotate 180 degrees\n> > - flip: vertical flip\n> > - mirror: horizontal flip\n>\n> From an application PoV, it should be able to set every possible rotation\n> defined in enum Orientation, I think.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/apps/cam/camera_session.cpp | 17 +++++++++++++++++\n> > src/apps/cam/main.cpp | 5 +++++\n> > src/apps/cam/main.h | 1 +\n> > 3 files changed, 23 insertions(+)\n> >\n> > diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> > index 8fcec6304d66..2d6a1440cde2 100644\n> > --- a/src/apps/cam/camera_session.cpp\n> > +++ b/src/apps/cam/camera_session.cpp\n> > @@ -65,6 +65,23 @@ CameraSession::CameraSession(CameraManager *cm,\n> > \t\treturn;\n> > \t}\n> >\n> > +\tif (options_.isSet(OptOrientation)) {\n> > +\t\tstd::string orient = options_[OptOrientation].toString();\n> > +\t\tif (orient == \"rot180\") {\n> > +\t\t\tconfig->orientation =\n> > +\t\t\t\tlibcamera::CameraConfiguration::rotate180;\n> > +\t\t} else if (orient == \"mirror\") {\n> > +\t\t\tconfig->orientation =\n> > +\t\t\t\tlibcamera::CameraConfiguration::flipRotate0;\n> > +\t\t} else if (orient == \"flip\") {\n> > +\t\t\tconfig->orientation =\n> > +\t\t\t\tlibcamera::CameraConfiguration::flipRotate180;\n> > +\t\t} else {\n> > +\t\t\tstd::cerr << \"Invalid orientation \" << orient << std::endl;\n> > +\t\t\treturn;\n>\n> If we want to restrict the orientation not supported by libcamera, we should\n> restrict them at libcamera level itself.\n>\n> Restricting them at application level doesn't make sense to me.\n\nRemember 'cam' is a test tool, not a full application.\n\nI had the same thought you had, but then I wondered what was the\npurpose of exposing a value we know cannot be used. The same reasoning\ncould be made for 'rotation0': does it make sense to have as an option\nsomething we know it's the 'default' ?\n\n> > +\t\t}\n> > +\t}\n> > +\n> > \t/* Apply configuration if explicitly requested. */\n> > \tif (StreamKeyValueParser::updateConfiguration(config.get(),\n> > \t\t\t\t\t\t options_[OptStream])) {\n> > diff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\n> > index 5d8a57bc14e5..8698d5eedcf8 100644\n> > --- a/src/apps/cam/main.cpp\n> > +++ b/src/apps/cam/main.cpp\n> > @@ -133,6 +133,11 @@ int CamApp::parseOptions(int argc, char *argv[])\n> > \t\t\t \"Capture until interrupted by user or until frames captured\",\n> > \t\t\t \"capture\", ArgumentOptional, \"count\", false,\n> > \t\t\t OptCamera);\n> > +\n> > +\tparser.addOption(OptOrientation, OptionString,\n> > +\t\t\t \"The camera stream image orientation (rot180, mirror, flip)\",\n> > +\t\t\t \"orientation\", ArgumentRequired, \"orientation\", false,\n> > +\t\t\t OptCamera);\n> > #ifdef HAVE_KMS\n> > \tparser.addOption(OptDisplay, OptionString,\n> > \t\t\t \"Display viewfinder through DRM/KMS on specified connector\",\n> > diff --git a/src/apps/cam/main.h b/src/apps/cam/main.h\n> > index 526aecece3f3..4aa959b32e13 100644\n> > --- a/src/apps/cam/main.h\n> > +++ b/src/apps/cam/main.h\n> > @@ -17,6 +17,7 @@ enum {\n> > \tOptList = 'l',\n> > \tOptListProperties = 'p',\n> > \tOptMonitor = 'm',\n> > +\tOptOrientation = 'o',\n> > \tOptSDL = 'S',\n> > \tOptStream = 's',\n> > \tOptListControls = 256,\n> > --\n> > 2.40.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05B09C3237\n\tfor ;\n\tWed, 21 Jun 2023 07:41:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBE8D628C2;\n\tWed, 21 Jun 2023 09:41:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0323561E41\n\tfor ;\n\tWed, 21 Jun 2023 09:41:50 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:1cf0:b3bc:c785:4625])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC3E9BC;\n\tWed, 21 Jun 2023 09:41:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1687333310;\n\tbh=1evvW8a2zkK/Tsal6fNhuVxUjyN5XpOYhcwhjrpCHw0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2WyTB19RQwKhYJOcvLqhfVLvunVM/ENqjgN6i1eaKHM9BP2+HbGaDro02CehXKAxt\n\t1zgefXqhV9+zQOenlTqRgyHlD5VxogOowhaYYGRP7qIuS+2chjmrE/ITWXBX4uwPkW\n\t+znBhDpdRgGuNvmxFNILjBrgFyxB1yAtHgMfqtAErIw/6vCvwWvet64LMuHhsdlSUf\n\tbxWu0EyhMYLIJmg+Lwh+PdMw05HoZFoSJgeHyePf5IoIoSKPJ3aVFS+9K8qBMhGIR8\n\t5n0u/ZC0J+5QveVKGtHTxq0qcM4kwc1ooovQQrB4bNyqW4/Drw3Gb3+mHmm5u8eJHf\n\tPcFtCkqfs+KLw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1687333274;\n\tbh=1evvW8a2zkK/Tsal6fNhuVxUjyN5XpOYhcwhjrpCHw0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CqqVIcBvI6t1Q+qmTHxAL5yZR42/tPV3zOxPXUN+qRgzs1L5ovuhovcoDMWQc4vTc\n\t1N2lXoTsT5aADfr8/zm3Yc61dSlYGHKu1uUS4kQ2d4ztDiriDcLQZknZxH2zUIo9Ps\n\tQyBQuSTCItvIvkM4ZfFyf2IKLo/B52LVgzvMDIjo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CqqVIcBv\"; dkim-atps=neutral","Date":"Wed, 21 Jun 2023 09:41:47 +0200","To":"Umang Jain ","Message-ID":"","References":"<20230620142904.72600-1-jacopo.mondi@ideasonboard.com>\n\t<20230620142904.72600-5-jacopo.mondi@ideasonboard.com>\n\t<69127b93-23db-8f90-63ff-9c8a7bb3553d@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<69127b93-23db-8f90-63ff-9c8a7bb3553d@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC 4/4] apps: cam: Add option to set stream\n\torientation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]