[{"id":2545,"web_url":"https://patchwork.libcamera.org/comment/2545/","msgid":"","date":"2019-08-29T14:10:43","subject":"Re: [libcamera-devel] [PATCH 09/13] libcamera: ipa: meson: Allow\n\taccess to internal libcamera headers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 28/08/2019 02:17, Niklas Söderlund wrote:\n> Allow IPA implementations to use internal libcamera headers so they can\n> utilize helpers not exposed to applications.\n> \n\nThis sounds reasonable, but we're interacting against a list of\n'ipa_dummy_sources', I suspect we should change the list name to\nsomething more like 'ipa_sources' or such.\n\nI see you've later added the rkisp-IPA to the same list to make use of\nthis shared_module definition.\n\nDo you anticipate that IPA's will be single file implementations? (in\nwhich case keeping them all at this level, and in this list is fine) -\nor could they become more complex? In which case we might want to try to\ngeneralise this shared_module definition some other way too.\n\nAll that said, I think we can defer worrying about complex IPAs until we\nhave one - and keep single files for now.\n\nBut that would suggest that the rename of the list might be appropriate\neither jointly in this patch, or as an extra.\n\nAnyway, for the include_directories change:\n\nReviewed-by: Kieran Bingham \n\nBut don't let that stop you updating this patch to rename the\nipa_dummy_source list as well if you feel it's appropriate here as a\nsimilar preparatory step.\n\n\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/ipa/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 2b9863bce3eabe80..dca7a9461385b68d 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -9,7 +9,7 @@ foreach t : ipa_dummy_sources\n> ipa = shared_module(t[0],\n> t[1],\n> name_prefix : '',\n> - include_directories : libcamera_includes,\n> + include_directories : includes,\n> install : true,\n> install_dir : ipa_install_dir)\n> endforeach\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 460F060BB0\n\tfor ;\n\tThu, 29 Aug 2019 16:10:47 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7F852E5;\n\tThu, 29 Aug 2019 16:10:46 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567087846;\n\tbh=vf7oG5k/KkW1zml1slrnpCyXaPrm8CTeXYg62S5niIM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=dKsZ3SdStNhd27Gq1R1mBuJuEJdq9Cv8U1JpNpsL0utVweMDOtp7BAI7FuVNQ23fA\n\tqwn/ksSqNHHkPAV4IB50oqASHqOHy/YKxTuwo1rRZNmgLF/Kxa2f9P52Y5Xb4l4YEF\n\t9PzbG+1tthn9xfBdYtRiyrn5+irkORzKgNu13J6s=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190828011710.32128-1-niklas.soderlund@ragnatech.se>\n\t<20190828011710.32128-10-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCJQQYAQoADwIbDAUCWcOUawUJ\n\tB4D+AgAKCRChHkZyEKRh/XJhEACr5iidt/0MZ0rWRMCbZFMWD7D2g6nZeOp+F2zY8CEUW+sd\n\tCDVd9BH9QX9KN5SZo6YtJzMzSzpcx45VwTvtQW0n/6Eujg9EUqblfU9xqvqDmbjEapr5d/OL\n\t21GTALb0owKhA5qDUGEcKGCphpQffKhTNo/BP99jvmJUj7IPSKH97qPypi8/ym8bAxB+uY31\n\tgHTMHf1jMJJ1pRo2tYYPeIIHGDqXBI4sp5GHHF+JcIhgR/e/A6w/dgzHYmQPl2ix5eZYEZbV\n\tTRP+gkX4NV8oHqa/lR+xPOlWElGB57viOSOoWriqxQbFy8XbG1GR8cWlkNtGBGVWaJaSoORP\n\tiowD7irXL91bCyFIqL+7BVk3Jy4uzP744PzE80KwxOp5SQAp9sPzFbgsJrLev90PZySjFHG0\n\twP144DK7nBjOj/J0g9OHVASP1JjK+nw7SDoKnETDIdRC0XmiHXk7TXzPdkvO0UkpHdEPjZUp\n\tWyuc0MqehjR/hTTPt4m/Y14XzEcy6JREIjOrFfUZVho2QpOdv9CNryGdieRTNjUtz463CIaZ\n\tdPBiw9mOMBoNffkn9FIoCjLnAaj9gUAnEHWBZOEviQ5NuyqpeP0YtzI4iaRbSUkYZHej99X3\n\tVmHrdLlMqd/ZgYYbPGSL4AN3FVACb5CxuxEHwo029VcE5U3CSjzqtCoX12tm7A==","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 29 Aug 2019 15:10:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20190828011710.32128-10-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 09/13] libcamera: ipa: meson: Allow\n\taccess to internal libcamera headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 14:10:47 -0000"}},{"id":2557,"web_url":"https://patchwork.libcamera.org/comment/2557/","msgid":"<20190829205230.GE8479@bigcity.dyn.berto.se>","date":"2019-08-29T20:52:30","subject":"Re: [libcamera-devel] [PATCH 09/13] libcamera: ipa: meson: Allow\n\taccess to internal libcamera headers","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"HI Kieran,\n\nThanks for your feedback.\n\nOn 2019-08-29 15:10:43 +0100, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 28/08/2019 02:17, Niklas Söderlund wrote:\n> > Allow IPA implementations to use internal libcamera headers so they can\n> > utilize helpers not exposed to applications.\n> > \n> \n> This sounds reasonable, but we're interacting against a list of\n> 'ipa_dummy_sources', I suspect we should change the list name to\n> something more like 'ipa_sources' or such.\n\nGood spot, not sure how I missed that.\n\n> \n> I see you've later added the rkisp-IPA to the same list to make use of\n> this shared_module definition.\n\nI will rename this list in the patch where I add the rkisp1 IPA as I \nthink it makes most sens.\n\n> \n> Do you anticipate that IPA's will be single file implementations? (in\n> which case keeping them all at this level, and in this list is fine) -\n> or could they become more complex? In which case we might want to try to\n> generalise this shared_module definition some other way too.\n\nI think over time they will grow to span multiple files, but for now I \nlike to keep it simple and build out once we know what we need.\n\n> \n> All that said, I think we can defer worrying about complex IPAs until we\n> have one - and keep single files for now.\n\nI agree :-)\n\n> \n> But that would suggest that the rename of the list might be appropriate\n> either jointly in this patch, or as an extra.\n\nI will do so when I add the rkisp1 IPA.\n\n> \n> Anyway, for the include_directories change:\n> \n> Reviewed-by: Kieran Bingham \n> \n> But don't let that stop you updating this patch to rename the\n> ipa_dummy_source list as well if you feel it's appropriate here as a\n> similar preparatory step.\n> \n> \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/ipa/meson.build | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> > index 2b9863bce3eabe80..dca7a9461385b68d 100644\n> > --- a/src/ipa/meson.build\n> > +++ b/src/ipa/meson.build\n> > @@ -9,7 +9,7 @@ foreach t : ipa_dummy_sources\n> > ipa = shared_module(t[0],\n> > t[1],\n> > name_prefix : '',\n> > - include_directories : libcamera_includes,\n> > + include_directories : includes,\n> > install : true,\n> > install_dir : ipa_install_dir)\n> > endforeach\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A35AC60BE5\n\tfor ;\n\tThu, 29 Aug 2019 22:52:32 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id x18so4415565ljh.1\n\tfor ;\n\tThu, 29 Aug 2019 13:52:32 -0700 (PDT)","from localhost (h-177-236.A463.priv.bahnhof.se. [217.31.177.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t3sm97633ljs.20.2019.08.29.13.52.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 29 Aug 2019 13:52:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=xQMAFrwAUgwz/30fJ9LWFCGSadjvg/yVYEZig51i7jw=;\n\tb=xV7uM56q7H0Yb72AGqzpWknecNqcISpAM3TJYr/la2eIH/q/FV5f+a792ZaFDcYpqT\n\tjsjfd1Xw/7HwRkLxIJ2WfsOMY1M7+Nf5be0K+p5sIxiQzYL810jmjIZ94Y7g6KNdzcLO\n\ti4+0Say5iiaXg0D3H2iqJbggNy8Pc2qgLU04gClRx0sTcaTxy+AP1NY9g7uE4z0+Yt77\n\tYETqi2GGYVdITukOJkVV2HCCfFarBLC6DJjj+GDquP/S7qLpwwlnnE2KYYDW73EH5KRg\n\tRUwI9StUODJ3XYAOj9f03pbRtK9VPKocXm3LTvrYE/7HJwqUM84y7jhRv3+1mFiUv9Br\n\tg6cA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=xQMAFrwAUgwz/30fJ9LWFCGSadjvg/yVYEZig51i7jw=;\n\tb=HjlIPTcJifsg8Xmb+duWAgGwLl1aJNnF69qs2TX6rq0uYic/wEXdSSw5ZXGz+iTKtp\n\tVMPm5PpslT+dVMJ6/0hxWXiF08QpeX9k767pN7vqkG/SyNRq6iu5Ww5t998++QmYUiuV\n\tP1ShhzNHgewTsa65m5noRiYpMCs0lyhK6biCeL1ELAYl+UpsGNvyIMz3MsAoIfCzDorv\n\txSA9jMn9Fa590YeUCjeiNU42OGWUW6D7NwjB9Eoct6a1m49a7K9lhD/rjIrh4bn/EQKh\n\tucKnnPy8DjvsPevWi4L3wLxrXGRRwKROeccdR0cIL7znVGSouzKK458L2ukX2s+dUrse\n\toVJQ==","X-Gm-Message-State":"APjAAAVa9g4u6h5IxiuruNFxjh1H9zdYZszwyb3/5v/PY+gQuTDDLvpj\n\tFr/BSiFEYNAhS376IZL0aJqE6w==","X-Google-Smtp-Source":"APXvYqyHTxYt3nAUettWI68v/NDxWX623KbJvuLB03ijgrJsgva0zChGT5vdkNizFkIw0F27EJJQpA==","X-Received":"by 2002:a05:651c:104a:: with SMTP id\n\tx10mr6313805ljm.238.1567111951971; \n\tThu, 29 Aug 2019 13:52:31 -0700 (PDT)","Date":"Thu, 29 Aug 2019 22:52:30 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190829205230.GE8479@bigcity.dyn.berto.se>","References":"<20190828011710.32128-1-niklas.soderlund@ragnatech.se>\n\t<20190828011710.32128-10-niklas.soderlund@ragnatech.se>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 09/13] libcamera: ipa: meson: Allow\n\taccess to internal libcamera headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 20:52:32 -0000"}}]