{"id":18738,"url":"https://patchwork.libcamera.org/api/patches/18738/?format=json","web_url":"https://patchwork.libcamera.org/patch/18738/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230615172608.378258-2-kieran.bingham@ideasonboard.com>","date":"2023-06-15T17:26:04","name":"[libcamera-devel,v4,1/5] libcamera: internal: request: convert to pragma once","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1b789fb14afa9163ead3d605445ebbaf453336be","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18738/mbox/","series":[{"id":3925,"url":"https://patchwork.libcamera.org/api/series/3925/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3925","date":"2023-06-15T17:26:03","name":"libcamera: Add new Camera devices property","version":4,"mbox":"https://patchwork.libcamera.org/series/3925/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18738/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18738/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58F00C322E\n\tfor ;\n\tThu, 15 Jun 2023 17:26:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F53A628B6;\n\tThu, 15 Jun 2023 19:26:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E705614FE\n\tfor ;\n\tThu, 15 Jun 2023 19:26:16 +0200 (CEST)","from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F8ACDA8;\n\tThu, 15 Jun 2023 19:25:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686849979;\n\tbh=UWg16aKjq9hZguPIsJUHsMnOeEtA2mQX06lQp7MG3yM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Z9Fu+swT2kHbYB7AHCUwagI8XmRCnNPJ7LI/ZRAPvoOAsDnrh8kVBMS06wnsIrQqC\n\th+uwoli3QZGf1nWXiU/MJ8AtGNgJyP3tzJ4O5scuSpcCKDlM6Q1WlInzc3mQUbCoKq\n\tbnBSDaGAQL0Oz0pa8qwuNv4JYyZAnU+6XACxrLWbjVsuQZu9NrSAQ5IkpaUxqGpTFz\n\t67Y3j3iJBM5HmIUD/LWutPgas+msDX4OLOSC8jvruVIvcY51Sys5YtK839ki1CV+iw\n\tainAol6NWsItFK8ieeezkgwb44TDYHYgtg8PY1X0XObc7Gejd8jUMApQ5DpM5tGxWC\n\tsNbNKbE9SmwjQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686849944;\n\tbh=UWg16aKjq9hZguPIsJUHsMnOeEtA2mQX06lQp7MG3yM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cro3J0hDPoeVGlnB/8Mdoy0kZ9EOySQUzPfY74+12Z6vikDhVx5LSIuCR+VYanR/q\n\tIMaTuzxGqeiGUEXnXpg4VYzpM/n/WPXwdm9NjHj2acHEe78MTbwBtqiTTPVLcp+gf1\n\tLH/rqH6YJlOKG2YOtDMFIEyMd47QjFL1y78AVpPo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cro3J0hD\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Thu, 15 Jun 2023 18:26:04 +0100","Message-Id":"<20230615172608.378258-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230615172608.378258-1-kieran.bingham@ideasonboard.com>","References":"<20230615172608.378258-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 1/5] libcamera: internal: request:\n\tconvert to pragma once","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tAshok Sidipotu ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nThe internal/request.h was missed at the time of the original\nconversion. Update it.\n\nFixes: df131ad08893 (\"libcamera: internal: Convert to pragma once\")\nTested-by: Ashok Sidipotu \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \nSigned-off-by: Kieran Bingham \n---\n include/libcamera/internal/request.h | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 8c92a27a95e5..3454cf5a72f5 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -4,8 +4,8 @@\n *\n * request.h - Request class private data\n */\n-#ifndef __LIBCAMERA_INTERNAL_REQUEST_H__\n-#define __LIBCAMERA_INTERNAL_REQUEST_H__\n+\n+#pragma once\n \n #include \n #include \n@@ -62,5 +62,3 @@ private:\n };\n \n } /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_INTERNAL_REQUEST_H__ */\n","prefixes":["libcamera-devel","v4","1/5"]}