[{"id":27329,"web_url":"https://patchwork.libcamera.org/comment/27329/","msgid":"<168665604551.2889415.932936380606209817@Monstersaurus>","date":"2023-06-13T11:34:05","subject":"Re: [libcamera-devel] [PATCH 1/2] gstreamer: src: Style change","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Robert,\n\nQuoting Robert Mader via libcamera-devel (2023-06-13 11:34:49)\n> Get rid of a variable and use a more common style in Gstreamer in\n> preparation for more properties.\n> \n> Signed-off-by: Robert Mader \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 15 ++++++++-------\n> 1 file changed, 8 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index a10cbd4f..721b35c2 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -837,11 +837,12 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n> &request_src_template,\n> GST_TYPE_LIBCAMERA_PAD);\n> \n> - GParamSpec *spec = g_param_spec_string(\"camera-name\", \"Camera Name\",\n> - \"Select by name which camera to use.\", nullptr,\n> - (GParamFlags)(GST_PARAM_MUTABLE_READY\n> - | G_PARAM_CONSTRUCT\n> - | G_PARAM_READWRITE\n> - | G_PARAM_STATIC_STRINGS));\n> - g_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n> + g_object_class_install_property(object_class, PROP_CAMERA_NAME,\n> + g_param_spec_string(\"camera-name\", \"Camera Name\",\n\nThis sounds fine to me - but the indentation is going to drive our\nclang-format crazy which means this generates a fair bit of checkstyle\nnoise.\n\nIn this instance, I think it's fine - as we probably expect in the\nfuture that this component could get moved into the gstreamer project so\nshould be more closely aligned to styles there perhaps.\n\nI don't think I can make clang-format/checkstyle have per file rules ;-(\n\nAnyway, that's just checker noise. For the change:\n\n\nReviewed-by: Kieran Bingham \n\n> + \"Select by name which camera to use.\",\n> + nullptr,\n> + (GParamFlags)(GST_PARAM_MUTABLE_READY\n> + | G_PARAM_CONSTRUCT\n> + | G_PARAM_READWRITE\n> + | G_PARAM_STATIC_STRINGS)));\n> }\n> -- \n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CBB8C31E9\n\tfor ;\n\tTue, 13 Jun 2023 11:34:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B690D61E50;\n\tTue, 13 Jun 2023 13:34:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 720E661E49\n\tfor ;\n\tTue, 13 Jun 2023 13:34:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33585E4;\n\tTue, 13 Jun 2023 13:33:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686656049;\n\tbh=8EJXdmhjk8IXfB/aLYSOPyrFjPCT0MIRjb3T80Ebv/E=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XyC4/DjgsOfdSCeZhjD7f6CVMp6Pb6SC04b4Gk2hGNHfcBUaga2Cr4p/68GPupvid\n\tCRXdLiV1eR5nzaudmpFjMjOXZ0sJdQZNm95s7uViRXEOciKrya8yhupM8wJF+Ms6p1\n\t/ISgLIGaqKCfhbd7exKTw+PeNCAv8QFpNri1l/m289JDtFkgQrGvA5sKGYI15v5/zt\n\tkbznV+bRud34ZgVCMWHToqzKdUy0sVkrxqPq99KXluxScL5iACBXUqzXYtA588S5Zv\n\t+24SN9D04hYLDlobUoXHqKPhrB3+FhK48La4P+mj3kKlAEfa/pghGuRWJJKH70MfsD\n\twOgJzoIIUHF1w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686656018;\n\tbh=8EJXdmhjk8IXfB/aLYSOPyrFjPCT0MIRjb3T80Ebv/E=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=V9/+LhW7IHZjUh+yiwAVrEQ7L+yIA8yqo09IQvsZgjlNSp0J1qcU40vO0ThbU2nbx\n\tMS5iEMpAtmz+oZN/m7z9hmvQMc/636dTo96MHSIrN2jcqokpH2dA1CWXgzovfTApuM\n\tf+ZO9CEA0l3DwrTnl9PzDUWpENEf7S/4ZSFR4Bz8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"V9/+LhW7\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230613103519.91370-2-robert.mader@collabora.com>","References":"<20230613103519.91370-1-robert.mader@collabora.com>\n\t<20230613103519.91370-2-robert.mader@collabora.com>","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 13 Jun 2023 12:34:05 +0100","Message-ID":"<168665604551.2889415.932936380606209817@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/2] gstreamer: src: Style change","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Robert Mader ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27332,"web_url":"https://patchwork.libcamera.org/comment/27332/","msgid":"<44f97a9f782931b3000edfe343cfbf814c9e84f8.camel@ndufresne.ca>","date":"2023-06-13T14:26:00","subject":"Re: [libcamera-devel] [PATCH 1/2] gstreamer: src: Style change","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mardi 13 juin 2023 à 12:34 +0100, Kieran Bingham via libcamera-devel a\nécrit :\n> Hi Robert,\n> \n> Quoting Robert Mader via libcamera-devel (2023-06-13 11:34:49)\n> > Get rid of a variable and use a more common style in Gstreamer in\n> > preparation for more properties.\n> > \n> > Signed-off-by: Robert Mader \n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 15 ++++++++-------\n> > 1 file changed, 8 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> > index a10cbd4f..721b35c2 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -837,11 +837,12 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n> > &request_src_template,\n> > GST_TYPE_LIBCAMERA_PAD);\n> > \n> > - GParamSpec *spec = g_param_spec_string(\"camera-name\", \"Camera Name\",\n> > - \"Select by name which camera to use.\", nullptr,\n> > - (GParamFlags)(GST_PARAM_MUTABLE_READY\n> > - | G_PARAM_CONSTRUCT\n> > - | G_PARAM_READWRITE\n> > - | G_PARAM_STATIC_STRINGS));\n> > - g_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n> > + g_object_class_install_property(object_class, PROP_CAMERA_NAME,\n> > + g_param_spec_string(\"camera-name\", \"Camera Name\",\n> \n> This sounds fine to me - but the indentation is going to drive our\n> clang-format crazy which means this generates a fair bit of checkstyle\n> noise.\n> \n> In this instance, I think it's fine - as we probably expect in the\n> future that this component could get moved into the gstreamer project so\n> should be more closely aligned to styles there perhaps.\n> \n> I don't think I can make clang-format/checkstyle have per file rules ;-(\n> \n> Anyway, that's just checker noise. For the change:\n> \n> \n> Reviewed-by: Kieran Bingham \n\np.s. I had this split like this to make the style check happy. Not sure it was\nimportant enough to change it to something the checker does not like ?\n\n> \n> > + \"Select by name which camera to use.\",\n> > + nullptr,\n> > + (GParamFlags)(GST_PARAM_MUTABLE_READY\n> > + | G_PARAM_CONSTRUCT\n> > + | G_PARAM_READWRITE\n> > + | G_PARAM_STATIC_STRINGS)));\n> > }\n> > -- \n> > 2.41.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D58A5BD78E\n\tfor ;\n\tTue, 13 Jun 2023 14:26:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 091EF61E50;\n\tTue, 13 Jun 2023 16:26:04 +0200 (CEST)","from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com\n\t[IPv6:2607:f8b0:4864:20::72b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 855CD61E49\n\tfor ;\n\tTue, 13 Jun 2023 16:26:02 +0200 (CEST)","by mail-qk1-x72b.google.com with SMTP id\n\taf79cd13be357-75ebccc2c9bso95168085a.2\n\tfor ;\n\tTue, 13 Jun 2023 07:26:02 -0700 (PDT)","from nicolas-tpx395.localdomain ([2606:6d00:15:c623::7a9])\n\tby smtp.gmail.com with ESMTPSA id\n\t6-20020a05620a070600b0075f04e2f556sm2581587qkc.33.2023.06.13.07.26.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 13 Jun 2023 07:26:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686666364;\n\tbh=wBnoS1NambEiAfvzj5izTy81odMgpxB4cp4rzvk5qYY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=m0m5ME8e5lq7NtOlZ8tqAEj61ck5mKLfhmCu5Qn3AcIRxTjBsGDXlpcdah6VYHPwY\n\t+uF6rnFkuVIg2Oj8E4SDYxcb1RWKCDvhycmcoNx4TZexUfQ/Bg/eBl2+MYJbl6zdkt\n\tw+hgkF5heCK6ooYNyxqzfyE23sn3W1e1NjCPqKeEGNTaG6p+2CxpMmtFc6P7HH2ANl\n\theujw95sOs/jOgJGe4Dq8ydqHH58ez8bbDqhWkL/D/DC2We4p7Pvcl7Tj/AhHzD5RU\n\t9k9WbWyOLEOmJiDT4/7DJZTOvMT939NumHeA0WDuSMv7AQCWtinIIJmODkbtVvblQ/\n\tmPK6xt4Ca2jtg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20221208.gappssmtp.com; s=20221208; t=1686666361;\n\tx=1689258361; \n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=uUwNI46eOFsObQmtuDyvWqe8limXsi36B8bgDsuFYe8=;\n\tb=oPYFADz7Nano1EyXr9n0Y3FCQR/ZCSIkhZJhFQVyTSr1iuXPpV5Io3sZYBlDiZbrz/\n\tCrdfbF+TqkiuJ7NbG8TTD5GW9EgAtNpZQlCek1VZAfWL0kO9EECElxkUWHUdsye4hRsU\n\th61R8uuwVy2B2IkqDmzegjm/WLz3bHxkMdpKdNA/ORMiO/+KAr01KRomCGCzZAFxu7vM\n\tSnnPK5TxYXkQC2fbCdWGhUtj8yoKRs+QR/CskaUP+487p/xZ7TCtZLlANSHRI3Qr+Ptc\n\tuH4uM4TcjrWMeXKUOP4qSvrBg35P1hUXF0KvVUMKS/JguNGSbij4dQ84xP5XBsvaQMHw\n\tgwDQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ndufresne-ca.20221208.gappssmtp.com\n\theader.i=@ndufresne-ca.20221208.gappssmtp.com header.b=\"oPYFADz7\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1686666361; x=1689258361;\n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=uUwNI46eOFsObQmtuDyvWqe8limXsi36B8bgDsuFYe8=;\n\tb=jaRr30j2gtUEVFT/NicCR6QpoXxsC/a0FtWEUxrqMYSiekSmju6UndWiJ6N20xxK8s\n\tv56bv9hIVGx8hV9FqzplC35hlKOM2aOdeuwa2JWtOwDS9wubKPNtHZFQTor/sNXXtP2Z\n\t7JYLZU9WSS6Qet8dId9/dhBbggm+Ffq9Emc/4s6sqcHfZF+RClf8ayLY/U1hmLjBvCCk\n\toNveheuECcsxKUL8vJA/RsWS9U8nhgCIJq/Xb+cbjxJBLPp5apRZAdqHXyT8SMxidF4Y\n\tZWJnnzQ9GGPXL6r+Tedp3A3j+sgcla8zaohiFxrdEqyfejwo443H+EeppwAX6qhuptxV\n\tsyCA==","X-Gm-Message-State":"AC+VfDycnAaaYw/GnmbrI1rludRyGuj3Ve506SjjSkvAG5f0n0gedUkx\n\tZlMIezqfxD4R7VIjqIXfBx4QshH6YsnlvYe5DeQ=","X-Google-Smtp-Source":"ACHHUZ6uCc9h06Q0/Vcz8vE1FwKRATOp2nuct9ON32loPnuV1C66TjGqgx8tAH3g5W+1NtWW9R3Lzg==","X-Received":"by 2002:a05:620a:1721:b0:75d:8e67:52d3 with SMTP id\n\taz33-20020a05620a172100b0075d8e6752d3mr14946369qkb.73.1686666361244; \n\tTue, 13 Jun 2023 07:26:01 -0700 (PDT)","Message-ID":"<44f97a9f782931b3000edfe343cfbf814c9e84f8.camel@ndufresne.ca>","To":"Kieran Bingham , Robert Mader\n\t, libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Jun 2023 10:26:00 -0400","In-Reply-To":"<168665604551.2889415.932936380606209817@Monstersaurus>","References":"<20230613103519.91370-1-robert.mader@collabora.com>\n\t<20230613103519.91370-2-robert.mader@collabora.com>\n\t<168665604551.2889415.932936380606209817@Monstersaurus>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.48.3 (3.48.3-1.fc38) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH 1/2] gstreamer: src: Style change","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicolas Dufresne via libcamera-devel\n\t","Reply-To":"Nicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27339,"web_url":"https://patchwork.libcamera.org/comment/27339/","msgid":"<8dc457ce-0682-2bc3-48aa-33f9716e5ae1@ideasonboard.com>","date":"2023-06-13T17:39:57","subject":"Re: [libcamera-devel] [PATCH 1/2] gstreamer: src: Style change","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nThank you for the patch.\n\nProbably the commit title can be expanded a bit more...\n\nOn 6/13/23 5:04 PM, Kieran Bingham via libcamera-devel wrote:\n> Hi Robert,\n>\n> Quoting Robert Mader via libcamera-devel (2023-06-13 11:34:49)\n>> Get rid of a variable and use a more common style in Gstreamer in\n>> preparation for more properties.\n>>\n>> Signed-off-by: Robert Mader \n>> ---\n>> src/gstreamer/gstlibcamerasrc.cpp | 15 ++++++++-------\n>> 1 file changed, 8 insertions(+), 7 deletions(-)\n>>\n>> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n>> index a10cbd4f..721b35c2 100644\n>> --- a/src/gstreamer/gstlibcamerasrc.cpp\n>> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n>> @@ -837,11 +837,12 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n>> &request_src_template,\n>> GST_TYPE_LIBCAMERA_PAD);\n>> \n>> - GParamSpec *spec = g_param_spec_string(\"camera-name\", \"Camera Name\",\n>> - \"Select by name which camera to use.\", nullptr,\n>> - (GParamFlags)(GST_PARAM_MUTABLE_READY\n>> - | G_PARAM_CONSTRUCT\n>> - | G_PARAM_READWRITE\n>> - | G_PARAM_STATIC_STRINGS));\n>> - g_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n>> + g_object_class_install_property(object_class, PROP_CAMERA_NAME,\n>> + g_param_spec_string(\"camera-name\", \"Camera Name\",\n> This sounds fine to me - but the indentation is going to drive our\n> clang-format crazy which means this generates a fair bit of checkstyle\n> noise.\n>\n> In this instance, I think it's fine - as we probably expect in the\n> future that this component could get moved into the gstreamer project so\n> should be more closely aligned to styles there perhaps.\n>\n> I don't think I can make clang-format/checkstyle have per file rules ;-(\n>\n> Anyway, that's just checker noise. For the change:\n>\n>\n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n\n>\n>> + \"Select by name which camera to use.\",\n>> + nullptr,\n>> + (GParamFlags)(GST_PARAM_MUTABLE_READY\n>> + | G_PARAM_CONSTRUCT\n>> + | G_PARAM_READWRITE\n>> + | G_PARAM_STATIC_STRINGS)));\n>> }\n>> -- \n>> 2.41.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55717BD78E\n\tfor ;\n\tTue, 13 Jun 2023 17:40:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B981661E4B;\n\tTue, 13 Jun 2023 19:40:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C6EF61E49\n\tfor ;\n\tTue, 13 Jun 2023 19:40:03 +0200 (CEST)","from [192.168.1.108] (unknown [103.86.18.143])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 45FB51AE;\n\tTue, 13 Jun 2023 19:39:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686678005;\n\tbh=2yW6lV2svCSacRUGyesVJiU6yFlwckTqyIlauLaHqCQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ZE3RwbDkCrNYr/QPUQfLKl/uHOtnyfhIGr5Y9HbhQeLE3wmeb97eawoYtiE5Zgp6O\n\tQkCH4kna7rqtjJ8wXl9YA62JtVjyW0sIM3wgnk9KWmSX8mIS0S+i3eH/eGox5sfqGU\n\tiF6C2XrUQKlYUpj0i8eY+A946fxo9dARV7mkBKCTpyP+KHQfxEd60p4wU65fFWnB7z\n\tBr4Bn/Mu/1l2tgnqwU2IbHAUcrhDt0ToOd2R2KycpQ4sQfXRH2XXPd4VbGpb0E9gwQ\n\tTAxcJdQiUbmsblMgA9avWV5Up9IX9Oo8MvybQtKT8SoJ0NOvNe0tqUlNfbdLqACmUV\n\tsueXSADdGZ6fw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686677973;\n\tbh=2yW6lV2svCSacRUGyesVJiU6yFlwckTqyIlauLaHqCQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=N55a3sFfjaRD/DG5YJSWqJkiVCNlpxodWB0DiBwumtOHNBqe+3aAouz0ZEHV+T4F7\n\tOFlwFLzlhdkf3wBuEf1dxzUvxxtLhB9DfvC3NVvO89LSXRaMrkUWaS88hAlA6tI3X+\n\tojaDSS0wbXTWNZhwBsYHegJ5OlYLla5n6yuB5eNM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"N55a3sFf\"; dkim-atps=neutral","Message-ID":"<8dc457ce-0682-2bc3-48aa-33f9716e5ae1@ideasonboard.com>","Date":"Tue, 13 Jun 2023 23:09:57 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tRobert Mader ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230613103519.91370-1-robert.mader@collabora.com>\n\t<20230613103519.91370-2-robert.mader@collabora.com>\n\t<168665604551.2889415.932936380606209817@Monstersaurus>","In-Reply-To":"<168665604551.2889415.932936380606209817@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] gstreamer: src: Style change","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]