[{"id":27479,"web_url":"https://patchwork.libcamera.org/comment/27479/","msgid":"<168851525998.3298873.9140039669101081841@Monstersaurus>","date":"2023-07-05T00:00:59","subject":"Re: [libcamera-devel] [PATCH v1 1/4] utils: checkstyle: Add\n\t__repr__ method to CommitFile class","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-06-12 23:47:48)\n> Add a custom representation to the CommitFile class in order to\n> facilitate debugging.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/checkstyle.py | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 5cc523b6fba3..7da888d8c365 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -191,6 +191,9 @@ class CommitFile:\n> else:\n> self.__filename = info[1]\n> \n> + def __repr__(self):\n> + return f'{self.__status} {self.__filename}'\n> +\n> @property\n> def filename(self):\n> return self.__filename\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BCC6BDC71\n\tfor ;\n\tWed, 5 Jul 2023 00:01:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58374628BB;\n\tWed, 5 Jul 2023 02:01:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB66961E38\n\tfor ;\n\tWed, 5 Jul 2023 02:01:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4FD918CC;\n\tWed, 5 Jul 2023 02:00:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688515264;\n\tbh=LroI3tV20CpZxp7NGLKPniB2FUWB37NeZc055oekTH4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hlCm570U2bqO6KzVqZ5J8YYF9mqIS9oVmsQWs1G8goPkbQLp3/QSchWPEBBoDGDDy\n\tde2NdN07xlK2hT++C2LW39wUmHMmCkA0qe2CBggOXghkH15XC7NtIi02ioWLVSgHSh\n\tCUeG/p/k0exHaG2BgfqBvP6GycGCCEuKp/CE+zwM21S/tnRUcu/Bzfr77DVP+ekAW1\n\tAcJ2lhQNEjhQpS0O56iePGIgj6fhsX3ejAg0f+F9I4RxFK1MD9WUDMflzPjqmUfG2Y\n\tSrORyqgRzptpjSJRppomT/QDaGZi9RbRKvhW0rpt0AB4FmXe+JJkB3LthPHKHXlFIZ\n\t4q8AUun27emAw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688515218;\n\tbh=LroI3tV20CpZxp7NGLKPniB2FUWB37NeZc055oekTH4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ohtit+boT/boLD+qES5wWjj5DnzISGV8z256wGMOqi9a94DsQX8mDSIApFRVBY6ec\n\tU0aD+WKeJ52k6rzctn8vx0AxWdWtY0GjPWq0Q7/sT4zymWvELspBVlAe81oi7QoqM1\n\txyHhE0mbFvrZYRbL9ZmabPvAhYwiXqa07D55BDzc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ohtit+bo\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230612224751.4437-2-laurent.pinchart@ideasonboard.com>","References":"<20230612224751.4437-1-laurent.pinchart@ideasonboard.com>\n\t<20230612224751.4437-2-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 05 Jul 2023 01:00:59 +0100","Message-ID":"<168851525998.3298873.9140039669101081841@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 1/4] utils: checkstyle: Add\n\t__repr__ method to CommitFile class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]