[{"id":27320,"web_url":"https://patchwork.libcamera.org/comment/27320/","msgid":"<20230612160711.GB28480@pendragon.ideasonboard.com>","date":"2023-06-12T16:07:11","subject":"Re: [libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the\n\tscript to work with recent media-ctl versions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hans,\n\nThank you for the patch.\n\nOn Mon, Jun 12, 2023 at 05:39:34PM +0200, Hans de Goede via libcamera-devel wrote:\n> Recent media-ctl versions include the framerate in the fmt property output:\n> \n> - entity 37: ov5693 4-0036 (1 pad, 1 link)\n> type V4L2 subdev subtype Sensor flags 0\n> device node name /dev/v4l-subdev6\n> \tpad0: Source\n> \t\t[fmt:SBGGR10_1X10/2592x1944@1/30\n> \t\t crop.bounds:(16,6)/2592x1944\n> \t\t crop:(16,6)/2592x1944]\n> \t\t-> \"ipu3-csi2 1\":0 [ENABLED]\n> \n> This resulted in $sensor_size getting set to: \"2592x1944@1 30\", which\n> causes the script to fail.\n> \n> Fix this by:\n> \n> 1. Replacing the gsub() to remove the '/' between e.g. SBGGR10_1X10\n> and 2592x1944 with a sub() so that only that first '/' gets replaced\n> (resulting in a $sensor_size of \"2592x1944@1/30\" instead).\n> \n> 2. Adding a new sub() to remove the @1/30 suffix.\n> \n> Signed-off-by: Hans de Goede \n\nDoes this mean you have a use for this script ? I was actually\nconsidering dropping it, as it's clearly unmaintained, and has long\noutlived its initial purpose of helping developing the IPU3 pipeline\nhandler.\n\n> ---\n> utils/ipu3/ipu3-capture.sh | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/ipu3/ipu3-capture.sh b/utils/ipu3/ipu3-capture.sh\n> index ba6147b4..9294d025 100755\n> --- a/utils/ipu3/ipu3-capture.sh\n> +++ b/utils/ipu3/ipu3-capture.sh\n> @@ -63,7 +63,8 @@ parse_pipeline() {\n> \t\tif (sensor) {\n> \t\t\tgsub(\\\".*fmt:\\\", \\\"\\\");\n> \t\t\tgsub(\\\"[] ].*\\\", \\\"\\\");\n> -\t\t\tgsub(\\\"/\\\", \\\" \\\");\n> +\t\t\tsub(\\\"/\\\", \\\" \\\");\n> +\t\t\tsub(\\\"@[0-9]+/[0-9]+\\\", \\\"\\\");\n> \t\t\tformat=\\$0;\n> \t\t}\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DF1DC3220\n\tfor ;\n\tMon, 12 Jun 2023 16:07:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A566C61E4B;\n\tMon, 12 Jun 2023 18:07:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C5E561E4A\n\tfor ;\n\tMon, 12 Jun 2023 18:07:11 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91159480;\n\tMon, 12 Jun 2023 18:06:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686586032;\n\tbh=QfphTdYM4AQ9JFty4nm07aqR69DOqWQOPzjSphdYZnk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ykrijM6m/QGYtK/6/8irtOKsR27WhbFMN4qUIfuke2DKyyrQVfA4PAsFWIc2IyXZV\n\tkKonl51J6GAI1gnqsQU5Xj+AZl7ExpMKM57+6WbBR5/4rSSsp51ZXt7fVYurKWU/Li\n\t3gQRKkt4kLQUOo3cBZElJmNXPFb5bqiuYxxVTie5C+u46bYyBfQsn5ZZJ/tl6bIBtv\n\tbLsYG0+N3gisU9GfZ3Fy6sIPQ4n7LvhvBwVK0ns35PEkZwcGJfKFv3Phm4wHvlwlVS\n\t6HY3TPLEEawlwhP3fjJZWiSItC3qyxf+4xjemB1+dJRMW/BrHhESU4pDPi58aGDio0\n\tXZy7YnKtcf0rA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686586001;\n\tbh=QfphTdYM4AQ9JFty4nm07aqR69DOqWQOPzjSphdYZnk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J+n/FEERId46uNBLUBup+jVlbiH9s28IlcFePgdivFxQ4fUnqbXav4vHM8FylD0to\n\t9IMZEqVXusMEr4jJUWKxlFh91ycdrLoqv2kJbOtOhgD7Yw0yfFyeXFxrv746jRtfW5\n\tgtG+294qncqfYe5h+MfsGZlbyBbyhAp/euLnxvPw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"J+n/FEER\"; dkim-atps=neutral","Date":"Mon, 12 Jun 2023 19:07:11 +0300","To":"Hans de Goede ","Message-ID":"<20230612160711.GB28480@pendragon.ideasonboard.com>","References":"<20230612153934.5618-1-hdegoede@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230612153934.5618-1-hdegoede@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the\n\tscript to work with recent media-ctl versions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27323,"web_url":"https://patchwork.libcamera.org/comment/27323/","msgid":"<61792592-793a-425f-36c3-be02734f51aa@redhat.com>","date":"2023-06-12T18:23:10","subject":"Re: [libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the\n\tscript to work with recent media-ctl versions","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/people/102/","name":"Hans de Goede","email":"hdegoede@redhat.com"},"content":"Hi Laurent,\n\nOn 6/12/23 18:07, Laurent Pinchart wrote:\n> Hi Hans,\n> \n> Thank you for the patch.\n> \n> On Mon, Jun 12, 2023 at 05:39:34PM +0200, Hans de Goede via libcamera-devel wrote:\n>> Recent media-ctl versions include the framerate in the fmt property output:\n>>\n>> - entity 37: ov5693 4-0036 (1 pad, 1 link)\n>> type V4L2 subdev subtype Sensor flags 0\n>> device node name /dev/v4l-subdev6\n>> \tpad0: Source\n>> \t\t[fmt:SBGGR10_1X10/2592x1944@1/30\n>> \t\t crop.bounds:(16,6)/2592x1944\n>> \t\t crop:(16,6)/2592x1944]\n>> \t\t-> \"ipu3-csi2 1\":0 [ENABLED]\n>>\n>> This resulted in $sensor_size getting set to: \"2592x1944@1 30\", which\n>> causes the script to fail.\n>>\n>> Fix this by:\n>>\n>> 1. Replacing the gsub() to remove the '/' between e.g. SBGGR10_1X10\n>> and 2592x1944 with a sub() so that only that first '/' gets replaced\n>> (resulting in a $sensor_size of \"2592x1944@1/30\" instead).\n>>\n>> 2. Adding a new sub() to remove the @1/30 suffix.\n>>\n>> Signed-off-by: Hans de Goede \n> \n> Does this mean you have a use for this script ? I was actually\n> considering dropping it, as it's clearly unmaintained, and has long\n> outlived its initial purpose of helping developing the IPU3 pipeline\n> handler.\n\nI am working on getting the ov2680 on a Lenovo Miix 510 to work (1)\nafter verifying + fixing this script by capturing some raw frames\non a Surface Go with OV5693 my test plan is to first get\nthe capturing of raw frames working before moving to adding\nlibcamera support for the ov2680 sensor (which will require\nadding the mandatory controls to the driver).\n\nTL;DR: yes I have a use for this, being able to capture raw\nframes is useful to separately test the sensor driver bringup\nfrom hooking things up in libcamera.\n\nI was actually thinking that it would be nice to get something\nsimilar working on IPU6 .\n\nRegards,\n\nHans\n\n\n1) Both as a standalone project and because it is another way to\ntest the drivers/media/i2c/ov2680.c fixes and updates I've been\nworking on for atomisp.\n\n\n\n\n\n> \n>> ---\n>> utils/ipu3/ipu3-capture.sh | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/utils/ipu3/ipu3-capture.sh b/utils/ipu3/ipu3-capture.sh\n>> index ba6147b4..9294d025 100755\n>> --- a/utils/ipu3/ipu3-capture.sh\n>> +++ b/utils/ipu3/ipu3-capture.sh\n>> @@ -63,7 +63,8 @@ parse_pipeline() {\n>> \t\tif (sensor) {\n>> \t\t\tgsub(\\\".*fmt:\\\", \\\"\\\");\n>> \t\t\tgsub(\\\"[] ].*\\\", \\\"\\\");\n>> -\t\t\tgsub(\\\"/\\\", \\\" \\\");\n>> +\t\t\tsub(\\\"/\\\", \\\" \\\");\n>> +\t\t\tsub(\\\"@[0-9]+/[0-9]+\\\", \\\"\\\");\n>> \t\t\tformat=\\$0;\n>> \t\t}\n>> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0CBFC3220\n\tfor ;\n\tMon, 12 Jun 2023 18:23:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 313F261E4B;\n\tMon, 12 Jun 2023 20:23:17 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D72AE61E4A\n\tfor ;\n\tMon, 12 Jun 2023 20:23:15 +0200 (CEST)","from mail-ed1-f70.google.com (mail-ed1-f70.google.com\n\t[209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-117-aoMJ3XzoPm6zmATD9NVPbg-1; Mon, 12 Jun 2023 14:23:13 -0400","by mail-ed1-f70.google.com with SMTP id\n\t4fb4d7f45d1cf-514a1501b0eso3412612a12.2\n\tfor ;\n\tMon, 12 Jun 2023 11:23:13 -0700 (PDT)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\tu13-20020a50eacd000000b005149b6ec1bdsm5350735edp.29.2023.06.12.11.23.10\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 12 Jun 2023 11:23:11 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686594197;\n\tbh=YB+lfcggE9bGTV4kttTCxUZST5G8OWwNK002xsEeOeU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Vzq7Q2FfxJgGLzFaPDiNNex+tnVfGup1AjzyRlcBccIltJkE6UcnLSuipkYWRiuNL\n\tJ9Nr7ANqnU48vxPU/scF/+IdcxWWdpGytORs2OZLl/Uyp932DgDxBmWLme68xA6btG\n\t2Z390z//UXrDcQOs+8KThp+Q+f9ObjnBJFUpRWKvorath+SH6ys3wC0z2uOy8aSvcn\n\tpw0vQDPxS6HlKZdJZiRGjaltxw3iW0cTvRilf6m68s7hZu3mPh1MTsb00uVgG/jrDO\n\tdi1UZ6EznyDSAPFOHnmdmW41Vg6hbbUKT2iTTLcR2U9ZdxZY8PQ+t8TTF80pgmjbOY\n\tTP/2y0ixEQksQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1686594194;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=TcWzB2lMLo3YvnLWQrQYZJNtyUBVQr2M97++NRuyvYU=;\n\tb=NPyOPP/fo8/5JXf0wmxpijks+hMtfvpjOBP1EiGa7fI/zi2H+B3VOP7Ee6SPJ0zgfV3zxR\n\t59LFgtYbJe9ZYVbar7lbB1zFqEuzfRUCuzto33QZPy8Z3e7p8jIULYSjDIeVyEbXm3FnP1\n\toR14sXMrH/2rR+sINJ8Uz5MyV1InlAk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"NPyOPP/f\"; \n\tdkim-atps=neutral","X-MC-Unique":"aoMJ3XzoPm6zmATD9NVPbg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1686594192; x=1689186192;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=TcWzB2lMLo3YvnLWQrQYZJNtyUBVQr2M97++NRuyvYU=;\n\tb=WZ6YbXWZYB6pG6uFh2hKcbdFBqWu+AT2EWgru1wxBQfA3MnVkW8lVtOekyGWfjsm3V\n\tXIWc/y/neH09pNGagCzg8XRx/Wf4LCgJurR8XXnMbwQNveLYw3TJX4q9QX1KZ4esPXEL\n\tl1MMyPKOriBs1K+FOY3GG2YdUrYzPlcJJC1rShVHRYwkmGEggNsfM/swXENkS3iKGJSd\n\tPDw/x02HYoM5dHn3TvJUkG9Pt9tRQn+0McF9GJTXJfMB43CdgeZK3X4pApsss99A1KBy\n\tHsHnA185HZ8Bi0Cmr+JZDu4Ebx+Ek7/w+ncjkUTJPqVcZ2NGyax61fp0Eh/NMyGVHrpX\n\tp40g==","X-Gm-Message-State":"AC+VfDy9HVIBdrv2irfZ/KkqCo8o0Ykiyh3TqbohB8ixu28V/rHynPcf\n\t+WEx2lX6ST/aQmuW1y71W+Bj4EyskmeJ9ay5szaPlPo7AgFUc9guiq8+bCEPKc59YeQhzPafC5B\n\t5E0volhJI5US+Lbpe5UIi6HiNhYxCZn6v3Bc+KH+g1g==","X-Received":["by 2002:a05:6402:358:b0:514:a69e:67cc with SMTP id\n\tr24-20020a056402035800b00514a69e67ccmr5366767edw.28.1686594191982; \n\tMon, 12 Jun 2023 11:23:11 -0700 (PDT)","by 2002:a05:6402:358:b0:514:a69e:67cc with SMTP id\n\tr24-20020a056402035800b00514a69e67ccmr5366756edw.28.1686594191617; \n\tMon, 12 Jun 2023 11:23:11 -0700 (PDT)"],"X-Google-Smtp-Source":"ACHHUZ7xcABXLmpwsfV+eOq07kzxCncNUb2jzJ/jaeUWwSqZfMD/BIas+lf6v39QiSbP47N51POjqg==","Message-ID":"<61792592-793a-425f-36c3-be02734f51aa@redhat.com>","Date":"Mon, 12 Jun 2023 20:23:10 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.10.0","To":"Laurent Pinchart ","References":"<20230612153934.5618-1-hdegoede@redhat.com>\n\t<20230612160711.GB28480@pendragon.ideasonboard.com>","In-Reply-To":"<20230612160711.GB28480@pendragon.ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US, nl","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the\n\tscript to work with recent media-ctl versions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Hans de Goede via libcamera-devel ","Reply-To":"Hans de Goede ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27476,"web_url":"https://patchwork.libcamera.org/comment/27476/","msgid":"<168851388619.3298873.11256882801920513669@Monstersaurus>","date":"2023-07-04T23:38:06","subject":"Re: [libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the\n\tscript to work with recent media-ctl versions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Hans de Goede via libcamera-devel (2023-06-12 19:23:10)\n> Hi Laurent,\n> \n> On 6/12/23 18:07, Laurent Pinchart wrote:\n> > Hi Hans,\n> > \n> > Thank you for the patch.\n> > \n> > On Mon, Jun 12, 2023 at 05:39:34PM +0200, Hans de Goede via libcamera-devel wrote:\n> >> Recent media-ctl versions include the framerate in the fmt property output:\n> >>\n> >> - entity 37: ov5693 4-0036 (1 pad, 1 link)\n> >> type V4L2 subdev subtype Sensor flags 0\n> >> device node name /dev/v4l-subdev6\n> >> pad0: Source\n> >> [fmt:SBGGR10_1X10/2592x1944@1/30\n> >> crop.bounds:(16,6)/2592x1944\n> >> crop:(16,6)/2592x1944]\n> >> -> \"ipu3-csi2 1\":0 [ENABLED]\n> >>\n> >> This resulted in $sensor_size getting set to: \"2592x1944@1 30\", which\n> >> causes the script to fail.\n> >>\n> >> Fix this by:\n> >>\n> >> 1. Replacing the gsub() to remove the '/' between e.g. SBGGR10_1X10\n> >> and 2592x1944 with a sub() so that only that first '/' gets replaced\n> >> (resulting in a $sensor_size of \"2592x1944@1/30\" instead).\n> >>\n> >> 2. Adding a new sub() to remove the @1/30 suffix.\n> >>\n> >> Signed-off-by: Hans de Goede \n> > \n> > Does this mean you have a use for this script ? I was actually\n> > considering dropping it, as it's clearly unmaintained, and has long\n> > outlived its initial purpose of helping developing the IPU3 pipeline\n> > handler.\n> \n> I am working on getting the ov2680 on a Lenovo Miix 510 to work (1)\n> after verifying + fixing this script by capturing some raw frames\n> on a Surface Go with OV5693 my test plan is to first get\n> the capturing of raw frames working before moving to adding\n> libcamera support for the ov2680 sensor (which will require\n> adding the mandatory controls to the driver).\n> \n> TL;DR: yes I have a use for this, being able to capture raw\n> frames is useful to separately test the sensor driver bringup\n> from hooking things up in libcamera.\n\nWell maybe we should pick this patch already then.\n\nI guess media-ctl shouldn't really be consumed by scripts like this -\nbut if it's working now at least we can save that and it may still be\nuseful in the future.\n\nReviewed-by: Kieran Bingham \n\n> \n> I was actually thinking that it would be nice to get something\n> similar working on IPU6 .\n> \n> Regards,\n> \n> Hans\n> \n> \n> 1) Both as a standalone project and because it is another way to\n> test the drivers/media/i2c/ov2680.c fixes and updates I've been\n> working on for atomisp.\n> \n> \n> \n> \n> \n> > \n> >> ---\n> >> utils/ipu3/ipu3-capture.sh | 3 ++-\n> >> 1 file changed, 2 insertions(+), 1 deletion(-)\n> >>\n> >> diff --git a/utils/ipu3/ipu3-capture.sh b/utils/ipu3/ipu3-capture.sh\n> >> index ba6147b4..9294d025 100755\n> >> --- a/utils/ipu3/ipu3-capture.sh\n> >> +++ b/utils/ipu3/ipu3-capture.sh\n> >> @@ -63,7 +63,8 @@ parse_pipeline() {\n> >> if (sensor) {\n> >> gsub(\\\".*fmt:\\\", \\\"\\\");\n> >> gsub(\\\"[] ].*\\\", \\\"\\\");\n> >> - gsub(\\\"/\\\", \\\" \\\");\n> >> + sub(\\\"/\\\", \\\" \\\");\n> >> + sub(\\\"@[0-9]+/[0-9]+\\\", \\\"\\\");\n> >> format=\\$0;\n> >> }\n> >> }\n> > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2636EBDC71\n\tfor ;\n\tTue, 4 Jul 2023 23:38:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 504D361E38;\n\tWed, 5 Jul 2023 01:38:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D53361E38\n\tfor ;\n\tWed, 5 Jul 2023 01:38:09 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 897A98CC;\n\tWed, 5 Jul 2023 01:37:24 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688513890;\n\tbh=1SffxiUoISDWrQRmYOg4BV3mhp4XrUXTXlPSHO3R9Fc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZTQpsg6Vw5T/UOEr0DYaKK357B5rTBIwQHanQYavCOMMN03mdgwX2+loiZ3fGqG0l\n\tROMw4NCV/V3EdI3w9HAiNZPljIoPYkYwfQHJeljpW+bCEukHCauqXwPny+Cp21VaYU\n\t+ohzMt4bZ302gQ8mdZoxQppau8gxxxAwjDbRUfh2sPu3LTddecZEAbusGrAdmVUFZg\n\tiKNW67+kE/FS3hCoCtVmdOIoBCW/Wk5OpUZ+L4+RIt0RyOy2Bf+A6nlqfZgrlJcXN6\n\tiGrirgNKbaVWCyD3awFRB/HRMhUu/YKrylCA+HKyzHkxn8n6240haI8nidqqzQ4L7n\n\tIG7iu31c1qp9g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688513844;\n\tbh=1SffxiUoISDWrQRmYOg4BV3mhp4XrUXTXlPSHO3R9Fc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=PdP894InnNpAZWz5+FZXCHLMtVPJ0jQM4gjgnudMDnw3uO/xkr9eQWbdw5tOAC6AB\n\t/LT3ExXMveaVtQzlMFbRi89SHcUqLxe/8o5aZYv1z4HqYbeOIXmRWJ+cbSGj/Lhqt1\n\tXljiJzsUl9Giu7ba503gTkwAC+RD6XnGVKVYUVmw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PdP894In\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<61792592-793a-425f-36c3-be02734f51aa@redhat.com>","References":"<20230612153934.5618-1-hdegoede@redhat.com>\n\t<20230612160711.GB28480@pendragon.ideasonboard.com>\n\t<61792592-793a-425f-36c3-be02734f51aa@redhat.com>","To":"Hans de Goede , Hans de Goede via libcamera-devel\n\t, \n\tLaurent Pinchart ","Date":"Wed, 05 Jul 2023 00:38:06 +0100","Message-ID":"<168851388619.3298873.11256882801920513669@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the\n\tscript to work with recent media-ctl versions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27477,"web_url":"https://patchwork.libcamera.org/comment/27477/","msgid":"<20230704234852.GA11949@pendragon.ideasonboard.com>","date":"2023-07-04T23:48:52","subject":"Re: [libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the\n\tscript to work with recent media-ctl versions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 05, 2023 at 12:38:06AM +0100, Kieran Bingham wrote:\n> Quoting Hans de Goede via libcamera-devel (2023-06-12 19:23:10)\n> > On 6/12/23 18:07, Laurent Pinchart wrote:\n> > > On Mon, Jun 12, 2023 at 05:39:34PM +0200, Hans de Goede via libcamera-devel wrote:\n> > >> Recent media-ctl versions include the framerate in the fmt property output:\n> > >>\n> > >> - entity 37: ov5693 4-0036 (1 pad, 1 link)\n> > >> type V4L2 subdev subtype Sensor flags 0\n> > >> device node name /dev/v4l-subdev6\n> > >> pad0: Source\n> > >> [fmt:SBGGR10_1X10/2592x1944@1/30\n> > >> crop.bounds:(16,6)/2592x1944\n> > >> crop:(16,6)/2592x1944]\n> > >> -> \"ipu3-csi2 1\":0 [ENABLED]\n> > >>\n> > >> This resulted in $sensor_size getting set to: \"2592x1944@1 30\", which\n> > >> causes the script to fail.\n> > >>\n> > >> Fix this by:\n> > >>\n> > >> 1. Replacing the gsub() to remove the '/' between e.g. SBGGR10_1X10\n> > >> and 2592x1944 with a sub() so that only that first '/' gets replaced\n> > >> (resulting in a $sensor_size of \"2592x1944@1/30\" instead).\n> > >>\n> > >> 2. Adding a new sub() to remove the @1/30 suffix.\n> > >>\n> > >> Signed-off-by: Hans de Goede \n> > > \n> > > Does this mean you have a use for this script ? I was actually\n> > > considering dropping it, as it's clearly unmaintained, and has long\n> > > outlived its initial purpose of helping developing the IPU3 pipeline\n> > > handler.\n> > \n> > I am working on getting the ov2680 on a Lenovo Miix 510 to work (1)\n> > after verifying + fixing this script by capturing some raw frames\n> > on a Surface Go with OV5693 my test plan is to first get\n> > the capturing of raw frames working before moving to adding\n> > libcamera support for the ov2680 sensor (which will require\n> > adding the mandatory controls to the driver).\n> > \n> > TL;DR: yes I have a use for this, being able to capture raw\n> > frames is useful to separately test the sensor driver bringup\n> > from hooking things up in libcamera.\n> \n> Well maybe we should pick this patch already then.\n> \n> I guess media-ctl shouldn't really be consumed by scripts like this -\n> but if it's working now at least we can save that and it may still be\n> useful in the future.\n> \n> Reviewed-by: Kieran Bingham \n\nRegardless of whether or not we decide to drop this script, I think we\nshouldn't leave it in a known broken state.\n\nReviewed-by: Laurent Pinchart \n\n> > I was actually thinking that it would be nice to get something\n> > similar working on IPU6 .\n> > \n> > Regards,\n> > \n> > Hans\n> > \n> > 1) Both as a standalone project and because it is another way to\n> > test the drivers/media/i2c/ov2680.c fixes and updates I've been\n> > working on for atomisp.\n> > \n> > >> ---\n> > >> utils/ipu3/ipu3-capture.sh | 3 ++-\n> > >> 1 file changed, 2 insertions(+), 1 deletion(-)\n> > >>\n> > >> diff --git a/utils/ipu3/ipu3-capture.sh b/utils/ipu3/ipu3-capture.sh\n> > >> index ba6147b4..9294d025 100755\n> > >> --- a/utils/ipu3/ipu3-capture.sh\n> > >> +++ b/utils/ipu3/ipu3-capture.sh\n> > >> @@ -63,7 +63,8 @@ parse_pipeline() {\n> > >> if (sensor) {\n> > >> gsub(\\\".*fmt:\\\", \\\"\\\");\n> > >> gsub(\\\"[] ].*\\\", \\\"\\\");\n> > >> - gsub(\\\"/\\\", \\\" \\\");\n> > >> + sub(\\\"/\\\", \\\" \\\");\n> > >> + sub(\\\"@[0-9]+/[0-9]+\\\", \\\"\\\");\n> > >> format=\\$0;\n> > >> }\n> > >> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C0F3BDC71\n\tfor ;\n\tTue, 4 Jul 2023 23:48:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C1A7628BB;\n\tWed, 5 Jul 2023 01:48:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED8B961E38\n\tfor ;\n\tWed, 5 Jul 2023 01:48:52 +0200 (CEST)","from pendragon.ideasonboard.com (85-160-42-71.reb.o2.cz\n\t[85.160.42.71])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B5418CC;\n\tWed, 5 Jul 2023 01:48:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688514534;\n\tbh=LU2cIGn7+vaiBCWJgMNlzU18MCnqRSMFfA7YUG4m0EM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3uEwGoJKlUuWyNK1XSVE229hdj6uR03imM+YAArRB7241X+rLtCPgN0OWnFLQNjkO\n\tLhJgfa8aUEtYUrsH9tXZ+Odm0l3EphShc/B1Jo8HUI9tqIA6uLnxL+pdd+hxp0jmTM\n\tL9tZv0lqpikNZgXr4Tmm2lZtAnpTSTKfZHs1O+sDIOwaFc6ll5mhMzW0D2LbXxCjha\n\tuBNbKo4nm9Qwq3vDHyQBcQztnkywEY32+HtTQCPnL+VMxcUU3yePaPerSHBJHU05BX\n\tJ4t7SXj/BShEsMz9pDc9qZ7ahX714PcDaA/A7iLJX6M0c7ehNvzYhrt4T6lF6G5c5v\n\tIadmzN1vkb9RQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688514488;\n\tbh=LU2cIGn7+vaiBCWJgMNlzU18MCnqRSMFfA7YUG4m0EM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GA9LxAUgTsURfTKxwyUwpJ8XFUbLWl8lL1/uCWiOpkuY5nbmeCSDSqkmF9kxT1ECV\n\tTazIyYQUQAoEaaUsnTRAoBKGLAB46mJDC2oCzglsxlez2/2+3wu+kgAqNL2u6nUjBQ\n\tBQv0BiV6niNlwVeJBa0e7XiQLdr+G5swPivNSbx8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GA9LxAUg\"; dkim-atps=neutral","Date":"Wed, 5 Jul 2023 02:48:52 +0300","To":"Kieran Bingham ","Message-ID":"<20230704234852.GA11949@pendragon.ideasonboard.com>","References":"<20230612153934.5618-1-hdegoede@redhat.com>\n\t<20230612160711.GB28480@pendragon.ideasonboard.com>\n\t<61792592-793a-425f-36c3-be02734f51aa@redhat.com>\n\t<168851388619.3298873.11256882801920513669@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<168851388619.3298873.11256882801920513669@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] utils: ipu3-capture.sh: Fix the\n\tscript to work with recent media-ctl versions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Hans de Goede via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]