[{"id":27303,"web_url":"https://patchwork.libcamera.org/comment/27303/","msgid":"<20230607145726.GC22127@pendragon.ideasonboard.com>","date":"2023-06-07T14:57:26","subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: tunings: Add missing short\n\tand long exposure profiles","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, Jun 07, 2023 at 12:48:07PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Some sensor tuning files were missing the short and/or long exposure\n> mode profiles. Add the missing items to the relevant files.\n> \n> As a drive-by, rename the \"sport\" exposure profile to \"short\" for the\n> IMX290 tuning.\n> \n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/ipa/rpi/vc4/data/imx290.json           |  7 ++++++-\n>  src/ipa/rpi/vc4/data/imx296.json           |  5 +++++\n>  src/ipa/rpi/vc4/data/imx296_mono.json      |  5 +++++\n>  src/ipa/rpi/vc4/data/imx378.json           |  5 +++++\n>  src/ipa/rpi/vc4/data/imx519.json           |  5 +++++\n>  src/ipa/rpi/vc4/data/imx708.json           |  5 +++++\n>  src/ipa/rpi/vc4/data/imx708_noir.json      |  5 +++++\n>  src/ipa/rpi/vc4/data/imx708_wide.json      |  5 +++++\n>  src/ipa/rpi/vc4/data/imx708_wide_noir.json |  5 +++++\n>  src/ipa/rpi/vc4/data/ov9281_mono.json      | 10 ++++++++++\n>  src/ipa/rpi/vc4/data/se327m12.json         |  5 +++++\n>  src/ipa/rpi/vc4/data/uncalibrated.json     | 10 ++++++++++\n>  12 files changed, 71 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/vc4/data/imx290.json b/src/ipa/rpi/vc4/data/imx290.json\n> index ace68d0ebf1c..8a7cadba38a2 100644\n> --- a/src/ipa/rpi/vc4/data/imx290.json\n> +++ b/src/ipa/rpi/vc4/data/imx290.json\n> @@ -70,10 +70,15 @@\n>                          \"shutter\": [ 10, 30000, 60000 ],\n>                          \"gain\": [ 1.0, 2.0, 8.0 ]\n>                      },\n> -                    \"sport\":\n> +                    \"short\":\n>                      {\n>                          \"shutter\": [ 10, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/imx296.json b/src/ipa/rpi/vc4/data/imx296.json\n> index ae8722c46a85..9330d0a9c81f 100644\n> --- a/src/ipa/rpi/vc4/data/imx296.json\n> +++ b/src/ipa/rpi/vc4/data/imx296.json\n> @@ -157,6 +157,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 8.0, 16.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\n> index db020550d70e..955af43cccff 100644\n> --- a/src/ipa/rpi/vc4/data/imx296_mono.json\n> +++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n> @@ -60,6 +60,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/imx378.json b/src/ipa/rpi/vc4/data/imx378.json\n> index 8b4ed22504b5..f7b68011b634 100644\n> --- a/src/ipa/rpi/vc4/data/imx378.json\n> +++ b/src/ipa/rpi/vc4/data/imx378.json\n> @@ -155,6 +155,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/imx519.json b/src/ipa/rpi/vc4/data/imx519.json\n> index 8ccfd3a631ff..1b0a77476aab 100644\n> --- a/src/ipa/rpi/vc4/data/imx519.json\n> +++ b/src/ipa/rpi/vc4/data/imx519.json\n> @@ -155,6 +155,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/imx708.json b/src/ipa/rpi/vc4/data/imx708.json\n> index b9830a3bf692..6b26d0a19609 100644\n> --- a/src/ipa/rpi/vc4/data/imx708.json\n> +++ b/src/ipa/rpi/vc4/data/imx708.json\n> @@ -165,6 +165,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/imx708_noir.json b/src/ipa/rpi/vc4/data/imx708_noir.json\n> index 075f70355cec..8d498153833b 100644\n> --- a/src/ipa/rpi/vc4/data/imx708_noir.json\n> +++ b/src/ipa/rpi/vc4/data/imx708_noir.json\n> @@ -165,6 +165,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/imx708_wide.json b/src/ipa/rpi/vc4/data/imx708_wide.json\n> index b772efee3b96..14bc918e7823 100644\n> --- a/src/ipa/rpi/vc4/data/imx708_wide.json\n> +++ b/src/ipa/rpi/vc4/data/imx708_wide.json\n> @@ -155,6 +155,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/imx708_wide_noir.json b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n> index c5f6b53dca7a..49442c0f9d81 100644\n> --- a/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n> +++ b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n> @@ -155,6 +155,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/ov9281_mono.json b/src/ipa/rpi/vc4/data/ov9281_mono.json\n> index 37944c63ad92..2b7292ec7e20 100644\n> --- a/src/ipa/rpi/vc4/data/ov9281_mono.json\n> +++ b/src/ipa/rpi/vc4/data/ov9281_mono.json\n> @@ -44,6 +44,16 @@\n>                      {\n>                          \"shutter\": [ 100, 15000, 30000, 60000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 3.0, 4.0, 8.0 ]\n> +                    },\n> +                    \"short\":\n> +                    {\n> +                        \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/se327m12.json b/src/ipa/rpi/vc4/data/se327m12.json\n> index ee69caea50c0..8552ed92bce6 100644\n> --- a/src/ipa/rpi/vc4/data/se327m12.json\n> +++ b/src/ipa/rpi/vc4/data/se327m12.json\n> @@ -155,6 +155,11 @@\n>                      {\n>                          \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":\n> diff --git a/src/ipa/rpi/vc4/data/uncalibrated.json b/src/ipa/rpi/vc4/data/uncalibrated.json\n> index 13eb3f177302..7654defa6dfe 100644\n> --- a/src/ipa/rpi/vc4/data/uncalibrated.json\n> +++ b/src/ipa/rpi/vc4/data/uncalibrated.json\n> @@ -31,6 +31,16 @@\n>                      {\n>                          \"shutter\": [ 100, 15000, 30000, 60000, 120000 ],\n>                          \"gain\": [ 1.0, 2.0, 3.0, 4.0, 6.0 ]\n> +                    },\n> +                    \"short\":\n> +                    {\n> +                        \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n> +                    },\n> +                    \"long\":\n> +                    {\n> +                        \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n> +                        \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n>                      }\n>                  },\n>                  \"constraint_modes\":","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FE02C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  7 Jun 2023 14:57:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F7D862886;\n\tWed,  7 Jun 2023 16:57:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B3C860579\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  7 Jun 2023 16:57:30 +0200 (CEST)","from pendragon.ideasonboard.com (om126233170111.36.openmobile.ne.jp\n\t[126.233.170.111])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C4F3FFA6;\n\tWed,  7 Jun 2023 16:57:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686149851;\n\tbh=yiM+05WHgWvocCVAJTCM6ViTjRYKbWgatO9wedo5YjQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CjETzueNL0MhQT/CHbKZ46OL/AQO1RKwUf8qmZwsejFxAjwZTrM8V9ugUxtHDYXih\n\tcOrQwVFmnGrdFWBk1Rhww15gjeYF1GqSQH3/2n3RyEekoYiLeDEnWjIoZovc9N2Uch\n\tYX6+yy8mFzVYRYpspYzNvi/rR7DAnh07L639xtRo9LsveemfWx0dgU9bqsgkSTsHpA\n\t6edAf8E2NOTbY1JzDjL4MbwETv2mj7aezSL82rVOTzSiddnE2AFxqxgl9KQIfEbrTc\n\tBDsBnVjJUrzhSAECClvQIj0RjFfKXrvS3DRzMBcy3X91TZhL7AYDXfDNvt+/yopEE3\n\tPoxrboREZep+A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686149823;\n\tbh=yiM+05WHgWvocCVAJTCM6ViTjRYKbWgatO9wedo5YjQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QGMOyGr4cPSrJ5/ScrIW7urHolj5lQbSrZ4dSIvmux3VdJe6ns6Et0aYblzZbMYNl\n\tvz8WA3nd1bqglpgWZlbDyEG6jN18WC6o5MEpbaQ4zXpdu4H+F+w2XcmaOCsrX/3eys\n\t3hhjbF8lfsQkiItk/NMSB20xq8alpEk1g7gxkvS4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QGMOyGr4\"; dkim-atps=neutral","Date":"Wed, 7 Jun 2023 17:57:26 +0300","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<20230607145726.GC22127@pendragon.ideasonboard.com>","References":"<20230607100054.4576-2-naush@raspberrypi.com>\n\t<20230607114807.18897-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230607114807.18897-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: tunings: Add missing short\n\tand long exposure profiles","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]