[{"id":27282,"web_url":"https://patchwork.libcamera.org/comment/27282/","msgid":"<20230606151328.GG7234@pendragon.ideasonboard.com>","date":"2023-06-06T15:13:28","subject":"Re: [libcamera-devel] [PATCH v2] libipa: camera_sensor_helper:\n\trestore alphabetical order","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Benjamin,\n\nThank you for the patch.\n\nOn Tue, Jun 06, 2023 at 04:27:11PM +0200, Benjamin Bara wrote:\n> From: Benjamin Bara \n> \n> The addition of the CameraSensorHelperImx327 class was not correctly\n> inserted in alphabetical sort order.\n> \n> Move it to the correct location.\n> \n> Fixes: 7d5b38e2ef41 (\"libipa: camera_sensor_helper: Add IMX327 helper\")\n> Reported-by: Laurent Pinchart \n> Signed-off-by: Benjamin Bara \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Unfortunately missed to keep the alphabetical order as mentioned by\n> Laurent.\n\nNo worries, that happens :-)\n\n> ---\n> Changes in v2:\n> - Add commit message\n> - Link to v1: https://lists.libcamera.org/pipermail/libcamera-devel/2023-June/038129.html\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 2eebd7ab..f0ecc383 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -428,11 +428,6 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n> \n> -class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n> -{\n> -};\n> -REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n> -\n> class CameraSensorHelperImx296 : public CameraSensorHelper\n> {\n> public:\n> @@ -444,6 +439,11 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n> \n> +class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n> +{\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n> +\n> class CameraSensorHelperImx477 : public CameraSensorHelper\n> {\n> public:\n> \n> ---\n> base-commit: a0271e72a86da5796891795565f43f20f7024a8d\n> change-id: 20230606-alphabetical-order-ea13b8e95f1e","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18C23C3200\n\tfor ;\n\tTue, 6 Jun 2023 15:13:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 745F362892;\n\tTue, 6 Jun 2023 17:13:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 157CF62709\n\tfor ;\n\tTue, 6 Jun 2023 17:13:31 +0200 (CEST)","from pendragon.ideasonboard.com (om126253223039.31.openmobile.ne.jp\n\t[126.253.223.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD62DAB;\n\tTue, 6 Jun 2023 17:13:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686064412;\n\tbh=1vN368pz0DGuTjCTpZSvQprqmGwuAIJgP5WH3HuZGSE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=q7szCwb5b1jLEBfRW3OhH1ci0108tTRDDJizm4zcI1Uk8oM0/Ryt7ijOyg9jWQZzU\n\tFjg+d3O7mqUmoxVz2s2vjoJvEwENogkYECOSZQx93BGkEE9zHgJ7AwuAfQ3viIoLAR\n\t+KZsXvbHk3i8QtBPYBKG3TT4c/vsmJv19SlOOb1S+TS1xxrGcBOrGspoeXymU5R9h6\n\t2rnIiTcua9N5Sj/j3SKLjcsrux01041rdhn6gLqKyDRO3blmJlwC6A9G+Gf/EfNyFi\n\tVtyBQ7Giq5JPkH4WJjFVwiFBgSEg6fggQVRGRAJ51zrUBQmf2n890+qmRzHTYdCT7g\n\tHBWeGMQYaQnwQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686064385;\n\tbh=1vN368pz0DGuTjCTpZSvQprqmGwuAIJgP5WH3HuZGSE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=osdmt21JymadTWQklsSEgn/FtFeeEhtc96X8tw+1aclG/d82R9VsxcM5VCU4z1e5J\n\tT7lvMfWhdDi5aER1fuAYpYySR50dNxI8Mpwh2lx5B/cs+p3aFCHTn7qrvYRPtgJNqs\n\tHXUUGn7AcakPgy3+vm8iW/Q4yK/RyUA0AOJrCdoU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"osdmt21J\"; dkim-atps=neutral","Date":"Tue, 6 Jun 2023 18:13:28 +0300","To":"Benjamin Bara ","Message-ID":"<20230606151328.GG7234@pendragon.ideasonboard.com>","References":"<20230606-alphabetical-order-v2-1-50869c0f9215@skidata.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230606-alphabetical-order-v2-1-50869c0f9215@skidata.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libipa: camera_sensor_helper:\n\trestore alphabetical order","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBenjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]