[{"id":27280,"web_url":"https://patchwork.libcamera.org/comment/27280/","msgid":"<168606137247.2889415.10908396226387227159@Monstersaurus>","date":"2023-06-06T14:22:52","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: restore\n\talphabetical order","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Benjamin,\n\nQuoting Benjamin Bara via libcamera-devel (2023-06-06 15:18:05)\n> From: Benjamin Bara \n> \n\nI'd still add a commit message here. We can add while applying if you're\nhappy:\n\nThe addition of the CameraSensorHelperImx327 class was not correctly\ninserted in alphabetical sort order.\n\nMove it to the correct location.\n\n> Fixes: 7d5b38e2ef41 (\"libipa: camera_sensor_helper: Add IMX327 helper\")\n> Reported-by: Laurent Pinchart \n> Signed-off-by: Benjamin Bara \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> Unfortunately missed to keep the alphabetical order as mentioned by\n> Laurent.\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 2eebd7ab..f0ecc383 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -428,11 +428,6 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n> \n> -class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n> -{\n> -};\n> -REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n> -\n> class CameraSensorHelperImx296 : public CameraSensorHelper\n> {\n> public:\n> @@ -444,6 +439,11 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n> \n> +class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n> +{\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n> +\n> class CameraSensorHelperImx477 : public CameraSensorHelper\n> {\n> public:\n> \n> ---\n> base-commit: a0271e72a86da5796891795565f43f20f7024a8d\n> change-id: 20230606-alphabetical-order-ea13b8e95f1e\n> \n> Best regards,\n> -- \n> Benjamin Bara \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8104C31E9\n\tfor ;\n\tTue, 6 Jun 2023 14:22:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E0A162722;\n\tTue, 6 Jun 2023 16:22:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E05BA62722\n\tfor ;\n\tTue, 6 Jun 2023 16:22:54 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 574AAAB;\n\tTue, 6 Jun 2023 16:22:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686061377;\n\tbh=wilbyjg4XhHNL8u9Ad5PRwW5kQSRPfe9PloTfQRmf94=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xdhx3wJoDG+EEpT0Bsq1JScPW7hMJAv6E5M5r46tNww2uCRRbzzENPsX9l8WXnNfO\n\txABmfBRPKnkEwiyeMx/KpGnktJRreDtI1i+HnLoSgGcsI7ZyAEczgvVKGw15/39Azt\n\tGP5JJ3DHs69dqiM5j9pcmSlJHtEq8QvoTibBl8cRz/BQIetnMh3fMPhK3Mk5DzetMM\n\tlAsI48+Hqxj9vJzAYSLKx/iJ63gjGT2/JBQ6h2gbdqYffc9poMzzOd+ophARXr3Gw5\n\tx6I+xboCM9N+vGITeg9rCGQJLTxEBF4qR7JUZhohNM9Tdya76lPBykCmwcT4D0wGa0\n\tp8L2cFItQ0Cbg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686061349;\n\tbh=wilbyjg4XhHNL8u9Ad5PRwW5kQSRPfe9PloTfQRmf94=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=lTQp1HUBTyCGgis0EQgLxIXdQrrBjapIMJtWB4GB82uweUPvtjjHftUXtqIC86QbO\n\tWRIr64wevdcfVznrE4XTlCYjy3d68T4rLmQ1DbJUVcXdE4wEXDBGAwn7DTH5aUCwi8\n\tlDrFuTofb51KQ5ukmKVb53zQOIsk9c+KuMiMdgx0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lTQp1HUB\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230606-alphabetical-order-v1-1-3c9c12a1a332@skidata.com>","References":"<20230606-alphabetical-order-v1-1-3c9c12a1a332@skidata.com>","To":"Benjamin Bara , libcamera-devel@lists.libcamera.org","Date":"Tue, 06 Jun 2023 15:22:52 +0100","Message-ID":"<168606137247.2889415.10908396226387227159@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: restore\n\talphabetical order","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Benjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]