[{"id":27276,"web_url":"https://patchwork.libcamera.org/comment/27276/","msgid":"","date":"2023-06-06T13:22:30","subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Mon, Jun 05, 2023 at 10:14:04AM +0100, Naushir Patuck via libcamera-devel wrote:\n> Update the AfMode control description to explicitly define a\n> startup/default behaviour.\n>\n> On startup, the camera will move the lens to the position given by the\n> default value of the LensPosition control if operating in manual focus\n> mode. Typically this would be the hyperfocal position of the lens.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index adea5f90acc5..765168e539a8 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -408,6 +408,13 @@ controls:\n> LensPosition control.\n>\n> In this mode the AfState will always report AfStateIdle.\n> +\n> + If the camera is started in AfModeManual, it will move the focus\n> + lens to the position specified by the LensPosition control.\n> +\n> + This mode is the recommended default value for the AfMode control.\n> + External cameras (as reported by the Location property set to\n> + CameraLocationExternal) may use a different default value.\n\nMissing an additional blank line\n\nCan be fixed when applying\n\nReviewed-by: Jacopo Mondi \n\n> - name: AfModeAuto\n> value: 1\n> description: |\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0390C3200\n\tfor ;\n\tTue, 6 Jun 2023 13:22:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F6C962892;\n\tTue, 6 Jun 2023 15:22:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97C246287E\n\tfor ;\n\tTue, 6 Jun 2023 15:22:33 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:72c3:346:a663:c82d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA43E105;\n\tTue, 6 Jun 2023 15:22:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686057755;\n\tbh=lsiKB8nRB65vo83eocOT+NyJtN3PzSpqbXuV9nCPAPc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=j1qw+kL3NeyWWc86ZZKxD58BRMLY+toQpIiaCSiC5Ss8x7imbJ8CJXbK/BDPhuh6e\n\thKYrEdX1XyetZeHFMxOjJA/16XGJ4d+k+OzrQ7wYswpPsHHAaOf8TeSmQxNdHM1FIt\n\txe7JPLPZhzFzwJvuzQ3ytvF4jR+NEG81anUwFrZ7lZCUika9m622rat2qoSQpIID4U\n\t1QQnmX/4jwd1rGgpqcj5Cv1ztdE0o2fSjOLEW+CeLv4MU+AHsDDfHfJC5fNNGx+r4f\n\tkYnGuwVAb5KewRoJKab1ssYWcXCzKWA7zvYQq/9zwoPjhTJNa9wI/d0BuB4YsJpL46\n\tFmt93sf9ImOIQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686057728;\n\tbh=lsiKB8nRB65vo83eocOT+NyJtN3PzSpqbXuV9nCPAPc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Dh4fKZucBrLzd/Wn1AqhSwfyIxWH/uHGN1dbOrVL4FRSNnvdWuSxhjk/+ym+jaGFL\n\tS7SsmfYs9XSwclP9KKT+PxYFJyNfFAPhPLKepWLmdGDOMBgc1Zz1mP9GtU8+78OkbI\n\tA7Zig+idAQBUmlnGNQLCLsJiD4Sac32okebUkQcM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Dh4fKZuc\"; dkim-atps=neutral","Date":"Tue, 6 Jun 2023 15:22:30 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20230605091406.31757-1-naush@raspberrypi.com>\n\t<20230605091406.31757-2-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230605091406.31757-2-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27278,"web_url":"https://patchwork.libcamera.org/comment/27278/","msgid":"","date":"2023-06-06T13:40:38","subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Jacopo,\n\nThank you for your feedback!\n\nOn Tue, 6 Jun 2023 at 14:22, Jacopo Mondi wrote:\n>\n> Hi Naush\n>\n> On Mon, Jun 05, 2023 at 10:14:04AM +0100, Naushir Patuck via libcamera-devel wrote:\n> > Update the AfMode control description to explicitly define a\n> > startup/default behaviour.\n> >\n> > On startup, the camera will move the lens to the position given by the\n> > default value of the LensPosition control if operating in manual focus\n> > mode. Typically this would be the hyperfocal position of the lens.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/control_ids.yaml | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index adea5f90acc5..765168e539a8 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -408,6 +408,13 @@ controls:\n> > LensPosition control.\n> >\n> > In this mode the AfState will always report AfStateIdle.\n> > +\n> > + If the camera is started in AfModeManual, it will move the focus\n> > + lens to the position specified by the LensPosition control.\n> > +\n> > + This mode is the recommended default value for the AfMode control.\n> > + External cameras (as reported by the Location property set to\n> > + CameraLocationExternal) may use a different default value.\n>\n> Missing an additional blank line\n\nI wasn't sure about this one. The documentation for enum values doesn't seem to\nhave a blank line between them so I left it out here as well. Is this\nnot correct?\n\nRegards,\nNaush\n\n>\n> Can be fixed when applying\n>\n> Reviewed-by: Jacopo Mondi \n>\n> > - name: AfModeAuto\n> > value: 1\n> > description: |\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42D31C3200\n\tfor ;\n\tTue, 6 Jun 2023 13:40:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A50DF62893;\n\tTue, 6 Jun 2023 15:40:54 +0200 (CEST)","from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com\n\t[IPv6:2607:f8b0:4864:20::b34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D62E62722\n\tfor ;\n\tTue, 6 Jun 2023 15:40:53 +0200 (CEST)","by mail-yb1-xb34.google.com with SMTP id\n\t3f1490d57ef6-bacfa9fa329so6402279276.0\n\tfor ;\n\tTue, 06 Jun 2023 06:40:53 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686058854;\n\tbh=29Dgad+1dYUtlpaem2544vFu7IB3iNqpU5Riv6ynrBw=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EUTVr0J/dLmc8Z/k1q6bqM/1CX5T1KTa6J538eNCJOsXFy4ZvEdB9HLBL3uRKhYCx\n\tICkNWfsZaaSju+oRL4ca4coEWrRyNGXRLi2esx+TJpb60iIw3+qU5h/QJJo2zZ2L1U\n\tyKiI9ALrBwZciiY1z4AdfsOK8vPL8Rsoci+wr4vyNOe7rrECg7LLJbK2K3GGybJPcM\n\tM708eqSzCDSSoHUtF5ngsa75jmUcK5DpigPEuUoBtypoY6tCgOO4GfxCwwyHnvp9Cr\n\trKxDJ8MET+7CWcQ5y+y+kGHndjoZVyAQzaMHZ3azEEuX/3sUgTkNyGIeozhsr+Saei\n\toNUBulDr2bBEg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1686058852; x=1688650852;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=nvaA+eNaoForQH/F8KXmys5v3q2PHUI51YQuHTsxnLs=;\n\tb=QB/a+SRmpufEN4A8ZqfQnMqUn59l6/XyU/TAZRA39bGXsLPNoyxkXBC7fhUUgSXSwL\n\ttv55Q39uF7imMnNlCOtW/P5mq0UagwBFN817cRjPUNZWGWOEGwMe5djdaPbxjpMctRqH\n\tUoLvYmPB2OXVYaQK62PFhXPyfGjSd9gEZRHHPBt6/X8Hi55TJl7yswDYf4Hc6SEjCsGl\n\t2rV3bsXaIP3rYUaoFfXV+7dA1FdA4q6bMNUnUmCS8b4kN1/IbTZpjjJL13v8P5BhbWWO\n\tkIsJjzdIQUYGNU+Yn4227pDvFZ0vylsUDUYiPUx2Cp84FMngXaV0w8wGCJHrAYzOFF+e\n\tl9gg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"QB/a+SRm\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1686058852; x=1688650852;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=nvaA+eNaoForQH/F8KXmys5v3q2PHUI51YQuHTsxnLs=;\n\tb=Yrif3RorxbGoIqeiT2r9ISPcAJ6/rQHR/cf+mBjJaaFyu9yYng42sQXsTk9kCah4j4\n\twrhhQ85kqITJnsPq4DuAD30N6hwtN9YpuFj0dIWsF563QOapDfltoiCS1YURccGQbe69\n\t0zTqReqyiylcGWY2KPv98VsAFATor4KVLMHibY7XM8raZ//L1zZi4wiHOHr3Lwx/jDnQ\n\tI2SSqa8uImm1GIJhwRrKW+8PVNXXjwlGTaZAIgPdAJzW9ufUTSoynMdE1G6qDthU0R+N\n\tGyAOzwOJzf4X1Ke2oue8Ws4Yee0RoPWCmEZ0whv9FEnVvIrAl+r2RjL3e8+WTY90RSO7\n\tPnww==","X-Gm-Message-State":"AC+VfDwo0IS/JXnngVf2VEIsnrfQ/SUMF/aKI2wIozdm2IOLod9QRdcI\n\tEQiCe4PDkMx6UFQAopsiAmJC8ti0UNRs50flAkGmoQ==","X-Google-Smtp-Source":"ACHHUZ6raHqAuXqUhowRc/FCGwu/AmyBTI4zVe+dQyhvJccY39HpGsoyBfqDq6y/GYm7DS5VgnTCFJAQmucFXzDg9nw=","X-Received":"by 2002:a0d:cc94:0:b0:568:9155:d615 with SMTP id\n\to142-20020a0dcc94000000b005689155d615mr2313673ywd.20.1686058852222;\n\tTue, 06 Jun 2023 06:40:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20230605091406.31757-1-naush@raspberrypi.com>\n\t<20230605091406.31757-2-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Tue, 6 Jun 2023 14:40:38 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27279,"web_url":"https://patchwork.libcamera.org/comment/27279/","msgid":"","date":"2023-06-06T14:02:11","subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Tue, Jun 06, 2023 at 02:40:38PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Hi Jacopo,\n>\n> Thank you for your feedback!\n>\n> On Tue, 6 Jun 2023 at 14:22, Jacopo Mondi wrote:\n> >\n> > Hi Naush\n> >\n> > On Mon, Jun 05, 2023 at 10:14:04AM +0100, Naushir Patuck via libcamera-devel wrote:\n> > > Update the AfMode control description to explicitly define a\n> > > startup/default behaviour.\n> > >\n> > > On startup, the camera will move the lens to the position given by the\n> > > default value of the LensPosition control if operating in manual focus\n> > > mode. Typically this would be the hyperfocal position of the lens.\n> > >\n> > > Signed-off-by: Naushir Patuck \n> > > ---\n> > > src/libcamera/control_ids.yaml | 7 +++++++\n> > > 1 file changed, 7 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > > index adea5f90acc5..765168e539a8 100644\n> > > --- a/src/libcamera/control_ids.yaml\n> > > +++ b/src/libcamera/control_ids.yaml\n> > > @@ -408,6 +408,13 @@ controls:\n> > > LensPosition control.\n> > >\n> > > In this mode the AfState will always report AfStateIdle.\n> > > +\n> > > + If the camera is started in AfModeManual, it will move the focus\n> > > + lens to the position specified by the LensPosition control.\n> > > +\n> > > + This mode is the recommended default value for the AfMode control.\n> > > + External cameras (as reported by the Location property set to\n> > > + CameraLocationExternal) may use a different default value.\n> >\n> > Missing an additional blank line\n>\n> I wasn't sure about this one. The documentation for enum values doesn't seem to\n> have a blank line between them so I left it out here as well. Is this\n> not correct?\n\nNope, you're right! I saw a blank line in the proposal Laurent sent\nand thought it got lost, but it is indeed intentional and correct your\nway\n\nSorry for the noise!\n\n>\n> Regards,\n> Naush\n>\n> >\n> > Can be fixed when applying\n> >\n> > Reviewed-by: Jacopo Mondi \n> >\n> > > - name: AfModeAuto\n> > > value: 1\n> > > description: |\n> > > --\n> > > 2.34.1\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5005DC31E9\n\tfor ;\n\tTue, 6 Jun 2023 14:02:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A657962722;\n\tTue, 6 Jun 2023 16:02:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 072BB62709\n\tfor ;\n\tTue, 6 Jun 2023 16:02:15 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:72c3:346:a663:c82d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AC74AB;\n\tTue, 6 Jun 2023 16:01:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686060136;\n\tbh=86btxOJWDrhXYxx/DoV+ubiy7iLX0XgYL0lzIXm5naU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RYo9k+iTTs2mLNf+CDgqEDTnDOvxXCKlxKEEfTbuPMwFpOTH4HE82LaJI+1z8cTLY\n\t1kTX89wzDeby9EWo76f84Jm5DkRLNWaZGW81rt+YLzAmmcxcmZqvI/Be85WTXN5+Ex\n\tK6koxmkmWvz5ZKUgb81MLJEwkBPzR9dVJ2fY03qT7Dfcw/NypcJTjlFtLlV5+HxFXq\n\tXU4+Qq+ehGRekSBBwIypkJww5kTMo69jI7awRGpnjcbh5faIzWwByBfNIhR4/u2yKQ\n\tbbnvTvcqCRq99HlP+TLVTFxxMgazujIqdz+sp2bf2hhn4dIvDRXTPABlskZhBEu+cv\n\tUTGqYIOvcbn8Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686060109;\n\tbh=86btxOJWDrhXYxx/DoV+ubiy7iLX0XgYL0lzIXm5naU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QfJ+kZ68s9TQ/quE4khWk89l0NFV0MH4HEMh4+qabCLMgvpURbshD+RGaUT9yjBpn\n\tiKT6nHEM4xSwg7t5ejoZkAVziijziNBKxpbd62aH21iY1rQC1IPaN/xVUIVhLqLww2\n\tmmXQL9ei77I/u4Oa7DmnRiqwNFKDSneoZ3v2G4Ds="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QfJ+kZ68\"; dkim-atps=neutral","Date":"Tue, 6 Jun 2023 16:02:11 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20230605091406.31757-1-naush@raspberrypi.com>\n\t<20230605091406.31757-2-naush@raspberrypi.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27283,"web_url":"https://patchwork.libcamera.org/comment/27283/","msgid":"<20230606152026.GA20136@pendragon.ideasonboard.com>","date":"2023-06-06T15:20:26","subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jun 05, 2023 at 10:14:04AM +0100, Naushir Patuck via libcamera-devel wrote:\n> Update the AfMode control description to explicitly define a\n> startup/default behaviour.\n> \n> On startup, the camera will move the lens to the position given by the\n> default value of the LensPosition control if operating in manual focus\n> mode. Typically this would be the hyperfocal position of the lens.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/control_ids.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index adea5f90acc5..765168e539a8 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -408,6 +408,13 @@ controls:\n> LensPosition control.\n> \n> In this mode the AfState will always report AfStateIdle.\n> +\n> + If the camera is started in AfModeManual, it will move the focus\n> + lens to the position specified by the LensPosition control.\n> +\n> + This mode is the recommended default value for the AfMode control.\n> + External cameras (as reported by the Location property set to\n> + CameraLocationExternal) may use a different default value.\n> - name: AfModeAuto\n> value: 1\n> description: |","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64880C31E9\n\tfor ;\n\tTue, 6 Jun 2023 15:20:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1D0C62893;\n\tTue, 6 Jun 2023 17:20:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD49662709\n\tfor ;\n\tTue, 6 Jun 2023 17:20:29 +0200 (CEST)","from pendragon.ideasonboard.com (om126253223039.31.openmobile.ne.jp\n\t[126.253.223.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28AE9283;\n\tTue, 6 Jun 2023 17:20:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686064830;\n\tbh=+N1viL+vRLTwmChmQ/fDcZTGA7yXglEkfP6HboPirdk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JMdkiJmBQb3UfbtyI16i4W0iE6KH6ts+2qTv6rQh6ZwYnHLSCZwfdZAB8gu041q0e\n\tj4pGro3a3CoORdXONcemHpUAqbiKChQKaGdqG597yHYiQXW39yS6+NxbFxWyo4GdJF\n\t9CfnQzkN2jN9OejnO++sfLXtMxoAFE57p3sY0QJC56Y5M7CBg8kuUo+nqdFSf+0VqZ\n\tTlrujhuc1iOFoPrkZLGfnEbw0AAg505EXVZ/eOBXk7uUWXE+fT6al1T7C/cAXPbPQI\n\tGPpVUeRkYpx9fiUTP8vF6SiLOt+H1i6Dzdl1f+pQOD/OvCMYiQ3te0rJWgn7Kb4w7t\n\ts0BJvATW12l7A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686064804;\n\tbh=+N1viL+vRLTwmChmQ/fDcZTGA7yXglEkfP6HboPirdk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Nx7p39jS3RUjFDdi+n97bFqxMGd3Sg5NS13qX+OyAoi59kf7+f7N5RYNqISOyzfBK\n\tlK7jA66PYh9rngMUkInkGaIy8b/FqJGvdHvwfmSVdRB5pKPF7PaKMUEd7lf4ZujSeH\n\tq8riBCGRX4R8WCk8EwSnnR/4GFLp/e8b1NnElHSE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Nx7p39jS\"; dkim-atps=neutral","Date":"Tue, 6 Jun 2023 18:20:26 +0300","To":"Naushir Patuck ","Message-ID":"<20230606152026.GA20136@pendragon.ideasonboard.com>","References":"<20230605091406.31757-1-naush@raspberrypi.com>\n\t<20230605091406.31757-2-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230605091406.31757-2-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]