[{"id":2522,"web_url":"https://patchwork.libcamera.org/comment/2522/","msgid":"<20190828161003.rcd37fcho2lxlj6e@uno.localdomain>","date":"2019-08-28T16:10:03","subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: controls: Add\n\tAeEnable","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Wed, Aug 28, 2019 at 03:17:02AM +0200, Niklas Söderlund wrote:\n> Add a control to turn Auto Exposure on or off.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/control_ids.h | 1 +\n> src/libcamera/controls.cpp | 7 +++++++\n> 2 files changed, 8 insertions(+)\n>\n> diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> index 75b6a2d5cafeca72..8cd44e571f705ac5 100644\n> --- a/include/libcamera/control_ids.h\n> +++ b/include/libcamera/control_ids.h\n> @@ -13,6 +13,7 @@\n> namespace libcamera {\n>\n> enum ControlId {\n> +\tAeEnable,\n> \tAwbEnable,\n> \tBrightness,\n> \tContrast,\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 727fdbd9450d2f40..54efef1bb337e945 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -186,6 +186,13 @@ std::string ControlValue::toString() const\n> * \\brief Numerical control ID\n> */\n>\n> +/**\n> + * \\var AeEnable\n> + * ControlType: Bool\n> + *\n> + * Enables or disables the AE. See also \\a libcamera::ControlId::ManualExposure.\n> + */\n> +\n\nI would now specify (even if it might seems obvious) in the\nManualExposure control documentation that the control is only taken\ninto account if AE is disabled.\n\n\n> /**\n> * \\var AwbEnable\n> * ControlType: Bool\n> --\n> 2.22.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E52F60BF6\n\tfor ;\n\tWed, 28 Aug 2019 18:08:32 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id B7D18100003;\n\tWed, 28 Aug 2019 16:08:31 +0000 (UTC)"],"Date":"Wed, 28 Aug 2019 18:10:03 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190828161003.rcd37fcho2lxlj6e@uno.localdomain>","References":"<20190828011710.32128-1-niklas.soderlund@ragnatech.se>\n\t<20190828011710.32128-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"xamcdkarcr7t4fqf\"","Content-Disposition":"inline","In-Reply-To":"<20190828011710.32128-6-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: controls: Add\n\tAeEnable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 28 Aug 2019 16:08:32 -0000"}},{"id":2556,"web_url":"https://patchwork.libcamera.org/comment/2556/","msgid":"<20190829201123.GD8479@bigcity.dyn.berto.se>","date":"2019-08-29T20:11:23","subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: controls: Add\n\tAeEnable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your feedback.\n\nOn 2019-08-28 18:10:03 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Wed, Aug 28, 2019 at 03:17:02AM +0200, Niklas Söderlund wrote:\n> > Add a control to turn Auto Exposure on or off.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > include/libcamera/control_ids.h | 1 +\n> > src/libcamera/controls.cpp | 7 +++++++\n> > 2 files changed, 8 insertions(+)\n> >\n> > diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> > index 75b6a2d5cafeca72..8cd44e571f705ac5 100644\n> > --- a/include/libcamera/control_ids.h\n> > +++ b/include/libcamera/control_ids.h\n> > @@ -13,6 +13,7 @@\n> > namespace libcamera {\n> >\n> > enum ControlId {\n> > +\tAeEnable,\n> > \tAwbEnable,\n> > \tBrightness,\n> > \tContrast,\n> > diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> > index 727fdbd9450d2f40..54efef1bb337e945 100644\n> > --- a/src/libcamera/controls.cpp\n> > +++ b/src/libcamera/controls.cpp\n> > @@ -186,6 +186,13 @@ std::string ControlValue::toString() const\n> > * \\brief Numerical control ID\n> > */\n> >\n> > +/**\n> > + * \\var AeEnable\n> > + * ControlType: Bool\n> > + *\n> > + * Enables or disables the AE. See also \\a libcamera::ControlId::ManualExposure.\n> > + */\n> > +\n> \n> I would now specify (even if it might seems obvious) in the\n> ManualExposure control documentation that the control is only taken\n> into account if AE is disabled.\n\nGood point, will do so for v2.\n\n> \n> \n> > /**\n> > * \\var AwbEnable\n> > * ControlType: Bool\n> > --\n> > 2.22.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CC5B60BE5\n\tfor ;\n\tThu, 29 Aug 2019 22:11:26 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id r134so2625921lff.12\n\tfor ;\n\tThu, 29 Aug 2019 13:11:25 -0700 (PDT)","from localhost (h-177-236.A463.priv.bahnhof.se. [217.31.177.236])\n\tby smtp.gmail.com with ESMTPSA id\n\tw77sm535695lff.49.2019.08.29.13.11.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 29 Aug 2019 13:11:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=o/knGM7D7rTEgJm3IV61gDEVOQL2B824z0dZcNhY7+8=;\n\tb=Khn0sLkFCrI6vrLgbKfLRYgN97BzMPjF1eo/6ODDpsZ9mn2u2ovlpVbHR3lyXAJb/i\n\tKHhIt4sg8Xpv2siFHOHAqwGj8n7PkI9IQAKyaMh4GMZgl47vGLJxKtSjYlW3y8HXsFJQ\n\tSf48oSiNqhnY4NXqKkWT221j3NsWalCpxX9JHF6XaYXEp3Vc9EtbIl0AAd48Ud5y4b20\n\tRJxiKlUi1q2Felm5PXuCYAJQGwhWNpzE1auvI9ao7p7PXh1g8Ahy0mxiVtY82k+Q+mxl\n\tBdc78tFOzrklLOzZnxw+4zjQxEjwZu/b9ksQdgkd+bjgzgGBteZhWFEUzKb7KMXeZFLN\n\t09rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=o/knGM7D7rTEgJm3IV61gDEVOQL2B824z0dZcNhY7+8=;\n\tb=FKIq99m74EWxzn2dyWLlKYhwOOYk112I5ECYSeZIo+Sd9qgF29X67cvu4sGNozhhn5\n\tb9rUqKxi1u8ExpqjUJjjam80z/O1xyL7lhEyHAc7NrmiGCsu/k2Zh7We+oFcLsWTsK2Y\n\tTWHgL55knKwEeqJHP+M85iYvoG/kpOGSDjwk6Jyxz4/2YlivYkj4kP8ChvPwy4cVxgLX\n\t05Enib+W34gKaN9PuSDUudUs4N4M7pay/1c0sgk1LlrueQWZal6ssP31XBnYeK6W5Pm1\n\t4MLOsXzJUR1wbGaqGvHS1HWYxoFhsM3Xcg21rtp0I6JrZQTGD8ne8T0923at20kYLzsC\n\tTTTQ==","X-Gm-Message-State":"APjAAAVCve3BKBuPRTScSrmevE7u7hZQkti4Ja7/jS1rrhZ4dt/vTt69\n\txaxT5aO0QubYpGTcZq526T2Yr9HuHEc=","X-Google-Smtp-Source":"APXvYqyGAaK1BGU328ml3zQBss/5pVdSJggWnpTveBD3pCMOQ7boc2YP6qRr6fRibodN0ZSS7ZtEAw==","X-Received":"by 2002:a19:2313:: with SMTP id\n\tj19mr7178858lfj.138.1567109485502; \n\tThu, 29 Aug 2019 13:11:25 -0700 (PDT)","Date":"Thu, 29 Aug 2019 22:11:23 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190829201123.GD8479@bigcity.dyn.berto.se>","References":"<20190828011710.32128-1-niklas.soderlund@ragnatech.se>\n\t<20190828011710.32128-6-niklas.soderlund@ragnatech.se>\n\t<20190828161003.rcd37fcho2lxlj6e@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190828161003.rcd37fcho2lxlj6e@uno.localdomain>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: controls: Add\n\tAeEnable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 20:11:26 -0000"}}]