[{"id":27233,"web_url":"https://patchwork.libcamera.org/comment/27233/","msgid":"<20230604092507.GA2483@pendragon.ideasonboard.com>","date":"2023-06-04T09:25:07","subject":"Re: [libcamera-devel] [PATCH v5 02/13] py: Fix code formatting","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Sat, Jun 03, 2023 at 10:56:04AM +0300, Tomi Valkeinen wrote:\n> Fix code formatting.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/py_main.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index fd140086..5a5f1a37 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -180,7 +180,7 @@ PYBIND11_MODULE(_libcamera, m)\n> \n> \t\t\tControlList controlList(self.controls());\n> \n> -\t\t\tfor (const auto& [id, obj]: controls) {\n> +\t\t\tfor (const auto &[id, obj] : controls) {\n> \t\t\t\tauto val = pyToControlValue(obj, id->type());\n> \t\t\t\tcontrolList.set(id->id(), val);\n> \t\t\t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15FA8C31E9\n\tfor ;\n\tSun, 4 Jun 2023 09:25:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A68462722;\n\tSun, 4 Jun 2023 11:25:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A8D361EA4\n\tfor ;\n\tSun, 4 Jun 2023 11:25:09 +0200 (CEST)","from pendragon.ideasonboard.com (om126166129043.28.openmobile.ne.jp\n\t[126.166.129.43])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 31BDF2CF;\n\tSun, 4 Jun 2023 11:24:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685870711;\n\tbh=4J1Om6rMXxe8bU2lm+dczhiKrpRT0vJQ1IRQm+P0AAk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QykaaMZF08ct5TcNJD2z7hRaWTfutxRysaver3SpeStukOIgFA2jyv3RsUIEhC0PT\n\tq6KZCy30hicnD0afH2paDTQTeDIMXvrnO4gmkGZqU9uHU/UERR9gQnMlR4bbuiV6Fo\n\tgENCmdCYffziiup+2aow8R83ypY2dRWrwPb+xMQi8FC4AkBWIrMXUbe//imBXf9ibm\n\t00PYnlKx3UNHRsXqGZ8/0skS2Xd6ww8j2JYm0D0noPI37m3iuKhYcLsCzUwEVvP3Na\n\t49ugnpXNMrI2wo1VuKL7QzqfAe7nfsKylX0YsCU7gZzPahvgvYeWfe77JhwAlg9QhA\n\ts/VckRExzo2eg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685870685;\n\tbh=4J1Om6rMXxe8bU2lm+dczhiKrpRT0vJQ1IRQm+P0AAk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=j22YeeF996IG4Pfq4VDlKltOS3IYoDdvNboEjWBdiwsIgZTG72N0WwYdCTKx6QXMK\n\taEQxwv2gBwnhwH98QEosRsNVkMRVvuAtm1/09h09KTvT7QnjrIpnGsIkrFG3qds1SI\n\tELCD2giVykQS/Wi1cJ7MKj+auRFa+JkHNOfyZpZs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"j22YeeF9\"; dkim-atps=neutral","Date":"Sun, 4 Jun 2023 12:25:07 +0300","To":"Tomi Valkeinen ","Message-ID":"<20230604092507.GA2483@pendragon.ideasonboard.com>","References":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>\n\t<20230603075615.20663-3-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230603075615.20663-3-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 02/13] py: Fix code formatting","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]