[{"id":27232,"web_url":"https://patchwork.libcamera.org/comment/27232/","msgid":"<20230604084740.GR26944@pendragon.ideasonboard.com>","date":"2023-06-04T08:47:40","subject":"Re: [libcamera-devel] [PATCH v5 01/13] subprojects: Drop pybind11\n\tfrom gitignore","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Sat, Jun 03, 2023 at 10:56:03AM +0300, Tomi Valkeinen wrote:\n> As we no longer have pybind11 as a subproject, drop it from the\n> gitignore.\n\nThis should have\n\nFixes: ad4719c10c6a (\"py: Move to mainline pybind11 version\")\n\n> Signed-off-by: Tomi Valkeinen \n\nWhile at it, you should drop\nsubprojects/packagefiles/pybind11/meson.build. I'll do so and update the\ncommit message to\n\nsubprojects: Drop leftovers of pybind11\n\nThe pybind11 subproject was removed in commit ad4719c10c6a (\"py: Move to\nmainline pybind11 version\"), but two traces remained, one in .gitignore\nand a second one as a meson.build for pybind11. Remove them.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> subprojects/.gitignore | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n> index ebe59479..04b6271f 100644\n> --- a/subprojects/.gitignore\n> +++ b/subprojects/.gitignore\n> @@ -4,4 +4,3 @@\n> /libyaml\n> /libyuv\n> /packagecache\n> -/pybind11-*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F88EC31E9\n\tfor ;\n\tSun, 4 Jun 2023 08:47:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5B7E62722;\n\tSun, 4 Jun 2023 10:47:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D28A061EA4\n\tfor ;\n\tSun, 4 Jun 2023 10:47:41 +0200 (CEST)","from pendragon.ideasonboard.com (om126166129043.28.openmobile.ne.jp\n\t[126.166.129.43])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF7802B6;\n\tSun, 4 Jun 2023 10:47:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685868463;\n\tbh=AYI8jh/6aNZDfeCTH8mincj+UIJ7qK1PeDWTITThZoQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=B3aXclC7NnRoucf7n0xqhITgU6ln/Eb9C05TK/LVm6xNETHa8gHpFsWcAhgfSSN7b\n\tmz/ksnn6Ggq5zU0ppsbHmLR6p0JidfBe/eSwZDILQ4C2Qs5uKhTFHb6K53IM84//9l\n\t+hux0zvDHJuhQ9/etE+LVFr8Dwxu1NVBvGUW5WrTL8kj+m5YmEXXCB7x83hVMIU+aT\n\tVExaR4KmQvzqXpKxpFYVQHfEgPHOQI33+kcayvJD9yRX1op2NwvO91VoirEX5SXHdO\n\tN0Pmgcw2kQyY557HmOQzG1+YryShhv/j5ngnDYE9HiYG4QxFf9jrs+qtJmApcdaXek\n\twv0Gxw4YHKmbw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685868437;\n\tbh=AYI8jh/6aNZDfeCTH8mincj+UIJ7qK1PeDWTITThZoQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Qy6hx60I1GVlnTWRDB8AMJzMRzZORYGXWtXsMozCYdh8/DMxvQdKgboGtAASkpTQ7\n\tW/cLMWA8/GnTIH2mnNGsGk/xdp72Aj4J5zdSpAy3IrL5IzGMh+TY8L5Gamr0Q93xra\n\tNCHP8uSkg+tRQZ+y5i4ot0YSL1zEf8V4OdrcxTO4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Qy6hx60I\"; dkim-atps=neutral","Date":"Sun, 4 Jun 2023 11:47:40 +0300","To":"Tomi Valkeinen ","Message-ID":"<20230604084740.GR26944@pendragon.ideasonboard.com>","References":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>\n\t<20230603075615.20663-2-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230603075615.20663-2-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 01/13] subprojects: Drop pybind11\n\tfrom gitignore","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27234,"web_url":"https://patchwork.libcamera.org/comment/27234/","msgid":"<249aab70-88f4-93b6-8dc3-778b9398532e@ideasonboard.com>","date":"2023-06-04T13:03:47","subject":"Re: [libcamera-devel] [PATCH v5 01/13] subprojects: Drop pybind11\n\tfrom gitignore","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 04/06/2023 11:47, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> Thank you for the patch.\n> \n> On Sat, Jun 03, 2023 at 10:56:03AM +0300, Tomi Valkeinen wrote:\n>> As we no longer have pybind11 as a subproject, drop it from the\n>> gitignore.\n> \n> This should have\n> \n> Fixes: ad4719c10c6a (\"py: Move to mainline pybind11 version\")\n> \n>> Signed-off-by: Tomi Valkeinen \n> \n> While at it, you should drop\n> subprojects/packagefiles/pybind11/meson.build. I'll do so and update the\n> commit message to\n\nAh. So we keep finding these leftovers. I wonder if this one is the last =).\n\n> subprojects: Drop leftovers of pybind11\n> \n> The pybind11 subproject was removed in commit ad4719c10c6a (\"py: Move to\n> mainline pybind11 version\"), but two traces remained, one in .gitignore\n> and a second one as a meson.build for pybind11. Remove them.\n> \n> Reviewed-by: Laurent Pinchart \n\nLooks fine to me.\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC9A6C3200\n\tfor ;\n\tSun, 4 Jun 2023 13:03:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A74162720;\n\tSun, 4 Jun 2023 15:03:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 420686055A\n\tfor ;\n\tSun, 4 Jun 2023 15:03:50 +0200 (CEST)","from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi\n\t[91.154.35.171])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B831C2CF;\n\tSun, 4 Jun 2023 15:03:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685883832;\n\tbh=oXhxkmfScsaL66eUbNI9idoXkxTDwEfWAhuUpjZlPZM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bOENDwyskHRjeL5lyjsbXkcF0r6hOM41ZkPYWRvF7KeKsyJ95fX3OdIHNQUHuET1F\n\toGcLxMACJCfcWll3yZ1wvN7bjFiYmrjvCgbEGvMk7nKEy6e45RsG2a7+4mRTSMcO4m\n\tEtdWzkZwgS+WDwlySJW9lv7+KOAU3ASebXqg8yulL6fk/Ea1UtR1OdKNe8z96kshsi\n\tasFUNn7MWsZF7kU1NclTN83rBFszLAqs6vTP2eOmJu32kYrp+Sp44y4J2anb8HV6Di\n\ts8S2Lh513FFjXD/UcaJraXtWbFVQBDGXqPCmz4TkL8fSgmo2I5jszLeLjbsmRgdXGF\n\t/OpMmqSdHXG2w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685883806;\n\tbh=oXhxkmfScsaL66eUbNI9idoXkxTDwEfWAhuUpjZlPZM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=gPhB/jfuW+EYZ7jLYPdj585lIolOrheELIiLvXb86n5Qt0NRzdAVN2HnB7yxJpmAe\n\tiPRZOKRdZQj9IMzBdUaeQ/xJWnWApumE6q+sguC9t9fTBWVb/Og50uFx0I2fUtgadE\n\txpV+1h6WRu0Y6PJwH9aG2z62akAqe5k2ZQRYjP7M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gPhB/jfu\"; dkim-atps=neutral","Message-ID":"<249aab70-88f4-93b6-8dc3-778b9398532e@ideasonboard.com>","Date":"Sun, 4 Jun 2023 16:03:47 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.11.0","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20230603075615.20663-1-tomi.valkeinen@ideasonboard.com>\n\t<20230603075615.20663-2-tomi.valkeinen@ideasonboard.com>\n\t<20230604084740.GR26944@pendragon.ideasonboard.com>","In-Reply-To":"<20230604084740.GR26944@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 01/13] subprojects: Drop pybind11\n\tfrom gitignore","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]