[{"id":27222,"web_url":"https://patchwork.libcamera.org/comment/27222/","msgid":"","date":"2023-06-02T08:36:04","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: controls: Define a\n\tdefault lens position behaviour","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nSeems clearer, I'm happy with this change!\n\nRegards,\nNaush\n\nOn Fri, 2 Jun 2023 at 07:09, Laurent Pinchart\n wrote:\n>\n> From: Naushir Patuck \n>\n> Update the AfMode control description to explicitly define a\n> startup/default behaviour.\n>\n> On startup, the camera will move the lens to the position given by the\n> default value of the LensPosition control if operating in manual focus\n> mode. Typically this would be the hyperfocal position of the lens.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 76d41f5f2a5a..985f792a53c1 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -408,7 +408,15 @@ controls:\n> LensPosition control.\n>\n> In this mode the AfState will always report AfStateIdle.\n> - - name: AfModeAuto\n> +\n> + If the camera is started is AfModeManual, it will move the focus\n> + lens to the position specified by the LensPosition control.\n> +\n> + This mode is the recommended default value for the AfMode control.\n> + External cameras (as reported by the Location property set to\n> + CameraLocationExternal) may use a different default value.\n> +\n> + name: AfModeAuto\n> value: 1\n> description: |\n> The AF algorithm is in auto mode. This means that the algorithm\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C44FC31E9\n\tfor ;\n\tFri, 2 Jun 2023 08:36:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE8D662754;\n\tFri, 2 Jun 2023 10:36:10 +0200 (CEST)","from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com\n\t[IPv6:2607:f8b0:4864:20::1134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 715DE626F8\n\tfor ;\n\tFri, 2 Jun 2023 10:36:09 +0200 (CEST)","by mail-yw1-x1134.google.com with SMTP id\n\t00721157ae682-565bd368e19so16495637b3.1\n\tfor ;\n\tFri, 02 Jun 2023 01:36:09 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685694970;\n\tbh=M+ea8qow2tYOwU4OfKQy75u4m3d6kTG1fTtn/BmFoMA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=x2JOa5BhKsKTe2h+TIg7YR6fbXwD0OdeBijqVhsEGjSBxQlib6xA+n2Cnje0xcwxP\n\t5P5g4OW/Xs5iM1zVxziRexN7WdElp7PhTF4HVCRmPKoHmRN69ZUYb0rERI/UcdsjWa\n\tOaqS7CFi3dKjDJgCzyepVH9XOZUfE2hNDc92McmSg2VkqjWzCjTrjuujJW9ykH1uKB\n\tI0BhWNiOsaZW3BXDp3Rn3XPZ6n6TqufYGe4Zoo9Igd6FkMBWIDjrMT4KtLbXvS4D/U\n\trX8VwdVXpZOn/W/37+T6AyX8VeT5BMfpEUpYoVQuEkdgWKR4kzadxOTGkJWmvJod2Q\n\t3bK1ZC4s7JLkA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1685694968; x=1688286968;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=uRXSUeF0oePm6MOyyBALLVidDlf7MsVgg7za5X40XsA=;\n\tb=B5dZQrgQA5qATGfkwiqyGYSIRus0BK1PmFSFB82Iv/ADM3mqe1h7QH+jgozOZ7bMDl\n\tc4TlmnO44GOmUjKFGipAoD85OJ2rmZjWHb4xj7+aj6Htooyp6IpaoL4jhaCG3jMzems5\n\tYoA4fqDrw6gjch7UNvCzPzQ5oWjsorDLA66Eb7hVHXA/t6WhiAlZ3GEBGqcWu3M8SqM3\n\tQNs3I5zeMSJeu5wO93OtgwDTU4zC5GF0EvHOS253Ky0ZEZLtArWEQkjJ5wfqyu3Ih/C2\n\taBW1bCe1+4hrXUGAlt16+hf9VF9U2Ty4rAIJa82SByULtFIKWJVUUTbiI83XNd7Xwy7x\n\tTPRw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"B5dZQrgQ\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1685694968; x=1688286968;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=uRXSUeF0oePm6MOyyBALLVidDlf7MsVgg7za5X40XsA=;\n\tb=DOlZ4qTVzF+IB2Y55hXVV++f8QXDT40Nj9PhD+Xiyj1dcev3R+/tehiKm8euW3iHrF\n\tsxElfFzQIQWIru6WtqlR2UtsEj++1dwjGuMNsCjgZwTbxfMpeqJ8Sj9jWEU2ahpfEaDH\n\ttTGnZBmhpbNMZMjmibrnkdUaRGqdQMqxJldSJ2NrsmNNMx7D3ABrW9sB0unhoXiPhIUO\n\tIsGXfEZON1RG9Dcz27yKzzuOrwXIoN4a3ky+VBy0i3ypROuDTTuQxYfbkPEYBlarc+nM\n\tE0Iofgycg0sngji7oX1+9QAcsQ6YmP8NW083mkxReXMUOfy19Hk/wODwfCkwuzyscjmp\n\tJu/w==","X-Gm-Message-State":"AC+VfDzQNvjI76zEViSMr7Kp5npleN4QM1iFUgkuuKPcqAsfWlgODglf\n\tHEb/pRAyI6TOCe+Eup6p8DOfEQwlf5fuiyamQZh0GA==","X-Google-Smtp-Source":"ACHHUZ4mgCH8qOdawW+KtdAt8sqVO1XHL5xvrNjEH5Sf2GMqMSN2zHiYvgB+syplsK99KiRVOMeD4KZZJQFb6EGUbDo=","X-Received":"by 2002:a0d:cb55:0:b0:565:c888:1d09 with SMTP id\n\tn82-20020a0dcb55000000b00565c8881d09mr12039168ywd.30.1685694968337;\n\tFri, 02 Jun 2023 01:36:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20230602060916.GP22609@pendragon.ideasonboard.com>\n\t<20230602060947.16309-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20230602060947.16309-1-laurent.pinchart@ideasonboard.com>","Date":"Fri, 2 Jun 2023 09:36:04 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: controls: Define a\n\tdefault lens position behaviour","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]