[{"id":27221,"web_url":"https://patchwork.libcamera.org/comment/27221/","msgid":"","date":"2023-06-02T08:33:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Drop reference\n\tto IPA in controls documentation","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Fri, 2 Jun 2023 at 06:43, Laurent Pinchart\n wrote:\n>\n> The controls relates to the public API, which doesn't expose IPA modules\n> as they are internal to libcamera. Replace the mention of \"IPA\" in the\n> controls documentation.\n>\n> While at it, fix a small text reflow issue.\n>\n> Signed-off-by: Laurent Pinchart \n\nSeems reasonable to me:\nReviewed-by: Naushir Patuck \n\n> ---\n> David, there's another mention of \"IPA\" in the FocusFoM control\n> documentation. I'm not sure how to best address that one, as it isn't\n> totally clear to me what you wanted to convey to the user. Could you\n> please give it a look ?\n\nI presume this is regarding the following text in the doc:\n\n\"\nThis control depends on the IPA to gather ISP statistics from the defined focus\nregion, and combine them in a suitable way to generate a FocusFoM value.\n\"\n\nEssentially it's trying to say that we take the stats from all focus regions\nand combine them in an appropriate way to return a single number to indicate\nfocus quality. Perhaps replace the sentence with something like the following:\n\n\"\nThis singular value may be based on a combination of statistics gathered from\nmultiple focus regions within an image. The number of focus regions and method\nof combination is platform dependent.\n\"\n\nNaush\n\n> ---\n> src/libcamera/control_ids.yaml | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index f6dbfd6c0bf0..5aa656cb5032 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -333,8 +333,8 @@ controls:\n> - FrameDurationLimits:\n> type: int64_t\n> description: |\n> - The minimum and maximum (in that order) frame duration,\n> - expressed in microseconds.\n> + The minimum and maximum (in that order) frame duration, expressed in\n> + microseconds.\n>\n> When provided by applications, the control specifies the sensor frame\n> duration interval the pipeline has to use. This limits the largest\n> @@ -343,7 +343,7 @@ controls:\n> the sensor will not be able to raise the exposure time above 33ms.\n> A fixed frame duration is achieved by setting the minimum and maximum\n> values to be the same. Setting both values to 0 reverts to using the\n> - IPA provided defaults.\n> + camera defaults.\n>\n> The maximum frame duration provides the absolute limit to the shutter\n> speed computed by the AE algorithm and it overrides any exposure mode\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AA5BC31E9\n\tfor ;\n\tFri, 2 Jun 2023 08:33:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11D43626F8;\n\tFri, 2 Jun 2023 10:33:31 +0200 (CEST)","from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com\n\t[IPv6:2607:f8b0:4864:20::1133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7592626F5\n\tfor ;\n\tFri, 2 Jun 2023 10:33:28 +0200 (CEST)","by mail-yw1-x1133.google.com with SMTP id\n\t00721157ae682-5659d85876dso16405857b3.2\n\tfor ;\n\tFri, 02 Jun 2023 01:33:28 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685694811;\n\tbh=zrcF16UI2EHYok+Zhad+bKS3f3q8YhexgzhdMMwtIXk=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wVqDy3bHVuuuAN5z0WFL9nTGcRIexA5DDyymb1Bm461mVBvFquIIQMx0GbNeJutax\n\tz8wBYl1QBvujvET8rWon4JW/brsQC4sWRwMLiffOI+R2fVIRIS3gokYmVBrHbjhY7F\n\theYF/Vp7hPHaJfgDgtG+s4E2kfsQBZyKe+iJbX2F28IPUXn5DhkqtIDpa4WD/1vb7a\n\t/DGMqS9e+pXjSzignnqTVP+42kM7axpZpJe2q628wIpgI6dDeIPrOfPlXZL+UW12U8\n\t1lUhWx8iMmzv7744vsY+GXgc4IiQaAe/Ko5JoEDtQkIwOSY3r+yrURGLzL9aHM2BIO\n\tuwMccrILo2B+w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1685694808; x=1688286808;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ulWB+OewFayLkes4UdeVGoXxcuZXPFYXakTxQC0Q7YM=;\n\tb=au2eynsudO2GzakCa/ucvRUGrxPsNyIcapK1PEFNjDZ1bMgZPP66rmYhA1M8s3+nzS\n\t8aNfv64HDHndeef/V9pU6ydsoi08SM9MTUf4pTSa9kuBHgmwsXqClLf3jb1o7X6kLmP5\n\tlFwExsZqWyW/PqPjieeEx6b8hLGch5cUhMCRouUuv+0EpZRD/pnS44bGTnFGdo0kthPy\n\tnrDeh+tP4ffJEiM0LLOMBIWVKyUXLTDo9zo3up1l8nazlY5WCecWBbbbxvsHzRhw0iXu\n\tSoz1a+XSn9cQf8pxsjjkBg/7WCuovRdj+T8bFvmgRlZWxoRixQSJP7fhgq9TJuSsFaJ3\n\tnU/w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"au2eynsu\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1685694808; x=1688286808;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ulWB+OewFayLkes4UdeVGoXxcuZXPFYXakTxQC0Q7YM=;\n\tb=RhcPBSdHk//+eZN6B1wIdE138fFZP1jpyn0sd6C3glZsVxn5P1YmYTVHozznAoFJfJ\n\tNfKVTnu/IFbA8znBl+QS4GZYw+YQrHoIjkvyz8f/CDswtpIUw6Pcm8/ypheKEZWerv4a\n\t5W5e1taQiv3VoX2VWVppeiPXpRF+vwckXF0apUEOIrHdNugyuN8VzYxhSXpPcTdyUVNe\n\tRNF9/5ztCF4sC/ae0WphShku0OgWa4E+rJDPFQKKh5XfBRGr/GSv6I/GJD99AiLq1hSk\n\t7d9O4lVGCaHFoByhlhyVkous4f1pNNPBHKbY5LOtgPGIE9XaPG5QTGdNQ5jRCwXHynf9\n\t6dPg==","X-Gm-Message-State":"AC+VfDyNiYhapHhektu70XssVccp2hcY4a551vIL/zByn6c622htc3Mk\n\tRKOyn1+/ilbLtd7Imz/XRHX5fshc8qRkrXp9Pa3/Cw==","X-Google-Smtp-Source":"ACHHUZ4sosFouE5wryrQ3nHrEwIpX1gMBGuIb0GfI1+9hVTbzW7rGJJd1UScKq8AE5Y6IxMjaTc87RUjH7MGcJkNwZc=","X-Received":"by 2002:a81:5c04:0:b0:54f:8b56:bb3 with SMTP id\n\tq4-20020a815c04000000b0054f8b560bb3mr9572928ywb.5.1685694807812;\n\tFri, 02 Jun 2023 01:33:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20230602054322.14815-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20230602054322.14815-1-laurent.pinchart@ideasonboard.com>","Date":"Fri, 2 Jun 2023 09:33:24 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Drop reference\n\tto IPA in controls documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]