[{"id":27212,"web_url":"https://patchwork.libcamera.org/comment/27212/","msgid":"<20230602044015.GN22609@pendragon.ideasonboard.com>","date":"2023-06-02T04:40:15","subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: imx296: Small refinements\n\tto the IMX296 mono sensor tuning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Thu, Jun 01, 2023 at 02:08:51PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Update the noise profile and reference lux level with newly taken\n> calibration pictures. Remove GEQ/cross-talk processing block as this is\n> a mono sensor.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rpi/vc4/data/imx296_mono.json | 15 ++++-----------\n> 1 file changed, 4 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\n> index 30965b4b8d61..db020550d70e 100644\n> --- a/src/ipa/rpi/vc4/data/imx296_mono.json\n> +++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n> @@ -14,25 +14,18 @@\n> {\n> \"rpi.lux\":\n> {\n> - \"reference_shutter_speed\": 19184,\n> + \"reference_shutter_speed\": 9998,\n> \"reference_gain\": 1.0,\n> \"reference_aperture\": 1.0,\n> - \"reference_lux\": 432,\n> - \"reference_Y\": 13773\n> + \"reference_lux\": 823,\n> + \"reference_Y\": 12396\n> }\n> },\n> {\n> \"rpi.noise\":\n> {\n> \"reference_constant\": 0,\n> - \"reference_slope\": 2.957\n> - }\n> - },\n> - {\n> - \"rpi.geq\":\n> - {\n> - \"offset\": 185,\n> - \"slope\": 0.0105\n> + \"reference_slope\": 2.753\n> }\n> },\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3990DC31E9\n\tfor ;\n\tFri, 2 Jun 2023 04:40:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 839C761EA5;\n\tFri, 2 Jun 2023 06:40:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6299961EA5\n\tfor ;\n\tFri, 2 Jun 2023 06:40:18 +0200 (CEST)","from pendragon.ideasonboard.com (om126156168104.26.openmobile.ne.jp\n\t[126.156.168.104])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F05B84DA;\n\tFri, 2 Jun 2023 06:39:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685680820;\n\tbh=yfhbA9sNCGXBl8b22So2TsMrtFPNikZAA9xyePbzU7A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0F5r5VN8sd7FprQ3ykKwUHdPAryKjAJTZAwao2mMcuU/1ai6q3gZNAd27+mvDAPUs\n\tgDYsQbtBO/JBdc9CYS3TxM1pjBIRLU0mrEzTyW/mIWKm7dXoAbLfzR6lWvzH+vOFtt\n\t0q+NHrR3Qto2UXe+OmQojqsIlyeNITY0i59CS5XJMCigMyVhVc90kdWd3Y4osua2GK\n\t4ijXT9oSPz3JsjFmG4hm2e283v8nGFuR99qwprZZoKA0fNlWOg89iuRhlx2Y07/1ye\n\tGZPfjxfkUtlY3pdY3/06gYrwNE9i+7rWScXX62t8E0V3JBZAUNcABnNya6lQOuQpV0\n\tO8Yefqh7EH6NQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685680795;\n\tbh=yfhbA9sNCGXBl8b22So2TsMrtFPNikZAA9xyePbzU7A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=X0dripRVuFs8nfojoX5UgIixbTAjRmtnM1qRJFBx8VapGi1bgrtvF2uxRoF4zdYCL\n\tFf9HYbl3u7oHlhfmG7Plq9rK1F4tOdMf98gD2vA9/jXk/YuOCfCEuSdqtMr+b3jm1K\n\tkMeFDhaHIlnDmXr2VjhJe/PY2GXW22IEQ2uSU/N0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X0dripRV\"; dkim-atps=neutral","Date":"Fri, 2 Jun 2023 07:40:15 +0300","To":"Naushir Patuck ","Message-ID":"<20230602044015.GN22609@pendragon.ideasonboard.com>","References":"<20230601130851.29591-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230601130851.29591-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: imx296: Small refinements\n\tto the IMX296 mono sensor tuning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]