{"id":18654,"url":"https://patchwork.libcamera.org/api/patches/18654/?format=json","web_url":"https://patchwork.libcamera.org/patch/18654/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230529123926.74775-2-jacopo.mondi@ideasonboard.com>","date":"2023-05-29T12:39:26","name":"[libcamera-devel,2/2] ipa: rkisp1: agc: Restore minimum analogue gain limit","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"19234abc1f0f0727652fda1c3c07f17b471dba0f","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18654/mbox/","series":[{"id":3891,"url":"https://patchwork.libcamera.org/api/series/3891/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3891","date":"2023-05-29T12:39:25","name":"[libcamera-devel,1/2] ipa: ipu3: agc: Drop hard-codec analogue gain max","version":1,"mbox":"https://patchwork.libcamera.org/series/3891/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18654/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18654/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8366AC328E\n\tfor ;\n\tMon, 29 May 2023 12:39:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DD8162702;\n\tMon, 29 May 2023 14:39:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7CA3626F8\n\tfor ;\n\tMon, 29 May 2023 14:39:43 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB8B9844;\n\tMon, 29 May 2023 14:39:23 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685363985;\n\tbh=5WhfivtXQp75812WPuMXBMgrMPus8kKYq1X9gRi4nuA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qgee1L1NcwVWXvvab/VGOUz6t404XzM6rhgcwbaTMrDyNC/u/KwheQHF2hH9dXWhJ\n\tDycxiubb5seFLZfoxCq8XBrDU5HrdCRY9hyH650/l8ZGGhfnUEZzE1n68TWBt+M3SM\n\tI5wVLamyhjaLPRozd32650NBeiZWh4EhK13yJ5jR0v101Oiqp9f8WcEuNtCcb1RUYz\n\ttAMvwW2v13XKarVnJGNjfQvSBvuurvFJFL8dN1tGXnOy/2FHyvZheQ/AHD+bI6lTsd\n\tC4QivQ3VWKVVkYFlgO3qG1zAClpK1TPEERdx2qxSmpc3tjk+5WQFUmZxJ7Aiu8xo+c\n\t2vofuDXlmI5dQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685363964;\n\tbh=5WhfivtXQp75812WPuMXBMgrMPus8kKYq1X9gRi4nuA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VYyy1WYEQv9th2g7REKxH/Uf517Nyy1K2FvBji84GAJPtIcaUKtpFpl3wYI2ytuS1\n\tqnbi28jeLfxbQrHpTtGpkxiRRpZaO9q9wOm4g3YYZVmA3WWHEy9yi/6n7kFP6T6iaP\n\t69K8BB/cCw1E1vwC7rSbQ1aLX+MUSjMXn6sDk8dg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VYyy1WYE\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 May 2023 14:39:26 +0200","Message-Id":"<20230529123926.74775-2-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20230529123926.74775-1-jacopo.mondi@ideasonboard.com>","References":"<20230529123926.74775-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] ipa: rkisp1: agc: Restore minimum\n\tanalogue gain limit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tBenjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Commit a3178dd0391f (\"ipa: rkisp1: agc: drop hard-coded analogue gain range\")\nremoved both minimum and maximum limits for the analogue gain value.\n\nHowever, as some sensors can potentially have a minimum gain lower than\n1.0, restore the check for the minimum limit.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\n--\n2.40.1","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex a4e5500e72d6..e5aeb3426eff 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -36,6 +36,9 @@ namespace ipa::rkisp1::algorithms {\n\n LOG_DEFINE_CATEGORY(RkISP1Agc)\n\n+/* Minimum limit for analogue gain value */\n+static constexpr double kMinAnalogueGain = 1.0;\n+\n /* \\todo Honour the FrameDurationLimits control instead of hardcoding a limit */\n static constexpr utils::Duration kMaxShutterSpeed = 60ms;\n\n@@ -254,7 +257,8 @@ void Agc::computeExposure(IPAContext &context, IPAFrameContext &frameContext,\n \tutils::Duration maxShutterSpeed = std::min(configuration.sensor.maxShutterSpeed,\n \t\t\t\t\t\t kMaxShutterSpeed);\n\n-\tdouble minAnalogueGain = configuration.sensor.minAnalogueGain;\n+\tdouble minAnalogueGain = std::max(configuration.sensor.minAnalogueGain,\n+\t\t\t\t\t kMinAnalogueGain);\n \tdouble maxAnalogueGain = configuration.sensor.maxAnalogueGain;\n\n \t/* Consider within 1% of the target as correctly exposed. */\n","prefixes":["libcamera-devel","2/2"]}