[{"id":27133,"web_url":"https://patchwork.libcamera.org/comment/27133/","msgid":"","date":"2023-05-24T12:49:56","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add Sony\n\tIMX327 sensor properties","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Benjamin\n\nOn Tue, May 23, 2023 at 07:12:43PM +0200, Benjamin Bara via libcamera-devel wrote:\n> From: Benjamin Bara \n>\n> Copy the sensor properties from Sony IMX290, as the IMX327 is a variant\n> of it.\n>\n> Signed-off-by: Benjamin Bara \n\nThis matches the information on the product brief\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n\n> ---\n> Hi,\n>\n> I forgot to add the properties when adding the helper last week.\n> These could also be squashed :)\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index fefb8afc..d35055d4 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -103,6 +103,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t.unitCellSize = { 2900, 2900 },\n> \t\t\t.testPatternModes = {},\n> \t\t} },\n> +\t\t{ \"imx327\", {\n> +\t\t\t.unitCellSize = { 2900, 2900 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n> \t\t{ \"imx296\", {\n> \t\t\t.unitCellSize = { 3450, 3450 },\n> \t\t\t.testPatternModes = {},\n>\n> ---\n> base-commit: e8fccaea46b9e545282cd37d54b1acb168608a46\n> change-id: 20230523-imx327-properties-61e7af857ba1\n>\n> Best regards,\n> --\n> Benjamin Bara \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 654C9C31E9\n\tfor ;\n\tWed, 24 May 2023 12:50:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB4E5626F5;\n\tWed, 24 May 2023 14:50:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7AF66039D\n\tfor ;\n\tWed, 24 May 2023 14:50:00 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:72c3:346:a663:c82d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB127283;\n\tWed, 24 May 2023 14:49:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1684932602;\n\tbh=F1xW0vjmLCpIuJaUB5KQ5yXOvYviXbMBWRmfIrYVDhE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Bnrv+zbcZke4C/4FvwtnPivMVCR///00gaP7maVp988pS+DRWs5Fp0dPzgYjnc85C\n\teaO8DBH9aE0TK67d6m7taGW3N0NMpXjVzsmVjHciSuCa7dPqeZoPYoKJjtGgYpZflg\n\tFCnwFe3vydz/IS6qtjxxz3w3uy17xdB5pNwb67dZ3nCqzOb6kR2xDHRlJ2/Zip7Ht0\n\tsyCeByEB6bp3fnd5xLftfmZ1/DF8NVL/gnE+WgctfXI9F8y72Ol2o9IHYAgUMxbKUx\n\tE9GxM0pBfYdrmlLjL32N6KLzrOLevg9EY/O81O8ZwmlV05Ry1LbRCDmvq0jneeO+pt\n\trHIFrKH0x2iSQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1684932584;\n\tbh=F1xW0vjmLCpIuJaUB5KQ5yXOvYviXbMBWRmfIrYVDhE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YBnBwfS4RWSkpA710mTgzmVdZTVL7QH7keovEea0xZYYmHC7dl+OaReCjMjGIoqph\n\tqLQwxh7twr/z6eZhNclpOe2/rERtkty7qVtnsIEwAV1T4c5lIGr8nWRfte/0ZNbk2L\n\t9EfNOIdGVQZuXhEmF7rVilVAcGleqJn6jE5U/s+4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YBnBwfS4\"; dkim-atps=neutral","Date":"Wed, 24 May 2023 14:49:56 +0200","To":"Benjamin Bara ","Message-ID":"","References":"<20230523-imx327-properties-v1-1-bd1e3933ec84@skidata.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230523-imx327-properties-v1-1-bd1e3933ec84@skidata.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add Sony\n\tIMX327 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBenjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27135,"web_url":"https://patchwork.libcamera.org/comment/27135/","msgid":"<168493306131.2931851.10008367316342349189@Monstersaurus>","date":"2023-05-24T12:57:41","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add Sony\n\tIMX327 sensor properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Benjamin Bara via libcamera-devel (2023-05-23 18:12:43)\n> From: Benjamin Bara \n> \n> Copy the sensor properties from Sony IMX290, as the IMX327 is a variant\n> of it.\n> \n> Signed-off-by: Benjamin Bara \n> ---\n> Hi,\n> \n> I forgot to add the properties when adding the helper last week.\n> These could also be squashed :)\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index fefb8afc..d35055d4 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -103,6 +103,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .unitCellSize = { 2900, 2900 },\n> .testPatternModes = {},\n> } },\n> + { \"imx327\", {\n\nI think we'd probably keep these in sort order based on the string here.\nI can move it while applying.\n\n\nReviewed-by: Kieran Bingham \n\n> + .unitCellSize = { 2900, 2900 },\n> + .testPatternModes = {},\n> + } },\n> { \"imx296\", {\n> .unitCellSize = { 3450, 3450 },\n> .testPatternModes = {},\n> \n> ---\n> base-commit: e8fccaea46b9e545282cd37d54b1acb168608a46\n> change-id: 20230523-imx327-properties-61e7af857ba1\n> \n> Best regards,\n> -- \n> Benjamin Bara \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8B65C3284\n\tfor ;\n\tWed, 24 May 2023 12:57:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47E4B626FC;\n\tWed, 24 May 2023 14:57:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A983626F5\n\tfor ;\n\tWed, 24 May 2023 14:57:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8AC7283;\n\tWed, 24 May 2023 14:57:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1684933066;\n\tbh=kYo2HGRWz0jsUYJkahW5hrcCDnYXV+mzokeKw9tJs1Q=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=iv89FD3oLEJSMuf3lH3Wi8DvlQW6y3cCFZBaC4gWPZLtzCpeL3taiAETi8Hww9+Nj\n\tA/q7S4xcKHDtWGuOXwrIWRvxbM4ZB2FoZakT8iGJnz3r5zokm8ewDCec3YWXdaizz3\n\t5Mq0WUQ1WLZr3mc5pwchonmM44t/F8WY7w2BfyYNTWEvchAVvpm751RHxEKjF4KrMX\n\t4nsM+dVdofR1ZDdhclkt8CTtlsESYk5f9w7cB+rQXG/eJTZeSWaVcpr1txrlzXWust\n\txjtC62jzJmngUK703gw/+zqawlr48Ws14nJR4wnd4twGXd0lEPeMrGhobkpe53vdFt\n\tBqtipyrIczhlw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1684933047;\n\tbh=kYo2HGRWz0jsUYJkahW5hrcCDnYXV+mzokeKw9tJs1Q=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=LgrQ64UaupN5Xy/y8SXn76VIvfAuHlvArlWnFWSYz1WfSVCXAFYpW+Dgs5LHHBcIR\n\tdb+iGg5J1Sojij3dVkSJZw6CIt5FeINyPvzC4h3JUMwZ5nE1FAXQ8KiZQ3d6me0IaN\n\tMjLdWEHpKj/vLnN/+OjC3N3L1AB1yRFe+Gq8TP/I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LgrQ64Ua\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230523-imx327-properties-v1-1-bd1e3933ec84@skidata.com>","References":"<20230523-imx327-properties-v1-1-bd1e3933ec84@skidata.com>","To":"Benjamin Bara , libcamera-devel@lists.libcamera.org","Date":"Wed, 24 May 2023 13:57:41 +0100","Message-ID":"<168493306131.2931851.10008367316342349189@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add Sony\n\tIMX327 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Benjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]