[{"id":27118,"web_url":"https://patchwork.libcamera.org/comment/27118/","msgid":"<168451185786.3378917.683874127961701062@Monstersaurus>","date":"2023-05-19T15:57:37","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Benjamin Bara via libcamera-devel (2023-05-19 16:48:13)\n> From: Benjamin Bara \n> \n> Add support for the Sony IMX327, which is added to the kernel with\n> commit 2d41947ec2c0 (\"media: i2c: imx290: Add support for imx327\n> variant\"). It is basically a derivate of the IMX290, therefore also\n> derive the helper.\n> \n> Signed-off-by: Benjamin Bara \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 21cdabd1..2eebd7ab 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -428,6 +428,11 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n> \n> +class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n> +{\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n\nThis looks reasonable.\n\nI wonder if we even need to have the new class at all? Does this work:\n\n\n REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n +REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx290)\n\n?\n\nI would indeed rather add references to existing compatibles than\nduplicate entire Helper classes where the result would be identical for\nequivalent devices so either way:\n\n\nReviewed-by: Kieran Bingham \n\n> +\n> class CameraSensorHelperImx296 : public CameraSensorHelper\n> {\n> public:\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B1BCC3284\n\tfor ;\n\tFri, 19 May 2023 15:57:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10C906285F;\n\tFri, 19 May 2023 17:57:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 840A9627CD\n\tfor ;\n\tFri, 19 May 2023 17:57:40 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C71424DB;\n\tFri, 19 May 2023 17:57:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1684511862;\n\tbh=y1A9Bp/hImwBkDsXMHDkSjC3qXeXCxckdCNeiAVqbfI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ByXf0Oe7GmcuyqYqPuUTlHHJ6QjSpC7+q0U7va9LBwSfupa9bkZnPaFu6wRgmkDMN\n\tl2r/e1k4mQ0C2PCN0ztVSeOmS6Pzkr49DRY0jofjSkfipP5dXudlyK84cx2/bTnhSf\n\tB01zHqJYlQGux5eScec7jBgEj2sImvKNLWLwszURgh7OIV4d+RWKD+XAv4rFW5aA6Q\n\tV4+dPZS6KJwNFlPdOFYEcaPVtn2v/6FaqKVNsOllDE08KjEsicF/tNVCGj7oSPZ2wj\n\tvkvZXdADja2xGfFGSj8N8BI6sG/MbwiAWR6HQwL94IghwuaGhjf7HoFc0aAky1BiZd\n\tDF9wGySjlY5FQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1684511846;\n\tbh=y1A9Bp/hImwBkDsXMHDkSjC3qXeXCxckdCNeiAVqbfI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fUBEsB4I7LjuL+P1KMRX/hm1Xr8k76uKXztR3GE+edQhZltMfmx8tyKNAJ3Z73zbq\n\ta1oX1JSHoxzbxY2NpMcpgbNhA7t3Yv2dqVJSQRU/XhPIg4Jp08D5ofQMcBmqKdPklj\n\t883wWROSDXAzqpGI4zJwihl/bRd1nZzG0ZPjnGNU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fUBEsB4I\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230519154813.448664-1-bbara93@gmail.com>","References":"<20230519154813.448664-1-bbara93@gmail.com>","To":"Benjamin Bara , libcamera-devel@lists.libcamera.org","Date":"Fri, 19 May 2023 16:57:37 +0100","Message-ID":"<168451185786.3378917.683874127961701062@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Benjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27120,"web_url":"https://patchwork.libcamera.org/comment/27120/","msgid":"","date":"2023-05-19T16:23:54","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hello\n\nOn Fri, May 19, 2023 at 04:57:37PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Benjamin Bara via libcamera-devel (2023-05-19 16:48:13)\n> > From: Benjamin Bara \n> >\n> > Add support for the Sony IMX327, which is added to the kernel with\n> > commit 2d41947ec2c0 (\"media: i2c: imx290: Add support for imx327\n> > variant\"). It is basically a derivate of the IMX290, therefore also\n> > derive the helper.\n> >\n> > Signed-off-by: Benjamin Bara \n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++\n> > 1 file changed, 5 insertions(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index 21cdabd1..2eebd7ab 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -428,6 +428,11 @@ public:\n> > };\n> > REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n> >\n> > +class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n> > +{\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n>\n> This looks reasonable.\n>\n> I wonder if we even need to have the new class at all? Does this work:\n>\n>\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx290)\n>\n> ?\n>\n> I would indeed rather add references to existing compatibles than\n> duplicate entire Helper classes where the result would be identical for\n> equivalent devices so either way:\n>\n>\n> Reviewed-by: Kieran Bingham \n\nWith Kieran's suggestions, if possible. Either waysL\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> > +\n> > class CameraSensorHelperImx296 : public CameraSensorHelper\n> > {\n> > public:\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF398C3284\n\tfor ;\n\tFri, 19 May 2023 16:23:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A853A62861;\n\tFri, 19 May 2023 18:23:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88CB5627D3\n\tfor ;\n\tFri, 19 May 2023 18:23:57 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B20F720;\n\tFri, 19 May 2023 18:23:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1684513438;\n\tbh=D7PMc0tM+PGMtU83ZgjT6VmJb96yG4spil/oL3dx1oU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kKrbjLCMIuKapQAymTNZ799XivQDiVEq9do0G/26uGu+4b2YFHirGf21b1qgZ5Xj/\n\tJ+1gF2SOoReT9RfOSaGmsmaqS4bNlCy5sfcED1GZsi2NoJPeq+++jpfmhuNNorw8cy\n\toxShioay+Iq41Stg7P/kdpA8bi8fsln9x1/kvLhwGXmHsW7Rvspnxab0Gg0QJRAIsW\n\tucr5YJA2vH5mYfhO26wr++P5cu1QKZGuhip82uVRbb5c5coc0fE8YSi5SHE28AYjCi\n\t52NlPtzvUuGTMPOPaA7N/IREknVTd+6ZY8a4EJGrHPYWDdQyLdAtg16Vff+MPrJBMM\n\ttLefRZ5VVkjPw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1684513424;\n\tbh=D7PMc0tM+PGMtU83ZgjT6VmJb96yG4spil/oL3dx1oU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NPLsUoIKBLUz0ZquMQ3ogK/f0r3VcCJ6dF/PzmG9ZoS+88TIxSt/l1EFDSrj0M/PZ\n\tfPnGIc4IK8ZDk4DUWRy3BjN+WIVFAX3LqLSaZh59B2d11BLhL5te01utxm6/XRlldh\n\tjgIqj/+4IFtOcYEvXHtrLXfZO+EG9MnfoX9B1fvM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NPLsUoIK\"; dkim-atps=neutral","Date":"Fri, 19 May 2023 18:23:54 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20230519154813.448664-1-bbara93@gmail.com>\n\t<168451185786.3378917.683874127961701062@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<168451185786.3378917.683874127961701062@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Benjamin Bara , libcamera-devel@lists.libcamera.org, \n\tBenjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27121,"web_url":"https://patchwork.libcamera.org/comment/27121/","msgid":"","date":"2023-05-19T16:40:55","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","submitter":{"id":163,"url":"https://patchwork.libcamera.org/api/people/163/","name":"Benjamin Bara","email":"bbara93@gmail.com"},"content":"Hi!\n\nOn Fri, 19 May 2023 at 17:57, Kieran Bingham\n wrote:\n> I would indeed rather add references to existing compatibles than\n> duplicate entire Helper classes where the result would be identical for\n> equivalent devices.\n\nYes, I think so too - but unfortunately it leads to an error for now, as\nit would redefine:\nlibcamera::ipa::CameraSensorHelperFactory\nlibcamera::ipa::global_CameraSensorHelperImx290Factory’\n\nRegards\nBenjamin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F178C31E9\n\tfor ;\n\tFri, 19 May 2023 16:41:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9B82627CD;\n\tFri, 19 May 2023 18:41:09 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 590F5627CD\n\tfor ;\n\tFri, 19 May 2023 18:41:08 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id\n\ta640c23a62f3a-96f588bc322so202337466b.1\n\tfor ;\n\tFri, 19 May 2023 09:41:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1684514469;\n\tbh=pnbzp8zSd+U8ag+xoRLacVuRWCI62JFwnPuwaMc8Foc=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JwoQOPQVMTZuy449lSfcdb8Z6KhPguXWDzlZ5c9YYpzOdkL69MF8DXVUW+PlI+T1u\n\tWHxpd6MFLXmUwKIP3SKC1BbvRlDPAEKl/eG9ym4IoA6kN3dN6NoZW/mtIPivxk/rqZ\n\tcExcdPaPQ9sSQTYR+Enkd29EfjmJ2B6eR6shmsdm7zX+QLQgCAsXUduSEePwZJyGUK\n\ty/zhIP5SjOAYxsAfWjGbsdSgN6SYRq7Txbnq+LvlGcstIpf5blyk9s/yT2MvTL3J9p\n\tVLVeqE9OVF3nXd2sr6gDI0Vlgd8Ph3VIVamKTs9Wp45Stkhbfoniuhzoxreh97TqF/\n\tRu6An/hyZiYNg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20221208; t=1684514468; x=1687106468;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=pnbzp8zSd+U8ag+xoRLacVuRWCI62JFwnPuwaMc8Foc=;\n\tb=OKCoUxdbXQjcM5c57ihacqs/LpOLdQ16itTSDqc1GtX9sh9xA1acnEw1nF1Nk7UC7T\n\tjnqCVCeAxKNvZy979B61wrT1EdQfYjSGI99Uz1m8MJ3PpBZW+kznTmkLtE9dG1ug0Te2\n\tXRXwc4PD5VPnzDbTDyKHVk7mlSaUynTOWPWuxL4zzVOYXBEoPf25iXuMv8vFgSiVeYUZ\n\t4kMQ5gMbunCQxs/NCeSTejJDeCbg2IIrpTZTgAQjqr82hwPiQvFj6gtI5D+iOr4z+3Cj\n\tCbjLN/JMbRplZBLYddeozlv77+csL4z/eW0DaYgk5R+8MAxZaoUFR4KjdOhNROYvQyn1\n\tkdag=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"OKCoUxdb\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1684514468; x=1687106468;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=pnbzp8zSd+U8ag+xoRLacVuRWCI62JFwnPuwaMc8Foc=;\n\tb=PLNmJ2gQ2VxCKHc4te+OwD+uk31TjdVWlrDi5kpOdZN/yHNGn8MPAzAR9x1KLe02Q2\n\tcQz8BoSaylhUUpYLQeWrpVdHZ9TsZ2/9kvDVYs8iSud3Us/IbIZD2Ws5Ba7JF108fA5A\n\t/vCR/iQrrSbmLRFd0lqHHh+JWa+/ny8WOsaUutwOJc3j/l4yUZiw1thTJsVYvQCphlWE\n\tPCCSqTgEUSrzuzcfV8u8EHPxoIzMJnyHK42hGsOeApRNvT9kfLDANjgLNyATf6Y0h8dk\n\t93Reu1f1R396Ld3c14kaqldejXbTQHlZScbKMYpVIChkvKz9qyyrtF2y3BjKCQac34AZ\n\tVhNg==","X-Gm-Message-State":"AC+VfDyynfvIWlt7MgY4t2Z2YXMhKeHiqjmcwes3tsrK57q2194dqpPE\n\t15Y75RTv1H3hc3UYFLeK+OW/6lFbIaALi+q2xu9sG8BDLb8=","X-Google-Smtp-Source":"ACHHUZ7A+BO2zXqToRxux5JJ7rnXsLik+v8jHZJolOR97CokbDWdFqV37RQwWw2u2eXh6y+M/v9cme+i9D/XEv6gtmk=","X-Received":"by 2002:a17:907:7d8a:b0:96f:1b96:6147 with SMTP id\n\toz10-20020a1709077d8a00b0096f1b966147mr2290561ejc.55.1684514467538;\n\tFri, 19 May 2023 09:41:07 -0700 (PDT)","MIME-Version":"1.0","References":"<20230519154813.448664-1-bbara93@gmail.com>\n\t<168451185786.3378917.683874127961701062@Monstersaurus>\n\t","In-Reply-To":"","Date":"Fri, 19 May 2023 18:40:55 +0200","Message-ID":"","To":"Jacopo Mondi , \n\tKieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Benjamin Bara via libcamera-devel ","Reply-To":"Benjamin Bara ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBenjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27122,"web_url":"https://patchwork.libcamera.org/comment/27122/","msgid":"<168451527347.3351248.6843792368050420075@Monstersaurus>","date":"2023-05-19T16:54:33","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Benjamin Bara (2023-05-19 17:40:55)\n> Hi!\n> \n> On Fri, 19 May 2023 at 17:57, Kieran Bingham\n> wrote:\n> > I would indeed rather add references to existing compatibles than\n> > duplicate entire Helper classes where the result would be identical for\n> > equivalent devices.\n> \n> Yes, I think so too - but unfortunately it leads to an error for now, as\n> it would redefine:\n> libcamera::ipa::CameraSensorHelperFactory\n> libcamera::ipa::global_CameraSensorHelperImx290Factory’\n\nWell then lets stick with your patch and we can see if we can optimise\nreuse in the future.\n\nI'll queue the patch up for merge.\n\nThanks,\n\nKieran\n\n> \n> Regards\n> Benjamin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1488C3284\n\tfor ;\n\tFri, 19 May 2023 16:54:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 154FA6285F;\n\tFri, 19 May 2023 18:54:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B49F7627CD\n\tfor ;\n\tFri, 19 May 2023 18:54:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22EC7720;\n\tFri, 19 May 2023 18:54:23 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1684515278;\n\tbh=nqaCzfvsKFZYb1WOh0TMggMxVLBD6hFVO65UD7YDICk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dzm+YWpZhyJYB9jca1NNg0Uupg8Cpf3XXzxRgBgStR8rTdnhFm4MwyPsTnQM6bPgJ\n\tlb8ybKAfNs/nM5Yp4CMEIjR73mduKn3bQEfHFTiN8rH3Sov1bGKWQ3a0tPHbdUWzUw\n\tncdEU5ocULGRJ3JmwunzOrSDNNBhLOSY7XHDLxpN/q/pSdTot8NDB8pLoUWhrTdvH3\n\tQUK/ckKKLivZH7gEiV6rXxL7N5DZahm4XAlgxJ3Pmy+XG3S8A9rGndV7qm5xGRwAPO\n\t3XAOR8Ps4zIPUlCS5+eccmIz+j4G69l3WoaAbQpGvXNaPIQvSRYcfxV9dTFDP8MnEq\n\tqbMllxc4fB9ew==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1684515263;\n\tbh=nqaCzfvsKFZYb1WOh0TMggMxVLBD6hFVO65UD7YDICk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fBGaYUhzDajV5hQx7sQOTp6A6syYytR9fIzGfdpvejyaL9x4/H/V0HmYK2/6KaTz4\n\tTD3zbzqHjjPi26izgP/iaHI9BeYMxEV2BsSYTv7Bc8obPJWuM2te4t3NjZ0kOY+sxn\n\tHmyfL4hcHPLuaFyAGUNolP4/EqR2M2o1ywphv6gI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fBGaYUhz\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20230519154813.448664-1-bbara93@gmail.com>\n\t<168451185786.3378917.683874127961701062@Monstersaurus>\n\t\n\t","To":"Benjamin Bara ,\n\tJacopo Mondi ","Date":"Fri, 19 May 2023 17:54:33 +0100","Message-ID":"<168451527347.3351248.6843792368050420075@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBenjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27153,"web_url":"https://patchwork.libcamera.org/comment/27153/","msgid":"<20230529095959.GP25984@pendragon.ideasonboard.com>","date":"2023-05-29T09:59:59","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 19, 2023 at 05:54:33PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Benjamin Bara (2023-05-19 17:40:55)\n> > On Fri, 19 May 2023 at 17:57, Kieran Bingham wrote:\n> > > I would indeed rather add references to existing compatibles than\n> > > duplicate entire Helper classes where the result would be identical for\n> > > equivalent devices.\n> > \n> > Yes, I think so too - but unfortunately it leads to an error for now, as\n> > it would redefine:\n> > libcamera::ipa::CameraSensorHelperFactory\n> > libcamera::ipa::global_CameraSensorHelperImx290Factory’\n> \n> Well then lets stick with your patch and we can see if we can optimise\n> reuse in the future.\n> \n> I'll queue the patch up for merge.\n\nThe alphabetical order is now messed up :-( Could you please send a fix\n?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D12BFC3213\n\tfor ;\n\tMon, 29 May 2023 10:00:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 306AA626FA;\n\tMon, 29 May 2023 12:00:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA9A960599\n\tfor ;\n\tMon, 29 May 2023 11:59:58 +0200 (CEST)","from pendragon.ideasonboard.com (om126255106133.24.openmobile.ne.jp\n\t[126.255.106.133])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99F86836;\n\tMon, 29 May 2023 11:59:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685354400;\n\tbh=foumA56WcQ/Fa+3f0Pv+7Fto0lA/DvmLR7wwscvTqOA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=n6/pveGM7EFqEYsEo47WniMLprjFaYLyCZ6/AEpup5rXDnaZLwc85GM6g0g7XbAUI\n\tIZr2+sdCIR+868Z5W68osH9/g6lf9jl1ZFIQiGzY0T3TeitvN0Xk0kKa3hmEzk9Iwr\n\tPWfDks7PzRUpVoVEi/t4Rt7fVPpRI9JSOv7zoPMVoKeiO5pbmvkUmU06DM8tBuV4ME\n\tPZOTOtWr0pLdEe5h5zLlZjQlO1zHx3GEa2RusFvCqiiEO7Paj8CmWsGJ59USTMvozw\n\to6twUNXqSHFyYSh7A+fVQ9jNdqXiKx66tlHaWN0Xs4Q0sFtcDMDT2kjaHQqhOBTkac\n\thFf3xJGIsUMOw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1685354378;\n\tbh=foumA56WcQ/Fa+3f0Pv+7Fto0lA/DvmLR7wwscvTqOA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=u8dYVtnDecQaSnFoAp7xkR2YPbNoxnPyNd+bKzUDHr2tRcxpW6g1gGhMHgUngLPp3\n\tuWzzpqHRQ1+cRW6sesvY+y2ZY+nMYDMr41r+h2/jDMzEoefuHfdsubTuwj82Dff6q1\n\tds3AiL/LqeM+grm2KQBuQDxA3bQYJTfkgW7W0CaM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"u8dYVtnD\"; dkim-atps=neutral","Date":"Mon, 29 May 2023 12:59:59 +0300","To":"Kieran Bingham ","Message-ID":"<20230529095959.GP25984@pendragon.ideasonboard.com>","References":"<20230519154813.448664-1-bbara93@gmail.com>\n\t<168451185786.3378917.683874127961701062@Monstersaurus>\n\t\n\t\n\t<168451527347.3351248.6843792368050420075@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<168451527347.3351248.6843792368050420075@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tIMX327 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Benjamin Bara ,\n\tJacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tBenjamin Bara ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]