[{"id":27274,"web_url":"https://patchwork.libcamera.org/comment/27274/","msgid":"<a36-647f1f00-7-67052780@90297503>","date":"2023-06-06T11:56:09","subject":"Re: [libcamera-devel] =?utf-8?q?=5BPATCH_v3_4/5=5D_libcamera=3A_?=\n\t=?utf-8?q?properties=3A_Provide_a_Devices_camera_property?=","submitter":{"id":165,"url":"https://patchwork.libcamera.org/api/people/165/","name":"Ashok Sidipotu","email":"ashok.sidipotu@collabora.com"},"content":"Tested-by: Ashok Sidipotu <ashok.sidipotu@collabora.com>\n\nOn Monday, May 15, 2023 18:15 IST, Kieran Bingham <kieran.bingham@ideasonboard.com> wrote:\n Provide a new Camera property that allows pipeline handlers to list any\ndevices used to operate the device. This allows other frameworks and\ndaemons such as Pipewire to better understand the resources consumed by\na Camera and consider ignoring those resources when enumerating camera\ndevices on a system.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\nsrc/libcamera/property_ids.yaml | 7 +++++++\n1 file changed, 7 insertions(+)\n\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex cb55e0ed2283..6141942969f9 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -690,6 +690,13 @@ controls:\nthat is twice that of the full resolution mode. This value will be valid\nafter the configure method has returned successfully.\n\n+ - Devices:\n+ type: int64_t\n+ size: [n]\n+ description: |\n+ A list of integer values of type dev_t denoting major and minor device\n+ number of the underlying devices used in the operation of this camera.\n+\n# ----------------------------------------------------------------------------\n# Draft properties section\n\n--\n2.34.1","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C47DBC32AA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  6 Jun 2023 12:03:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52A1F628A2;\n\tTue,  6 Jun 2023 14:03:30 +0200 (CEST)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4178662892\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  6 Jun 2023 13:56:10 +0200 (CEST)","from hamburger.collabora.co.uk (hamburger.collabora.co.uk\n\t[IPv6:2a01:4f8:1c1c:f269::1])\n\tby madras.collabora.co.uk (Postfix) with ESMTP id DB4C66606EAD;\n\tTue,  6 Jun 2023 12:56:09 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686053010;\n\tbh=sdHpviYpnP0MBjowZOV6dhky7qJwyBZYHbr7UIDFO88=;\n\th=In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:\n\tList-Post:List-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=wVmX1KVvGhJ+5VJXEgqTVokSw70nLy7/QL2qM8hwdgqA9jgqw53wB6oEZQVujoepC\n\tSuQFleBPUDrCqeL0HowIkrFgfoRUa7HGNJ/f5l8jjibEB6zIRaFlVMou8MjTvjMse3\n\tiMRd8Keo5zrDLCHIauc9Z7kpUUF3AvD3PGjf6REbe3pvoFMFaSFdSoaOvy7UXHPSrJ\n\teVFYQxytueVR+RALjNjEFtij9J8N4so1OQGEbbpyCKJjS76qBuEWR0OuP23dpIRLTx\n\td32bMUxt6xfi1HQhVjAZ1TmfAkZhjkUArv8t24YjpqMPRDxNVsyTQrKuQ7Jln7e87x\n\tV045YLj3qP/lQ==","In-Reply-To":"<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>","Content-Type":"multipart/alternative;\n\tboundary=\"----=_=-_OpenGroupware_org_NGMime-2614-1686052569.630236-1------\"","X-Forward":"127.0.0.1","Date":"Tue, 06 Jun 2023 12:56:09 +0100","To":"\"Kieran Bingham\" <kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Message-ID":"<a36-647f1f00-7-67052780@90297503>","User-Agent":"SOGoMail 5.8.0","X-Mailman-Approved-At":"Tue, 06 Jun 2023 14:03:27 +0200","Subject":"Re: [libcamera-devel] =?utf-8?q?=5BPATCH_v3_4/5=5D_libcamera=3A_?=\n\t=?utf-8?q?properties=3A_Provide_a_Devices_camera_property?=","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Ashok Sidipotu via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Ashok Sidipotu <ashok.sidipotu@collabora.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27290,"web_url":"https://patchwork.libcamera.org/comment/27290/","msgid":"<20230606162152.GF25679@pendragon.ideasonboard.com>","date":"2023-06-06T16:21:52","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, May 15, 2023 at 01:45:49PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Provide a new Camera property that allows pipeline handlers to list any\n> devices used to operate the device. This allows other frameworks and\n\nMaybe \"any kernel device used to operate the camera\" to be more precise\n?\n\n> daemons such as Pipewire to better understand the resources consumed by\n\ns/Pipewire/PipeWire/\n\n> a Camera and consider ignoring those resources when enumerating camera\n> devices on a system.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> ---\n>  src/libcamera/property_ids.yaml | 7 +++++++\n>  1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index cb55e0ed2283..6141942969f9 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -690,6 +690,13 @@ controls:\n>          that is twice that of the full resolution mode. This value will be valid\n>          after the configure method has returned successfully.\n>  \n> +  - Devices:\n> +      type: int64_t\n> +      size: [n]\n> +      description: |\n> +        A list of integer values of type dev_t denoting major and minor device\n> +        number of the underlying devices used in the operation of this camera.\n\ns/number/numbers/\n\nI would extend it with\n\n        Different cameras may report identical devices.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> +\n>    # ----------------------------------------------------------------------------\n>    # Draft properties section\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47653C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  6 Jun 2023 16:21:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B402E62893;\n\tTue,  6 Jun 2023 18:21:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2441962722\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  6 Jun 2023 18:21:55 +0200 (CEST)","from pendragon.ideasonboard.com (om126253223039.31.openmobile.ne.jp\n\t[126.253.223.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83C9F283;\n\tTue,  6 Jun 2023 18:21:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686068516;\n\tbh=A0c7Auet+K0OHGhG7Sbq7kaCQ02/ZzAf9mfnHpWS/Cc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=f5NtORDtfenm15GrswqSRlsMxpA4S8M8I7qbp1Zfh+WLvQi1aVnF1UMIw7Dh0JILm\n\th+EFYGm6639DbwOBjbauELuoZN82U2tdVZNykAWCLr6nmRl36PMtor5sIN1FC/4rDH\n\tpPfxVCffsyZ3a495iqiKlGC2qi++4NumE4wLA+NTkqZJZdp3C4ZOErmKhoGWnrET+D\n\t4oJB2QWtUColVUBNJJwpfQWAzbk3CkoOn2whYEQXhilsRpNgb7LlZSQTHxkf0pS76X\n\tOG7wLfFh5/ZVUbugH2cj7ouZPFb87VPlOaWgUn/XQcplvE5hVoYfSVMiP2TSq0n5ND\n\tWROvk6kX89vIg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686068489;\n\tbh=A0c7Auet+K0OHGhG7Sbq7kaCQ02/ZzAf9mfnHpWS/Cc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YgtO3whfu+ZKBs4bxKhikk3ZTw/mIC7qiqHqIK6Pui7jghPGS8ZgbZmdODAGnKJZw\n\tgf0IhgZa7oXpkKEF02NvXu7etTMnq3wllu6CWPnhr80LmK1R7t8EwLpE8AaRryLT/x\n\tEBpuakcSYvJwXcJMeBFfax2sLtKNdgj2HlDgau30="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YgtO3whf\"; dkim-atps=neutral","Date":"Tue, 6 Jun 2023 19:21:52 +0300","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20230606162152.GF25679@pendragon.ideasonboard.com>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27314,"web_url":"https://patchwork.libcamera.org/comment/27314/","msgid":"<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>","date":"2023-06-11T21:46:06","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2023. május 15., hétfő 14:45 keltezéssel, Kieran Bingham via libcamera-devel <libcamera-devel@lists.libcamera.org> írta:\n\n> Provide a new Camera property that allows pipeline handlers to list any\n> devices used to operate the device. This allows other frameworks and\n> daemons such as Pipewire to better understand the resources consumed by\n> a Camera and consider ignoring those resources when enumerating camera\n> devices on a system.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> ---\n>  src/libcamera/property_ids.yaml | 7 +++++++\n>  1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index cb55e0ed2283..6141942969f9 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -690,6 +690,13 @@ controls:\n>          that is twice that of the full resolution mode. This value will be valid\n>          after the configure method has returned successfully.\n> \n> +  - Devices:\n> +      type: int64_t\n\nI am wondering why the type is `int64_t`. POSIX only says `dev_t` is an integer type[0].\nBoth glibc[1] and musl[2] define it as an unsigned (64-bit) integer (at least as far as I checked).\n\n\n> +      size: [n]\n> +      description: |\n> +        A list of integer values of type dev_t denoting major and minor device\n> +        number of the underlying devices used in the operation of this camera.\n> +\n>    # ----------------------------------------------------------------------------\n>    # Draft properties section\n> \n> --\n> 2.34.1\n\n\n[0]: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html#tag_13_67\n[1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=bits/typesizes.h;h=5dd1700649463583c573b95cc6df8ac677316ea9;hb=HEAD#l29\n[2]: https://git.musl-libc.org/cgit/musl/tree/include/alltypes.h.in?id=718f363bc2067b6487900eddc9180c84e7739f80#n31","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35B7CC3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 11 Jun 2023 21:46:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E741609F3;\n\tSun, 11 Jun 2023 23:46:20 +0200 (CEST)","from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C060F6020C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 11 Jun 2023 23:46:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686519980;\n\tbh=WLP8+Vii7GFDi0H4ELHv05hHdXhWWOoSo97tArwAUNI=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=F7KBN6OFLqjw6iX7r4djj4UF7UmPR4PYI9jJEZBMm5btPMEn03teBmJvlsqzzLi/j\n\tr/dTPz9L4f+aXN3HaZhs5RzY+NuXUrye1Z7VfTrmsYhbI8dXC/dLcQn+GyZuqAAkqk\n\tPcxTGWVgsZkisElsj8s9r8SNAFhrBKx1IKcqOR+jJBUotEJxzwkPvL+k/FLhuF0hyM\n\t4S0+UlGbigdvYG18QPb01awUoVghvQughRx+8FncSn5PA+/ItcmxbIQtkX3MEqjt62\n\tqsVOZSLE7Yj6Sny+6HeODwTwzgrb7qNRcUSbFetNHU0/TOAhRm1yl6homB4G8IfIrW\n\tT6LfnLHpj0y0w==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1686519977; x=1686779177;\n\tbh=NlGGu14+3APiVN8UudtSLNZxRVFhUY5aLYp2rHkdV1c=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=iScYFGeRbtcEpsL8EKTxYKzbAXrEyLdQTOjLMu4p3jimrN+9E5fPXjKGSePKYt2qX\n\taSbwSmorlt6oeN2I2rwyUD6SHFyzezkChlO0OaPh9H/GWfCC1nTowUajV2X7OeAnvX\n\tEClbAI/ZGX0yvV0oEqk+niqewhob3BGEzk4WotHXLnLVVEbGfTtCzXAyKdp4QKZ4sH\n\tfRi+t0P4LNS1C+mNu9LVdQQkQaiWMxpP79oHWA+hA3zdSkQ1jb6I+/WLj1BAYShcEo\n\tuKgkAPyZIcddL4ySAnSTGzyWLVL/5Bqn2kzsL+ogSUJpVRN4t5LsofspR0jh95uBa0\n\tDddhYWeXumPaw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"iScYFGeR\"; dkim-atps=neutral","Date":"Sun, 11 Jun 2023 21:46:06 +0000","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>","In-Reply-To":"<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27321,"web_url":"https://patchwork.libcamera.org/comment/27321/","msgid":"<168658729996.2889415.1342142542009270475@Monstersaurus>","date":"2023-06-12T16:28:19","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2023-06-11 22:46:06)\n> Hi\n> \n> \n> 2023. május 15., hétfő 14:45 keltezéssel, Kieran Bingham via libcamera-devel <libcamera-devel@lists.libcamera.org> írta:\n> \n> > Provide a new Camera property that allows pipeline handlers to list any\n> > devices used to operate the device. This allows other frameworks and\n> > daemons such as Pipewire to better understand the resources consumed by\n> > a Camera and consider ignoring those resources when enumerating camera\n> > devices on a system.\n> > \n> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> > ---\n> >  src/libcamera/property_ids.yaml | 7 +++++++\n> >  1 file changed, 7 insertions(+)\n> > \n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index cb55e0ed2283..6141942969f9 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -690,6 +690,13 @@ controls:\n> >          that is twice that of the full resolution mode. This value will be valid\n> >          after the configure method has returned successfully.\n> > \n> > +  - Devices:\n> > +      type: int64_t\n> \n> I am wondering why the type is `int64_t`. POSIX only says `dev_t` is an integer type[0].\n> Both glibc[1] and musl[2] define it as an unsigned (64-bit) integer (at least as far as I checked).\n\nIndeed every implementation I can see define it as a 64-bit, but the\nkernel uses only 32 bits.\n\nThis is a libcamera control limitation ultimately, as we don't have\nunsigned integer controls. I'm not sure yet if adding would be helpful\nor difficult. It might be worth trying out.\n\n--\nKieran\n\n\n\n> > +      size: [n]\n> > +      description: |\n> > +        A list of integer values of type dev_t denoting major and minor device\n> > +        number of the underlying devices used in the operation of this camera.\n> > +\n> >    # ----------------------------------------------------------------------------\n> >    # Draft properties section\n> > \n> > --\n> > 2.34.1\n> \n> \n> [0]: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html#tag_13_67\n> [1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=bits/typesizes.h;h=5dd1700649463583c573b95cc6df8ac677316ea9;hb=HEAD#l29\n> [2]: https://git.musl-libc.org/cgit/musl/tree/include/alltypes.h.in?id=718f363bc2067b6487900eddc9180c84e7739f80#n31","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53AECC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Jun 2023 16:28:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92DAD61E50;\n\tMon, 12 Jun 2023 18:28:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D81161E4A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jun 2023 18:28:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 561BBCE6;\n\tMon, 12 Jun 2023 18:27:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686587304;\n\tbh=1yo1fJO/E3+6SsM2FbNRwHoNZv26gr0Cf3JnlGt/+1s=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=I20FJQazyMyPv3w6mxhYpM/YKgUzM1nonFVM9PQziRRq6lrGXXYBFk4pyNQEyIqJt\n\tggmlmFITaVUhoe+FxwoVlSwZYTHoJ4lhOT/pd7rq4truEALNvQXn3IfBQjvQhxZtxv\n\tNYKZ3kYygxmhfGNoF75SfybN56AIEMl1KgqthRoe21rh/z9AAF60FC6ssRd5rXNiM+\n\tB19f2oaNaE3k3LFRE0rHKH0rytF90ia2g/6bUwt/3E3kNph7gctoSwv27J+8Mys/6F\n\t6DbArd8zTDmbANO3yvLGUg1IC3DtUhPG9u/Vi7b7pTom+2PmwiqROQJOnaNUkk3ol4\n\tN3DXe85nzIdiQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686587273;\n\tbh=1yo1fJO/E3+6SsM2FbNRwHoNZv26gr0Cf3JnlGt/+1s=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wOO0RKgGovD0Wof4H0eWU2ECoLp/yCqIG9exm74GOedwET/RIiklr/4Xh5Z64n8eF\n\t9Lby9YB5pR9IKFyN6fLpUBNEbd+9SDpJVIkCRJsDP74UPHXCTZkkRVuUHMm8alVvK+\n\tfSe0I3TgxnV5A7tXLqgTRKDgv/hTcqo4I4ti5KVU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wOO0RKgG\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>\n\t<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>","Date":"Mon, 12 Jun 2023 17:28:19 +0100","Message-ID":"<168658729996.2889415.1342142542009270475@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27322,"web_url":"https://patchwork.libcamera.org/comment/27322/","msgid":"<20230612174437.GD28480@pendragon.ideasonboard.com>","date":"2023-06-12T17:44:37","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jun 12, 2023 at 05:28:19PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Barnabás Pőcze (2023-06-11 22:46:06)\n> > 2023. május 15., hétfő 14:45 keltezéssel, Kieran Bingham via libcamera-devel <libcamera-devel@lists.libcamera.org> írta:\n> > \n> > > Provide a new Camera property that allows pipeline handlers to list any\n> > > devices used to operate the device. This allows other frameworks and\n> > > daemons such as Pipewire to better understand the resources consumed by\n> > > a Camera and consider ignoring those resources when enumerating camera\n> > > devices on a system.\n> > > \n> > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> > > ---\n> > >  src/libcamera/property_ids.yaml | 7 +++++++\n> > >  1 file changed, 7 insertions(+)\n> > > \n> > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > index cb55e0ed2283..6141942969f9 100644\n> > > --- a/src/libcamera/property_ids.yaml\n> > > +++ b/src/libcamera/property_ids.yaml\n> > > @@ -690,6 +690,13 @@ controls:\n> > >          that is twice that of the full resolution mode. This value will be valid\n> > >          after the configure method has returned successfully.\n> > > \n> > > +  - Devices:\n> > > +      type: int64_t\n> > \n> > I am wondering why the type is `int64_t`. POSIX only says `dev_t` is an integer type[0].\n> > Both glibc[1] and musl[2] define it as an unsigned (64-bit) integer (at least as far as I checked).\n> \n> Indeed every implementation I can see define it as a 64-bit, but the\n> kernel uses only 32 bits.\n> \n> This is a libcamera control limitation ultimately, as we don't have\n> unsigned integer controls. I'm not sure yet if adding would be helpful\n> or difficult. It might be worth trying out.\n\nAn int64_t makes sure it will always fit the dev_t value regardless of\nthe platform, so I don't really see much added value in adding a\nplatform-dependent integer type for controls.\n\n> > > +      size: [n]\n> > > +      description: |\n> > > +        A list of integer values of type dev_t denoting major and minor device\n> > > +        number of the underlying devices used in the operation of this camera.\n> > > +\n> > >    # ----------------------------------------------------------------------------\n> > >    # Draft properties section\n> > > \n> > \n> > [0]: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html#tag_13_67\n> > [1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=bits/typesizes.h;h=5dd1700649463583c573b95cc6df8ac677316ea9;hb=HEAD#l29\n> > [2]: https://git.musl-libc.org/cgit/musl/tree/include/alltypes.h.in?id=718f363bc2067b6487900eddc9180c84e7739f80#n31","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80E8FC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Jun 2023 17:44:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E371461E50;\n\tMon, 12 Jun 2023 19:44:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6ABE61E4A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jun 2023 19:44:37 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B567480;\n\tMon, 12 Jun 2023 19:44:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686591878;\n\tbh=ATS696sU/IEvsVPf7AyzRh7YkbNfrKUEmKsQn0/cdco=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=T5fKwaHNg4QCUyKFC10dcE7jpNMnu994jMP+a0CqRllbfr+Kv24S3sROBtujuK/8z\n\tCDiagcuHeurVoCztL6Vu/tUNmSR6TOj5O86hpTyZd6MIdhHPJbfi5iy5WN62+l848S\n\tC1WYgbesMHj6+8mrX5DQu9TfHGHA9aBFIHSAbKtf+w8aSbzXtxwIeujusrtMOKedE8\n\tIvZDAKTV4DiyGxX5huPjVVHA4kiopkd8QWReLjPQq0fs9tICYrARI0LkEaRsbC4mGB\n\t3Jtr1hPrHvfHpsrml4cuYALoYKPItMbqNip5obLTvObCJrAh2irhmHZoxYr/xV5JOg\n\tqjWi5XoQvEklw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686591848;\n\tbh=ATS696sU/IEvsVPf7AyzRh7YkbNfrKUEmKsQn0/cdco=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jTNFHh5cvsBG77yWyxtm2C0RK4zp6fwxz7abTzNh8VRiJoLzOnD9YEu6mzK5GocLU\n\t3VLmn+08cPlFX3LJk+31LV1PrRDlmUmiW//BuJJ/MAOmUvt0IEh3JPrmDhst28Nbeq\n\t9QWW94ixZX0Xm39VOalSBtUX0/b9WN3F8ufakbmA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jTNFHh5c\"; dkim-atps=neutral","Date":"Mon, 12 Jun 2023 20:44:37 +0300","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20230612174437.GD28480@pendragon.ideasonboard.com>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>\n\t<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>\n\t<168658729996.2889415.1342142542009270475@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<168658729996.2889415.1342142542009270475@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27335,"web_url":"https://patchwork.libcamera.org/comment/27335/","msgid":"<skWkEX5KaahlUUqxI87kmKmQ3AQ6R_VggLEIam6hjmGojxTqGrikz975V0-li9PJCB6m-TY-XDjw8e5nqE_q0v0R5anEj2dAhK9vdVpBW6w=@protonmail.com>","date":"2023-06-13T15:48:39","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2023. június 12., hétfő 18:28 keltezéssel, Kieran Bingham <kieran.bingham@ideasonboard.com> írta:\n\n> [...]\n> > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > index cb55e0ed2283..6141942969f9 100644\n> > > --- a/src/libcamera/property_ids.yaml\n> > > +++ b/src/libcamera/property_ids.yaml\n> > > @@ -690,6 +690,13 @@ controls:\n> > >          that is twice that of the full resolution mode. This value will be valid\n> > >          after the configure method has returned successfully.\n> > >\n> > > +  - Devices:\n> > > +      type: int64_t\n> >\n> > I am wondering why the type is `int64_t`. POSIX only says `dev_t` is an integer type[0].\n> > Both glibc[1] and musl[2] define it as an unsigned (64-bit) integer (at least as far as I checked).\n> \n> Indeed every implementation I can see define it as a 64-bit, but the\n> kernel uses only 32 bits.\n> \n> This is a libcamera control limitation ultimately, as we don't have\n> unsigned integer controls. I'm not sure yet if adding would be helpful\n> or difficult. It might be worth trying out.\n> [...]\n\nAhh, I wasn't aware that libcamera does not have uint controls. Thanks for the clarification.\n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70A88C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Jun 2023 15:48:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D53F361E4B;\n\tTue, 13 Jun 2023 17:48:51 +0200 (CEST)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B91C861E49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jun 2023 17:48:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686671331;\n\tbh=DDekZ/hUq3Tv5JIKZu6mqWhSB2BaiV8kVA8TG33rIvk=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hLbEh8nIGVVBmB84Hnv9bTfhXpkZl3cPc2AifsGIZVTtSWVATHr6dVZFbUk1VhZPN\n\tJt+0TH+MGhafPgI9at8r1v+Yz8GwfbyKRe/s3WCLan1kTu7Bz/040UtNnqY+mzddeo\n\t+mb+hGCqzZ919oXaoBxuP7dwvIoIAed2EnD+meOwpr9d8vAj/Dz/wXrdLcFaR4LpxF\n\t8jRxOZcrsnRIlkV96Yhuwi5FA8wFfyxGS2YH+i+vkdpQh7X8LL7jfQdLtPYDjk7Q3n\n\tO5kj5j/bonFoTB1FlfbIkvRWaKomq6IGiC9s+8ohiMjFpd2sO3C2QLcnt9QmPU+fKU\n\tMFEWzPWILHBXg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1686671329; x=1686930529;\n\tbh=Ef+2vLOAQAWJtav7yiVCSH8IpaXmgasPzbM3SftWlXM=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=qmnhwwFDIHQ26G6MLhHhlkAuFmZetXFKIMCPFVdTWZL7jJqWOhRmz1pOXN4NhnLnI\n\t0v+aY9IC3gyyPAOOyOawsMFc1xs6uO4wAFRDo+P8Kpa6kEZqbg4oj0CRzyIAtWeXLs\n\tYQdLM8L0gOvaFmw1VuT8doh8ueHCiu6cn2ISwg4lntZoX94b1uAhxkpGW81QiveKAf\n\tSs9eqoWLt6xsp4Dwby/qSpAfTohN2nguqwECyCH1hosiOIODlDO9HHm8frSW70mtiP\n\tViv1FNrjp2djBhOb4ViPvlNOxctvo9Qr/IBuvZiv2IL6mkutRhrERNL0U463If8Pkd\n\tC8vkreKe1K30Q=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"qmnhwwFD\"; dkim-atps=neutral","Date":"Tue, 13 Jun 2023 15:48:39 +0000","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<skWkEX5KaahlUUqxI87kmKmQ3AQ6R_VggLEIam6hjmGojxTqGrikz975V0-li9PJCB6m-TY-XDjw8e5nqE_q0v0R5anEj2dAhK9vdVpBW6w=@protonmail.com>","In-Reply-To":"<168658729996.2889415.1342142542009270475@Monstersaurus>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>\n\t<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>\n\t<168658729996.2889415.1342142542009270475@Monstersaurus>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27336,"web_url":"https://patchwork.libcamera.org/comment/27336/","msgid":"<okwk4w0h1bOEiEkCBlvmNoreZSMCBXXNFHqzrhXslJimHWddwBEJM_HC3B5hJQ9KCKdtHy6yqhJYeGsoOHN6DZ7fMJT9lHbD2Iv93s2ACuQ=@protonmail.com>","date":"2023-06-13T15:55:32","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2023. június 12., hétfő 19:44 keltezéssel, Laurent Pinchart <laurent.pinchart@ideasonboard.com> írta:\n\n> [...]\n> > > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > > index cb55e0ed2283..6141942969f9 100644\n> > > > --- a/src/libcamera/property_ids.yaml\n> > > > +++ b/src/libcamera/property_ids.yaml\n> > > > @@ -690,6 +690,13 @@ controls:\n> > > >          that is twice that of the full resolution mode. This value will be valid\n> > > >          after the configure method has returned successfully.\n> > > >\n> > > > +  - Devices:\n> > > > +      type: int64_t\n> > >\n> > > I am wondering why the type is `int64_t`. POSIX only says `dev_t` is an integer type[0].\n> > > Both glibc[1] and musl[2] define it as an unsigned (64-bit) integer (at least as far as I checked).\n> >\n> > Indeed every implementation I can see define it as a 64-bit, but the\n> > kernel uses only 32 bits.\n> >\n> > This is a libcamera control limitation ultimately, as we don't have\n> > unsigned integer controls. I'm not sure yet if adding would be helpful\n> > or difficult. It might be worth trying out.\n> \n> An int64_t makes sure it will always fit the dev_t value regardless of\n> the platform, so I don't really see much added value in adding a\n> platform-dependent integer type for controls.\n> [...]\n\nI did not mean to imply that the size should be platform dependent.\nJust that I would have used uint64_t probably, but at that time\nI was not aware that libcamera had no uint controls.\n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CF95BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Jun 2023 15:55:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C98C261E50;\n\tTue, 13 Jun 2023 17:55:49 +0200 (CEST)","from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3BF361E49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jun 2023 17:55:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686671749;\n\tbh=bdmoNUgBjnJJHrLrm1im0ZpSDRkcAp/I94BBD9iRC1U=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QH3GrvNsuD248l22OINyBdq0pybvbYMGnM4nyea643DSOx9W6Cd6gn2PdGzNTVnJL\n\t4BnS0fCS+UxurGc9UW7eFKmP2V3WCwUKBcqWa9M3C+eVFtFPEnhnjVq+DLXbU3s3a7\n\t0cq3nCyck8t8K2CjSq+T37W6O2b5bfbZ2wqkh0giBgsfGynNIpcwZYFzVlfvsw5kf7\n\tjV34HmolIjQHWos7Cg9zVL6dYTfk7mN5IbRxrJ4ENfx30O3snbtPcLJ3drUgv9kTpU\n\tNUrqyWCLaOvo9lKYPkJJsFfwku/jxVlUy0qXynXPyInxUGetFTInbia1wqob/5CZu1\n\t1MftUODVpViRA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1686671748; x=1686930948;\n\tbh=YYDt/7jAEsMv9BX2NXCaC9SCQhiQRp0+fVNYViTjIXw=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=Ky5/NrMhzNA+SuUAi06riKTvAfu1a4PMzqYWNrYRopTQDZyuaeEpEKx7pBphmVSfk\n\t2gUOZB1ZaNN9nRn9F9D/Vc0lSRHdJ+9GiuyvDV6ViAVh/I63vkOY6xvS2tL3TnWird\n\tOPm2bnYbGz1KJsTrsEuz/fxYttdJVL3rNMdRapPXzO7QN8DTHJcP7Cc5ebEnM2U8nL\n\tuF8bMS92PatuIcBpCCvnc6lM4tbyZ3wZGXUvgIAgm2K2nrYgRXCCO/BhdKO6Rf3de1\n\tpHU2WneLTtu3QAsCpwJ3PaVpg3qdfaw3w/gblVuvmGG02JX6NjMgdHNisADxD7CTcd\n\tU9EBDKRf+vRsw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"Ky5/NrMh\"; dkim-atps=neutral","Date":"Tue, 13 Jun 2023 15:55:32 +0000","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<okwk4w0h1bOEiEkCBlvmNoreZSMCBXXNFHqzrhXslJimHWddwBEJM_HC3B5hJQ9KCKdtHy6yqhJYeGsoOHN6DZ7fMJT9lHbD2Iv93s2ACuQ=@protonmail.com>","In-Reply-To":"<20230612174437.GD28480@pendragon.ideasonboard.com>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>\n\t<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>\n\t<168658729996.2889415.1342142542009270475@Monstersaurus>\n\t<20230612174437.GD28480@pendragon.ideasonboard.com>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27337,"web_url":"https://patchwork.libcamera.org/comment/27337/","msgid":"<168667625261.2889415.12251732423375385023@Monstersaurus>","date":"2023-06-13T17:10:52","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2023-06-13 16:48:39)\n> Hi\n> \n> \n> 2023. június 12., hétfő 18:28 keltezéssel, Kieran Bingham <kieran.bingham@ideasonboard.com> írta:\n> \n> > [...]\n> > > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > > index cb55e0ed2283..6141942969f9 100644\n> > > > --- a/src/libcamera/property_ids.yaml\n> > > > +++ b/src/libcamera/property_ids.yaml\n> > > > @@ -690,6 +690,13 @@ controls:\n> > > >          that is twice that of the full resolution mode. This value will be valid\n> > > >          after the configure method has returned successfully.\n> > > >\n> > > > +  - Devices:\n> > > > +      type: int64_t\n> > >\n> > > I am wondering why the type is `int64_t`. POSIX only says `dev_t` is an integer type[0].\n> > > Both glibc[1] and musl[2] define it as an unsigned (64-bit) integer (at least as far as I checked).\n> > \n> > Indeed every implementation I can see define it as a 64-bit, but the\n> > kernel uses only 32 bits.\n> > \n> > This is a libcamera control limitation ultimately, as we don't have\n> > unsigned integer controls. I'm not sure yet if adding would be helpful\n> > or difficult. It might be worth trying out.\n> > [...]\n> \n> Ahh, I wasn't aware that libcamera does not have uint controls. Thanks for the clarification.\n\nHave you reviewed the patches enough to consider providing a set of\nReviewed-by tags perhaps?\n\nDo you have any thoughts or preferences on the control name? Laurent has\ndiscussed the option between \"Devices\" and \"SystemDevices\" - I'm really\nhoping someone will weigh in on which they prefer to be able to move\nforwards and merge this series.\n\n(I prefer Devices, so that makes it 1 vs 1)\n\n--\nRegards\n\nKieran\n\n\n> \n> \n> Regards,\n> Barnabás Pőcze","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BD00C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Jun 2023 17:10:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B748E61E4B;\n\tTue, 13 Jun 2023 19:10:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3AE061E49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jun 2023 19:10:55 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EDA01AE;\n\tTue, 13 Jun 2023 19:10:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686676257;\n\tbh=xWd6hULrACKyXUBCds3h0c7cFpW/TkTdGTJe3BDqw/M=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3ZRTMbo41URGyH8T9Q1Lt0HH+NQtIWW1rClyXEFNCAs7jiQRtvs+8jn/nbvtv3sK0\n\t1n1m99YuTPPHEIPgnz829FkQ7JCyJWInkewv4xfkkswLkbxm6qGpdJLGBWEy+MiRXI\n\tmmTkv5Oa5js6Z2tPd6d0q9s7tbUNq2YLiaqe4+8vRDvtvkZyXkv1iVFqq1LIOyVMr/\n\t7IaQMtVLBGI2oLXWDShrzmvrMD6CmWUQVWLMqu9e1bfMH4+S8tfDU27Wlb4kFc9gVo\n\tRltj9RX0t57JA2G0VoX20G7Na8WZKhrDIaWX07UYVPk95cjmTjMaPzEGm3hWxgjbad\n\te/7RR776H+kVQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686676225;\n\tbh=xWd6hULrACKyXUBCds3h0c7cFpW/TkTdGTJe3BDqw/M=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tsTY5U5kWagDb8Suh1REI1Cf2qespwBsD4SmAWXHYxM+8GwDjnnZ/UuURHTmuKDaa\n\t3nMM0eUQF1Lmr2KWVwYJzsKhxCtuIyqVmR4uW7VxYEQA+plm+hugVKpGZjMHFTf+nR\n\tZOCkBrFZlnK6UTKT0cGpJgygTDl50naApYMPt8+k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tsTY5U5k\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<skWkEX5KaahlUUqxI87kmKmQ3AQ6R_VggLEIam6hjmGojxTqGrikz975V0-li9PJCB6m-TY-XDjw8e5nqE_q0v0R5anEj2dAhK9vdVpBW6w=@protonmail.com>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>\n\t<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>\n\t<168658729996.2889415.1342142542009270475@Monstersaurus>\n\t<skWkEX5KaahlUUqxI87kmKmQ3AQ6R_VggLEIam6hjmGojxTqGrikz975V0-li9PJCB6m-TY-XDjw8e5nqE_q0v0R5anEj2dAhK9vdVpBW6w=@protonmail.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>","Date":"Tue, 13 Jun 2023 18:10:52 +0100","Message-ID":"<168667625261.2889415.12251732423375385023@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27344,"web_url":"https://patchwork.libcamera.org/comment/27344/","msgid":"<UGEANEiDd_ciNJvHd8uvQIkoGqdI_UWFoYmoWfow9tUxnzA6qM5aDqgYVCmohPaCSaMHRg_zcfOUhWHnAemldHy1X7DPQqGfh_wWi9EfpUw=@protonmail.com>","date":"2023-06-14T21:50:57","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2023. június 13., kedd 19:10 keltezéssel, Kieran Bingham <kieran.bingham@ideasonboard.com> írta:\n\n> Quoting Barnabás Pőcze (2023-06-13 16:48:39)\n> > Hi\n> >\n> >\n> > 2023. június 12., hétfő 18:28 keltezéssel, Kieran Bingham <kieran.bingham@ideasonboard.com> írta:\n> >\n> > > [...]\n> > > > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > > > index cb55e0ed2283..6141942969f9 100644\n> > > > > --- a/src/libcamera/property_ids.yaml\n> > > > > +++ b/src/libcamera/property_ids.yaml\n> > > > > @@ -690,6 +690,13 @@ controls:\n> > > > >          that is twice that of the full resolution mode. This value will be valid\n> > > > >          after the configure method has returned successfully.\n> > > > >\n> > > > > +  - Devices:\n> > > > > +      type: int64_t\n> > > >\n> > > > I am wondering why the type is `int64_t`. POSIX only says `dev_t` is an integer type[0].\n> > > > Both glibc[1] and musl[2] define it as an unsigned (64-bit) integer (at least as far as I checked).\n> > >\n> > > Indeed every implementation I can see define it as a 64-bit, but the\n> > > kernel uses only 32 bits.\n> > >\n> > > This is a libcamera control limitation ultimately, as we don't have\n> > > unsigned integer controls. I'm not sure yet if adding would be helpful\n> > > or difficult. It might be worth trying out.\n> > > [...]\n> >\n> > Ahh, I wasn't aware that libcamera does not have uint controls. Thanks for the clarification.\n> \n> Have you reviewed the patches enough to consider providing a set of\n> Reviewed-by tags perhaps?\n> \n> Do you have any thoughts or preferences on the control name? Laurent has\n> discussed the option between \"Devices\" and \"SystemDevices\" - I'm really\n> hoping someone will weigh in on which they prefer to be able to move\n> forwards and merge this series.\n> \n> (I prefer Devices, so that makes it 1 vs 1)\n> [...]\n\nWell, I can certainly weigh in, but I don't think you will be pleased, because\nmy preference leans towards \"SystemDevices\". But I would even go as far as to\nsuggest \"{,Underlying}{Kernel,System}DeviceIDs\" as potential candidates.\nAdmittedly some of those are long, but consider that\n\n - most programs won't need this, and\n - those that need will very likely only query it in a single place.\n\nSo I think even something like \"UnderlyingKernelDeviceIDs\" could work,\nand I think that name is quite descriptive.\n\nBut, of course, since this is likely a very rarely used control, I think both\n\"Devices\" and \"SystemDevices\" would work just fine.\n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85B11BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jun 2023 21:51:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E910461E4D;\n\tWed, 14 Jun 2023 23:51:09 +0200 (CEST)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8269261E4A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jun 2023 23:51:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686779469;\n\tbh=4BM+buiLt0kBq6vjtehIOPE4eXVhnKmkMNcffG7XGjM=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yJkAPw5xAwQk+O7yfZv6iLBdfHL8D81Dx9d02IdIl+it+oo2DQJHdXS2zyOxf4ERl\n\tKSURqWCECIjWJSM9p1ig8KAEECnDpB6sXmJtdDuy6P3UzzXAD8mRgsZPqZsZD477Vl\n\tM9hFmjAlVzkn1y0sv1bafHm0pU+DvLuxx3miBa9qtiOVAZchi4ndDXpBSoo8Hwx1Zf\n\tnPSlMjHJbxqzEOsIheqryewaVjtbaw6p/7+Ey9sLb70N8j2z3jC8g9RssAJ0CxkU47\n\t6ba9A2jZOdQRTbd3I6B+X8eW4xLCOeHC5Hl2I+BH2T3Ql70KopT+MPhl2gplFJALO1\n\t1IQ2MmHqtjjRg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1686779468; x=1687038668;\n\tbh=a/2fzJCYk+n+sWTyTINpzUwsEowdKnAqFDrhTUSt/2E=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=HNQei+Eia99oRBz9laIPbCrHCqgw3UdUO4UE/ZOZzI5AUK9c11RtK9RkDIGfeANHA\n\ta0W8UomLBmW/lmYsDyxiqQcGvdUosvjcrG5eGkuMdbYhVPHZFVPASN7HpVVmMY2vz/\n\tFPS3+zDBNvlfbYepkCA9jp/GsuegiyExjXvVdpu9TVqoe9cZ8LTJ9buvtb9e+NljPi\n\tiiPQxcuNOcPmohWXtt51ccjQLqeZuc1yCeYwWBNLlZpn5/5S0uloFqOwTpyOWM9+Ne\n\t2Z4G9o9tqv5ckFAk41+VzTePRLnVJXanIPAHfmuMa4V9NjV3vyrdsH4XjKO3T+CDF2\n\tEufVyn+sPQQhw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"HNQei+Ei\"; dkim-atps=neutral","Date":"Wed, 14 Jun 2023 21:50:57 +0000","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<UGEANEiDd_ciNJvHd8uvQIkoGqdI_UWFoYmoWfow9tUxnzA6qM5aDqgYVCmohPaCSaMHRg_zcfOUhWHnAemldHy1X7DPQqGfh_wWi9EfpUw=@protonmail.com>","In-Reply-To":"<168667625261.2889415.12251732423375385023@Monstersaurus>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>\n\t<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>\n\t<168658729996.2889415.1342142542009270475@Monstersaurus>\n\t<skWkEX5KaahlUUqxI87kmKmQ3AQ6R_VggLEIam6hjmGojxTqGrikz975V0-li9PJCB6m-TY-XDjw8e5nqE_q0v0R5anEj2dAhK9vdVpBW6w=@protonmail.com>\n\t<168667625261.2889415.12251732423375385023@Monstersaurus>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27350,"web_url":"https://patchwork.libcamera.org/comment/27350/","msgid":"<168681728404.3585053.14148502601990308270@Monstersaurus>","date":"2023-06-15T08:21:24","subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Barnabás\n\nThank you for weighing in!\n\nQuoting Barnabás Pőcze (2023-06-14 22:50:57)\n> Hi\n> \n> \n> 2023. június 13., kedd 19:10 keltezéssel, Kieran Bingham <kieran.bingham@ideasonboard.com> írta:\n> \n> > Quoting Barnabás Pőcze (2023-06-13 16:48:39)\n> > > Hi\n> > >\n> > >\n> > > 2023. június 12., hétfő 18:28 keltezéssel, Kieran Bingham <kieran.bingham@ideasonboard.com> írta:\n> > >\n> > > > [...]\n> > > > > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > > > > index cb55e0ed2283..6141942969f9 100644\n> > > > > > --- a/src/libcamera/property_ids.yaml\n> > > > > > +++ b/src/libcamera/property_ids.yaml\n> > > > > > @@ -690,6 +690,13 @@ controls:\n> > > > > >          that is twice that of the full resolution mode. This value will be valid\n> > > > > >          after the configure method has returned successfully.\n> > > > > >\n> > > > > > +  - Devices:\n> > > > > > +      type: int64_t\n> > > > >\n> > > > > I am wondering why the type is `int64_t`. POSIX only says `dev_t` is an integer type[0].\n> > > > > Both glibc[1] and musl[2] define it as an unsigned (64-bit) integer (at least as far as I checked).\n> > > >\n> > > > Indeed every implementation I can see define it as a 64-bit, but the\n> > > > kernel uses only 32 bits.\n> > > >\n> > > > This is a libcamera control limitation ultimately, as we don't have\n> > > > unsigned integer controls. I'm not sure yet if adding would be helpful\n> > > > or difficult. It might be worth trying out.\n> > > > [...]\n> > >\n> > > Ahh, I wasn't aware that libcamera does not have uint controls. Thanks for the clarification.\n> > \n> > Have you reviewed the patches enough to consider providing a set of\n> > Reviewed-by tags perhaps?\n\nHow about this point. Do you conisder that you've looked through this\ncode enough to say you have reviewed it?\n\n> > \n> > Do you have any thoughts or preferences on the control name? Laurent has\n> > discussed the option between \"Devices\" and \"SystemDevices\" - I'm really\n> > hoping someone will weigh in on which they prefer to be able to move\n> > forwards and merge this series.\n> > \n> > (I prefer Devices, so that makes it 1 vs 1)\n> > [...]\n> \n> Well, I can certainly weigh in, but I don't think you will be pleased, because\n> my preference leans towards \"SystemDevices\". But I would even go as far as to\n\nI'm afraid to say I am pleased! I don't mind favouring the least popular\noption. That's just my personal preference, but if more people voice\ntheir opinions it breaks an otherwise tie point ;-)\n\n> suggest \"{,Underlying}{Kernel,System}DeviceIDs\" as potential candidates.\n> Admittedly some of those are long, but consider that\n> \n>  - most programs won't need this, and\n>  - those that need will very likely only query it in a single place.\n> \n> So I think even something like \"UnderlyingKernelDeviceIDs\" could work,\n> and I think that name is quite descriptive.\n> \n> But, of course, since this is likely a very rarely used control, I think both\n> \"Devices\" and \"SystemDevices\" would work just fine.\n\nI don't think I want to make the name overly long, but you did throw in\none option that I like more than SystemDevices\n\n KernelDevices\n\nBut now I have a third option to pick from - so I need more voters and\npeople to weigh in on their opinion ...\n\nMaybe I won't be pleased after all :-) (Joking of course, I'm very happy\nfor the input - thanks!)\n\nAnyway, as it stands, if no one else comments I'll update this with\nSystemDevices to prepare for merge (Unless we raise the votes on\nKernelDevices).\n\nRegards\n--\nKieran","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78908C322E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jun 2023 08:21:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBA5961E45;\n\tThu, 15 Jun 2023 10:21:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AE1461E45\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jun 2023 10:21:26 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33BFD9CA;\n\tThu, 15 Jun 2023 10:20:55 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686817287;\n\tbh=1uPM1IXiLv9N3scd3r1KHqYMRhYcZae6YcDabfRx0yY=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=LakMH53R3yHtLH3jvNZULkDkMd7jRFsobtkWl+OcCKEp9tj5o+QfTydfeHL4rgAZ0\n\t1zjx0hfB3XiqoMxsxD+wV3gIGknVuD6SD8MAZww43oGYJdY1xA8lCDrVDMgP33AQXk\n\tG+hsxzpPfbtWt3squC/IpnumTshPjzRkCBFoHDtIMz9lMbud4Esxheic4KHfIw2uEU\n\tfSYpcTPi6cTBd1wtzJFWkJaE3bYg5P4K/zLNijeX0lW6b6Po5MVlmMsjFjBpJOqypr\n\tV6ZOmPTbVvV6Q9RgO6zSpZ18GsyWQqbt4lY4uLXc8k0fmFg0SypIKYxf07x5eU1T7M\n\t/YBx1dAQFQLOQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686817255;\n\tbh=1uPM1IXiLv9N3scd3r1KHqYMRhYcZae6YcDabfRx0yY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ovbbG6ned+Xmc/x2tK+Ta6chzJVr+JAZLKXQ+ng8ImbJsdWyzc/J2zgTpNAdMdVa8\n\tobvjVJfxCbt6kTHYazWsXZ7F1owPunV5x3Vg2+6Zm5cfxHWp+QMY6E2yDhNWcWxBJo\n\tQA2d609bRgS6SM/Q8y0BlSWy/VyXks5u4O4ThrUU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ovbbG6ne\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<UGEANEiDd_ciNJvHd8uvQIkoGqdI_UWFoYmoWfow9tUxnzA6qM5aDqgYVCmohPaCSaMHRg_zcfOUhWHnAemldHy1X7DPQqGfh_wWi9EfpUw=@protonmail.com>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-5-kieran.bingham@ideasonboard.com>\n\t<MLytuGq9RTq9a0APuPZ1BE4r5IwxUOL15WvGeDiUgz8WA4vgJKeH5Bmll2cNiQrlC8EaoMv7CLwq3ItkX_P5aibyZw6BE4gNYtBcE5n_k_Y=@protonmail.com>\n\t<168658729996.2889415.1342142542009270475@Monstersaurus>\n\t<skWkEX5KaahlUUqxI87kmKmQ3AQ6R_VggLEIam6hjmGojxTqGrikz975V0-li9PJCB6m-TY-XDjw8e5nqE_q0v0R5anEj2dAhK9vdVpBW6w=@protonmail.com>\n\t<168667625261.2889415.12251732423375385023@Monstersaurus>\n\t<UGEANEiDd_ciNJvHd8uvQIkoGqdI_UWFoYmoWfow9tUxnzA6qM5aDqgYVCmohPaCSaMHRg_zcfOUhWHnAemldHy1X7DPQqGfh_wWi9EfpUw=@protonmail.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>","Date":"Thu, 15 Jun 2023 09:21:24 +0100","Message-ID":"<168681728404.3585053.14148502601990308270@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]