[{"id":27271,"web_url":"https://patchwork.libcamera.org/comment/27271/","msgid":"<168c-647f1e80-1-2235d640@253257962>","date":"2023-06-06T11:53:51","subject":"Re: [libcamera-devel] =?utf-8?q?=5BPATCH_v3_1/5=5D_libcamera=3A_?=\n\t=?utf-8?b?aW50ZXJuYWw6Pz09P3V0Zi04P3E/IHJlcXVlc3Q6IGNvbnZlcnQgdG8g?=\n\t=?utf-8?q?pragma_once?=","submitter":{"id":165,"url":"https://patchwork.libcamera.org/api/people/165/","name":"Ashok Sidipotu","email":"ashok.sidipotu@collabora.com"},"content":"Tested-by: Ashok Sidipotu \nOn Monday, May 15, 2023 18:15 IST, Kieran Bingham wrote:\n Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nThe internal/request.h was missed at the time of the original\nconversion. Update it.\n\nFixes: df131ad08893 (\"libcamera: internal: Convert to pragma once\")\nSigned-off-by: Kieran Bingham \n---\ninclude/libcamera/internal/request.h | 6 ++----\n1 file changed, 2 insertions(+), 4 deletions(-)\n\ndiff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 8c92a27a95e5..3454cf5a72f5 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -4,8 +4,8 @@\n*\n* request.h - Request class private data\n*/\n-#ifndef __LIBCAMERA_INTERNAL_REQUEST_H__\n-#define __LIBCAMERA_INTERNAL_REQUEST_H__\n+\n+#pragma once\n\n#include \n#include \n@@ -62,5 +62,3 @@ private:\n};\n\n} /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_INTERNAL_REQUEST_H__ */\n--\n2.34.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF819C31E9\n\tfor ;\n\tTue, 6 Jun 2023 12:03:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24BE46289E;\n\tTue, 6 Jun 2023 14:03:28 +0200 (CEST)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DDBE62709\n\tfor ;\n\tTue, 6 Jun 2023 13:53:52 +0200 (CEST)","from hamburger.collabora.co.uk (hamburger.collabora.co.uk\n\t[IPv6:2a01:4f8:1c1c:f269::1])\n\tby madras.collabora.co.uk (Postfix) with ESMTP id 98C446606EAD;\n\tTue, 6 Jun 2023 12:53:51 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686053008;\n\tbh=KkSM3komJfSKEqem2M1hk4SRMOMVAZMVsYfZCel1iKk=;\n\th=In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:\n\tList-Post:List-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=lAR8cVSq4xtmZKhYE7K+F/g599HjpImaoyY2q8yxs51n6C2T/HOI5CB3aC9caKuWx\n\tL02k9dAvTU5dgjKzamPuTb1ElcFQh6xUzaH/Z4e9uvvuiBNrYggm698VyvZjEFcdoY\n\tzMHx7t4F6zmDOojbYRy7QazFepCiHxrvTaMSTpDQG9qdj+lCkeYht+0ylUoAw3Q0+y\n\t0dIyKK7crkVsA4mMtU+ypZQd3CTJiaHhZJVbg3aAcjtNa9wo5C2geL1TfcZeAeBKDa\n\tw+ISh/KfMeqjxCZg9zKAfqniub80yndLlvI+Rv4iACi/E0TsjHRILbb1DpjfQelTiS\n\t40XoNOXaQiz2A==","In-Reply-To":"<20230515124550.3601128-2-kieran.bingham@ideasonboard.com>","Content-Type":"multipart/alternative;\n\tboundary=\"----=_=-_OpenGroupware_org_NGMime-5772-1686052431.365223-0------\"","X-Forward":"127.0.0.1","Date":"Tue, 06 Jun 2023 12:53:51 +0100","To":"\"Kieran Bingham\" ","MIME-Version":"1.0","Message-ID":"<168c-647f1e80-1-2235d640@253257962>","User-Agent":"SOGoMail 5.8.0","X-Mailman-Approved-At":"Tue, 06 Jun 2023 14:03:27 +0200","Subject":"Re: [libcamera-devel] =?utf-8?q?=5BPATCH_v3_1/5=5D_libcamera=3A_?=\n\t=?utf-8?b?aW50ZXJuYWw6Pz09P3V0Zi04P3E/IHJlcXVlc3Q6IGNvbnZlcnQgdG8g?=\n\t=?utf-8?q?pragma_once?=","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Ashok Sidipotu via libcamera-devel\n\t","Reply-To":"Ashok Sidipotu ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27287,"web_url":"https://patchwork.libcamera.org/comment/27287/","msgid":"<20230606155606.GC25679@pendragon.ideasonboard.com>","date":"2023-06-06T15:56:06","subject":"Re: [libcamera-devel] [PATCH v3 1/5] libcamera: internal: request:\n\tconvert to pragma once","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, May 15, 2023 at 01:45:46PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Remove the verbose #ifndef/#define/#endif pattern for maintaining\n> header idempotency, and replace it with a simple #pragma once.\n> \n> This simplifies the headers, and prevents redundant changes when\n> header files get moved.\n> \n> The internal/request.h was missed at the time of the original\n> conversion. Update it.\n> \n> Fixes: df131ad08893 (\"libcamera: internal: Convert to pragma once\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/request.h | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\n> index 8c92a27a95e5..3454cf5a72f5 100644\n> --- a/include/libcamera/internal/request.h\n> +++ b/include/libcamera/internal/request.h\n> @@ -4,8 +4,8 @@\n> *\n> * request.h - Request class private data\n> */\n> -#ifndef __LIBCAMERA_INTERNAL_REQUEST_H__\n> -#define __LIBCAMERA_INTERNAL_REQUEST_H__\n> +\n> +#pragma once\n> \n> #include \n> #include \n> @@ -62,5 +62,3 @@ private:\n> };\n> \n> } /* namespace libcamera */\n> -\n> -#endif /* __LIBCAMERA_INTERNAL_REQUEST_H__ */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD233C3200\n\tfor ;\n\tTue, 6 Jun 2023 15:56:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BE7A62722;\n\tTue, 6 Jun 2023 17:56:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C26B262709\n\tfor ;\n\tTue, 6 Jun 2023 17:56:09 +0200 (CEST)","from pendragon.ideasonboard.com (om126253223039.31.openmobile.ne.jp\n\t[126.253.223.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55064AB;\n\tTue, 6 Jun 2023 17:55:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686066971;\n\tbh=SLg3AQQLWkcOPlLyqrVwxBuyAm4TpQ67oWe3OUYnMfA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nmbxTMuhqWZPA61amfBkLc9aADW2a0tGYcYEKiSusf0FvrHgB7SyWF3Rd8Lk+a2hh\n\taHVXri369E/nnzI1apBOrE7oR+DkVNjDUW1TsAtEi7AmQJy8Tke5seKAHJ6gYp1g97\n\t+W8r2AcNY1OHNTRqIuAUM/7MKR3ucuJwVzXg5iz+DEatIQTmsKHT3q4cPZME/iebWJ\n\tpUzHOS+WTcHpX4n8mO5Oi7klaZeSfeBvA5Q99oDJ0cAWOeziuEXtbcz1bROKDrWbqi\n\tf/0Jo6v8tTGyXq4tq1DGI5PTJ8tmmOvwWS4rmH6h1rhscUfd2YYKuqVQZuL9QASKMP\n\teJBy6v+BFTz2Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686066944;\n\tbh=SLg3AQQLWkcOPlLyqrVwxBuyAm4TpQ67oWe3OUYnMfA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pEKbpmfI6irEsTSDqq/MWIngY5eQFNzcwrlbYdZCCjqaYU9mZU2era0mW2fcLvNQC\n\ty5gaGMsKDkpg5LvLbg+SCMovBl2Eklg5B9d335IwNS78F8ZtmknyVaqBR8ZingywtF\n\tOg+KgyKsRhyiu4K6LkE69XjfU2e49RvOTHtw0V2Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pEKbpmfI\"; dkim-atps=neutral","Date":"Tue, 6 Jun 2023 18:56:06 +0300","To":"Kieran Bingham ","Message-ID":"<20230606155606.GC25679@pendragon.ideasonboard.com>","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230515124550.3601128-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/5] libcamera: internal: request:\n\tconvert to pragma once","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27354,"web_url":"https://patchwork.libcamera.org/comment/27354/","msgid":"","date":"2023-06-15T11:33:18","subject":"Re: [libcamera-devel] [PATCH v3 1/5] libcamera: internal: request:\n\tconvert to pragma once","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Mon, May 15, 2023 at 01:45:46PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Remove the verbose #ifndef/#define/#endif pattern for maintaining\n> header idempotency, and replace it with a simple #pragma once.\n>\n> This simplifies the headers, and prevents redundant changes when\n> header files get moved.\n>\n> The internal/request.h was missed at the time of the original\n> conversion. Update it.\n>\n> Fixes: df131ad08893 (\"libcamera: internal: Convert to pragma once\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> include/libcamera/internal/request.h | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n>\n> diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\n> index 8c92a27a95e5..3454cf5a72f5 100644\n> --- a/include/libcamera/internal/request.h\n> +++ b/include/libcamera/internal/request.h\n> @@ -4,8 +4,8 @@\n> *\n> * request.h - Request class private data\n> */\n> -#ifndef __LIBCAMERA_INTERNAL_REQUEST_H__\n> -#define __LIBCAMERA_INTERNAL_REQUEST_H__\n> +\n> +#pragma once\n>\n> #include \n> #include \n> @@ -62,5 +62,3 @@ private:\n> };\n>\n> } /* namespace libcamera */\n> -\n> -#endif /* __LIBCAMERA_INTERNAL_REQUEST_H__ */\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3A63C322E\n\tfor ;\n\tThu, 15 Jun 2023 11:33:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F06E628B5;\n\tThu, 15 Jun 2023 13:33:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80B9A614FE\n\tfor ;\n\tThu, 15 Jun 2023 13:33:21 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:72c3:346:a663:c82d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E70A5891;\n\tThu, 15 Jun 2023 13:32:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686828803;\n\tbh=jlFqj2w3KCKfKY4oCXeFytP9OPzy9IP0j149Ha5+nVc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vifhD6dgrYY+ftJxka5hpzmFpNXrrEz64HHyR0SeprEVeOnMmlByYDsHNJpYMkF9v\n\tqtDRmWGbFAKEg1IpPTWuPItXFcxxpuaMA1mW8s2Nfa+9jMhmsH5W9uSXDzYOxqUonR\n\tk7uzKx7oi6/3jLp8pS0fJhUJFyX9KLhxu5FRYMgPoPSB84t1EekWwGkPkD6td6o4ax\n\tAXi4RAUWpJdpStkBZW57dJxk5esCU8y91/0scFOu1ejanHN5z3HL1OfLH5bX0+b0Sb\n\tvJ1bD9/8ERY2plA0FlCnm3Gtgo8X36EVI6rIuQBJsasw7kvcIDDaRR4cR90/fh/rCZ\n\tsRiqOGYRAoGPg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1686828770;\n\tbh=jlFqj2w3KCKfKY4oCXeFytP9OPzy9IP0j149Ha5+nVc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=myVQvo7t0Asz33qSwFdYb9wYAEGGCA07QHqT3eWtbr6Lr5PKNJKAEhhI+a4xLqvVv\n\tjZZDIDvSv9Tw6KGgdD7Xb6h0HAcaotUPx8cen+e044bFeBtpFgkLflnXNJ8QsAM+Ew\n\tP2ItZnMpEdnXST5uPNnuvzhF4S6KSeJyucvEg3L4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"myVQvo7t\"; dkim-atps=neutral","Date":"Thu, 15 Jun 2023 13:33:18 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20230515124550.3601128-1-kieran.bingham@ideasonboard.com>\n\t<20230515124550.3601128-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230515124550.3601128-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/5] libcamera: internal: request:\n\tconvert to pragma once","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]