[{"id":27087,"web_url":"https://patchwork.libcamera.org/comment/27087/","msgid":"<20230513150307.jx76lf3aygo5x3zn@lati>","date":"2023-05-13T15:03:07","subject":"Re: [libcamera-devel] [PATCH v2 3/4] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Thu, May 11, 2023 at 11:58:32PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Provide a new Camera property that allows pipeline handlers to list any\n> devices used to operate the device. This allows other frameworks and\n> daemons such as Pipewire to better understand the resources consumed by\n> a Camera and consider ignoring those resources when enumerating camera\n> devices on a system.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/property_ids.yaml | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n>\n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index cb55e0ed2283..4fed8f862efb 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -690,6 +690,14 @@ controls:\n> that is twice that of the full resolution mode. This value will be valid\n> after the configure method has returned successfully.\n>\n> +\n\nAdditional blank line ?\n\nWith this fixed:\nReviewed-by: Jacopo Mondi \n\n\n> + - Devices:\n> + type: int64_t\n> + size: [n]\n> + description: |\n> + A list of integer values of type dev_t denoting major and minor device\n> + number of the underlying devices used in the operation of this camera.\n> +\n> # ----------------------------------------------------------------------------\n> # Draft properties section\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A108BD16B\n\tfor ;\n\tSat, 13 May 2023 15:03:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 035B9627DE;\n\tSat, 13 May 2023 17:03:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 643A360539\n\tfor ;\n\tSat, 13 May 2023 17:03:10 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CEA4F6CA;\n\tSat, 13 May 2023 17:03:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683990192;\n\tbh=UjsBsRNtqDoqqf6VXsAVIfsZEVbBRvah0xmjsrAzgOk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yZDGjl9de+th4P+nM/46PY3gEDdiX+hTskpz4jgYdPD0j4TrqMS9jqL0XX7M6ADsj\n\t+qRdKriZaxhYBCb4+QQARnYObzr4QBrGZrernCCeWE7U7E9MpWpcgMnb+azZLpInuw\n\tJezkrkwbCL6fIMSY0RZay4lSInD507ZPfDY9ddgW8thOcDA+yVuuTpqw428qWpKgWq\n\tDyYMFkOIp3hYqoxb/SytCU169PBSY6SRSs+tr13OZXlhLu6v3QlNFUSxvk8tO1jmzP\n\truA7dA63XfPkuNpQmVuAhkRGzcSrdfcaEtGL9T6dndgahegXvXo9wT29pLRXLKfmXX\n\tp/k1m+YrDqk6w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683990181;\n\tbh=UjsBsRNtqDoqqf6VXsAVIfsZEVbBRvah0xmjsrAzgOk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lsjUYb5fRebNLQuJAT28NKmRYXSe1vXXeiw6tUQIpVPwHnCoj184UB0/RCDPqMnWL\n\tXBAcZxwiAO9Pqb2PjSwOuaKPyFtGeuxkMf1QiUiPpdgC8C8OOFH8q9mAp17YnuqU5Z\n\tXmvx5X5F8OBbPM972mWDTzvlWU4yItSDskP7XvDo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lsjUYb5f\"; dkim-atps=neutral","Date":"Sat, 13 May 2023 17:03:07 +0200","To":"Kieran Bingham ","Message-ID":"<20230513150307.jx76lf3aygo5x3zn@lati>","References":"<20230511225833.361699-1-kieran.bingham@ideasonboard.com>\n\t<20230511225833.361699-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230511225833.361699-4-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"George Kiagiadakis ,\n\tlibcamera devel ,\n\tRobert Mader ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27091,"web_url":"https://patchwork.libcamera.org/comment/27091/","msgid":"<168399232359.1830511.5220095098106502517@Monstersaurus>","date":"2023-05-13T15:38:43","subject":"Re: [libcamera-devel] [PATCH v2 3/4] libcamera: properties: Provide\n\ta Devices camera property","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2023-05-13 16:03:07)\n> Hi Kieran\n> \n> On Thu, May 11, 2023 at 11:58:32PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > Provide a new Camera property that allows pipeline handlers to list any\n> > devices used to operate the device. This allows other frameworks and\n> > daemons such as Pipewire to better understand the resources consumed by\n> > a Camera and consider ignoring those resources when enumerating camera\n> > devices on a system.\n> >\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/property_ids.yaml | 8 ++++++++\n> > 1 file changed, 8 insertions(+)\n> >\n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index cb55e0ed2283..4fed8f862efb 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -690,6 +690,14 @@ controls:\n> > that is twice that of the full resolution mode. This value will be valid\n> > after the configure method has returned successfully.\n> >\n> > +\n> \n> Additional blank line ?\n\nHa, I thought that was intentional when I looked at this before I sent,\nbut indeed the others are separated by single lines so this is excess.\n\nWill remove.\n\n\n> \n> With this fixed:\n> Reviewed-by: Jacopo Mondi \n> \n> \n> > + - Devices:\n> > + type: int64_t\n> > + size: [n]\n> > + description: |\n> > + A list of integer values of type dev_t denoting major and minor device\n> > + number of the underlying devices used in the operation of this camera.\n> > +\n> > # ----------------------------------------------------------------------------\n> > # Draft properties section\n> >\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96226BE08B\n\tfor ;\n\tSat, 13 May 2023 15:38:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33FAA633B5;\n\tSat, 13 May 2023 17:38:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0FB2627DE\n\tfor ;\n\tSat, 13 May 2023 17:38:46 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BE6D6CA;\n\tSat, 13 May 2023 17:38:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683992328;\n\tbh=xNqc1XBRUyIZSE2UWob8Y1LscnYJPVM9EQY2WKLEQYg=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bcNq37ewUOeX6uT5ARwFLYVnoHLi4+I02dIcUGUoRZCj7BzNvsDczS1LwBMUh1WNh\n\tLRNPUL/aAEdcvZNd5vm9kyb32sL5gcP54jD4prTf/zQoodJysaUguDKyph2lQ+TV0p\n\t7WR8rdkaYkUyQ/1zJLu74gYaFmYXyfAefJjSUdQRQdqxHJsf59zGAA6QVIXwVI4BPO\n\tARuIRarkhtRjylAN35L4jQsAgKzgOMk9e1cGwuvNxmiwr75ZYLM0cKy8uTnnbgrrig\n\t2ZMfdyAog42AJE8hLpemqQiSPHS62BKt1wAD5ntxy/r5v5CWxY9cR1zDriDLHx8TIJ\n\tGyGV1vAphYoTA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683992317;\n\tbh=xNqc1XBRUyIZSE2UWob8Y1LscnYJPVM9EQY2WKLEQYg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=uKpyCHiGNw2+SHIoLJOBcme7nlBMnRBnFUchQZUOQWO5qbNJxtlAmihrFQ114wHmC\n\tJ2hZrp2KeQx3+Ug/n9PbWjEZ+EvSrdo9s0084bsCpVCDcwRtjK1YGtQ69kjEtwvk9w\n\tVYyI+NkVuBqdPgvIplbGZQd96J8UAfQRCCGCUgYM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uKpyCHiG\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230513150307.jx76lf3aygo5x3zn@lati>","References":"<20230511225833.361699-1-kieran.bingham@ideasonboard.com>\n\t<20230511225833.361699-4-kieran.bingham@ideasonboard.com>\n\t<20230513150307.jx76lf3aygo5x3zn@lati>","To":"Jacopo Mondi ","Date":"Sat, 13 May 2023 16:38:43 +0100","Message-ID":"<168399232359.1830511.5220095098106502517@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] libcamera: properties: Provide\n\ta Devices camera property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"George Kiagiadakis ,\n\tlibcamera devel ,\n\tRobert Mader ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]