[{"id":27085,"web_url":"https://patchwork.libcamera.org/comment/27085/","msgid":"<20230513143813.reth4smraiixsde3@lati>","date":"2023-05-13T14:45:07","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: camera_manager:\n\tMove private implementation to internal","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Thu, May 11, 2023 at 11:58:30PM +0100, Kieran Bingham via libcamera-devel wrote:\n> The CameraManager makes use of the Extensible pattern to provide an\n> internal private implementation that is not exposed in the public API.\n>\n> Move the Private declaration to an internal header to make it available\n> from other internal components in preperation for reducing the surface\n> area of the public interface of the Camera Manager.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/internal/camera_manager.h | 66 +++++++++++++++++++++\n> include/libcamera/internal/meson.build | 1 +\n> src/libcamera/camera_manager.cpp | 49 ++-------------\n> 3 files changed, 71 insertions(+), 45 deletions(-)\n> create mode 100644 include/libcamera/internal/camera_manager.h\n>\n> diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\n> new file mode 100644\n> index 000000000000..4bba3ac2eb29\n> --- /dev/null\n> +++ b/include/libcamera/internal/camera_manager.h\n> @@ -0,0 +1,66 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2023, Ideas on Board Oy.\n> + *\n> + * camera_manager.h - Camera manager private data\n> + */\n> +#ifndef __LIBCAMERA_INTERNAL_CAMERA_MANAGER_H__\n> +#define __LIBCAMERA_INTERNAL_CAMERA_MANAGER_H__\n\n#pragma once ?\n\n> +\n> +#include \n> +\n> +#include \n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/ipa_manager.h\"\n> +#include \"libcamera/internal/process.h\"\n> +\n> +namespace libcamera {\n> +\n> +class DeviceEnumerator;\n> +\n> +class CameraManager::Private : public Extensible::Private, public Thread\n> +{\n> +\tLIBCAMERA_DECLARE_PUBLIC(CameraManager)\n> +\n> +public:\n> +\tPrivate();\n> +\n> +\tint start();\n> +\tvoid addCamera(std::shared_ptr camera,\n> +\t\t const std::vector &devnums) LIBCAMERA_TSA_EXCLUDES(mutex_);\n> +\tvoid removeCamera(Camera *camera) LIBCAMERA_TSA_EXCLUDES(mutex_);\n> +\n> +\t/*\n> +\t * This mutex protects\n> +\t *\n> +\t * - initialized_ and status_ during initialization\n> +\t * - cameras_ and camerasByDevnum_ after initialization\n> +\t */\n> +\tmutable Mutex mutex_;\n> +\tstd::vector> cameras_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> +\tstd::map> camerasByDevnum_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> +\n> +protected:\n> +\tvoid run() override;\n> +\n> +private:\n> +\tint init();\n> +\tvoid createPipelineHandlers();\n> +\tvoid cleanup() LIBCAMERA_TSA_EXCLUDES(mutex_);\n> +\n> +\tConditionVariable cv_;\n> +\tbool initialized_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> +\tint status_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> +\n> +\tstd::unique_ptr enumerator_;\n> +\n> +\tIPAManager ipaManager_;\n> +\tProcessManager processManager_;\n> +};\n> +\n> +} /* namespace libcamera */\n> +\n> +#endif // __LIBCAMERA_INTERNAL_CAMERA_MANAGER_H__\n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index d75088059996..0028ed0dc27f 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -13,6 +13,7 @@ libcamera_internal_headers = files([\n> 'bayer_format.h',\n> 'byte_stream_buffer.h',\n> 'camera.h',\n> + 'camera_manager.h',\n> 'camera_controls.h',\n> 'camera_lens.h',\n> 'camera_sensor.h',\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index c1edefdad160..b95284ba5a80 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -9,20 +9,19 @@\n>\n> #include \n>\n> -#include \n> -\n> #include \n> #include \n> #include \n> #include \n>\n> +#include \n> +\n> +#include \"libcamera/internal/camera_manager.h\"\n\nI would include this one first to make sure it is self-contained\n\n> #include \"libcamera/internal/device_enumerator.h\"\n> -#include \"libcamera/internal/ipa_manager.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> -#include \"libcamera/internal/process.h\"\n>\n> /**\n> - * \\file camera_manager.h\n> + * \\file libcamera/camera_manager.h\n\nis this needed ?\n\nAll minors:\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n\n> * \\brief The camera manager\n> */\n>\n> @@ -33,46 +32,6 @@ namespace libcamera {\n>\n> LOG_DEFINE_CATEGORY(Camera)\n>\n> -class CameraManager::Private : public Extensible::Private, public Thread\n> -{\n> -\tLIBCAMERA_DECLARE_PUBLIC(CameraManager)\n> -\n> -public:\n> -\tPrivate();\n> -\n> -\tint start();\n> -\tvoid addCamera(std::shared_ptr camera,\n> -\t\t const std::vector &devnums) LIBCAMERA_TSA_EXCLUDES(mutex_);\n> -\tvoid removeCamera(Camera *camera) LIBCAMERA_TSA_EXCLUDES(mutex_);\n> -\n> -\t/*\n> -\t * This mutex protects\n> -\t *\n> -\t * - initialized_ and status_ during initialization\n> -\t * - cameras_ and camerasByDevnum_ after initialization\n> -\t */\n> -\tmutable Mutex mutex_;\n> -\tstd::vector> cameras_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> -\tstd::map> camerasByDevnum_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> -\n> -protected:\n> -\tvoid run() override;\n> -\n> -private:\n> -\tint init();\n> -\tvoid createPipelineHandlers();\n> -\tvoid cleanup() LIBCAMERA_TSA_EXCLUDES(mutex_);\n> -\n> -\tConditionVariable cv_;\n> -\tbool initialized_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> -\tint status_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> -\n> -\tstd::unique_ptr enumerator_;\n> -\n> -\tIPAManager ipaManager_;\n> -\tProcessManager processManager_;\n> -};\n> -\n> CameraManager::Private::Private()\n> \t: initialized_(false)\n> {\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3879EBD16B\n\tfor ;\n\tSat, 13 May 2023 14:45:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82335633B4;\n\tSat, 13 May 2023 16:45:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4E6860539\n\tfor ;\n\tSat, 13 May 2023 16:45:15 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 330B67F8;\n\tSat, 13 May 2023 16:45:06 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683989117;\n\tbh=WSnFH8PJNTR2AYM3BRDU1qO0ZVGSoNPolmE4UNrtcpQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZSApEHCJS6VcxaDkrgkReAlD23sW8nw5M62LDtI96G0+BGG3dEkyCSH5VVikzj5CL\n\tH7Cb09czF3CKHiGZ0ZMW7qZqb26CvFXV4ks2LZNsWT4GZTADy5ZEb/37qJdFnkuB+n\n\tdnRynMN37N7U0r3aJoTo3W8eDP0D9V4mFMJHrd1gz/qrRyIBbOsO+khiypr+L652BZ\n\ttwJUKPE6V//nOPcu1jnPd6PNwJJB8+ApNM6qaHRVdMEgF51qM04msWq7Gr5lxYWuNZ\n\tcVk1HqXkU/34DrZmWU2+NnTIxErJAgxqsHLkQsC7DsdVUv7RfoFX+GJycDPW3T7BcN\n\tP7wlVlQ7aU3Fw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683989106;\n\tbh=WSnFH8PJNTR2AYM3BRDU1qO0ZVGSoNPolmE4UNrtcpQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ulHAxznDvU2DE1K2c4/mluV9gnXVyBY3qEyUR/vqAMd7+LJg3Qqbv/rEIUQ9HJLxO\n\tCdBBHWGHm9OAPjyHtQadoTg3/v0evPYpfGn81BTd02H/rAhcTHB2Cr7olGkEXrlCtG\n\tvviH5yZV57HLXsxrsuwANyMKxuJfgmjICabhGNT0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ulHAxznD\"; dkim-atps=neutral","Date":"Sat, 13 May 2023 16:45:07 +0200","To":"Kieran Bingham ","Message-ID":"<20230513143813.reth4smraiixsde3@lati>","References":"<20230511225833.361699-1-kieran.bingham@ideasonboard.com>\n\t<20230511225833.361699-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230511225833.361699-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: camera_manager:\n\tMove private implementation to internal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"George Kiagiadakis ,\n\tlibcamera devel ,\n\tRobert Mader ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27089,"web_url":"https://patchwork.libcamera.org/comment/27089/","msgid":"<168399212412.1830511.16837234823903470670@Monstersaurus>","date":"2023-05-13T15:35:24","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: camera_manager:\n\tMove private implementation to internal","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2023-05-13 15:45:07)\n> Hi Kieran\n> \n> On Thu, May 11, 2023 at 11:58:30PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > The CameraManager makes use of the Extensible pattern to provide an\n> > internal private implementation that is not exposed in the public API.\n> >\n> > Move the Private declaration to an internal header to make it available\n> > from other internal components in preperation for reducing the surface\n> > area of the public interface of the Camera Manager.\n> >\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > include/libcamera/internal/camera_manager.h | 66 +++++++++++++++++++++\n> > include/libcamera/internal/meson.build | 1 +\n> > src/libcamera/camera_manager.cpp | 49 ++-------------\n> > 3 files changed, 71 insertions(+), 45 deletions(-)\n> > create mode 100644 include/libcamera/internal/camera_manager.h\n> >\n> > diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\n> > new file mode 100644\n> > index 000000000000..4bba3ac2eb29\n> > --- /dev/null\n> > +++ b/include/libcamera/internal/camera_manager.h\n> > @@ -0,0 +1,66 @@\n> > +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> > +/*\n> > + * Copyright (C) 2023, Ideas on Board Oy.\n> > + *\n> > + * camera_manager.h - Camera manager private data\n> > + */\n> > +#ifndef __LIBCAMERA_INTERNAL_CAMERA_MANAGER_H__\n> > +#define __LIBCAMERA_INTERNAL_CAMERA_MANAGER_H__\n> \n> #pragma once ?\n\n Yes :-) Not sure how I missed that.\n\n> \n> > +\n> > +#include \n> > +\n> > +#include \n> > +#include \n> > +\n> > +#include \n> > +\n> > +#include \"libcamera/internal/ipa_manager.h\"\n> > +#include \"libcamera/internal/process.h\"\n> > +\n> > +namespace libcamera {\n> > +\n> > +class DeviceEnumerator;\n> > +\n> > +class CameraManager::Private : public Extensible::Private, public Thread\n> > +{\n> > + LIBCAMERA_DECLARE_PUBLIC(CameraManager)\n> > +\n> > +public:\n> > + Private();\n> > +\n> > + int start();\n> > + void addCamera(std::shared_ptr camera,\n> > + const std::vector &devnums) LIBCAMERA_TSA_EXCLUDES(mutex_);\n> > + void removeCamera(Camera *camera) LIBCAMERA_TSA_EXCLUDES(mutex_);\n> > +\n> > + /*\n> > + * This mutex protects\n> > + *\n> > + * - initialized_ and status_ during initialization\n> > + * - cameras_ and camerasByDevnum_ after initialization\n> > + */\n> > + mutable Mutex mutex_;\n> > + std::vector> cameras_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> > + std::map> camerasByDevnum_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> > +\n> > +protected:\n> > + void run() override;\n> > +\n> > +private:\n> > + int init();\n> > + void createPipelineHandlers();\n> > + void cleanup() LIBCAMERA_TSA_EXCLUDES(mutex_);\n> > +\n> > + ConditionVariable cv_;\n> > + bool initialized_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> > + int status_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> > +\n> > + std::unique_ptr enumerator_;\n> > +\n> > + IPAManager ipaManager_;\n> > + ProcessManager processManager_;\n> > +};\n> > +\n> > +} /* namespace libcamera */\n> > +\n> > +#endif // __LIBCAMERA_INTERNAL_CAMERA_MANAGER_H__\n> > diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> > index d75088059996..0028ed0dc27f 100644\n> > --- a/include/libcamera/internal/meson.build\n> > +++ b/include/libcamera/internal/meson.build\n> > @@ -13,6 +13,7 @@ libcamera_internal_headers = files([\n> > 'bayer_format.h',\n> > 'byte_stream_buffer.h',\n> > 'camera.h',\n> > + 'camera_manager.h',\n> > 'camera_controls.h',\n> > 'camera_lens.h',\n> > 'camera_sensor.h',\n> > diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> > index c1edefdad160..b95284ba5a80 100644\n> > --- a/src/libcamera/camera_manager.cpp\n> > +++ b/src/libcamera/camera_manager.cpp\n> > @@ -9,20 +9,19 @@\n> >\n> > #include \n> >\n> > -#include \n> > -\n> > #include \n> > #include \n> > #include \n> > #include \n> >\n> > +#include \n> > +\n> > +#include \"libcamera/internal/camera_manager.h\"\n> \n> I would include this one first to make sure it is self-contained\n\nHrm ... the public one already is. I guess it makes sense to have both\nup at the top?\n\n\n> \n> > #include \"libcamera/internal/device_enumerator.h\"\n> > -#include \"libcamera/internal/ipa_manager.h\"\n> > #include \"libcamera/internal/pipeline_handler.h\"\n> > -#include \"libcamera/internal/pruocess.h\"\n> >\n> > /**\n> > - * \\file camera_manager.h\n> > + * \\file libcamera/camera_manager.h\n> \n> is this needed ?\n\nYes, otherwise doxygen complains.\n\n> \n> All minors:\n> Reviewed-by: Jacopo Mondi \n\nThanks\n\n\n> \n> Thanks\n> j\n> \n> \n> > * \\brief The camera manager\n> > */\n> >\n> > @@ -33,46 +32,6 @@ namespace libcamera {\n> >\n> > LOG_DEFINE_CATEGORY(Camera)\n> >\n> > -class CameraManager::Private : public Extensible::Private, public Thread\n> > -{\n> > - LIBCAMERA_DECLARE_PUBLIC(CameraManager)\n> > -\n> > -public:\n> > - Private();\n> > -\n> > - int start();\n> > - void addCamera(std::shared_ptr camera,\n> > - const std::vector &devnums) LIBCAMERA_TSA_EXCLUDES(mutex_);\n> > - void removeCamera(Camera *camera) LIBCAMERA_TSA_EXCLUDES(mutex_);\n> > -\n> > - /*\n> > - * This mutex protects\n> > - *\n> > - * - initialized_ and status_ during initialization\n> > - * - cameras_ and camerasByDevnum_ after initialization\n> > - */\n> > - mutable Mutex mutex_;\n> > - std::vector> cameras_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> > - std::map> camerasByDevnum_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> > -\n> > -protected:\n> > - void run() override;\n> > -\n> > -private:\n> > - int init();\n> > - void createPipelineHandlers();\n> > - void cleanup() LIBCAMERA_TSA_EXCLUDES(mutex_);\n> > -\n> > - ConditionVariable cv_;\n> > - bool initialized_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> > - int status_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> > -\n> > - std::unique_ptr enumerator_;\n> > -\n> > - IPAManager ipaManager_;\n> > - ProcessManager processManager_;\n> > -};\n> > -\n> > CameraManager::Private::Private()\n> > : initialized_(false)\n> > {\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8F58BD16B\n\tfor ;\n\tSat, 13 May 2023 15:35:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 324C8633B4;\n\tSat, 13 May 2023 17:35:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DD4260539\n\tfor ;\n\tSat, 13 May 2023 17:35:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E307D6CA;\n\tSat, 13 May 2023 17:35:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683992129;\n\tbh=44x85JEnOcGPZrc7ZBV5iPzFcm0XhT63TCc17OYrAB8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3OaWheS540Vg7PzxgbBltXsf0IbWSUnKEG83GUVVNwwOPhXAnG88Dql7j9yVKm1+v\n\ta6/bJkVTWboUS4YZmmSkfg49O7dToebbIIDpUyZkIR45ak1ST3+otB0bt4QDP7CxXR\n\twa83gKGkQdKw7gLF2n57vOnm+zRc1zzW0AQY4r8nLQ3AUKNZwAKmKEFsRRKUnvpgfB\n\tUxb3Q+GSb75h7eeejkduH4194ynfU3r3jN4baySDt1vu21iTPDSWhUCurffPZeo5ds\n\tx5DpvQeF1y5rk+fcr0j25JHdq5sfIpmhOUmjekekAqWRoSo6Fqs5QXOcC43Ynmfgmy\n\t6rbCDIaYTRF6g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683992118;\n\tbh=44x85JEnOcGPZrc7ZBV5iPzFcm0XhT63TCc17OYrAB8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=SzmFH2eBUVEs0yX/wB0OwoHa+KSZNaAja9AdPxKwKiNr2wk4GLcEZzCq4Q7gDXF+c\n\tSit3jqfgMlbKlXjBKjYrenDi6wL2PFiHlLTvql/iCh8uigNaRSB2F5I++SNkuMfv3a\n\t0pTjwvIwfEbDF83UsutsGRupcTdVZMoQXSrMW+8U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SzmFH2eB\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230513143813.reth4smraiixsde3@lati>","References":"<20230511225833.361699-1-kieran.bingham@ideasonboard.com>\n\t<20230511225833.361699-2-kieran.bingham@ideasonboard.com>\n\t<20230513143813.reth4smraiixsde3@lati>","To":"Jacopo Mondi ","Date":"Sat, 13 May 2023 16:35:24 +0100","Message-ID":"<168399212412.1830511.16837234823903470670@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: camera_manager:\n\tMove private implementation to internal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"George Kiagiadakis ,\n\tlibcamera devel ,\n\tRobert Mader ,\n\tWim Taymans ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]