[{"id":27066,"web_url":"https://patchwork.libcamera.org/comment/27066/","msgid":"<20230508140716.GX23514@pendragon.ideasonboard.com>","date":"2023-05-08T14:07:16","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Allow IPA\n\tloading in nested subdirs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, May 08, 2023 at 03:45:01PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Now that we allow IPA modules to live in nested directories for the\n> RaspberryPi platform, it is required to allow parsing one more level\n> to be able to run libcamera from the source directory.\n> \n> Without this patch the $(builddir)/src/ipa/rpi/vc4/ipa_rpi_vc4.so\n> IPA module cannot be loaded.\n> \n> The issue is only present when running from the source directory\n> as when libcamera is installed all IPA modules are deployed to a single\n> $(prefix)/$(libcamera_libdir)/libamera/ location.\n\nGood catch. With the right Fixes: tag,\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/ipa_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 030ef43fb994..ac5397003b50 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -138,7 +138,7 @@ IPAManager::IPAManager()\n> \tstd::string root = utils::libcameraBuildPath();\n> \tif (!root.empty()) {\n> \t\tstd::string ipaBuildPath = root + \"src/ipa\";\n> -\t\tconstexpr int maxDepth = 1;\n> +\t\tconstexpr int maxDepth = 2;\n> \n> \t\tLOG(IPAManager, Info)\n> \t\t\t<< \"libcamera is not installed. Adding '\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA028C0DA4\n\tfor ;\n\tMon, 8 May 2023 14:07:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AA25633B4;\n\tMon, 8 May 2023 16:07:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F6056053A\n\tfor ;\n\tMon, 8 May 2023 16:07:04 +0200 (CEST)","from pendragon.ideasonboard.com (softbank126090219015.bbtec.net\n\t[126.90.219.15])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A56B6755;\n\tMon, 8 May 2023 16:06:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683554825;\n\tbh=0khTB0mqI7KrRh3hYd6XuzWnfRm0rXIWD3kNW/2TXGE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=h76R2o45FetOk+1HNA32hW2fFXsW5BvUGwWfTNPMX20eZ98w0pVBx+0lGu41DT2m1\n\txX47mrr4vcEkyi3/m9g8GD2p1vFonveAeZBPoqRP76jZ4t0JOjcrWzNxNm20EXDr+c\n\tbdRXUg13AyKR/I3F52L3q44JEB2Q8vaRP13jaqCRI7UVwDq7Y7Re/uUI4HAa1J1XQl\n\t69KY7aP9Dx0XiPpnK3w0CUdn7KdT05vJQYijofJt/rzDhtpJ05I2OFrarjbCrUXeEO\n\tPBnZqGypyK+nqZ3/PVPTm9lAhdqHon67DBM2JRzV531DzRLsWzrHlzM7suG83qJ3hm\n\tP/ueqBJxdtBkQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683554818;\n\tbh=0khTB0mqI7KrRh3hYd6XuzWnfRm0rXIWD3kNW/2TXGE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vqjA5YwdKobd9dR+OdOaKeo/4QsD828PgJexn28jEtWZ0htWw4jeSfLQpIojz4iuV\n\tJ08htOdRFgpABXtPFQQ95PUE/Waoerh+K65F6DHYItkvlK0ItcbCxzCN/FrDEPHiSO\n\tJ1fSk6K7OjvrycvkhlaJNP6bMFuTcaCuTTGuDGgQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vqjA5Ywd\"; dkim-atps=neutral","Date":"Mon, 8 May 2023 17:07:16 +0300","To":"Jacopo Mondi ","Message-ID":"<20230508140716.GX23514@pendragon.ideasonboard.com>","References":"<20230508134501.23802-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230508134501.23802-1-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Allow IPA\n\tloading in nested subdirs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27068,"web_url":"https://patchwork.libcamera.org/comment/27068/","msgid":"","date":"2023-05-08T16:19:10","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Allow IPA\n\tloading in nested subdirs","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi\n\nOn 5/8/23 7:37 PM, Laurent Pinchart via libcamera-devel wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Mon, May 08, 2023 at 03:45:01PM +0200, Jacopo Mondi via libcamera-devel wrote:\n>> Now that we allow IPA modules to live in nested directories for the\n>> RaspberryPi platform, it is required to allow parsing one more level\n>> to be able to run libcamera from the source directory.\n>>\n>> Without this patch the $(builddir)/src/ipa/rpi/vc4/ipa_rpi_vc4.so\n>> IPA module cannot be loaded.\n>>\n>> The issue is only present when running from the source directory\n>> as when libcamera is installed all IPA modules are deployed to a single\n>> $(prefix)/$(libcamera_libdir)/libamera/ location.\n> Good catch. With the right Fixes: tag,\n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n>\n>> Signed-off-by: Jacopo Mondi \n>> ---\n>> src/libcamera/ipa_manager.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n>> index 030ef43fb994..ac5397003b50 100644\n>> --- a/src/libcamera/ipa_manager.cpp\n>> +++ b/src/libcamera/ipa_manager.cpp\n>> @@ -138,7 +138,7 @@ IPAManager::IPAManager()\n>> \tstd::string root = utils::libcameraBuildPath();\n>> \tif (!root.empty()) {\n>> \t\tstd::string ipaBuildPath = root + \"src/ipa\";\n>> -\t\tconstexpr int maxDepth = 1;\n>> +\t\tconstexpr int maxDepth = 2;\n>>\n>> \t\tLOG(IPAManager, Info)\n>> \t\t\t<< \"libcamera is not installed. Adding '\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54D9CBE08B\n\tfor ;\n\tMon, 8 May 2023 16:19:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C205F633B4;\n\tMon, 8 May 2023 18:19:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 502DC6053A\n\tfor ;\n\tMon, 8 May 2023 18:19:17 +0200 (CEST)","from [192.168.1.105] (unknown [103.251.226.10])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5ADF27CE;\n\tMon, 8 May 2023 18:19:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683562758;\n\tbh=KmOtxmClh4/NcAOaknvzFwiLinEghGrBc8HU8RqXM4A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=c4GnkhizpNpRy3UhfsCc9FMPoq1jxyj3yx3k2FSGVUQ9gEvZjNTHUh1eBy5xCmWm6\n\tLClgYRnxsoboaECp2c6kgQ40X5XLK7fn0BgYK2d7SKCYC2L2h8w8gjjCT2kcnzomTl\n\tyTxWKAYRzk87tsnApVYidcOBzCZi2pGqOoZOzZXseDNYpNUQMSER14bvRB8AZRkW1h\n\tsni7JSUBxgCWxfm7pFJwqljoUAsr1gvS9j8KiTvmr0l/58i4V15HKtihb3hxjexqDB\n\tTG5SPP4LIsAChSyMRaZJlaTUT1oh4Nk5zPbssEYoJpKJpzSFTTYOw/0XwUw4dYnXW+\n\tT/j8FIwh62FGQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683562751;\n\tbh=KmOtxmClh4/NcAOaknvzFwiLinEghGrBc8HU8RqXM4A=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=qbDdOGR7rght6SoKSrGD6W+awcuBY+OcilXsW+pBwnMF9AaJdr/1Dra3x5B7azIqy\n\tAxjjFM+Gn2YuHArlse8RbeUu48w55cl+GjEfs2Rb9qksSxSAmw8ReQjDZL6NnHdbux\n\t2wwtHUCSujHrQ4BGJIIaDsAbeTDygpt/ZboL9/2I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qbDdOGR7\"; dkim-atps=neutral","Message-ID":"","Date":"Mon, 8 May 2023 21:49:10 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","To":"Laurent Pinchart ,\n\tJacopo Mondi ","References":"<20230508134501.23802-1-jacopo.mondi@ideasonboard.com>\n\t<20230508140716.GX23514@pendragon.ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20230508140716.GX23514@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Allow IPA\n\tloading in nested subdirs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]