[{"id":27051,"web_url":"https://patchwork.libcamera.org/comment/27051/","msgid":"<20230504150425.GK4551@pendragon.ideasonboard.com>","date":"2023-05-04T15:04:25","subject":"Re: [libcamera-devel] [PATCH v2 2/2] v4l2: Move the v4l2 compat\n\tlayer to libexec/libcamera","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, May 04, 2023 at 03:48:01PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Move the v4l2-compat.so shared library installation to the libcamera\n> directory under libexec. This is the same location that the proxy\n> workers live and will facilitate easier packaging of the V4L2\n> compatibiltiy layer with distributions.\n\ns/compatibiltiy/compatibility/\n\n> Create a new libcamera_libexecdir variable within meson to simplify\n> representation of this path and update the proxy worker meson.build\n> infrastructure to make use of it as well.\n> \n> Signed-off-by: Kieran Bingham \n\nLooks good !\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/proxy/worker/meson.build | 2 +-\n> src/meson.build | 1 +\n> src/v4l2/meson.build | 3 ++-\n> 3 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/proxy/worker/meson.build b/src/libcamera/proxy/worker/meson.build\n> index 70c8760a3d42..aa4d9cd7b5d8 100644\n> --- a/src/libcamera/proxy/worker/meson.build\n> +++ b/src/libcamera/proxy/worker/meson.build\n> @@ -1,6 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -proxy_install_dir = get_option('libexecdir') / 'libcamera'\n> +proxy_install_dir = libcamera_libexecdir\n> \n> # generate {pipeline}_ipa_proxy_worker.cpp\n> foreach mojom : ipa_mojoms\n> diff --git a/src/meson.build b/src/meson.build\n> index a3821fb90a0f..165a77bb9d53 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -3,6 +3,7 @@\n> # Cache system paths\n> libcamera_datadir = get_option('datadir') / 'libcamera'\n> libcamera_libdir = get_option('libdir') / 'libcamera'\n> +libcamera_libexecdir = get_option('libexecdir') / 'libcamera'\n> libcamera_sysconfdir = get_option('sysconfdir') / 'libcamera'\n> \n> config_h.set('LIBCAMERA_DATA_DIR', '\"' + get_option('prefix') / libcamera_datadir + '\"')\n> diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n> index f132103cb503..ab4b35dd0e6b 100644\n> --- a/src/v4l2/meson.build\n> +++ b/src/v4l2/meson.build\n> @@ -31,6 +31,7 @@ v4l2_compat = shared_library('v4l2-compat',\n> v4l2_compat_sources,\n> name_prefix : '',\n> install : true,\n> + install_dir : libcamera_libexecdir,\n> dependencies : [libcamera_private, libdl],\n> cpp_args : v4l2_compat_cpp_args)\n> \n> @@ -38,7 +39,7 @@ v4l2_compat = shared_library('v4l2-compat',\n> # adaptation layer.\n> \n> cdata = configuration_data()\n> -cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / get_option('libdir') / 'v4l2-compat.so')\n> +cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / libcamera_libexecdir / 'v4l2-compat.so')\n> \n> configure_file(input : 'libcamerify.in',\n> output : 'libcamerify',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49AD7BD16B\n\tfor ;\n\tThu, 4 May 2023 15:04:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0DA3627DE;\n\tThu, 4 May 2023 17:04:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 619A661EAE\n\tfor ;\n\tThu, 4 May 2023 17:04:16 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 043976E0;\n\tThu, 4 May 2023 17:04:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683212657;\n\tbh=aXaElG6lk039kUi2u4BjFDbkYg/wtXkwhaOuuWgSRvU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=iS5XsFnBDJIvA0kToPuDbYh/iBs0PStEidQoux0zaqBELwN4rnFsGVeD+eV85HfA3\n\tC63C9T3rnLYki3zTdrXVPNphkeUQnDwDeh19h4LbOwwNFaxqoj/gdFxnfIscdRAuMf\n\tsdEb90Hs8a6EJZXMJgMIrn7SJxi5buyvBp3erD71LrEeekOy7umS5CsyDyoy5fvR6T\n\tdhmR8Cy+dXqDAXjwENAckq8zDqZ0uFrOdM6grgul4REkeqmdcUlYG0Wpm9YmT44Wd3\n\t6MRrRqq7ATBrWumcRXXD89v8JQFhLBmJ2chGk3CUR2vHmzEYkRBqjPWEZ2MA65K6Tg\n\toyKOyDsl0EMWg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683212652;\n\tbh=aXaElG6lk039kUi2u4BjFDbkYg/wtXkwhaOuuWgSRvU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vz3E9HJPns4cgR0VAAmcr7mdHnloOaZ1S4u0kZf3wmqG5HIShF8RwWt1Z7KFOVZWO\n\tNdRu7cHO54cGv0BDf4yBB6Op7VwmhK/k2RVAvIzpwhFmZPj8YUHfgcSVZQDJvcHfuJ\n\tl4Y2tIo3ZtD2GyNsTTnHDcgQjAOBpHm4nTBq/QqM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vz3E9HJP\"; dkim-atps=neutral","Date":"Thu, 4 May 2023 18:04:25 +0300","To":"Kieran Bingham ","Message-ID":"<20230504150425.GK4551@pendragon.ideasonboard.com>","References":"<20230504144801.2590668-1-kieran.bingham@ideasonboard.com>\n\t<20230504144801.2590668-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230504144801.2590668-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] v4l2: Move the v4l2 compat\n\tlayer to libexec/libcamera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27054,"web_url":"https://patchwork.libcamera.org/comment/27054/","msgid":"<87jzxow1gg.fsf@minerva.mail-host-address-is-not-set>","date":"2023-05-04T15:39:11","subject":"Re: [libcamera-devel] [PATCH v2 2/2] v4l2: Move the v4l2 compat\n\tlayer to libexec/libcamera","submitter":{"id":95,"url":"https://patchwork.libcamera.org/api/people/95/","name":"Javier Martinez Canillas","email":"javierm@redhat.com"},"content":"Kieran Bingham writes:\n\nHello Kieran,\n\n> Move the v4l2-compat.so shared library installation to the libcamera\n> directory under libexec. This is the same location that the proxy\n> workers live and will facilitate easier packaging of the V4L2\n> compatibiltiy layer with distributions.\n>\n> Create a new libcamera_libexecdir variable within meson to simplify\n> representation of this path and update the proxy worker meson.build\n> infrastructure to make use of it as well.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n\nThanks a lot for your patch!\n\nReviewed-by: Javier Martinez Canillas ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D44E1BD16B\n\tfor ;\n\tThu, 4 May 2023 15:39:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93936627DE;\n\tThu, 4 May 2023 17:39:18 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC62461EAE\n\tfor ;\n\tThu, 4 May 2023 17:39:16 +0200 (CEST)","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-621-u6Wgze6-OVao45RLEkrIcg-1; Thu, 04 May 2023 11:39:14 -0400","by mail-wr1-f72.google.com with SMTP id\n\tffacd0b85a97d-2f479aeddc4so355555f8f.2\n\tfor ;\n\tThu, 04 May 2023 08:39:14 -0700 (PDT)","from localhost (205.pool92-176-231.dynamic.orange.es.\n\t[92.176.231.205]) by smtp.gmail.com with ESMTPSA id\n\tm6-20020a5d6246000000b002feea065cc9sm37175348wrv.111.2023.05.04.08.39.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 May 2023 08:39:12 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683214758;\n\tbh=pKIWjds8ujoAe4R93uA6nBA1T1B2m+qiC5hSa6zxhpk=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=lYJeWgjXBuMdqa5pWIrMPOzmPWj8G9iOzTn20SiBpLX+N6oH2CpfPOmR4v8fJA4lf\n\tlBU+1HPPxoV8+QfHhyt5GU5cbpeUJ5u0fGwME9AwzwLs9cVPfELfDtgJ9XBeEU7wqW\n\tsS3Uz30RDVRzybGbVMG0z07hpJTfDJUtbZo55rFlFkqwTl3z+3aIjGR0zBVlF1ZdQ8\n\tPE0C998IabLmHz7PBuoxQ1BdxG/Kx497zS86f00pYQUZWlafsxUxeYhJHdt40kSYPM\n\tndl3PJVU4k56jgl+o5SwiTx+2zBEVqUA9VbV7VWgR3g07U+xLxTRWiTWTx6QHeiVrQ\n\tp9V9shft+zTRg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1683214755;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=9+HaGI+sd55kp0YZHLRw/J2ZzY55GmzUbkEAezqLf/E=;\n\tb=FF47YbWJZ6t319XLvvWkVeXgU2zUMLH4+Umaf+GnxEJxddjuFoZea4DiJyBjweE+crbgV8\n\t3l6vPKwC81Ug6NvC3VRu91oHTJVZUdCo5xXzhDIlHzGvROyRgq8+jrLw1I06rJf59mbiZy\n\tHYV/kzkelKXBr4FfbeLDQP5zRvK7JdQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"FF47YbWJ\"; \n\tdkim-atps=neutral","X-MC-Unique":"u6Wgze6-OVao45RLEkrIcg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1683214753; x=1685806753;\n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; \n\tbh=9+HaGI+sd55kp0YZHLRw/J2ZzY55GmzUbkEAezqLf/E=;\n\tb=h+GwmoBD7Es/aDg80lnJd/m+PQTI8eAu/4RxQU/YYGsGbO2rNJNi0nb11ETs07758k\n\tVxDvljjzGs3DdqQkwkdLLUgY3Qd+b8yRsB61TbD/rhsB84NJPYV8boPz4gLET0nXSVuw\n\tKpjz9+US0+lKqU1rA5SO5GgPYx7oVn1NFyGx+bpY/OCz/lAcEfIyb5M6d723ixLB+A8J\n\tmqm2eA6rCFqHgAeTtwL5gy4fj93BIHN+e9X44KBy/jtRzEX3wjTKKThiP0jB3FMmDGlA\n\tA4x1U+Z+mfNKUIrHOaQNCl4HNRdUL9LLfnjpulPXwsVUIYwdOTnUYl60Q2EUwIFrWWD3\n\tZW1Q==","X-Gm-Message-State":"AC+VfDxuqccEUG2jlCThNuIZt+U62DBXz054ryvR8KvCwuaBvWaUOEPl\n\tgr6Ee/aqo9MyjOLgX409XvFRg9j4CQaIB+RyJudTDNKSGYzkzWkOb2RCGTzE1ca/XxiDS5hpxB7\n\tYKk+tNG5RcZnPzT1N1wM1XbAGBL612D22i1q6Fz62HA==","X-Received":["by 2002:adf:f346:0:b0:304:79c1:725d with SMTP id\n\te6-20020adff346000000b0030479c1725dmr3208258wrp.45.1683214752879; \n\tThu, 04 May 2023 08:39:12 -0700 (PDT)","by 2002:adf:f346:0:b0:304:79c1:725d with SMTP id\n\te6-20020adff346000000b0030479c1725dmr3208246wrp.45.1683214752535; \n\tThu, 04 May 2023 08:39:12 -0700 (PDT)"],"X-Google-Smtp-Source":"ACHHUZ4VkEaXDFCBcWBAdB3dBwAh0q7xZrhZLpq+IBD9sMlM3ecNwqHXH65ZwreMhbGRgCehxRKFuQ==","To":"Kieran Bingham , libcamera devel\n\t","In-Reply-To":"<20230504144801.2590668-3-kieran.bingham@ideasonboard.com>","References":"<20230504144801.2590668-1-kieran.bingham@ideasonboard.com>\n\t<20230504144801.2590668-3-kieran.bingham@ideasonboard.com>","Date":"Thu, 04 May 2023 17:39:11 +0200","Message-ID":"<87jzxow1gg.fsf@minerva.mail-host-address-is-not-set>","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] v4l2: Move the v4l2 compat\n\tlayer to libexec/libcamera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Javier Martinez Canillas via libcamera-devel\n\t","Reply-To":"Javier Martinez Canillas ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]