{"id":18602,"url":"https://patchwork.libcamera.org/api/patches/18602/?format=json","web_url":"https://patchwork.libcamera.org/patch/18602/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230504144801.2590668-2-kieran.bingham@ideasonboard.com>","date":"2023-05-04T14:48:00","name":"[libcamera-devel,v2,1/2] libcamera: ipa_manager: Only parse IPA modules","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"a4126355a381e8edadee3ee89caca1776fd7f6c6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18602/mbox/","series":[{"id":3865,"url":"https://patchwork.libcamera.org/api/series/3865/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3865","date":"2023-05-04T14:47:59","name":"V4L2 Compatibility installation directory","version":2,"mbox":"https://patchwork.libcamera.org/series/3865/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18602/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18602/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EA08C327C\n\tfor ;\n\tThu, 4 May 2023 14:48:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A855633B5;\n\tThu, 4 May 2023 16:48:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AFDB627DE\n\tfor ;\n\tThu, 4 May 2023 16:48:07 +0200 (CEST)","from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0EF27CE;\n\tThu, 4 May 2023 16:48:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683211689;\n\tbh=l7vYOSDfk2w3/NkfqAVHXW3cFN465DX/rZaoY2+qhew=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VueOaUDlI60zpUZQ1x/pokdec4b7/XseoMegX58lmJMw/Tg3sw4aKdXGPBfr0EC6h\n\t1GIa15FvXUMxVEO5IUQfQUzaWhuQwcqARbkOC4hvigWXHdmtsXK6BdwDixEoxrVCbQ\n\tpGt4tNJqwi3J181nQoduY3VdCixDexf7CRQQk1nIRPoc1joOl9x+IOUw9+4Co5b468\n\tvAX4BxU+w8vvGnAKUxyvi6+TMbsSUEy/FG8REeE6CukaDQXJQonIYg4md+m77oYu9p\n\t0H3s32cuygVvLN1e8kt3l/PeNYMucNlL+rWj3AI8c/Rv64yeGcKDpKGFgxTlw1LWZK\n\tCdmgeM8sG43gQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683211683;\n\tbh=l7vYOSDfk2w3/NkfqAVHXW3cFN465DX/rZaoY2+qhew=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YevsyqP4yefnFaDVsx7zme37BT6UuNJF41DnTKV7DAVxnBB6lYrF0NgFTblm688LD\n\t0jOJdobGdLNnCJxMpyV1F2OQJiw5C1+PwLROdLtlkXdG9qQLFuu9560s3Lx7OJF6mw\n\tEk9g0sKIG0JGhcLvrKFb/NSMyJv3Q3qcdBOx+K7g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YevsyqP4\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Thu, 4 May 2023 15:48:00 +0100","Message-Id":"<20230504144801.2590668-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230504144801.2590668-1-kieran.bingham@ideasonboard.com>","References":"<20230504144801.2590668-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/2] libcamera: ipa_manager: Only parse\n\tIPA modules","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Ensure that when we iterate the libcamera libdir we only select shared\nobjects which are expected to be IPA modules, with an ipa_ prefix.\n\nAny shared object not matching this filter is ignored and not processed\nby the IPA Manager.\n\nReviewed-by: Javier Martinez Canillas \nSigned-off-by: Kieran Bingham \n---\n src/libcamera/ipa_manager.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 030ef43fb994..c0c2f027e902 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -206,6 +206,10 @@ void IPAManager::parseDir(const char *libDir, unsigned int maxDepth,\n \t\tif (strcmp(&ent->d_name[offset], \".so\"))\n \t\t\tcontinue;\n \n+\t\t/* Ignore any modules which are not IPAs. */\n+\t\tif (strncmp(ent->d_name, \"ipa_\", 4) != 0)\n+\t\t\tcontinue;\n+\n \t\tfiles.push_back(std::string(libDir) + \"/\" + ent->d_name);\n \t}\n \n","prefixes":["libcamera-devel","v2","1/2"]}