[{"id":27059,"web_url":"https://patchwork.libcamera.org/comment/27059/","msgid":"<20230504163328.GP4551@pendragon.ideasonboard.com>","date":"2023-05-04T16:33:28","subject":"Re: [libcamera-devel] [PATCH 06/13] ipa: raspberrypi: Refactor and\n\tmove IPA code","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, May 03, 2023 at 01:20:28PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Split the Raspberry Pi IPA code into common and VC4/BCM2835 specific\n> file structures.\n> \n> The common code files now live in src/ipa/rpi/{cam_helper,controller}/\n> and the vc4 specific files in src/ipa/rpi/vc4/.\n\ns/vc4 specific/vc4-specific/\n\n> To build the IPA, the meson configuration option to select\n> the Raspberry Pi IPA has now changed from \"raspberrypi\" to\n> \"rpi/vc4\":\n> \n> meson setup build --Dipas=rpi/vc4\n> \n> With this change, the camera tuning files are now installed under\n> share/libcamera/ipa/rpi/vc4/\n> \n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> ---\n>  Documentation/environment_variables.rst       |  2 +-\n>  meson_options.txt                             |  2 +-\n>  src/ipa/raspberrypi/meson.build               | 68 -------------------\n>  src/ipa/{raspberrypi => rpi}/README.md        |  0\n>  .../cam_helper}/cam_helper.cpp                |  0\n>  .../cam_helper}/cam_helper.h                  |  2 +-\n>  .../cam_helper}/cam_helper_imx219.cpp         |  0\n>  .../cam_helper}/cam_helper_imx290.cpp         |  0\n>  .../cam_helper}/cam_helper_imx296.cpp         |  0\n>  .../cam_helper}/cam_helper_imx477.cpp         |  0\n>  .../cam_helper}/cam_helper_imx519.cpp         |  0\n>  .../cam_helper}/cam_helper_imx708.cpp         |  0\n>  .../cam_helper}/cam_helper_ov5647.cpp         |  0\n>  .../cam_helper}/cam_helper_ov9281.cpp         |  0\n>  .../cam_helper}/md_parser.h                   |  0\n>  .../cam_helper}/md_parser_smia.cpp            |  0\n>  src/ipa/rpi/cam_helper/meson.build            | 26 +++++++\n>  .../controller/af_algorithm.h                 |  0\n>  .../controller/af_status.h                    |  0\n>  .../controller/agc_algorithm.h                |  0\n>  .../controller/agc_status.h                   |  0\n>  .../controller/algorithm.cpp                  |  0\n>  .../controller/algorithm.h                    |  0\n>  .../controller/alsc_status.h                  |  0\n>  .../controller/awb_algorithm.h                |  0\n>  .../controller/awb_status.h                   |  0\n>  .../controller/black_level_status.h           |  0\n>  .../controller/camera_mode.h                  |  0\n>  .../controller/ccm_algorithm.h                |  0\n>  .../controller/ccm_status.h                   |  0\n>  .../controller/contrast_algorithm.h           |  0\n>  .../controller/contrast_status.h              |  0\n>  .../controller/controller.cpp                 |  0\n>  .../controller/controller.h                   |  0\n>  .../controller/denoise_algorithm.h            |  0\n>  .../controller/denoise_status.h               |  0\n>  .../controller/device_status.cpp              |  0\n>  .../controller/device_status.h                |  0\n>  .../controller/dpc_status.h                   |  0\n>  .../controller/geq_status.h                   |  0\n>  .../controller/histogram.cpp                  |  0\n>  .../controller/histogram.h                    |  0\n>  .../controller/lux_status.h                   |  0\n>  src/ipa/rpi/controller/meson.build            | 29 ++++++++\n>  .../controller/metadata.h                     |  0\n>  .../controller/noise_status.h                 |  0\n>  .../controller/pdaf_data.h                    |  0\n>  .../{raspberrypi => rpi}/controller/pwl.cpp   |  0\n>  src/ipa/{raspberrypi => rpi}/controller/pwl.h |  0\n>  .../controller/region_stats.h                 |  0\n>  .../controller/rpi/af.cpp                     |  0\n>  .../{raspberrypi => rpi}/controller/rpi/af.h  |  0\n>  .../controller/rpi/agc.cpp                    |  0\n>  .../{raspberrypi => rpi}/controller/rpi/agc.h |  0\n>  .../controller/rpi/alsc.cpp                   |  0\n>  .../controller/rpi/alsc.h                     |  0\n>  .../controller/rpi/awb.cpp                    |  0\n>  .../{raspberrypi => rpi}/controller/rpi/awb.h |  0\n>  .../controller/rpi/black_level.cpp            |  0\n>  .../controller/rpi/black_level.h              |  0\n>  .../controller/rpi/ccm.cpp                    |  0\n>  .../{raspberrypi => rpi}/controller/rpi/ccm.h |  0\n>  .../controller/rpi/contrast.cpp               |  0\n>  .../controller/rpi/contrast.h                 |  0\n>  .../controller/rpi/dpc.cpp                    |  0\n>  .../{raspberrypi => rpi}/controller/rpi/dpc.h |  0\n>  .../controller/rpi/focus.h                    |  0\n>  .../controller/rpi/geq.cpp                    |  0\n>  .../{raspberrypi => rpi}/controller/rpi/geq.h |  0\n>  .../controller/rpi/lux.cpp                    |  0\n>  .../{raspberrypi => rpi}/controller/rpi/lux.h |  0\n>  .../controller/rpi/noise.cpp                  |  0\n>  .../controller/rpi/noise.h                    |  0\n>  .../controller/rpi/sdn.cpp                    |  0\n>  .../{raspberrypi => rpi}/controller/rpi/sdn.h |  0\n>  .../controller/rpi/sharpen.cpp                |  0\n>  .../controller/rpi/sharpen.h                  |  0\n>  .../controller/sharpen_algorithm.h            |  0\n>  .../controller/sharpen_status.h               |  0\n>  .../controller}/statistics.h                  |  0\n>  src/ipa/rpi/meson.build                       | 13 ++++\n>  .../{raspberrypi => rpi/vc4}/data/imx219.json |  0\n>  .../vc4}/data/imx219_noir.json                |  0\n>  .../{raspberrypi => rpi/vc4}/data/imx290.json |  0\n>  .../{raspberrypi => rpi/vc4}/data/imx296.json |  0\n>  .../vc4}/data/imx296_mono.json                |  0\n>  .../{raspberrypi => rpi/vc4}/data/imx378.json |  0\n>  .../{raspberrypi => rpi/vc4}/data/imx477.json |  0\n>  .../vc4}/data/imx477_noir.json                |  0\n>  .../vc4}/data/imx477_scientific.json          |  0\n>  .../vc4}/data/imx477_v1.json                  |  0\n>  .../{raspberrypi => rpi/vc4}/data/imx519.json |  0\n>  .../{raspberrypi => rpi/vc4}/data/imx708.json |  0\n>  .../vc4}/data/imx708_noir.json                |  0\n>  .../vc4}/data/imx708_wide.json                |  0\n>  .../vc4}/data/imx708_wide_noir.json           |  0\n>  .../{raspberrypi => rpi/vc4}/data/meson.build |  2 +-\n>  .../{raspberrypi => rpi/vc4}/data/ov5647.json |  0\n>  .../vc4}/data/ov5647_noir.json                |  0\n>  .../vc4}/data/ov9281_mono.json                |  0\n>  .../vc4}/data/se327m12.json                   |  0\n>  .../vc4}/data/uncalibrated.json               |  0\n>  src/ipa/rpi/vc4/meson.build                   | 48 +++++++++++++\n>  .../{raspberrypi => rpi/vc4}/raspberrypi.cpp  | 48 ++++++-------\n>  104 files changed, 144 insertions(+), 96 deletions(-)\n>  delete mode 100644 src/ipa/raspberrypi/meson.build\n>  rename src/ipa/{raspberrypi => rpi}/README.md (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper.h (99%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx219.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx290.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx296.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx477.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx519.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_imx708.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov5647.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/cam_helper_ov9281.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser.h (100%)\n>  rename src/ipa/{raspberrypi => rpi/cam_helper}/md_parser_smia.cpp (100%)\n>  create mode 100644 src/ipa/rpi/cam_helper/meson.build\n>  rename src/ipa/{raspberrypi => rpi}/controller/af_algorithm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/af_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/agc_algorithm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/agc_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/algorithm.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/algorithm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/alsc_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/awb_algorithm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/awb_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/black_level_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/camera_mode.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/ccm_algorithm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/ccm_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/contrast_algorithm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/contrast_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/controller.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/controller.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/denoise_algorithm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/denoise_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/device_status.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/device_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/dpc_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/geq_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/histogram.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/histogram.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/lux_status.h (100%)\n>  create mode 100644 src/ipa/rpi/controller/meson.build\n>  rename src/ipa/{raspberrypi => rpi}/controller/metadata.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/noise_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/pdaf_data.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/pwl.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/pwl.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/region_stats.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/af.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/agc.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/alsc.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/awb.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/black_level.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/ccm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/contrast.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/dpc.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/focus.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/geq.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/lux.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/noise.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/sdn.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.cpp (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/rpi/sharpen.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/sharpen_algorithm.h (100%)\n>  rename src/ipa/{raspberrypi => rpi}/controller/sharpen_status.h (100%)\n>  rename src/ipa/{raspberrypi => rpi/controller}/statistics.h (100%)\n>  create mode 100644 src/ipa/rpi/meson.build\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx219_noir.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx290.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx296_mono.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx378.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_noir.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_scientific.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx477_v1.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx519.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_noir.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/imx708_wide_noir.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/meson.build (89%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/ov5647_noir.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/ov9281_mono.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/se327m12.json (100%)\n>  rename src/ipa/{raspberrypi => rpi/vc4}/data/uncalibrated.json (100%)\n>  create mode 100644 src/ipa/rpi/vc4/meson.build\n>  rename src/ipa/{raspberrypi => rpi/vc4}/raspberrypi.cpp (98%)\n\nYou're missing a s@raspberrypi@rpi/vc4@ rename in .reuse/dep5.\n\n> \n> diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst\n> index 4bf38b877897..a9b230bcd93e 100644\n> --- a/Documentation/environment_variables.rst\n> +++ b/Documentation/environment_variables.rst\n> @@ -143,7 +143,7 @@ contain tuning parameters for the algorithms, in JSON format.\n>  The ``LIBCAMERA_IPA_CONFIG_PATH`` variable can be used to specify custom\n>  storage locations to search for those configuration files.\n>  \n> -`Examples <https://git.libcamera.org/libcamera/libcamera.git/tree/src/ipa/raspberrypi/data>`__\n> +`Examples <https://git.libcamera.org/libcamera/libcamera.git/tree/src/ipa/rpi/vc4/data>`__\n>  \n>  IPA module\n>  ~~~~~~~~~~\n> diff --git a/meson_options.txt b/meson_options.txt\n> index b4afb8e591a8..c8cd53b49ba1 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -27,7 +27,7 @@ option('gstreamer',\n>  \n>  option('ipas',\n>          type : 'array',\n> -        choices : ['ipu3', 'raspberrypi', 'rkisp1', 'vimc'],\n> +        choices : ['ipu3', 'rkisp1', 'rpi/vc4', 'vimc'],\n>          description : 'Select which IPA modules to build')\n>  \n>  option('lc-compliance',\n> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\n> deleted file mode 100644\n> index 95437cbcc962..000000000000\n> --- a/src/ipa/raspberrypi/meson.build\n> +++ /dev/null\n> @@ -1,68 +0,0 @@\n> -# SPDX-License-Identifier: CC0-1.0\n> -\n> -ipa_name = 'ipa_rpi'\n> -\n> -rpi_ipa_deps = [\n> -    libcamera_private,\n> -    libatomic,\n> -]\n> -\n> -rpi_ipa_includes = [\n> -    ipa_includes,\n> -    libipa_includes,\n> -    include_directories('controller')\n> -]\n> -\n> -rpi_ipa_sources = files([\n> -    'raspberrypi.cpp',\n> -    'md_parser_smia.cpp',\n> -    'cam_helper.cpp',\n> -    'cam_helper_ov5647.cpp',\n> -    'cam_helper_imx219.cpp',\n> -    'cam_helper_imx290.cpp',\n> -    'cam_helper_imx296.cpp',\n> -    'cam_helper_imx477.cpp',\n> -    'cam_helper_imx519.cpp',\n> -    'cam_helper_imx708.cpp',\n> -    'cam_helper_ov9281.cpp',\n> -    'controller/controller.cpp',\n> -    'controller/histogram.cpp',\n> -    'controller/algorithm.cpp',\n> -    'controller/rpi/af.cpp',\n> -    'controller/rpi/alsc.cpp',\n> -    'controller/rpi/awb.cpp',\n> -    'controller/rpi/sharpen.cpp',\n> -    'controller/rpi/black_level.cpp',\n> -    'controller/rpi/geq.cpp',\n> -    'controller/rpi/noise.cpp',\n> -    'controller/rpi/lux.cpp',\n> -    'controller/rpi/agc.cpp',\n> -    'controller/rpi/dpc.cpp',\n> -    'controller/rpi/ccm.cpp',\n> -    'controller/rpi/contrast.cpp',\n> -    'controller/rpi/sdn.cpp',\n> -    'controller/pwl.cpp',\n> -    'controller/device_status.cpp',\n> -])\n> -\n> -mod = shared_module(ipa_name,\n> -                    [rpi_ipa_sources, libcamera_generated_ipa_headers],\n> -                    name_prefix : '',\n> -                    include_directories : rpi_ipa_includes,\n> -                    dependencies : rpi_ipa_deps,\n> -                    link_with : libipa,\n> -                    install : true,\n> -                    install_dir : ipa_install_dir)\n> -\n> -if ipa_sign_module\n> -    custom_target(ipa_name + '.so.sign',\n> -                  input : mod,\n> -                  output : ipa_name + '.so.sign',\n> -                  command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> -                  install : false,\n> -                  build_by_default : true)\n> -endif\n> -\n> -subdir('data')\n> -\n> -ipa_names += ipa_name\n> diff --git a/src/ipa/raspberrypi/README.md b/src/ipa/rpi/README.md\n> similarity index 100%\n> rename from src/ipa/raspberrypi/README.md\n> rename to src/ipa/rpi/README.md\n> diff --git a/src/ipa/raspberrypi/cam_helper.cpp b/src/ipa/rpi/cam_helper/cam_helper.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper.cpp\n> diff --git a/src/ipa/raspberrypi/cam_helper.h b/src/ipa/rpi/cam_helper/cam_helper.h\n> similarity index 99%\n> rename from src/ipa/raspberrypi/cam_helper.h\n> rename to src/ipa/rpi/cam_helper/cam_helper.h\n> index b3f8c9803094..58a4b202d5a8 100644\n> --- a/src/ipa/raspberrypi/cam_helper.h\n> +++ b/src/ipa/rpi/cam_helper/cam_helper.h\n> @@ -13,7 +13,7 @@\n>  #include <libcamera/base/span.h>\n>  #include <libcamera/base/utils.h>\n>  \n> -#include \"camera_mode.h\"\n> +#include \"controller/camera_mode.h\"\n>  #include \"controller/controller.h\"\n>  #include \"controller/metadata.h\"\n>  #include \"md_parser.h\"\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx219.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx219.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper_imx219.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper_imx219.cpp\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper_imx290.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx296.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx296.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper_imx296.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper_imx296.cpp\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper_imx477.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper_imx477.cpp\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx519.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx519.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper_imx519.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper_imx519.cpp\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper_imx708.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> diff --git a/src/ipa/raspberrypi/cam_helper_ov5647.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov5647.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper_ov5647.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper_ov5647.cpp\n> diff --git a/src/ipa/raspberrypi/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/cam_helper_ov9281.cpp\n> rename to src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> diff --git a/src/ipa/raspberrypi/md_parser.h b/src/ipa/rpi/cam_helper/md_parser.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/md_parser.h\n> rename to src/ipa/rpi/cam_helper/md_parser.h\n> diff --git a/src/ipa/raspberrypi/md_parser_smia.cpp b/src/ipa/rpi/cam_helper/md_parser_smia.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/md_parser_smia.cpp\n> rename to src/ipa/rpi/cam_helper/md_parser_smia.cpp\n> diff --git a/src/ipa/rpi/cam_helper/meson.build b/src/ipa/rpi/cam_helper/meson.build\n> new file mode 100644\n> index 000000000000..bdf2db8eb742\n> --- /dev/null\n> +++ b/src/ipa/rpi/cam_helper/meson.build\n> @@ -0,0 +1,26 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +rpi_ipa_cam_helper_sources = files([\n> +    'cam_helper.cpp',\n> +    'cam_helper_ov5647.cpp',\n> +    'cam_helper_imx219.cpp',\n> +    'cam_helper_imx290.cpp',\n> +    'cam_helper_imx296.cpp',\n> +    'cam_helper_imx477.cpp',\n> +    'cam_helper_imx519.cpp',\n> +    'cam_helper_imx708.cpp',\n> +    'cam_helper_ov9281.cpp',\n> +    'md_parser_smia.cpp',\n> +])\n> +\n> +rpi_ipa_cam_helper_includes = [\n> +    include_directories('..'),\n> +]\n> +\n> +rpi_ipa_cam_helper_deps = [\n> +    libcamera_private,\n> +]\n> +\n> +rpi_ipa_cam_helper_lib = static_library('rpi_ipa_cam_helper', rpi_ipa_cam_helper_sources,\n> +                                        include_directories : rpi_ipa_cam_helper_includes,\n> +                                        dependencies : rpi_ipa_cam_helper_deps)\n> diff --git a/src/ipa/raspberrypi/controller/af_algorithm.h b/src/ipa/rpi/controller/af_algorithm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/af_algorithm.h\n> rename to src/ipa/rpi/controller/af_algorithm.h\n> diff --git a/src/ipa/raspberrypi/controller/af_status.h b/src/ipa/rpi/controller/af_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/af_status.h\n> rename to src/ipa/rpi/controller/af_status.h\n> diff --git a/src/ipa/raspberrypi/controller/agc_algorithm.h b/src/ipa/rpi/controller/agc_algorithm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/agc_algorithm.h\n> rename to src/ipa/rpi/controller/agc_algorithm.h\n> diff --git a/src/ipa/raspberrypi/controller/agc_status.h b/src/ipa/rpi/controller/agc_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/agc_status.h\n> rename to src/ipa/rpi/controller/agc_status.h\n> diff --git a/src/ipa/raspberrypi/controller/algorithm.cpp b/src/ipa/rpi/controller/algorithm.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/algorithm.cpp\n> rename to src/ipa/rpi/controller/algorithm.cpp\n> diff --git a/src/ipa/raspberrypi/controller/algorithm.h b/src/ipa/rpi/controller/algorithm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/algorithm.h\n> rename to src/ipa/rpi/controller/algorithm.h\n> diff --git a/src/ipa/raspberrypi/controller/alsc_status.h b/src/ipa/rpi/controller/alsc_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/alsc_status.h\n> rename to src/ipa/rpi/controller/alsc_status.h\n> diff --git a/src/ipa/raspberrypi/controller/awb_algorithm.h b/src/ipa/rpi/controller/awb_algorithm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/awb_algorithm.h\n> rename to src/ipa/rpi/controller/awb_algorithm.h\n> diff --git a/src/ipa/raspberrypi/controller/awb_status.h b/src/ipa/rpi/controller/awb_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/awb_status.h\n> rename to src/ipa/rpi/controller/awb_status.h\n> diff --git a/src/ipa/raspberrypi/controller/black_level_status.h b/src/ipa/rpi/controller/black_level_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/black_level_status.h\n> rename to src/ipa/rpi/controller/black_level_status.h\n> diff --git a/src/ipa/raspberrypi/controller/camera_mode.h b/src/ipa/rpi/controller/camera_mode.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/camera_mode.h\n> rename to src/ipa/rpi/controller/camera_mode.h\n> diff --git a/src/ipa/raspberrypi/controller/ccm_algorithm.h b/src/ipa/rpi/controller/ccm_algorithm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/ccm_algorithm.h\n> rename to src/ipa/rpi/controller/ccm_algorithm.h\n> diff --git a/src/ipa/raspberrypi/controller/ccm_status.h b/src/ipa/rpi/controller/ccm_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/ccm_status.h\n> rename to src/ipa/rpi/controller/ccm_status.h\n> diff --git a/src/ipa/raspberrypi/controller/contrast_algorithm.h b/src/ipa/rpi/controller/contrast_algorithm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/contrast_algorithm.h\n> rename to src/ipa/rpi/controller/contrast_algorithm.h\n> diff --git a/src/ipa/raspberrypi/controller/contrast_status.h b/src/ipa/rpi/controller/contrast_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/contrast_status.h\n> rename to src/ipa/rpi/controller/contrast_status.h\n> diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/controller.cpp\n> rename to src/ipa/rpi/controller/controller.cpp\n> diff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/rpi/controller/controller.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/controller.h\n> rename to src/ipa/rpi/controller/controller.h\n> diff --git a/src/ipa/raspberrypi/controller/denoise_algorithm.h b/src/ipa/rpi/controller/denoise_algorithm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/denoise_algorithm.h\n> rename to src/ipa/rpi/controller/denoise_algorithm.h\n> diff --git a/src/ipa/raspberrypi/controller/denoise_status.h b/src/ipa/rpi/controller/denoise_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/denoise_status.h\n> rename to src/ipa/rpi/controller/denoise_status.h\n> diff --git a/src/ipa/raspberrypi/controller/device_status.cpp b/src/ipa/rpi/controller/device_status.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/device_status.cpp\n> rename to src/ipa/rpi/controller/device_status.cpp\n> diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/rpi/controller/device_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/device_status.h\n> rename to src/ipa/rpi/controller/device_status.h\n> diff --git a/src/ipa/raspberrypi/controller/dpc_status.h b/src/ipa/rpi/controller/dpc_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/dpc_status.h\n> rename to src/ipa/rpi/controller/dpc_status.h\n> diff --git a/src/ipa/raspberrypi/controller/geq_status.h b/src/ipa/rpi/controller/geq_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/geq_status.h\n> rename to src/ipa/rpi/controller/geq_status.h\n> diff --git a/src/ipa/raspberrypi/controller/histogram.cpp b/src/ipa/rpi/controller/histogram.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/histogram.cpp\n> rename to src/ipa/rpi/controller/histogram.cpp\n> diff --git a/src/ipa/raspberrypi/controller/histogram.h b/src/ipa/rpi/controller/histogram.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/histogram.h\n> rename to src/ipa/rpi/controller/histogram.h\n> diff --git a/src/ipa/raspberrypi/controller/lux_status.h b/src/ipa/rpi/controller/lux_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/lux_status.h\n> rename to src/ipa/rpi/controller/lux_status.h\n> diff --git a/src/ipa/rpi/controller/meson.build b/src/ipa/rpi/controller/meson.build\n> new file mode 100644\n> index 000000000000..feb0334e8bb4\n> --- /dev/null\n> +++ b/src/ipa/rpi/controller/meson.build\n> @@ -0,0 +1,29 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +rpi_ipa_controller_sources = files([\n> +    'algorithm.cpp',\n> +    'controller.cpp',\n> +    'device_status.cpp',\n> +    'histogram.cpp',\n> +    'pwl.cpp',\n> +    'rpi/af.cpp',\n> +    'rpi/agc.cpp',\n> +    'rpi/alsc.cpp',\n> +    'rpi/awb.cpp',\n> +    'rpi/black_level.cpp',\n> +    'rpi/ccm.cpp',\n> +    'rpi/contrast.cpp',\n> +    'rpi/dpc.cpp',\n> +    'rpi/geq.cpp',\n> +    'rpi/lux.cpp',\n> +    'rpi/noise.cpp',\n> +    'rpi/sdn.cpp',\n> +    'rpi/sharpen.cpp',\n> +])\n> +\n> +rpi_ipa_controller_deps = [\n> +    libcamera_private,\n> +]\n> +\n> +rpi_ipa_controller_lib = static_library('rpi_ipa_controller', rpi_ipa_controller_sources,\n> +                                        dependencies : rpi_ipa_controller_deps)\n> diff --git a/src/ipa/raspberrypi/controller/metadata.h b/src/ipa/rpi/controller/metadata.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/metadata.h\n> rename to src/ipa/rpi/controller/metadata.h\n> diff --git a/src/ipa/raspberrypi/controller/noise_status.h b/src/ipa/rpi/controller/noise_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/noise_status.h\n> rename to src/ipa/rpi/controller/noise_status.h\n> diff --git a/src/ipa/raspberrypi/controller/pdaf_data.h b/src/ipa/rpi/controller/pdaf_data.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/pdaf_data.h\n> rename to src/ipa/rpi/controller/pdaf_data.h\n> diff --git a/src/ipa/raspberrypi/controller/pwl.cpp b/src/ipa/rpi/controller/pwl.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/pwl.cpp\n> rename to src/ipa/rpi/controller/pwl.cpp\n> diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/rpi/controller/pwl.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/pwl.h\n> rename to src/ipa/rpi/controller/pwl.h\n> diff --git a/src/ipa/raspberrypi/controller/region_stats.h b/src/ipa/rpi/controller/region_stats.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/region_stats.h\n> rename to src/ipa/rpi/controller/region_stats.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/af.cpp b/src/ipa/rpi/controller/rpi/af.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/af.cpp\n> rename to src/ipa/rpi/controller/rpi/af.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/af.h b/src/ipa/rpi/controller/rpi/af.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/af.h\n> rename to src/ipa/rpi/controller/rpi/af.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/rpi/controller/rpi/agc.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/agc.cpp\n> rename to src/ipa/rpi/controller/rpi/agc.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.h b/src/ipa/rpi/controller/rpi/agc.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/agc.h\n> rename to src/ipa/rpi/controller/rpi/agc.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/rpi/controller/rpi/alsc.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> rename to src/ipa/rpi/controller/rpi/alsc.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.h b/src/ipa/rpi/controller/rpi/alsc.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/alsc.h\n> rename to src/ipa/rpi/controller/rpi/alsc.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/awb.cpp\n> rename to src/ipa/rpi/controller/rpi/awb.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.h b/src/ipa/rpi/controller/rpi/awb.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/awb.h\n> rename to src/ipa/rpi/controller/rpi/awb.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/black_level.cpp b/src/ipa/rpi/controller/rpi/black_level.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/black_level.cpp\n> rename to src/ipa/rpi/controller/rpi/black_level.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/black_level.h b/src/ipa/rpi/controller/rpi/black_level.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/black_level.h\n> rename to src/ipa/rpi/controller/rpi/black_level.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/ccm.cpp b/src/ipa/rpi/controller/rpi/ccm.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/ccm.cpp\n> rename to src/ipa/rpi/controller/rpi/ccm.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/ccm.h b/src/ipa/rpi/controller/rpi/ccm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/ccm.h\n> rename to src/ipa/rpi/controller/rpi/ccm.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/contrast.cpp b/src/ipa/rpi/controller/rpi/contrast.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/contrast.cpp\n> rename to src/ipa/rpi/controller/rpi/contrast.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/contrast.h b/src/ipa/rpi/controller/rpi/contrast.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/contrast.h\n> rename to src/ipa/rpi/controller/rpi/contrast.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/dpc.cpp b/src/ipa/rpi/controller/rpi/dpc.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/dpc.cpp\n> rename to src/ipa/rpi/controller/rpi/dpc.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/dpc.h b/src/ipa/rpi/controller/rpi/dpc.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/dpc.h\n> rename to src/ipa/rpi/controller/rpi/dpc.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/focus.h b/src/ipa/rpi/controller/rpi/focus.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/focus.h\n> rename to src/ipa/rpi/controller/rpi/focus.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/geq.cpp b/src/ipa/rpi/controller/rpi/geq.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/geq.cpp\n> rename to src/ipa/rpi/controller/rpi/geq.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/geq.h b/src/ipa/rpi/controller/rpi/geq.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/geq.h\n> rename to src/ipa/rpi/controller/rpi/geq.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/lux.cpp b/src/ipa/rpi/controller/rpi/lux.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/lux.cpp\n> rename to src/ipa/rpi/controller/rpi/lux.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/lux.h b/src/ipa/rpi/controller/rpi/lux.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/lux.h\n> rename to src/ipa/rpi/controller/rpi/lux.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/noise.cpp b/src/ipa/rpi/controller/rpi/noise.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/noise.cpp\n> rename to src/ipa/rpi/controller/rpi/noise.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/noise.h b/src/ipa/rpi/controller/rpi/noise.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/noise.h\n> rename to src/ipa/rpi/controller/rpi/noise.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/sdn.cpp b/src/ipa/rpi/controller/rpi/sdn.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> rename to src/ipa/rpi/controller/rpi/sdn.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/sdn.h b/src/ipa/rpi/controller/rpi/sdn.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/sdn.h\n> rename to src/ipa/rpi/controller/rpi/sdn.h\n> diff --git a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp b/src/ipa/rpi/controller/rpi/sharpen.cpp\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n> rename to src/ipa/rpi/controller/rpi/sharpen.cpp\n> diff --git a/src/ipa/raspberrypi/controller/rpi/sharpen.h b/src/ipa/rpi/controller/rpi/sharpen.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/rpi/sharpen.h\n> rename to src/ipa/rpi/controller/rpi/sharpen.h\n> diff --git a/src/ipa/raspberrypi/controller/sharpen_algorithm.h b/src/ipa/rpi/controller/sharpen_algorithm.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/sharpen_algorithm.h\n> rename to src/ipa/rpi/controller/sharpen_algorithm.h\n> diff --git a/src/ipa/raspberrypi/controller/sharpen_status.h b/src/ipa/rpi/controller/sharpen_status.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/controller/sharpen_status.h\n> rename to src/ipa/rpi/controller/sharpen_status.h\n> diff --git a/src/ipa/raspberrypi/statistics.h b/src/ipa/rpi/controller/statistics.h\n> similarity index 100%\n> rename from src/ipa/raspberrypi/statistics.h\n> rename to src/ipa/rpi/controller/statistics.h\n> diff --git a/src/ipa/rpi/meson.build b/src/ipa/rpi/meson.build\n> new file mode 100644\n> index 000000000000..7d7a61f7cea7\n> --- /dev/null\n> +++ b/src/ipa/rpi/meson.build\n> @@ -0,0 +1,13 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +subdir('cam_helper')\n> +subdir('controller')\n> +\n> +foreach pipeline : pipelines\n> +    pipeline = pipeline.split('/')\n> +    if pipeline.length() < 2 or pipeline[0] != 'rpi'\n> +        continue\n> +    endif\n> +\n> +    subdir(pipeline[1])\n> +endforeach\n> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/rpi/vc4/data/imx219.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx219.json\n> rename to src/ipa/rpi/vc4/data/imx219.json\n> diff --git a/src/ipa/raspberrypi/data/imx219_noir.json b/src/ipa/rpi/vc4/data/imx219_noir.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx219_noir.json\n> rename to src/ipa/rpi/vc4/data/imx219_noir.json\n> diff --git a/src/ipa/raspberrypi/data/imx290.json b/src/ipa/rpi/vc4/data/imx290.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx290.json\n> rename to src/ipa/rpi/vc4/data/imx290.json\n> diff --git a/src/ipa/raspberrypi/data/imx296.json b/src/ipa/rpi/vc4/data/imx296.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx296.json\n> rename to src/ipa/rpi/vc4/data/imx296.json\n> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx296_mono.json\n> rename to src/ipa/rpi/vc4/data/imx296_mono.json\n> diff --git a/src/ipa/raspberrypi/data/imx378.json b/src/ipa/rpi/vc4/data/imx378.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx378.json\n> rename to src/ipa/rpi/vc4/data/imx378.json\n> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/rpi/vc4/data/imx477.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx477.json\n> rename to src/ipa/rpi/vc4/data/imx477.json\n> diff --git a/src/ipa/raspberrypi/data/imx477_noir.json b/src/ipa/rpi/vc4/data/imx477_noir.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx477_noir.json\n> rename to src/ipa/rpi/vc4/data/imx477_noir.json\n> diff --git a/src/ipa/raspberrypi/data/imx477_scientific.json b/src/ipa/rpi/vc4/data/imx477_scientific.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx477_scientific.json\n> rename to src/ipa/rpi/vc4/data/imx477_scientific.json\n> diff --git a/src/ipa/raspberrypi/data/imx477_v1.json b/src/ipa/rpi/vc4/data/imx477_v1.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx477_v1.json\n> rename to src/ipa/rpi/vc4/data/imx477_v1.json\n> diff --git a/src/ipa/raspberrypi/data/imx519.json b/src/ipa/rpi/vc4/data/imx519.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx519.json\n> rename to src/ipa/rpi/vc4/data/imx519.json\n> diff --git a/src/ipa/raspberrypi/data/imx708.json b/src/ipa/rpi/vc4/data/imx708.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx708.json\n> rename to src/ipa/rpi/vc4/data/imx708.json\n> diff --git a/src/ipa/raspberrypi/data/imx708_noir.json b/src/ipa/rpi/vc4/data/imx708_noir.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx708_noir.json\n> rename to src/ipa/rpi/vc4/data/imx708_noir.json\n> diff --git a/src/ipa/raspberrypi/data/imx708_wide.json b/src/ipa/rpi/vc4/data/imx708_wide.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx708_wide.json\n> rename to src/ipa/rpi/vc4/data/imx708_wide.json\n> diff --git a/src/ipa/raspberrypi/data/imx708_wide_noir.json b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/imx708_wide_noir.json\n> rename to src/ipa/rpi/vc4/data/imx708_wide_noir.json\n> diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/rpi/vc4/data/meson.build\n> similarity index 89%\n> rename from src/ipa/raspberrypi/data/meson.build\n> rename to src/ipa/rpi/vc4/data/meson.build\n> index b163a052f57c..bcf5658ba5d2 100644\n> --- a/src/ipa/raspberrypi/data/meson.build\n> +++ b/src/ipa/rpi/vc4/data/meson.build\n> @@ -23,4 +23,4 @@ conf_files = files([\n>  ])\n>  \n>  install_data(conf_files,\n> -             install_dir : ipa_data_dir / 'raspberrypi')\n> +             install_dir : ipa_data_dir / 'rpi' / 'vc4')\n> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/rpi/vc4/data/ov5647.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/ov5647.json\n> rename to src/ipa/rpi/vc4/data/ov5647.json\n> diff --git a/src/ipa/raspberrypi/data/ov5647_noir.json b/src/ipa/rpi/vc4/data/ov5647_noir.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/ov5647_noir.json\n> rename to src/ipa/rpi/vc4/data/ov5647_noir.json\n> diff --git a/src/ipa/raspberrypi/data/ov9281_mono.json b/src/ipa/rpi/vc4/data/ov9281_mono.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/ov9281_mono.json\n> rename to src/ipa/rpi/vc4/data/ov9281_mono.json\n> diff --git a/src/ipa/raspberrypi/data/se327m12.json b/src/ipa/rpi/vc4/data/se327m12.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/se327m12.json\n> rename to src/ipa/rpi/vc4/data/se327m12.json\n> diff --git a/src/ipa/raspberrypi/data/uncalibrated.json b/src/ipa/rpi/vc4/data/uncalibrated.json\n> similarity index 100%\n> rename from src/ipa/raspberrypi/data/uncalibrated.json\n> rename to src/ipa/rpi/vc4/data/uncalibrated.json\n> diff --git a/src/ipa/rpi/vc4/meson.build b/src/ipa/rpi/vc4/meson.build\n> new file mode 100644\n> index 000000000000..cbd4dec62659\n> --- /dev/null\n> +++ b/src/ipa/rpi/vc4/meson.build\n> @@ -0,0 +1,48 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +ipa_name = 'ipa_rpi_vc4'\n> +\n> +vc4_ipa_deps = [\n> +    libcamera_private,\n> +    libatomic,\n> +]\n> +\n> +vc4_ipa_libs = [\n> +    rpi_ipa_cam_helper_lib,\n> +    rpi_ipa_controller_lib\n> +]\n> +\n> +vc4_ipa_includes = [\n> +    ipa_includes,\n> +    libipa_includes,\n> +]\n> +\n> +vc4_ipa_sources = files([\n> +    'raspberrypi.cpp',\n> +])\n> +\n> +vc4_ipa_includes += include_directories('..')\n> +\n> +mod = shared_module(ipa_name,\n> +                    [vc4_ipa_sources, libcamera_generated_ipa_headers],\n> +                    name_prefix : '',\n> +                    include_directories : vc4_ipa_includes,\n> +                    dependencies : vc4_ipa_deps,\n> +                    link_with : libipa,\n> +                    link_whole : vc4_ipa_libs,\n> +                    install : true,\n> +                    install_dir : ipa_install_dir)\n> +\n> +if ipa_sign_module\n> +    custom_target(ipa_name + '.so.sign',\n> +                  input : mod,\n> +                  output : ipa_name + '.so.sign',\n> +                  command : [ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@'],\n> +                  install : false,\n> +                  build_by_default : true)\n> +endif\n> +\n> +subdir('data')\n> +\n> +ipa_names += ipa_name\n> +\n\nExtra blank line.\n\nI'll fix those issues when applying.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/rpi/vc4/raspberrypi.cpp\n> similarity index 98%\n> rename from src/ipa/raspberrypi/raspberrypi.cpp\n> rename to src/ipa/rpi/vc4/raspberrypi.cpp\n> index 9c29fa9a5e5c..5d3bf4caf3da 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/rpi/vc4/raspberrypi.cpp\n> @@ -33,29 +33,29 @@\n>  \n>  #include \"libcamera/internal/mapped_framebuffer.h\"\n>  \n> -#include \"af_algorithm.h\"\n> -#include \"af_status.h\"\n> -#include \"agc_algorithm.h\"\n> -#include \"agc_status.h\"\n> -#include \"alsc_status.h\"\n> -#include \"awb_algorithm.h\"\n> -#include \"awb_status.h\"\n> -#include \"black_level_status.h\"\n> -#include \"cam_helper.h\"\n> -#include \"ccm_algorithm.h\"\n> -#include \"ccm_status.h\"\n> -#include \"contrast_algorithm.h\"\n> -#include \"contrast_status.h\"\n> -#include \"controller.h\"\n> -#include \"denoise_algorithm.h\"\n> -#include \"denoise_status.h\"\n> -#include \"dpc_status.h\"\n> -#include \"geq_status.h\"\n> -#include \"lux_status.h\"\n> -#include \"metadata.h\"\n> -#include \"sharpen_algorithm.h\"\n> -#include \"sharpen_status.h\"\n> -#include \"statistics.h\"\n> +#include \"cam_helper/cam_helper.h\"\n> +#include \"controller/af_algorithm.h\"\n> +#include \"controller/af_status.h\"\n> +#include \"controller/agc_algorithm.h\"\n> +#include \"controller/agc_status.h\"\n> +#include \"controller/alsc_status.h\"\n> +#include \"controller/awb_algorithm.h\"\n> +#include \"controller/awb_status.h\"\n> +#include \"controller/black_level_status.h\"\n> +#include \"controller/ccm_algorithm.h\"\n> +#include \"controller/ccm_status.h\"\n> +#include \"controller/contrast_algorithm.h\"\n> +#include \"controller/contrast_status.h\"\n> +#include \"controller/controller.h\"\n> +#include \"controller/denoise_algorithm.h\"\n> +#include \"controller/denoise_status.h\"\n> +#include \"controller/dpc_status.h\"\n> +#include \"controller/geq_status.h\"\n> +#include \"controller/lux_status.h\"\n> +#include \"controller/metadata.h\"\n> +#include \"controller/sharpen_algorithm.h\"\n> +#include \"controller/sharpen_status.h\"\n> +#include \"controller/statistics.h\"\n>  \n>  namespace libcamera {\n>  \n> @@ -1840,7 +1840,7 @@ const struct IPAModuleInfo ipaModuleInfo = {\n>  \tIPA_MODULE_API_VERSION,\n>  \t1,\n>  \t\"PipelineHandlerRPi\",\n> -\t\"raspberrypi\",\n> +\t\"rpi/vc4\",\n>  };\n>  \n>  IPAInterface *ipaCreate()","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C2A4C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  4 May 2023 16:33:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEB6C633B8;\n\tThu,  4 May 2023 18:33:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBE80633B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  4 May 2023 18:33:17 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AF147CE;\n\tThu,  4 May 2023 18:33:12 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683217998;\n\tbh=gtowlnYhClT3lS284SYcSAfjuPBPDqtv/HLTN8s6V0g=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=31guAZsEpWCfD+P5ZflYki4BDoqnPpu0Jwev0qnJ767B1QiKsTD1O79FK7AkHSK1y\n\t+lXTslryEU2iDTJqTF9a9y2ynyB/9hfVc8y+NyrfYfxvZ2WHs2kGTUmlKnchnIlvgb\n\t4GK7fgO06gfTP/XQ19EknDPsrK3s8eHCyj7WonUxLjDTeA0uv2ZwNXIACicRNqRu6i\n\tECjvj0cCxKv1m/ukayqwlMgKj0RkKVz8Ib5PsmXPaHk22+8nZTYtvyTeLl6emKKqh9\n\t4gvEVTwuK+JzgLK6tVALuJq30Zzkm459MPCdftR0khlY8OzcqdchDVP4KXpsgJYzJ9\n\tRQ9dhMMIvnNFQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683217994;\n\tbh=gtowlnYhClT3lS284SYcSAfjuPBPDqtv/HLTN8s6V0g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tXziGs/NAyLiGSvxUuvGy7Sz/NZBTReG3REKVdiYGkM5g9lVSqKANFJ6YPVObTXhO\n\t8GCmKv8BcexvFkmY8EHKmSJJ7XtgbolZDcM52e4n/RGvwbYCGalNcThaEbpOJ13lTT\n\t1sFItYqVoWPrl/HhIuOGeQ3pnN+DVciI0DwoE9aY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tXziGs/N\"; dkim-atps=neutral","Date":"Thu, 4 May 2023 19:33:28 +0300","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<20230504163328.GP4551@pendragon.ideasonboard.com>","References":"<20230503122035.32026-1-naush@raspberrypi.com>\n\t<20230503122035.32026-7-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230503122035.32026-7-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 06/13] ipa: raspberrypi: Refactor and\n\tmove IPA code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]