[{"id":27017,"web_url":"https://patchwork.libcamera.org/comment/27017/","msgid":"","date":"2023-05-03T07:06:51","subject":"Re: [libcamera-devel] [PATCH v1] qcam: Remove redundant check","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Tue, May 02, 2023 at 05:55:53PM +0000, Barnabás Pőcze via libcamera-devel wrote:\n> The switch statement checks `roles.size()` with cases for 1 and 2,\n> so in the `default` branch, `role.size() > 2`, i.e. it is always\n> different from 1, so the check is unnecessary.\n>\n> Signed-off-by: Barnabás Pőcze \n\nIndeed!\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/qcam/main_window.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> index fb2db4aa..680668df 100644\n> --- a/src/apps/qcam/main_window.cpp\n> +++ b/src/apps/qcam/main_window.cpp\n> @@ -381,11 +381,8 @@ int MainWindow::startCapture()\n> \t\t}\n> \t\tbreak;\n> \tdefault:\n> -\t\tif (roles.size() != 1) {\n> -\t\t\tqWarning() << \"Unsupported stream configuration\";\n> -\t\t\treturn -EINVAL;\n> -\t\t}\n> -\t\tbreak;\n> +\t\tqWarning() << \"Unsupported stream configuration\";\n> +\t\treturn -EINVAL;\n> \t}\n>\n> \t/* Configure the camera. */\n> --\n> 2.40.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED28EC0DA4\n\tfor ;\n\tWed, 3 May 2023 07:06:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 431D0633A8;\n\tWed, 3 May 2023 09:06:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D013F61EAD\n\tfor ;\n\tWed, 3 May 2023 09:06:54 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42E204FE;\n\tWed, 3 May 2023 09:06:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683097616;\n\tbh=hRT4QcteYldwG27FNwExKOSat6Gu3ijYuB30meJVqYM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tOnjEbpPeFUOyxCm27f77XzEr1IDb7bUB5ugJisuSSQPY4GO/NRU9joiKG8enhWAX\n\tnK2d1P910B9Bx8QAj1MptneHOjk4bCSXp1f8WGzCRSyzOZ94uYPZXIG2AIfiRbUav8\n\tryR6bDWPKWNAGfW8oOeelVSl76LO0DoamXGeVSULD40QPasXmPygI/2H4DJWkyZ5GD\n\tAQh5ohuo5JlGK9rWKDwzBesjOi0vRMG9dgxod1h7rqLReMnu79i9I8txYZWsH3egLC\n\tSCA3XBtuj7pr7t6cyBo2mzqbQl/ztBClGDJX0cz9FDuyzH5SiLkbwRU1Ss9Fh1oKgg\n\tqaDIA0S8LLjBA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683097612;\n\tbh=hRT4QcteYldwG27FNwExKOSat6Gu3ijYuB30meJVqYM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VYYDAi4lM7OOpsZfyoifuI2EbY/uHYMo6FQITsK4y2HCPc0w+ocKUWoaUbxFJBAhc\n\t576ngFfjbsYdGRvL+R5NsH2SsCfGjV0e1HnQKf8fI4McA/w3+/KHS+0hb86W41fZpz\n\tOCxf8NVPCFwes0LKNdl1i6hpuAyLrqitWNbwN+ok="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VYYDAi4l\"; dkim-atps=neutral","Date":"Wed, 3 May 2023 09:06:51 +0200","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Message-ID":"","References":"<20230502175551.70018-1-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20230502175551.70018-1-pobrn@protonmail.com>","Subject":"Re: [libcamera-devel] [PATCH v1] qcam: Remove redundant check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27018,"web_url":"https://patchwork.libcamera.org/comment/27018/","msgid":"<34bb85d2-55b0-a66d-c1b2-c82399fad8c5@ideasonboard.com>","date":"2023-05-03T07:16:08","subject":"Re: [libcamera-devel] [PATCH v1] qcam: Remove redundant check","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nOn 5/2/23 11:25 PM, Barnabás Pőcze via libcamera-devel wrote:\n> The switch statement checks `roles.size()` with cases for 1 and 2,\n> so in the `default` branch, `role.size() > 2`, i.e. it is always\n> different from 1, so the check is unnecessary.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Umang Jain \n\n> ---\n> src/apps/qcam/main_window.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> index fb2db4aa..680668df 100644\n> --- a/src/apps/qcam/main_window.cpp\n> +++ b/src/apps/qcam/main_window.cpp\n> @@ -381,11 +381,8 @@ int MainWindow::startCapture()\n> \t\t}\n> \t\tbreak;\n> \tdefault:\n> -\t\tif (roles.size() != 1) {\n> -\t\t\tqWarning() << \"Unsupported stream configuration\";\n> -\t\t\treturn -EINVAL;\n> -\t\t}\n> -\t\tbreak;\n> +\t\tqWarning() << \"Unsupported stream configuration\";\n> +\t\treturn -EINVAL;\n> \t}\n>\n> \t/* Configure the camera. */\n> --\n> 2.40.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8BF5BD16B\n\tfor ;\n\tWed, 3 May 2023 07:16:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BBED633A8;\n\tWed, 3 May 2023 09:16:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 893F461EAD\n\tfor ;\n\tWed, 3 May 2023 09:16:13 +0200 (CEST)","from [192.168.1.105] (unknown [103.86.18.137])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75E4E4FE;\n\tWed, 3 May 2023 09:16:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683098175;\n\tbh=dxeCuoz9LWV783Yuz5+ySgTJkeZZfx6CVgb675CKspA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=TFAZhQZiupAruc2/DUe7sAGQpVH0RaNxwSjLLzumRL7pG+ZFdl8nylmvoCDHPrAs2\n\tZJkgK/STBSkNl6s236b4w7fIT7gmjQwYCOCXQxbXTIzngMRF4EFT5bud03JIjTBmDq\n\tVUSSjiuAXEATPeERoA27pPDwVQC99sMgfMe9ZPIucVTZX0CaAhqrMACTf78d8qeH+L\n\tjzf6MzIx9vo7mSLljhkPwQ7FUY6QFLAYe+MBtrSXen5Lerpb0sj6nFWR4zY4mZKR0c\n\tshlVenaDdBIRVLRRxRhAebuk0nu4ZRm6bml7qVMnTaPjbXVu3XDHO8nfgBbnRSlZi+\n\tjD4d275dAya3g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683098171;\n\tbh=dxeCuoz9LWV783Yuz5+ySgTJkeZZfx6CVgb675CKspA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=hmDxSOoB6zgsZJ8shLCPjVQXNgjfgOyvQ36HTPP7ODHqmNzjj0MPMdCyyFwrm1Mda\n\tMI7i6Uhs6vT/zkEh93G2ZGgqISyouDnZNeYjm/goa//OO5Eh6OMl1munmFIU+RiyLk\n\tP6XV/SwnLNaSZ5kkwXZuXjxvJIAHSz9gxQgCE9aU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hmDxSOoB\"; dkim-atps=neutral","Message-ID":"<34bb85d2-55b0-a66d-c1b2-c82399fad8c5@ideasonboard.com>","Date":"Wed, 3 May 2023 12:46:08 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20230502175551.70018-1-pobrn@protonmail.com>","Content-Language":"en-US","In-Reply-To":"<20230502175551.70018-1-pobrn@protonmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1] qcam: Remove redundant check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27024,"web_url":"https://patchwork.libcamera.org/comment/27024/","msgid":"<41HiqJ5hLLXLeculJ778IZd3PDyEMW6keOWXQBU4owGBNe5WFA1HB9l8IdtRGNE3-d8DMY-l5VlFjNaqwr4ruDlnYZGRcLNPCuaz7OSlAJU=@protonmail.com>","date":"2023-05-03T12:37:49","subject":"Re: [libcamera-devel] [PATCH v1] qcam: Remove redundant check","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"I am now thinking that maybe the subject should be changed from\n\n qcam:\n\nto\n\n apps: qcam:\n\nI checked the output of `git log src/apps/qcam` but there was not a lot to go by.\nShould I resend? Or could someone change it if the second version is preferable\nwhen applying?\n\n\n2023. május 2., kedd 19:55 keltezéssel, Barnabás Pőcze írta:\n\n> The switch statement checks `roles.size()` with cases for 1 and 2,\n> so in the `default` branch, `role.size() > 2`, i.e. it is always\n> different from 1, so the check is unnecessary.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/apps/qcam/main_window.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> index fb2db4aa..680668df 100644\n> --- a/src/apps/qcam/main_window.cpp\n> +++ b/src/apps/qcam/main_window.cpp\n> @@ -381,11 +381,8 @@ int MainWindow::startCapture()\n> \t\t}\n> \t\tbreak;\n> \tdefault:\n> -\t\tif (roles.size() != 1) {\n> -\t\t\tqWarning() << \"Unsupported stream configuration\";\n> -\t\t\treturn -EINVAL;\n> -\t\t}\n> -\t\tbreak;\n> +\t\tqWarning() << \"Unsupported stream configuration\";\n> +\t\treturn -EINVAL;\n> \t}\n> \n> \t/* Configure the camera. */\n> --\n> 2.40.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B0B7C0DA4\n\tfor ;\n\tWed, 3 May 2023 12:38:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CEC2633B5;\n\tWed, 3 May 2023 14:38:04 +0200 (CEST)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A264627DE\n\tfor ;\n\tWed, 3 May 2023 14:38:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683117484;\n\tbh=en2OMeqcUmiZ0pcCYyhYMIvCX3Y+x635Z+eUOemqnPE=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YmOHPRLXziq27V78FGlUWh45l9BN2tMBYWTscKSu6386ZIhYicSqouqX2/hAGXHOW\n\t20O8jam10k16kWpgTs0efLr/UXSpvpR7vU/MioO+3phQ8wQa93jYSuxo+j2B1DTAv1\n\tc+Xrm9ea8jyKM7VPuA2+o3Ohvy/oEU97WYDg090t7TSYRKqsFpDsVPL0x9vvIHluUy\n\tU6X1JbnaoCagbUtNnDa/+4UyhRYcCg/iesxdp2wRhJRTVDeSXlTQCB5k6VQyy1gl9W\n\tpEKUth4J8r1Iwuhsv2JdUhtqOdym/cadLqM5TsciG43+k50D9DhIT3qRRJ1Kw6KX8O\n\tIGdfhxisiPa9Q==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1683117481; x=1683376681;\n\tbh=oAufDcVQCjiZr0IYUoPPCODxPle2nv3SBLRaHtDmBj0=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=bvsdEUAuZryxvdyAUsrFlfCWPHgcBhL0q9FB+0Gs0KD5jMljbolsOoQtKibPye97u\n\tQIylw7/84LnaAzcU0UW9l0xiEVzUBa9Lzuf8Cei6OFX/5HNwwN3qk+PTBf/e2uxb6l\n\t8C04Z6MG0/jqcPSMX8ZCSlljj8ZR5k5rIqdGo37DwtVw9pqgrXHAQ8ld3dHy+ijT5v\n\tJt6Dm5OWF1D1rDt8f5JznAdERKdxGBAMC6lLMh4kO8RpTu+xF4jaTcBcwP2IxLinol\n\tz9mw2G6o+7x8OyC2GvxB7oCLeeTn1g3waq5B+uKZK5tHRn8F5xtj72Pw4cwDvqxcdy\n\tCQszCRC2J+6iQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"bvsdEUAu\"; dkim-atps=neutral","Date":"Wed, 03 May 2023 12:37:49 +0000","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<41HiqJ5hLLXLeculJ778IZd3PDyEMW6keOWXQBU4owGBNe5WFA1HB9l8IdtRGNE3-d8DMY-l5VlFjNaqwr4ruDlnYZGRcLNPCuaz7OSlAJU=@protonmail.com>","In-Reply-To":"<20230502175551.70018-1-pobrn@protonmail.com>","References":"<20230502175551.70018-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH v1] qcam: Remove redundant check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27033,"web_url":"https://patchwork.libcamera.org/comment/27033/","msgid":"","date":"2023-05-03T14:04:16","subject":"Re: [libcamera-devel] [PATCH v1] qcam: Remove redundant check","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Wed, May 03, 2023 at 12:37:49PM +0000, Barnabás Pőcze via libcamera-devel wrote:\n> I am now thinking that maybe the subject should be changed from\n>\n> qcam:\n>\n> to\n>\n> apps: qcam:\n>\n> I checked the output of `git log src/apps/qcam` but there was not a lot to go by.\n> Should I resend? Or could someone change it if the second version is preferable\n> when applying?\n\nNo worries, I had already update it and I plan to push it later\ntoday\n\n>\n>\n> 2023. május 2., kedd 19:55 keltezéssel, Barnabás Pőcze írta:\n>\n> > The switch statement checks `roles.size()` with cases for 1 and 2,\n> > so in the `default` branch, `role.size() > 2`, i.e. it is always\n> > different from 1, so the check is unnecessary.\n> >\n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > src/apps/qcam/main_window.cpp | 7 ++-----\n> > 1 file changed, 2 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> > index fb2db4aa..680668df 100644\n> > --- a/src/apps/qcam/main_window.cpp\n> > +++ b/src/apps/qcam/main_window.cpp\n> > @@ -381,11 +381,8 @@ int MainWindow::startCapture()\n> > \t\t}\n> > \t\tbreak;\n> > \tdefault:\n> > -\t\tif (roles.size() != 1) {\n> > -\t\t\tqWarning() << \"Unsupported stream configuration\";\n> > -\t\t\treturn -EINVAL;\n> > -\t\t}\n> > -\t\tbreak;\n> > +\t\tqWarning() << \"Unsupported stream configuration\";\n> > +\t\treturn -EINVAL;\n> > \t}\n> >\n> > \t/* Configure the camera. */\n> > --\n> > 2.40.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17A8ABD16B\n\tfor ;\n\tWed, 3 May 2023 14:04:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CCADE633A8;\n\tWed, 3 May 2023 16:04:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EA0F627DE\n\tfor ;\n\tWed, 3 May 2023 16:04:20 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB09EBC;\n\tWed, 3 May 2023 16:04:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683122661;\n\tbh=RXTT3o+T6ehtLOe5NHAx3lWAxgPw6HQDoU2TBiTwm8A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tmyg0z42F+GPqwYAplpKbbjb//pj1q5dv9nrelbGYbJ1PSiO7/MGGZub6QDhCSyBj\n\ta+xVka9Uo/k1ddDcJzZ5KYhh9HG5asyi5GMEQVDdR5MLGw7SZZ/pKqZ0ldEtuoxgOX\n\t9FJ2HVKnclY2SwixieKzT6H0riqo8ndA/BCLKh3kBk2fo/AZhO/2s4BXnJ1bzePPvF\n\twrW5X21m4OGcjsUG3uzB2A4+ifVYhnGItE+tQTHNDvEUNIK+aoOxDB41byj/ZRt/M7\n\tkkUUmWc0s6hO/g9/Ecuz07QHy19g1G4QcoE/Kvtu8a9eDlfAFZIXhynTnDOmbQbWz2\n\tIyjtKg98JhoOw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683122657;\n\tbh=RXTT3o+T6ehtLOe5NHAx3lWAxgPw6HQDoU2TBiTwm8A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=o6CasJuEOyP6JQab+liZDVJMBZOCzJSFDQXbcuKjXWJkKmcSXMjdlkMXjrSZjTg4I\n\trynoJTymPq6FLRZ6ADr+wrLmU2hlPnoBhweL2jN/9R8jmvJkSenkRHDR0sM5a39ux0\n\tRhMQaDjx6f+dFBkxAvhq6y8QeO+mjPUWFNgVJx3w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o6CasJuE\"; dkim-atps=neutral","Date":"Wed, 3 May 2023 16:04:16 +0200","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Message-ID":"","References":"<20230502175551.70018-1-pobrn@protonmail.com>\n\t<41HiqJ5hLLXLeculJ778IZd3PDyEMW6keOWXQBU4owGBNe5WFA1HB9l8IdtRGNE3-d8DMY-l5VlFjNaqwr4ruDlnYZGRcLNPCuaz7OSlAJU=@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<41HiqJ5hLLXLeculJ778IZd3PDyEMW6keOWXQBU4owGBNe5WFA1HB9l8IdtRGNE3-d8DMY-l5VlFjNaqwr4ruDlnYZGRcLNPCuaz7OSlAJU=@protonmail.com>","Subject":"Re: [libcamera-devel] [PATCH v1] qcam: Remove redundant check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]