[{"id":27006,"web_url":"https://patchwork.libcamera.org/comment/27006/","msgid":"<168303057100.30031.8978614302378175860@Monstersaurus>","date":"2023-05-02T12:29:31","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally via libcamera-devel (2023-05-02 12:13:57)\n> The STM32 contains a camera pipeline known as the DCMIPP (Digital\n> Camera-Memory Interface Pixel Processor) which receives data from a\n> parallel interface and dumps the post-processed data to memory. The\n> pipeline is capable of some processing in the form of downscaling\n> captured data through cropping or skipping the sensor's output.\n> \n> The simple pipeline handler is quite capable of handling the DCMIPP\n> given its operation is handled entirely through configuring the pads\n> of a media graph, so add support for the driver to the pipeline's\n> supportedDevices array.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> Support for the dcmipp has been tested on an stm32mp135f-dk with a gc2145\n> camera sensor. Note that the dcmipp driver **is not** in mainline at the moment,\n> and nor is the gc2145's driver. @Hugues, @Alain, is there a plan to move those\n> drivers upstream?\n\nAs I understand it, the drivers are open, and as long as there is an\nexpectation that they are going upstream - that's 'enough' to get this\nmerged in libcamera I believe.\n\nIt's also a really easily 'line' to maintain ;-)\n\n\n> A few changes to ST's kernel were needed to fix some format propagation problems\n> and some missing controls for the GC2145 for this to work. Those can be found in\n> my tree linked below [1], along with some fixes to the CSI-2 to Parallel bridge\n> driver which _is_ upstream and which I posted to linux-media [2].\n> \n> [1] https://github.com/djrscally/linux/tree/v5.15-stm32mp\n> [2] https://lore.kernel.org/linux-media/20230502103547.150918-1-dan.scally@ideasonboard.com/T/#t\n> \n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index e1f8b989..01516bc3 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -194,6 +194,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> { \"mxc-isi\", {} },\n> { \"qcom-camss\", {} },\n> { \"sun6i-csi\", {} },\n> + { \"dcmipp\", {} },\n\nAlphabetical sort order ;-)\n\nWith that...\n\nReviewed-by: Kieran Bingham \n\n> };\n> \n> } /* namespace */\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B61E3C0DA4\n\tfor ;\n\tTue, 2 May 2023 12:29:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C0D7627DC;\n\tTue, 2 May 2023 14:29:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B780160538\n\tfor ;\n\tTue, 2 May 2023 14:29:33 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 901FA814;\n\tTue, 2 May 2023 14:29:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683030575;\n\tbh=c9byG630ZoPUKIXIy+eiEKgPHbP7QIwq8jKtb6Mw2qo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bxEiABFJgJdAaazfzS6mG8mNHkJfzSyTgoHfcUA/INNa1nMU0iD1+ZFXCYdqcFdUS\n\t6FpbXXum0uMPN3dO44GrqraJh+EuNc1KV9sJamjSjyWxl3lv1IgCdV0H/EJ/39dzuD\n\tugL14wB0p5hbvLTs0PasYQicO5Bxdz/N1IXank6evqYUJiaG88V80DWh7hu7Ir49or\n\tCzEYW5fTFoVv5nIxmMRBKVsx4UUNA6YjrfgSgeoBw7AK5/4lssvB3rnM6ajtEftejY\n\tcFM5jZan/itNhI1PIOJyhVTUq9OrtiOnl8pbhEvPUyiBaUB7ssFmadR9Ov6i7ov2vT\n\tlExBVfABjNG2A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683030571;\n\tbh=c9byG630ZoPUKIXIy+eiEKgPHbP7QIwq8jKtb6Mw2qo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=TNIUV/r8RwV+LA1gU7uKmqLE0lwU1sdUzvDMyW+PtOAqJZOKVXZJM8DxEWnAmjM2H\n\t6Abi3dtO9kx3pc/Pl1r4qQcdvVYIV5Q/W7eOQqTmZ6ZZA57GZo5rJf8ufxgULhWtju\n\tYne6ymB3Z1hmTE/wEMcW+xOJBocyU+GrpywCLgTo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TNIUV/r8\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230502111357.157442-1-dan.scally@ideasonboard.com>","References":"<20230502111357.157442-1-dan.scally@ideasonboard.com>","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 02 May 2023 13:29:31 +0100","Message-ID":"<168303057100.30031.8978614302378175860@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"hugues.fruchet@foss.st.com, alain.volmat@foss.st.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27007,"web_url":"https://patchwork.libcamera.org/comment/27007/","msgid":"<20230502123332.GE26884@pendragon.ideasonboard.com>","date":"2023-05-02T12:33:32","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, May 02, 2023 at 01:29:31PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Daniel Scally via libcamera-devel (2023-05-02 12:13:57)\n> > The STM32 contains a camera pipeline known as the DCMIPP (Digital\n> > Camera-Memory Interface Pixel Processor) which receives data from a\n> > parallel interface and dumps the post-processed data to memory. The\n> > pipeline is capable of some processing in the form of downscaling\n> > captured data through cropping or skipping the sensor's output.\n> > \n> > The simple pipeline handler is quite capable of handling the DCMIPP\n> > given its operation is handled entirely through configuring the pads\n> > of a media graph, so add support for the driver to the pipeline's\n> > supportedDevices array.\n> > \n> > Signed-off-by: Daniel Scally \n> > ---\n> > Support for the dcmipp has been tested on an stm32mp135f-dk with a gc2145\n> > camera sensor. Note that the dcmipp driver **is not** in mainline at the moment,\n> > and nor is the gc2145's driver. @Hugues, @Alain, is there a plan to move those\n> > drivers upstream?\n> \n> As I understand it, the drivers are open, and as long as there is an\n> expectation that they are going upstream - that's 'enough' to get this\n> merged in libcamera I believe.\n\nWe don't have to wait for the dcmipp driver to land upstream before\nmerging this, but I'd like to understand the upstreaming plan first.\n\n> It's also a really easily 'line' to maintain ;-)\n> \n> > A few changes to ST's kernel were needed to fix some format propagation problems\n> > and some missing controls for the GC2145 for this to work. Those can be found in\n> > my tree linked below [1], along with some fixes to the CSI-2 to Parallel bridge\n> > driver which _is_ upstream and which I posted to linux-media [2].\n> > \n> > [1] https://github.com/djrscally/linux/tree/v5.15-stm32mp\n> > [2] https://lore.kernel.org/linux-media/20230502103547.150918-1-dan.scally@ideasonboard.com/T/#t\n> > \n> > src/libcamera/pipeline/simple/simple.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index e1f8b989..01516bc3 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -194,6 +194,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> > { \"mxc-isi\", {} },\n> > { \"qcom-camss\", {} },\n> > { \"sun6i-csi\", {} },\n> > + { \"dcmipp\", {} },\n> \n> Alphabetical sort order ;-)\n> \n> With that...\n> \n> Reviewed-by: Kieran Bingham \n> \n> > };\n> > \n> > } /* namespace */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77ED1BD16B\n\tfor ;\n\tTue, 2 May 2023 12:33:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 192F9627DC;\n\tTue, 2 May 2023 14:33:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41E9860538\n\tfor ;\n\tTue, 2 May 2023 14:33:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43A26814;\n\tTue, 2 May 2023 14:33:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683030803;\n\tbh=VApEJhoE8qUc4gzHX4P92f7vdNMxzAWVqWxSd3KUya8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MLpFV8A5jEiMcGXGRhAYSfFkNoHf34M1Yo01/Yq92M4BS+2t3WiPV7XebkyOUHWqf\n\tdoQRJcTAOlqMeI3isXt1/RLhNLFvQKpr8siKiXxrGSYRhuvGUIyheacsQIO3yzWJ23\n\tTkdwgL/vafysNxcmTjVpgQAKrPFgikMcULDR89DsafiaA+am6LShW1uC3osL94QfOp\n\tiMsai2aZS/b1uS5Q/2lPVJDMuO77iNSSxlfIG0d2cExNsjFC1rIDP8G/PpFV3vLeKh\n\t+/eYyrPlmEKsqLRVThZgkDgVphh2F3RyQNy6+DOYbaDXHZ/7qm5AEJu4XETq+cVEbl\n\tJkvpzvWrtQM5w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683030799;\n\tbh=VApEJhoE8qUc4gzHX4P92f7vdNMxzAWVqWxSd3KUya8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fa6L6w0qJ+V69Le8tkt7UVCYeS0e4ia+gxZVC3nfOLLw9e4+ScocD4WZWIMV8Dw+/\n\t9so6bEZt/iJGvNuDNzsejkj9VJFw5bcsKWeh9wNZiILAHLcLlqqHZ/c9DXv1B8Ro1v\n\tgnPd/MCJ5n4F6e55iKEpNLkgOD3syMDQQxFpFKD4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fa6L6w0q\"; dkim-atps=neutral","Date":"Tue, 2 May 2023 15:33:32 +0300","To":"Kieran Bingham ","Message-ID":"<20230502123332.GE26884@pendragon.ideasonboard.com>","References":"<20230502111357.157442-1-dan.scally@ideasonboard.com>\n\t<168303057100.30031.8978614302378175860@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<168303057100.30031.8978614302378175860@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"hugues.fruchet@foss.st.com, libcamera-devel@lists.libcamera.org,\n\talain.volmat@foss.st.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27019,"web_url":"https://patchwork.libcamera.org/comment/27019/","msgid":"<47550641-9382-6033-423d-e62e34e3fdd6@foss.st.com>","date":"2023-05-03T08:18:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","submitter":{"id":161,"url":"https://patchwork.libcamera.org/api/people/161/","name":"Hugues FRUCHET","email":"hugues.fruchet@foss.st.com"},"content":"Hi Laurent,\n\nDCMIPP kernel driver has been submitted but no feedback received yet:\nhttps://www.spinics.net/lists/linux-media/msg218378.html\nWould be nice to get at least a first level of review before pushing a \nnew version.\n\nFor GC2145, we are in the middle of the bridge with two versions of \ndriver that can be found on the net: a pinephone version with a \nparallel interface support and our driver which is a CSI-2 version (we \nhave a small amount of support from GalaxyCore, not amazing but better \nthan nothing...)\n\nBest regards,\n\nOn 5/2/23 14:33, Laurent Pinchart wrote:\n> On Tue, May 02, 2023 at 01:29:31PM +0100, Kieran Bingham via libcamera-devel wrote:\n>> Quoting Daniel Scally via libcamera-devel (2023-05-02 12:13:57)\n>>> The STM32 contains a camera pipeline known as the DCMIPP (Digital\n>>> Camera-Memory Interface Pixel Processor) which receives data from a\n>>> parallel interface and dumps the post-processed data to memory. The\n>>> pipeline is capable of some processing in the form of downscaling\n>>> captured data through cropping or skipping the sensor's output.\n>>>\n>>> The simple pipeline handler is quite capable of handling the DCMIPP\n>>> given its operation is handled entirely through configuring the pads\n>>> of a media graph, so add support for the driver to the pipeline's\n>>> supportedDevices array.\n>>>\n>>> Signed-off-by: Daniel Scally \n>>> ---\n>>> Support for the dcmipp has been tested on an stm32mp135f-dk with a gc2145\n>>> camera sensor. Note that the dcmipp driver **is not** in mainline at the moment,\n>>> and nor is the gc2145's driver. @Hugues, @Alain, is there a plan to move those\n>>> drivers upstream?\n>>\n>> As I understand it, the drivers are open, and as long as there is an\n>> expectation that they are going upstream - that's 'enough' to get this\n>> merged in libcamera I believe.\n> \n> We don't have to wait for the dcmipp driver to land upstream before\n> merging this, but I'd like to understand the upstreaming plan first.\n> \n>> It's also a really easily 'line' to maintain ;-)\n>>\n>>> A few changes to ST's kernel were needed to fix some format propagation problems\n>>> and some missing controls for the GC2145 for this to work. Those can be found in\n>>> my tree linked below [1], along with some fixes to the CSI-2 to Parallel bridge\n>>> driver which _is_ upstream and which I posted to linux-media [2].\n>>>\n>>> [1] https://github.com/djrscally/linux/tree/v5.15-stm32mp\n>>> [2] https://lore.kernel.org/linux-media/20230502103547.150918-1-dan.scally@ideasonboard.com/T/#t\n>>>\n>>> src/libcamera/pipeline/simple/simple.cpp | 1 +\n>>> 1 file changed, 1 insertion(+)\n>>>\n>>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>>> index e1f8b989..01516bc3 100644\n>>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>>> @@ -194,6 +194,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n>>> { \"mxc-isi\", {} },\n>>> { \"qcom-camss\", {} },\n>>> { \"sun6i-csi\", {} },\n>>> + { \"dcmipp\", {} },\n>>\n>> Alphabetical sort order ;-)\n>>\n>> With that...\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> };\n>>> \n>>> } /* namespace */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB335C0DA4\n\tfor ;\n\tWed, 3 May 2023 09:11:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52830633A8;\n\tWed, 3 May 2023 11:11:34 +0200 (CEST)","from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com\n\t[185.132.182.106])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F60061EAD\n\tfor ;\n\tWed, 3 May 2023 10:18:04 +0200 (CEST)","from pps.filterd (m0241204.ppops.net [127.0.0.1])\n\tby mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n\t3436HAOZ032624; Wed, 3 May 2023 10:18:03 +0200","from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])\n\tby mx07-00178001.pphosted.com (PPS) with ESMTPS id 3qb37umqyg-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Wed, 03 May 2023 10:18:03 +0200","from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20])\n\tby beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 36ACA10002A; \n\tWed, 3 May 2023 10:18:02 +0200 (CEST)","from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69])\n\tby euls16034.sgp.st.com (STMicroelectronics) with ESMTP id\n\t268C7216ECF; Wed, 3 May 2023 10:18:02 +0200 (CEST)","from [10.201.20.99] (10.201.20.99) by SHFDAG1NODE1.st.com\n\t(10.75.129.69) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21;\n\tWed, 3 May 2023 10:18:01 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683105094;\n\tbh=efEIt7F93G94N8bup19QonSiEsVVN4wBzRp52OryQ08=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=m8NzbBiYTIDnm7TXjz0+rPDEmoHQ8NYoGUs/Th547l+tJoGXugOa7Kzl+xlfTdrp4\n\tq2XScQG8dOzH9befV/JxL2my0/HV199S/bGhkDY/WWWpZrqzQREFzl5H4SINRQPC6L\n\toEy0L1ZEKRuZiEVWvskHoB9NgFBOuANnvEqk6pHDOjpUxUbrZ0tdTx4zz+fWC0RZz5\n\tdtc/ohJfaAgS4NfVptzPOJtv4XihB4+Z5bjAriu7uyug3bTr8h3gdnmvilX3Ow1QHl\n\t5j+XabMj1jT2v0x0n4EIfKD8+h9JDFShb0VXohwJ+uVK08WXGUUa67k0E07SmV+eeK\n\tGsm5NHFG+01fA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n\th=message-id : date :\n\tmime-version : subject : to : cc : references : from : in-reply-to :\n\tcontent-type : content-transfer-encoding; s=selector1;\n\tbh=L6nnSkMIDR4bP133JD/cJCPtnUh3YM2DAGOXVEOM1VM=;\n\tb=jkivte+D6DUDLcw3Irw/jlW5WKUd9TLzw1B0jDdWHLVGt4yaSvnUO7hfTX4fkUNshyXE\n\tGgSSYMVftkAiBwry34CyvX+ufrCMaqugBkYwsh6IX0J+GM83qrqEtOHZYcfFNWgPHKpo\n\tV6XxIK2G6t8r/JwYECJDZpdTzJBG2fPCtB+5ck17+uwSC9zfeXkT5ggIbs3hSkphqJJx\n\tTCr/r0ZBLXbznF98LTiaiFjQ1Xrt0QsaTp/AJrh0jszPAIUiSeEqKWbsqY5LN135HsVC\n\trRNPBYJ7vbaVyLFlQXxJZw1VAGlXOJ5SyyysQvCV7yd1PbToA4E3N+20ddF6gt21zXt/\n\tjQ== "],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=foss.st.com\n\theader.i=@foss.st.com header.b=\"jkivte+D\"; \n\tdkim-atps=neutral","Message-ID":"<47550641-9382-6033-423d-e62e34e3fdd6@foss.st.com>","Date":"Wed, 3 May 2023 10:18:01 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.10.0","Content-Language":"en-US","To":"Laurent Pinchart , Kieran Bingham\n\t","References":"<20230502111357.157442-1-dan.scally@ideasonboard.com>\n\t<168303057100.30031.8978614302378175860@Monstersaurus>\n\t<20230502123332.GE26884@pendragon.ideasonboard.com>","In-Reply-To":"<20230502123332.GE26884@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.201.20.99]","X-ClientProxiedBy":"SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com\n\t(10.75.129.69)","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.205, Aquarius:18.0.942, Hydra:6.0.573,\n\tFMLib:17.11.170.22\n\tdefinitions=2023-05-03_04,2023-04-27_01,2023-02-09_01","X-Mailman-Approved-At":"Wed, 03 May 2023 11:11:32 +0200","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Hugues FRUCHET via libcamera-devel\n\t","Reply-To":"Hugues FRUCHET ","Cc":"alain.volmat@foss.st.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27025,"web_url":"https://patchwork.libcamera.org/comment/27025/","msgid":"<20230503124245.GB32586@pendragon.ideasonboard.com>","date":"2023-05-03T12:42:45","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hugues,\n\nOn Wed, May 03, 2023 at 10:18:01AM +0200, Hugues FRUCHET wrote:\n> Hi Laurent,\n> \n> DCMIPP kernel driver has been submitted but no feedback received yet:\n> https://www.spinics.net/lists/linux-media/msg218378.html\n> Would be nice to get at least a first level of review before pushing a \n> new version.\n\nOK, I'll take the blame :-) Dan told me he will review the patch series,\nI'll try to do so too, but will possibly wait for a v2 if he reports\nmany issues to be addressed.\n\n> For GC2145, we are in the middle of the bridge with two versions of \n> driver that can be found on the net: a pinephone version with a \n> parallel interface support and our driver which is a CSI-2 version (we \n> have a small amount of support from GalaxyCore, not amazing but better \n> than nothing...)\n\nDo you plan to upstream your driver ?\n\n> On 5/2/23 14:33, Laurent Pinchart wrote:\n> > On Tue, May 02, 2023 at 01:29:31PM +0100, Kieran Bingham via libcamera-devel wrote:\n> >> Quoting Daniel Scally via libcamera-devel (2023-05-02 12:13:57)\n> >>> The STM32 contains a camera pipeline known as the DCMIPP (Digital\n> >>> Camera-Memory Interface Pixel Processor) which receives data from a\n> >>> parallel interface and dumps the post-processed data to memory. The\n> >>> pipeline is capable of some processing in the form of downscaling\n> >>> captured data through cropping or skipping the sensor's output.\n> >>>\n> >>> The simple pipeline handler is quite capable of handling the DCMIPP\n> >>> given its operation is handled entirely through configuring the pads\n> >>> of a media graph, so add support for the driver to the pipeline's\n> >>> supportedDevices array.\n> >>>\n> >>> Signed-off-by: Daniel Scally \n> >>> ---\n> >>> Support for the dcmipp has been tested on an stm32mp135f-dk with a gc2145\n> >>> camera sensor. Note that the dcmipp driver **is not** in mainline at the moment,\n> >>> and nor is the gc2145's driver. @Hugues, @Alain, is there a plan to move those\n> >>> drivers upstream?\n> >>\n> >> As I understand it, the drivers are open, and as long as there is an\n> >> expectation that they are going upstream - that's 'enough' to get this\n> >> merged in libcamera I believe.\n> > \n> > We don't have to wait for the dcmipp driver to land upstream before\n> > merging this, but I'd like to understand the upstreaming plan first.\n> > \n> >> It's also a really easily 'line' to maintain ;-)\n> >>\n> >>> A few changes to ST's kernel were needed to fix some format propagation problems\n> >>> and some missing controls for the GC2145 for this to work. Those can be found in\n> >>> my tree linked below [1], along with some fixes to the CSI-2 to Parallel bridge\n> >>> driver which _is_ upstream and which I posted to linux-media [2].\n> >>>\n> >>> [1] https://github.com/djrscally/linux/tree/v5.15-stm32mp\n> >>> [2] https://lore.kernel.org/linux-media/20230502103547.150918-1-dan.scally@ideasonboard.com/T/#t\n> >>>\n> >>> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> >>> 1 file changed, 1 insertion(+)\n> >>>\n> >>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> >>> index e1f8b989..01516bc3 100644\n> >>> --- a/src/libcamera/pipeline/simple/simple.cpp\n> >>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> >>> @@ -194,6 +194,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> >>> { \"mxc-isi\", {} },\n> >>> { \"qcom-camss\", {} },\n> >>> { \"sun6i-csi\", {} },\n> >>> + { \"dcmipp\", {} },\n> >>\n> >> Alphabetical sort order ;-)\n> >>\n> >> With that...\n> >>\n> >> Reviewed-by: Kieran Bingham \n> >>\n> >>> };\n> >>> \n> >>> } /* namespace */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D3CCBD16B\n\tfor ;\n\tWed, 3 May 2023 12:42:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10F94633B5;\n\tWed, 3 May 2023 14:42:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9065F627DE\n\tfor ;\n\tWed, 3 May 2023 14:42:32 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7EFBBC;\n\tWed, 3 May 2023 14:42:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683117754;\n\tbh=sBJE3uGdfgAfKSf/Mfsrs5eor5TWmx2oU4RWTsSnjso=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=V/ahzxNmpbmt95PeKW6dFAfR+GKTQPrvnfjYnqS/o030xoQ1rnOPLvSJ8xBUcOUGO\n\tUWer9/0KJ6uFxl4LF61pITG80TyZt9lK0MbbIsJkgtPyRsJwtl4o6urOkNejPdUFg1\n\tZYNxnSjq6wa5EZzoikrlZGQQQiIdvhdxdki9ocsisKWQWq8dXKMbxC61J4T/BD1sk2\n\tLQdeQJ3RS7xEEsWWM25frJA1vztxFOsUSL7J5MMLzYPu04zUa3HTgIcJlKOdkAsfuh\n\t4SFF8qFP7CA6dHq/6rLpeRGhquUNbgeYdDqJ0TXJaO86+S9fwu4oebluVcmiRYTjda\n\tNlwoCY96fS9yg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683117749;\n\tbh=sBJE3uGdfgAfKSf/Mfsrs5eor5TWmx2oU4RWTsSnjso=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q9AT7cX1e7QU8amiTIeA0H7vhaeS54IML4DxgrSl7ykIwkEDdnhx4HtBQbc5llcVc\n\tBwAdWw4DoiVLaJsdT6idc4EAilq1R2kKZ1OjHVhwRc+L/wsp3UGGF0007fM6DsuTM3\n\tULg2CZKubJxiPbsDsjDVZnGnODOGak7WuNPRi3Lw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Q9AT7cX1\"; dkim-atps=neutral","Date":"Wed, 3 May 2023 15:42:45 +0300","To":"Hugues FRUCHET ","Message-ID":"<20230503124245.GB32586@pendragon.ideasonboard.com>","References":"<20230502111357.157442-1-dan.scally@ideasonboard.com>\n\t<168303057100.30031.8978614302378175860@Monstersaurus>\n\t<20230502123332.GE26884@pendragon.ideasonboard.com>\n\t<47550641-9382-6033-423d-e62e34e3fdd6@foss.st.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<47550641-9382-6033-423d-e62e34e3fdd6@foss.st.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"alain.volmat@foss.st.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27026,"web_url":"https://patchwork.libcamera.org/comment/27026/","msgid":"<20230503124326.GC32586@pendragon.ideasonboard.com>","date":"2023-05-03T12:43:26","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, May 03, 2023 at 03:42:50PM +0300, Laurent Pinchart wrote:\n> Hi Hugues,\n> \n> On Wed, May 03, 2023 at 10:18:01AM +0200, Hugues FRUCHET wrote:\n> > Hi Laurent,\n> > \n> > DCMIPP kernel driver has been submitted but no feedback received yet:\n> > https://www.spinics.net/lists/linux-media/msg218378.html\n> > Would be nice to get at least a first level of review before pushing a \n> > new version.\n> \n> OK, I'll take the blame :-) Dan told me he will review the patch series,\n> I'll try to do so too, but will possibly wait for a v2 if he reports\n> many issues to be addressed.\n\nAlso, given that the driver is on the list and that I have no reason to\nbelieve you won't follow up on review and get it merged,\n\nReviewed-by: Laurent Pinchart \n\nfor this patch.\n\n> > For GC2145, we are in the middle of the bridge with two versions of \n> > driver that can be found on the net: a pinephone version with a \n> > parallel interface support and our driver which is a CSI-2 version (we \n> > have a small amount of support from GalaxyCore, not amazing but better \n> > than nothing...)\n> \n> Do you plan to upstream your driver ?\n> \n> > On 5/2/23 14:33, Laurent Pinchart wrote:\n> > > On Tue, May 02, 2023 at 01:29:31PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > >> Quoting Daniel Scally via libcamera-devel (2023-05-02 12:13:57)\n> > >>> The STM32 contains a camera pipeline known as the DCMIPP (Digital\n> > >>> Camera-Memory Interface Pixel Processor) which receives data from a\n> > >>> parallel interface and dumps the post-processed data to memory. The\n> > >>> pipeline is capable of some processing in the form of downscaling\n> > >>> captured data through cropping or skipping the sensor's output.\n> > >>>\n> > >>> The simple pipeline handler is quite capable of handling the DCMIPP\n> > >>> given its operation is handled entirely through configuring the pads\n> > >>> of a media graph, so add support for the driver to the pipeline's\n> > >>> supportedDevices array.\n> > >>>\n> > >>> Signed-off-by: Daniel Scally \n> > >>> ---\n> > >>> Support for the dcmipp has been tested on an stm32mp135f-dk with a gc2145\n> > >>> camera sensor. Note that the dcmipp driver **is not** in mainline at the moment,\n> > >>> and nor is the gc2145's driver. @Hugues, @Alain, is there a plan to move those\n> > >>> drivers upstream?\n> > >>\n> > >> As I understand it, the drivers are open, and as long as there is an\n> > >> expectation that they are going upstream - that's 'enough' to get this\n> > >> merged in libcamera I believe.\n> > > \n> > > We don't have to wait for the dcmipp driver to land upstream before\n> > > merging this, but I'd like to understand the upstreaming plan first.\n> > > \n> > >> It's also a really easily 'line' to maintain ;-)\n> > >>\n> > >>> A few changes to ST's kernel were needed to fix some format propagation problems\n> > >>> and some missing controls for the GC2145 for this to work. Those can be found in\n> > >>> my tree linked below [1], along with some fixes to the CSI-2 to Parallel bridge\n> > >>> driver which _is_ upstream and which I posted to linux-media [2].\n> > >>>\n> > >>> [1] https://github.com/djrscally/linux/tree/v5.15-stm32mp\n> > >>> [2] https://lore.kernel.org/linux-media/20230502103547.150918-1-dan.scally@ideasonboard.com/T/#t\n> > >>>\n> > >>> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> > >>> 1 file changed, 1 insertion(+)\n> > >>>\n> > >>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > >>> index e1f8b989..01516bc3 100644\n> > >>> --- a/src/libcamera/pipeline/simple/simple.cpp\n> > >>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > >>> @@ -194,6 +194,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> > >>> { \"mxc-isi\", {} },\n> > >>> { \"qcom-camss\", {} },\n> > >>> { \"sun6i-csi\", {} },\n> > >>> + { \"dcmipp\", {} },\n> > >>\n> > >> Alphabetical sort order ;-)\n> > >>\n> > >> With that...\n> > >>\n> > >> Reviewed-by: Kieran Bingham \n> > >>\n> > >>> };\n> > >>> \n> > >>> } /* namespace */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D25CBBD16B\n\tfor ;\n\tWed, 3 May 2023 12:43:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CAA0633B5;\n\tWed, 3 May 2023 14:43:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2B01627DE\n\tfor ;\n\tWed, 3 May 2023 14:43:13 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E878BC;\n\tWed, 3 May 2023 14:43:09 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683117795;\n\tbh=NHEYxr3lhSbK5qvsFui9mdGqY+ws4OzdP6N76oriDiY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bVh3fj+1AedQJgRTMDRozi0uFNtmLkF+48DniM0EnqvEQqe336ISpNeoCfEDL5azp\n\txZ1zjTX0UR4GmDzgvxqbC/h0+Jm5w//iMDVGW+VePE58sOUrDYeKO5AzPueA81ia0p\n\tuM0MMoqEicY+I/oxzYWIqmPdtmTKPv1MeLfZNNoqvWk8W2c92wpqcYET8w3V/47ZLY\n\thJ2fpGvBZY/pkateDWon4t6IVdZ5RyuxNTvlpjAzkGLdVWjZdatUdsrxyKTHhI2DcW\n\tGoAEzYMS2J2C7srPOcD3AGbF5C5PU5S9tJ+6yCpMYu3z97nl21X4csNMYUoR4fBcoW\n\tbwAxJgXoDcdhw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683117791;\n\tbh=NHEYxr3lhSbK5qvsFui9mdGqY+ws4OzdP6N76oriDiY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DNe+gjit0DkScOAMVNzzsHBw6guXW1vjQxBeLLjCfzle4yRubsHys14xJGWF47KtF\n\ttzUHqjjeiPiTOfscLE8JuDhQhQ+BcTsvJd//TPPLBb0GcTaI4z1ie9i/l8KJcTQ5Jq\n\tut31mFyOD0/UlB8ONf492g/S6n0F36N38HEMBEoY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DNe+gjit\"; dkim-atps=neutral","Date":"Wed, 3 May 2023 15:43:26 +0300","To":"Hugues FRUCHET ","Message-ID":"<20230503124326.GC32586@pendragon.ideasonboard.com>","References":"<20230502111357.157442-1-dan.scally@ideasonboard.com>\n\t<168303057100.30031.8978614302378175860@Monstersaurus>\n\t<20230502123332.GE26884@pendragon.ideasonboard.com>\n\t<47550641-9382-6033-423d-e62e34e3fdd6@foss.st.com>\n\t<20230503124245.GB32586@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230503124245.GB32586@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"alain.volmat@foss.st.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27035,"web_url":"https://patchwork.libcamera.org/comment/27035/","msgid":"<20230503141636.GA1229742@gnbcxd0016.gnb.st.com>","date":"2023-05-03T14:16:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","submitter":{"id":162,"url":"https://patchwork.libcamera.org/api/people/162/","name":"Alain Volmat","email":"alain.volmat@foss.st.com"},"content":"Hi Laurent,\n\nOn Wed, May 03, 2023 at 03:42:45PM +0300, Laurent Pinchart wrote:\n> Hi Hugues,\n> \n> On Wed, May 03, 2023 at 10:18:01AM +0200, Hugues FRUCHET wrote:\n> > Hi Laurent,\n> > \n> > DCMIPP kernel driver has been submitted but no feedback received yet:\n> > https://www.spinics.net/lists/linux-media/msg218378.html\n> > Would be nice to get at least a first level of review before pushing a \n> > new version.\n> \n> OK, I'll take the blame :-) Dan told me he will review the patch series,\n> I'll try to do so too, but will possibly wait for a v2 if he reports\n> many issues to be addressed.\n\nThanks a lot. Once we have some first comments I will push a v2 :-)\n\n> > For GC2145, we are in the middle of the bridge with two versions of \n> > driver that can be found on the net: a pinephone version with a \n> > parallel interface support and our driver which is a CSI-2 version (we \n> > have a small amount of support from GalaxyCore, not amazing but better \n> > than nothing...)\n> \n> Do you plan to upstream your driver ?\n\nThe idea is to first give a try to merge our driver with the one from\npinephone (that is adding the CSI2 part into the pinephone version).\nI am giving it a try currently and then yes, for sure I'll then upstream\nthe driver.\n\n> \n> > On 5/2/23 14:33, Laurent Pinchart wrote:\n> > > On Tue, May 02, 2023 at 01:29:31PM +0100, Kieran Bingham via libcamera-devel wrote:\n> > >> Quoting Daniel Scally via libcamera-devel (2023-05-02 12:13:57)\n> > >>> The STM32 contains a camera pipeline known as the DCMIPP (Digital\n> > >>> Camera-Memory Interface Pixel Processor) which receives data from a\n> > >>> parallel interface and dumps the post-processed data to memory. The\n> > >>> pipeline is capable of some processing in the form of downscaling\n> > >>> captured data through cropping or skipping the sensor's output.\n> > >>>\n> > >>> The simple pipeline handler is quite capable of handling the DCMIPP\n> > >>> given its operation is handled entirely through configuring the pads\n> > >>> of a media graph, so add support for the driver to the pipeline's\n> > >>> supportedDevices array.\n> > >>>\n> > >>> Signed-off-by: Daniel Scally \n> > >>> ---\n> > >>> Support for the dcmipp has been tested on an stm32mp135f-dk with a gc2145\n> > >>> camera sensor. Note that the dcmipp driver **is not** in mainline at the moment,\n> > >>> and nor is the gc2145's driver. @Hugues, @Alain, is there a plan to move those\n> > >>> drivers upstream?\n> > >>\n> > >> As I understand it, the drivers are open, and as long as there is an\n> > >> expectation that they are going upstream - that's 'enough' to get this\n> > >> merged in libcamera I believe.\n> > > \n> > > We don't have to wait for the dcmipp driver to land upstream before\n> > > merging this, but I'd like to understand the upstreaming plan first.\n> > > \n> > >> It's also a really easily 'line' to maintain ;-)\n> > >>\n> > >>> A few changes to ST's kernel were needed to fix some format propagation problems\n> > >>> and some missing controls for the GC2145 for this to work. Those can be found in\n> > >>> my tree linked below [1], along with some fixes to the CSI-2 to Parallel bridge\n> > >>> driver which _is_ upstream and which I posted to linux-media [2].\n> > >>>\n> > >>> [1] https://github.com/djrscally/linux/tree/v5.15-stm32mp\n> > >>> [2] https://lore.kernel.org/linux-media/20230502103547.150918-1-dan.scally@ideasonboard.com/T/#t\n> > >>>\n> > >>> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> > >>> 1 file changed, 1 insertion(+)\n> > >>>\n> > >>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > >>> index e1f8b989..01516bc3 100644\n> > >>> --- a/src/libcamera/pipeline/simple/simple.cpp\n> > >>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > >>> @@ -194,6 +194,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> > >>> { \"mxc-isi\", {} },\n> > >>> { \"qcom-camss\", {} },\n> > >>> { \"sun6i-csi\", {} },\n> > >>> + { \"dcmipp\", {} },\n> > >>\n> > >> Alphabetical sort order ;-)\n> > >>\n> > >> With that...\n> > >>\n> > >> Reviewed-by: Kieran Bingham \n> > >>\n> > >>> };\n> > >>> \n> > >>> } /* namespace */\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1659BC0DA4\n\tfor ;\n\tWed, 3 May 2023 14:29:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 360D8633B4;\n\tWed, 3 May 2023 16:29:40 +0200 (CEST)","from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com\n\t[185.132.182.106])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6601E61EAF\n\tfor ;\n\tWed, 3 May 2023 16:16:45 +0200 (CEST)","from pps.filterd (m0288072.ppops.net [127.0.0.1])\n\tby mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n\t343DYSZb010290; Wed, 3 May 2023 16:16:44 +0200","from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])\n\tby mx07-00178001.pphosted.com (PPS) with ESMTPS id 3q8rnmremj-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Wed, 03 May 2023 16:16:44 +0200","from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20])\n\tby beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6FB3B10002A; \n\tWed, 3 May 2023 16:16:43 +0200 (CEST)","from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69])\n\tby euls16034.sgp.st.com (STMicroelectronics) with ESMTP id\n\t5E7CF229A9C; Wed, 3 May 2023 16:16:43 +0200 (CEST)","from gnbcxd0016.gnb.st.com (10.129.178.213) by SHFDAG1NODE1.st.com\n\t(10.75.129.69) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21;\n\tWed, 3 May 2023 16:16:43 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683124180;\n\tbh=YIDXpBd4ylmmEZHFA/eMNav1RyuNk3Z8M6IIkB7orFk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZjqfARGihrTPZTSAwpgmzVwyNRhtAxSoErbhFntbBcfg8Up4ZCSS2ON9B8/8aVilT\n\tXw0qy78pilBFRO37s4cUCR/2nGKKpBsMiNcC9cLrfHOHes27HVqhzjgr2U190tBSF6\n\tgJn5BeLR639kstdIb53HRj6ch93WMeSV4RRL3w4IKTuEnMfq8HItXbMalgNkP35VZY\n\tk0eheKr+w9n7OC2v2ZBQu44CfFOXQhBZshlSKedeydxn5it/Cxla4hnE3RjBAsEELe\n\tkmMMwW9XHEpwKhLV3ai6shmRA5t3pscKUZoSSI2gJqJDChNJx/Trz14J8oqb47db+z\n\tu4C4hsrufv3vg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n\th=date : from : to :\n\tcc : subject : message-id : references : mime-version : content-type\n\t: in-reply-to; s=selector1;\n\tbh=roTe25FoasosbvBzri0R1YcMtHqlU4ULezqgJ25qswc=; \n\tb=zudSpT3ZEddHXhU1XDGbUfKPko3gBZE+XCoyYmKlqzAUc3h53Xk/A/J2HMscsNNfHGMG\n\tA2PnkxlVCE6y2yUGVll5LjzGLoFAsy9WgM+oTWkwklOsrX1/Exq3hTRGghDQKRWjEYa1\n\tUty4GGj5uLEd8s7H5moTrmDn3dFbvb3k/9Q6Bijxm5wW1m8nJMzX5UYlgSbXaSAPEMJf\n\taWudiH8OuEtwl5mZtBkQ73jyA0sbcK7fx1mDdifmOmTmwP4v6rMv4L1DCVl4fxVS5MMp\n\t29fcp5Tpsy0KkyAXAlmOTnha4worW7EfjAukMKt5s2AwAxOZ8aoZm4Gs0+zUTua/8hcK\n\tOQ== "],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=foss.st.com\n\theader.i=@foss.st.com header.b=\"zudSpT3Z\"; \n\tdkim-atps=neutral","Date":"Wed, 3 May 2023 16:16:36 +0200","To":"Laurent Pinchart ","Message-ID":"<20230503141636.GA1229742@gnbcxd0016.gnb.st.com>","References":"<20230502111357.157442-1-dan.scally@ideasonboard.com>\n\t<168303057100.30031.8978614302378175860@Monstersaurus>\n\t<20230502123332.GE26884@pendragon.ideasonboard.com>\n\t<47550641-9382-6033-423d-e62e34e3fdd6@foss.st.com>\n\t<20230503124245.GB32586@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"<20230503124245.GB32586@pendragon.ideasonboard.com>","X-Disclaimer":"ce message est personnel / this message is private","X-Originating-IP":"[10.129.178.213]","X-ClientProxiedBy":"SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com\n\t(10.75.129.69)","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.205, Aquarius:18.0.942, Hydra:6.0.573,\n\tFMLib:17.11.170.22\n\tdefinitions=2023-05-03_10,2023-05-03_01,2023-02-09_01","X-Mailman-Approved-At":"Wed, 03 May 2023 16:29:39 +0200","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Add\n\tsupport for ST's DCMIPP","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Alain Volmat via libcamera-devel ","Reply-To":"Alain Volmat ","Cc":"Hugues FRUCHET ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]