[{"id":27027,"web_url":"https://patchwork.libcamera.org/comment/27027/","msgid":"<d286ac12-b054-fec4-d52c-d303410555af@redhat.com>","date":"2023-05-03T12:51:38","subject":"Re: [libcamera-devel] [PATCH 2/2] v4l2: Move the v4l2-compat to\n\tlibcamera/","submitter":{"id":95,"url":"https://patchwork.libcamera.org/api/people/95/","name":"Javier Martinez Canillas","email":"javierm@redhat.com"},"content":"Hello Kieran,\n\nThanks for your patch.\n\nOn 5/1/23 17:55, Kieran Bingham wrote:\n> Move the v4l2-compat.so shared library installation to the libcamera\n> library directory. This is the same location that IPA modules live and\n> will allow the 'generically sounding' v4l2-compat.so to be more clearly\n> identified as a libcamera compatibility layer.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n> We could also rename this to libcamera-v4l2-compat.so, and/or we could\n> also re-consider whether the libcamera-hal.so file should also live\n> under the libcamera/ libdir by default.\n> \n>  src/v4l2/meson.build | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n> index f132103cb503..114fddf7302a 100644\n> --- a/src/v4l2/meson.build\n> +++ b/src/v4l2/meson.build\n> @@ -31,6 +31,7 @@ v4l2_compat = shared_library('v4l2-compat',\n>                               v4l2_compat_sources,\n>                               name_prefix : '',\n>                               install : true,\n> +                             install_dir : libcamera_libdir,\n>                               dependencies : [libcamera_private, libdl],\n>                               cpp_args : v4l2_compat_cpp_args)\n>  \n> @@ -38,7 +39,7 @@ v4l2_compat = shared_library('v4l2-compat',\n>  # adaptation layer.\n>  \n>  cdata = configuration_data()\n> -cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / get_option('libdir') / 'v4l2-compat.so')\n> +cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / libcamera_libdir / 'v4l2-compat.so')\n>\n\nAs Laurent mentioned in another thread, I think that:\n\n+cdata.set('LIBCAMERA_V4L2_SO', get_option('libexecdir') / 'libcamera' / 'v4l2-compat.so')\n\nwould be better and more consistent with how other projects install\nshared objects that are not meant to be public.\n\nThat would also solve the issue I had when trying to enable the v4l2\ncompatibility layer and ship it in a separate libcamera-v4l2 sub-package.\n\nIf you post a v2 with that change, feel free to add my:\n\nReviewed-by: Javier Martinez Canillas <javierm@redhat.com>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 406FEC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  3 May 2023 12:51:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5FCF627DE;\n\tWed,  3 May 2023 14:51:44 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB27861EAF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 May 2023 14:51:42 +0200 (CEST)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-279-CC848N5iN3W1_hbMDAsz2g-1; Wed, 03 May 2023 08:51:40 -0400","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-3f315735edeso14574715e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 03 May 2023 05:51:40 -0700 (PDT)","from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.\n\t[92.176.231.205]) by smtp.gmail.com with ESMTPSA id\n\ts1-20020adff801000000b00300aee6c9cesm33921302wrp.20.2023.05.03.05.51.38\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 03 May 2023 05:51:38 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683118304;\n\tbh=yj6gzB0OEFjzwaPE4Q5C7BI5u+BrS7WT3f8BzRtjntU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=313f+n++wqGoMPRuurVXDab25poyo0vp6aMrcNTdJypM2D+7fUWOHLwS0mxcjsAOz\n\tpNufuf/wmgTJrhM/zjix08snda2hz/VX2RdMVlVKmp3oGIIPcdx8/d9kyrTmp54EpO\n\thUMCH1brwGyG3zr/QxawzTN2xjTWc8VQL8EWXmHV32kbl1/VK3n2TwIbN+1JKYTs6S\n\t0oIB3Su9352RQBDGjd44wXaEQNdQ5K6jdwSZmoT2z49kHUx82AfHaCkemUBzG1rSjj\n\tjEwYdYhphpMEgIaaJXpcK6oTKpFCejdMraFM6IdHoLmFrToa4MYjLCT0/EnWpjnI/v\n\tqDx8OOdRhiAMg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1683118301;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=RJrWSjxdoXy3t/TL0z26Gzh2+0dy7y6FrUUjm9OrkNc=;\n\tb=TgLmlItF62DHu25Z261xvvpsPWoJlgKFeZn6byTZoasiG7ZEDgSfaz96Hn/iqbYqmKv6FQ\n\tUZRd1UOALGsTbiQoYe46P8VvH/2p2L4LRJumChrX5h7p2mEEF/OathDN2LxeroJkwXzsHJ\n\teIVwt72ImxURnSLLeA2RyMaPTQs7Iv8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"TgLmlItF\"; \n\tdkim-atps=neutral","X-MC-Unique":"CC848N5iN3W1_hbMDAsz2g-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1683118299; x=1685710299;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=RJrWSjxdoXy3t/TL0z26Gzh2+0dy7y6FrUUjm9OrkNc=;\n\tb=C+jRBAxQVUodEu6BxhGKR8q9Ol+M0087yyLwEk79eOy10fHj0rRzklHmdVWihOS3iD\n\tqahbU6JnnnZ1S65ty1vnRmMdw1pilKPD8tb5w71SKgqJRfNqN3ubizJpGNoqyJ9c9tCQ\n\tg0OpbO4qPYuDUifTMNmgLnW8nwpf0B90dZWk4SdA7OLMkSQ3CRZmk86DMP1uppFdjb0q\n\tMtu+c3o2j9K0sNIpXr+53hD92GUI2/ESXq6TI3smA/MHSh77MCTgVwZ6EPkJu7N/39jH\n\t8CxkgHgk9Ir+m9GoIC+lie/GPhT5kJhOmnEOrrJIZTo4biWzPNgfCYNEYDxN5Vdwyho1\n\tM4ZA==","X-Gm-Message-State":"AC+VfDy7N/RQq1Xw/0zQjMIgVEdwJ8xiLjQFLc9SjNm8UQE3Lr1j61m+\n\ttabg3J2u0eWnfLA1VDUM67FoWepX1Xa7YgmOGjYdVPOVos2ty1ILei9EG0yn7o+waRjr+a/nkBb\n\tJtwxwyQ6lRAYBbOQXsh5CpKj71/WPxnwUqFcxguOKog==","X-Received":["by 2002:a05:600c:1d83:b0:3f1:88b:bd40 with SMTP id\n\tp3-20020a05600c1d8300b003f1088bbd40mr1319049wms.14.1683118299477; \n\tWed, 03 May 2023 05:51:39 -0700 (PDT)","by 2002:a05:600c:1d83:b0:3f1:88b:bd40 with SMTP id\n\tp3-20020a05600c1d8300b003f1088bbd40mr1319030wms.14.1683118299127; \n\tWed, 03 May 2023 05:51:39 -0700 (PDT)"],"X-Google-Smtp-Source":"ACHHUZ5cfCwEwU/RAom4u7VM/L8xZasJswhq7SeEi9M9pSFpv6BkVhPVnIB8OhJ59Bz54VRN/yhTfQ==","Message-ID":"<d286ac12-b054-fec4-d52c-d303410555af@redhat.com>","Date":"Wed, 3 May 2023 14:51:38 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.10.0","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","References":"<20230501155507.116039-1-kieran.bingham@ideasonboard.com>\n\t<20230501155507.116039-3-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20230501155507.116039-3-kieran.bingham@ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] v4l2: Move the v4l2-compat to\n\tlibcamera/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Javier Martinez Canillas via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Javier Martinez Canillas <javierm@redhat.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27029,"web_url":"https://patchwork.libcamera.org/comment/27029/","msgid":"<20230503130604.GF32586@pendragon.ideasonboard.com>","date":"2023-05-03T13:06:04","subject":"Re: [libcamera-devel] [PATCH 2/2] v4l2: Move the v4l2-compat to\n\tlibcamera/","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Javier and Kieran,\n\nOn Wed, May 03, 2023 at 02:51:38PM +0200, Javier Martinez Canillas via libcamera-devel wrote:\n> On 5/1/23 17:55, Kieran Bingham wrote:\n> > Move the v4l2-compat.so shared library installation to the libcamera\n> > library directory. This is the same location that IPA modules live and\n> > will allow the 'generically sounding' v4l2-compat.so to be more clearly\n> > identified as a libcamera compatibility layer.\n> > \n> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > ---\n> > We could also rename this to libcamera-v4l2-compat.so, and/or we could\n\nI think libcamera/v4l2-compat.so is enough from a namespacing point of\nview.\n\n> > also re-consider whether the libcamera-hal.so file should also live\n> > under the libcamera/ libdir by default.\n\nThat's a question specific to Android (and Chrome OS), I don't recall\nwhat the Android rules are.\n\n> >  src/v4l2/meson.build | 3 ++-\n> >  1 file changed, 2 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n> > index f132103cb503..114fddf7302a 100644\n> > --- a/src/v4l2/meson.build\n> > +++ b/src/v4l2/meson.build\n> > @@ -31,6 +31,7 @@ v4l2_compat = shared_library('v4l2-compat',\n> >                               v4l2_compat_sources,\n> >                               name_prefix : '',\n> >                               install : true,\n> > +                             install_dir : libcamera_libdir,\n> >                               dependencies : [libcamera_private, libdl],\n> >                               cpp_args : v4l2_compat_cpp_args)\n> >  \n> > @@ -38,7 +39,7 @@ v4l2_compat = shared_library('v4l2-compat',\n> >  # adaptation layer.\n> >  \n> >  cdata = configuration_data()\n> > -cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / get_option('libdir') / 'v4l2-compat.so')\n> > +cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / libcamera_libdir / 'v4l2-compat.so')\n> \n> As Laurent mentioned in another thread, I think that:\n> \n> +cdata.set('LIBCAMERA_V4L2_SO', get_option('libexecdir') / 'libcamera' / 'v4l2-compat.so')\n\nI think you need\n\n\tget_option('prefix') / get_option('libexecdir') / 'libcamera' / 'v4l2-compat.so'\n\n> would be better and more consistent with how other projects install\n> shared objects that are not meant to be public.\n\nAccording to\nhttps://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html,\n\n\"/usr/libexec includes internal binaries that are not intended to be\nexecuted directly by users or shell scripts. Applications may use a\nsingle subdirectory under /usr/libexec.\"\n\nThis being said, valgrind installs LD_PRELOAD-able .so files in libexec,\nand there are some other .so from different packages there too. I thus\nthink it makes sense to store v4l2-compat.so in libexec.\n\nIf we go for libexec, the first patch in this series could also be\ndropped. We could keep it for additional safety, but until we store\nother files in that directory, it's a bit pointless.\n\n> That would also solve the issue I had when trying to enable the v4l2\n> compatibility layer and ship it in a separate libcamera-v4l2 sub-package.\n> \n> If you post a v2 with that change, feel free to add my:\n> \n> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 404B3C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  3 May 2023 13:05:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A672F627DE;\n\tWed,  3 May 2023 15:05:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 650CC61EAF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 May 2023 15:05:51 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB002755;\n\tWed,  3 May 2023 15:05:47 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683119153;\n\tbh=1J22BSQgX70JPXsv2l4rYrdzFLsc0OEYYYSiwyr6e5A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=W0ayToYpFtmI4HaVLsBLfPuczzImZVzKpaRjGIpJ5ik+h3YB6HT8ULBnEiYeBmxKE\n\tWmF6sx8c9wqIOR57rfONNMtuJ5pGRIriaERhKGGESBJmQI7b+56L5ejdsUmHDlYrnp\n\tIN89Ho5ERZ1yRneLQpzZiKRZ2618dBvkuHcLuP+sW5lkT0kEW2BJOxbU+uNiOuJXW5\n\toAPe+8VxQXr4+trPIF43yeOoX4Xx84Jd8mTxAEFbA6cY8DZxYrUiogYvJ3U/+m6bst\n\t8IUfa42tBz8aJQv0B2aZa57/2WR9JQjHF8uypRdJqqKLIiO7zJkzIiVUGCo4rhgqiL\n\tBJdRlVKZ6bT4A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683119148;\n\tbh=1J22BSQgX70JPXsv2l4rYrdzFLsc0OEYYYSiwyr6e5A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gat8azxxIcPLLhl97pO5+zKlhA8b8+tfP9mHc4zq/Flksuhz+YCgODjQYq7FRXLGJ\n\tIvu6dgldBKf5pnAT+xVkU7j8aqqKQsEBNzUAfSTNJocMjcq/heCnNp0YV255GTG5cT\n\tod8Rlh9iOvkn4zeu2uriNdzovy1QaQHbgasDHskI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gat8azxx\"; dkim-atps=neutral","Date":"Wed, 3 May 2023 16:06:04 +0300","To":"Javier Martinez Canillas <javierm@redhat.com>","Message-ID":"<20230503130604.GF32586@pendragon.ideasonboard.com>","References":"<20230501155507.116039-1-kieran.bingham@ideasonboard.com>\n\t<20230501155507.116039-3-kieran.bingham@ideasonboard.com>\n\t<d286ac12-b054-fec4-d52c-d303410555af@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<d286ac12-b054-fec4-d52c-d303410555af@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] v4l2: Move the v4l2-compat to\n\tlibcamera/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27030,"web_url":"https://patchwork.libcamera.org/comment/27030/","msgid":"<87v8h9wnij.fsf@minerva.mail-host-address-is-not-set>","date":"2023-05-03T13:30:28","subject":"Re: [libcamera-devel] [PATCH 2/2] v4l2: Move the v4l2-compat to\n\tlibcamera/","submitter":{"id":95,"url":"https://patchwork.libcamera.org/api/people/95/","name":"Javier Martinez Canillas","email":"javierm@redhat.com"},"content":"Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n\n> Hi Javier and Kieran,\n>\n> On Wed, May 03, 2023 at 02:51:38PM +0200, Javier Martinez Canillas via libcamera-devel wrote:\n>> On 5/1/23 17:55, Kieran Bingham wrote:\n>> > Move the v4l2-compat.so shared library installation to the libcamera\n>> > library directory. This is the same location that IPA modules live and\n>> > will allow the 'generically sounding' v4l2-compat.so to be more clearly\n>> > identified as a libcamera compatibility layer.\n>> > \n>> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>> > ---\n>> > We could also rename this to libcamera-v4l2-compat.so, and/or we could\n>\n> I think libcamera/v4l2-compat.so is enough from a namespacing point of\n> view.\n>\n\nAgreed.\n\n>> > also re-consider whether the libcamera-hal.so file should also live\n>> > under the libcamera/ libdir by default.\n>\n> That's a question specific to Android (and Chrome OS), I don't recall\n> what the Android rules are.\n>\n>> >  src/v4l2/meson.build | 3 ++-\n>> >  1 file changed, 2 insertions(+), 1 deletion(-)\n>> > \n>> > diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n>> > index f132103cb503..114fddf7302a 100644\n>> > --- a/src/v4l2/meson.build\n>> > +++ b/src/v4l2/meson.build\n>> > @@ -31,6 +31,7 @@ v4l2_compat = shared_library('v4l2-compat',\n>> >                               v4l2_compat_sources,\n>> >                               name_prefix : '',\n>> >                               install : true,\n>> > +                             install_dir : libcamera_libdir,\n>> >                               dependencies : [libcamera_private, libdl],\n>> >                               cpp_args : v4l2_compat_cpp_args)\n>> >  \n>> > @@ -38,7 +39,7 @@ v4l2_compat = shared_library('v4l2-compat',\n>> >  # adaptation layer.\n>> >  \n>> >  cdata = configuration_data()\n>> > -cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / get_option('libdir') / 'v4l2-compat.so')\n>> > +cdata.set('LIBCAMERA_V4L2_SO', get_option('prefix') / libcamera_libdir / 'v4l2-compat.so')\n>> \n>> As Laurent mentioned in another thread, I think that:\n>> \n>> +cdata.set('LIBCAMERA_V4L2_SO', get_option('libexecdir') / 'libcamera' / 'v4l2-compat.so')\n>\n> I think you need\n>\n> \tget_option('prefix') / get_option('libexecdir') / 'libcamera' / 'v4l2-compat.so'\n>\n\nRight, sorry I missed the 'prefix' when typed the above.\n\n>> would be better and more consistent with how other projects install\n>> shared objects that are not meant to be public.\n>\n> According to\n> https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html,\n>\n> \"/usr/libexec includes internal binaries that are not intended to be\n> executed directly by users or shell scripts. Applications may use a\n> single subdirectory under /usr/libexec.\"\n>\n> This being said, valgrind installs LD_PRELOAD-able .so files in libexec,\n> and there are some other .so from different packages there too. I thus\n> think it makes sense to store v4l2-compat.so in libexec.\n>\n> If we go for libexec, the first patch in this series could also be\n> dropped. We could keep it for additional safety, but until we store\n> other files in that directory, it's a bit pointless.\n>\n\nAgreed.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CE6EBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  3 May 2023 13:30:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9216633B4;\n\tWed,  3 May 2023 15:30:35 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F15D361EAF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 May 2023 15:30:34 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-64-3GN5IVHqNcyV0cOEfsmTsQ-1; Wed, 03 May 2023 09:30:31 -0400","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-3f170a1fbe7so31358495e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 03 May 2023 06:30:31 -0700 (PDT)","from localhost (205.pool92-176-231.dynamic.orange.es.\n\t[92.176.231.205]) by smtp.gmail.com with ESMTPSA id\n\tl2-20020a1ced02000000b003f19b3d89e9sm1930941wmh.33.2023.05.03.06.30.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 May 2023 06:30:29 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683120635;\n\tbh=+s0k2qniaui7Hy+EXa2tEL7jztq8qEtYlTNKxDvBMlo=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tPm83+YEFBR9nCWzg2gzsr52Qi0OyfEaiy2RZRWd1ulxEVNVHiBjd4V984XnOUOyv\n\txiCdlLefv+rRN5l1ACZscc3aqzexqLNdYOcOAAr8qdGjLQzVtrdb8tzIxqN5P7RvMv\n\tGktYVhg8LZJMjV1ORAo5VsL6eJaixv42EiUOYYLz76M7782+4WtU2YZHAtUv3C4lJA\n\tgO8Jgf+6S1ASg+pamHJlJqrw/WukuFjukeFyV2jtzc+CXlJHlhg14wnUgAEbgj45t6\n\tipFDypvVmgDX+YIKjREYEWewDjX+OQWZmODv8OwcdPOAYNk3L4T7OHYhu0RgcaWVcl\n\tvo0+MWqaqXz0Q==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1683120633;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=49gqEwSwqj0q4B4t/S+1cwBvb+a3KGe+jMKiMsV3IrE=;\n\tb=GtddZeB/2j1wDsQVWj31YUJKNIcaXlGWny1abiJ8wOwz8j/hPcFpnT0CxUf4JZEJPdiV5d\n\t7015I5VKZHH7p4G5yYeeAYC/8PoOQ4ZGxJdnOdfHdfZhfObdpd9U6qbQ23LoVxWtYrftTw\n\tMm03cQuQdKJ6WQSUQG0SrlFt74caRM8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"GtddZeB/\"; \n\tdkim-atps=neutral","X-MC-Unique":"3GN5IVHqNcyV0cOEfsmTsQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1683120630; x=1685712630;\n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; \n\tbh=49gqEwSwqj0q4B4t/S+1cwBvb+a3KGe+jMKiMsV3IrE=;\n\tb=VsRPHY6OkwUMXwXH2aHMjkK8U5fi/5PoayL1JDAB41L4yrB2agHv4JzqXx0+jTj3NN\n\tHoQPCIxkvWl4R79lfS71ZPn+KrHBwnVS15nxpvdcRMkEE5fTrdqgdgVTki+82nDlX+U0\n\tgFv1mTmEaU5dCjGDhJnnkmCk9dcRMvim6Rrwr98GQ9Zs5HgmWNdt4QkENdUnkMr5tesJ\n\tsw/EXARjwniJ67vGs1zF2InNqi3J+MXg0ZBvSc4OT+SAPN5i76Eyc1ckpanO3uc9Cayz\n\tBfVIadnLN9sQOu+IDcWcDhfV56NpJwNnx2FW4ZZte+hRfMZjiGaX8qFAGmnFQD4s8XGf\n\tONTg==","X-Gm-Message-State":"AC+VfDzJPTDVqkX/vNp+0Q16tdnqG/R09O6KUWDcKT7h0fQhxjmg3bcc\n\tHl399fCHDvUjEOeBTrm4nRz/+gL1ixghuI6vqNzXc60b73myk2GEjMz7SvRfqaQTqAEQvydJSKB\n\tPbA5UsRZTNTJQ5LjopVOK+eB+U38fEU0e7g==","X-Received":["by 2002:a7b:c40f:0:b0:3f0:8034:f77e with SMTP id\n\tk15-20020a7bc40f000000b003f08034f77emr14483352wmi.20.1683120630132; \n\tWed, 03 May 2023 06:30:30 -0700 (PDT)","by 2002:a7b:c40f:0:b0:3f0:8034:f77e with SMTP id\n\tk15-20020a7bc40f000000b003f08034f77emr14483336wmi.20.1683120629772; \n\tWed, 03 May 2023 06:30:29 -0700 (PDT)"],"X-Google-Smtp-Source":"ACHHUZ438DgffjEUR6iHHrHHdMvULPwNwHuLoYq1b1ZWAU7a5ERL5XfAVZIJRLInM2t3aJ1x+n5nlw==","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20230503130604.GF32586@pendragon.ideasonboard.com>","References":"<20230501155507.116039-1-kieran.bingham@ideasonboard.com>\n\t<20230501155507.116039-3-kieran.bingham@ideasonboard.com>\n\t<d286ac12-b054-fec4-d52c-d303410555af@redhat.com>\n\t<20230503130604.GF32586@pendragon.ideasonboard.com>","Date":"Wed, 03 May 2023 15:30:28 +0200","Message-ID":"<87v8h9wnij.fsf@minerva.mail-host-address-is-not-set>","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 2/2] v4l2: Move the v4l2-compat to\n\tlibcamera/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Javier Martinez Canillas via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Javier Martinez Canillas <javierm@redhat.com>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]