[{"id":26982,"web_url":"https://patchwork.libcamera.org/comment/26982/","msgid":"<20230428022003.GA13163@pendragon.ideasonboard.com>","date":"2023-04-28T02:20:03","subject":"Re: [libcamera-devel] [PATCH v1] Documentation: guides:\n\tpipeline-handler: Fix spelling error","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Thu, Apr 27, 2023 at 08:45:15PM +0000, Barnabás Pőcze via libcamera-devel wrote:\n> Both {Camera,PipelineHandler}::generateConfiguration() take a list\n> of `StreamRole` objects, and not a list of `StreamRoles` objects.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index 7ac6e60c..e08bb72f 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -729,7 +729,7 @@ function.\n> .. _Camera::generateConfiguration(): https://libcamera.org/api-html/classlibcamera_1_1Camera.html#a25c80eb7fc9b1cf32692ce0c7f09991d\n> .. _PipelineHandler::generateConfiguration(): https://libcamera.org/api-html/classlibcamera_1_1PipelineHandler.html#a7932e87735695500ce1f8c7ae449b65b\n> \n> -Configurations are generated by receiving a list of ``StreamRoles`` instances,\n> +Configurations are generated by receiving a list of ``StreamRole`` instances,\n\nWe also have a StreamRoles class, but you're right, we mean StreamRole\nhere.\n\nReviewed-by: Laurent Pinchart \n\n> which libcamera uses as predefined ways an application intends to use a camera\n> (You can read the full list in the `StreamRole API`_ documentation). These are\n> optional hints on how an application intends to use a stream, and a pipeline","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5171BDCBD\n\tfor ;\n\tFri, 28 Apr 2023 02:19:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BE8E627E0;\n\tFri, 28 Apr 2023 04:19:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D168A627B7\n\tfor ;\n\tFri, 28 Apr 2023 04:19:52 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C436814;\n\tFri, 28 Apr 2023 04:19:39 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682648394;\n\tbh=x74oJN9Y5Vpu50q5Zp6NBPv3j5k51On9jPisP2cyItA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=s1lgaVsZQOFrWbzGhqrUkloRxbZ37bu/f0Qb0rNgqgGgFGcQAGEPPrX+TvPEL3Tja\n\ti+ELBzvLf0TlGsxBT2uh2+PmSYFwIHG1Xs7RoWdykrmuPOuj8uryPA8W/l3k3tV/CP\n\tYK2SWeXJi83lNRwK1/fJcNMKELlSxF9St4D+Tz+E4/Oz/2G71ukxPM4LcjPY5M4BWU\n\tou0do84RMF9RVUOUIwDs9HOJcaKy+0aVA53mmyes1m0bqvrlEWHAAnCMj9JDd/0U8o\n\ttn3LE7qHkRNbWNMPL1nhMgK75IVtvisr0lDy87UW4kzQ6AufbD2SqWy93JIrFKBdCd\n\tnpnf9rQHdKNAg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682648380;\n\tbh=x74oJN9Y5Vpu50q5Zp6NBPv3j5k51On9jPisP2cyItA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MDVsIjQ36SKol3l4hdZawKPRBWF0Y6inJJbH/2PLhRmc0iDOF7PddE6Jc0uIDbGE2\n\tAT5OIpKF3kyGOMUy4Jlg18kE+c0Hubsh2qAVAmEx8e7ISoWe8i3t+95wEHbV1ho9yn\n\tjZmCSaiRMfLtSqJGsgJRTb2HdMNZOcBaB8ma/bwo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MDVsIjQ3\"; dkim-atps=neutral","Date":"Fri, 28 Apr 2023 05:20:03 +0300","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Message-ID":"<20230428022003.GA13163@pendragon.ideasonboard.com>","References":"<20230427201254.322586-1-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20230427201254.322586-1-pobrn@protonmail.com>","Subject":"Re: [libcamera-devel] [PATCH v1] Documentation: guides:\n\tpipeline-handler: Fix spelling error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26984,"web_url":"https://patchwork.libcamera.org/comment/26984/","msgid":"","date":"2023-04-28T03:54:30","subject":"Re: [libcamera-devel] [PATCH v1] Documentation: guides:\n\tpipeline-handler: Fix spelling error","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nThank you for the patch\n\nOn 4/28/23 7:50 AM, Laurent Pinchart via libcamera-devel wrote:\n> Hi Barnabás,\n>\n> Thank you for the patch.\n>\n> On Thu, Apr 27, 2023 at 08:45:15PM +0000, Barnabás Pőcze via libcamera-devel wrote:\n>> Both {Camera,PipelineHandler}::generateConfiguration() take a list\n>> of `StreamRole` objects, and not a list of `StreamRoles` objects.\n>>\n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> Documentation/guides/pipeline-handler.rst | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n>> index 7ac6e60c..e08bb72f 100644\n>> --- a/Documentation/guides/pipeline-handler.rst\n>> +++ b/Documentation/guides/pipeline-handler.rst\n>> @@ -729,7 +729,7 @@ function.\n>> .. _Camera::generateConfiguration(): https://libcamera.org/api-html/classlibcamera_1_1Camera.html#a25c80eb7fc9b1cf32692ce0c7f09991d\n>> .. _PipelineHandler::generateConfiguration(): https://libcamera.org/api-html/classlibcamera_1_1PipelineHandler.html#a7932e87735695500ce1f8c7ae449b65b\n>>\n>> -Configurations are generated by receiving a list of ``StreamRoles`` instances,\n>> +Configurations are generated by receiving a list of ``StreamRole`` instances,\n> We also have a StreamRoles class, but you're right, we mean StreamRole\n> here.\n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n>\n>> which libcamera uses as predefined ways an application intends to use a camera\n>> (You can read the full list in the `StreamRole API`_ documentation). These are\n>> optional hints on how an application intends to use a stream, and a pipeline","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E9B2BDCBD\n\tfor ;\n\tFri, 28 Apr 2023 03:54:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D24CE627D4;\n\tFri, 28 Apr 2023 05:54:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B62261EAE\n\tfor ;\n\tFri, 28 Apr 2023 05:54:37 +0200 (CEST)","from [192.168.1.105] (unknown [103.86.18.160])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDE0C814;\n\tFri, 28 Apr 2023 05:54:23 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682654079;\n\tbh=elwMsf2KG4YC9OuRCA4hJh1j8rxK+2NiBQXnqq2dBDM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Zof4pfCKwBmy5CIcjRoi89TvJqXFPjw6ADmWD6RGEluELFVMs5/muNm958eHyH5aE\n\t75JI3Iy95u4hvD9cB6hYp0L5cZoMB5QJ6e9WrpTJjHugfjQ5Yc/rxcPKHTcf+WB+3t\n\tgPnNiUzstoJmlhtQEXMe2wxjEmvGnVHUqlbpMVYdwQP/7eA563efLpFvMrDATOAcsR\n\tKwMb4qTZrj80suZdwL1TWs9EyCaZ2kZstjXwd5kiuaWgAs5yGiTsnzRTgCddI/M3Hu\n\tSMMHUcsz8xO8We57l6XoQvZ5qG9mAUBuQVJahbv39NmBq63yfq+WcBbHearhZLuuB0\n\tydi0Rp12J2KNA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682654064;\n\tbh=elwMsf2KG4YC9OuRCA4hJh1j8rxK+2NiBQXnqq2dBDM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=ELG7P3NfMO4+wGT0pSv18//SoEVb/Rvq+FKG99Y/8oWPYUYeWpbs1dS7wHJQ6cTgR\n\t3tojWQelVwsGWzFrzHe+BxwgiihT6MnQdEMo0w0yCJWIjGOq4Uiiv+p3MeiAEQ4J2u\n\tY0v7nIMUHDRHJEUfwyFGlSswvryQQRCbdL4rLhLo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ELG7P3Nf\"; dkim-atps=neutral","Message-ID":"","Date":"Fri, 28 Apr 2023 09:24:30 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","To":"Laurent Pinchart , =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= ","References":"<20230427201254.322586-1-pobrn@protonmail.com>\n\t<20230428022003.GA13163@pendragon.ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20230428022003.GA13163@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1] Documentation: guides:\n\tpipeline-handler: Fix spelling error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]