[{"id":2571,"web_url":"https://patchwork.libcamera.org/comment/2571/","msgid":"<20190903201656.GA4788@pendragon.ideasonboard.com>","date":"2019-09-03T20:16:56","subject":"Re: [libcamera-devel] [PATCH v2 1/7] [TEMP] include: linux: Update\n\tv4l2-controls.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Aug 27, 2019 at 11:50:01AM +0200, Jacopo Mondi wrote:\n> Import a temporary version of the v4l2-controls.h with the newly added\n> definition of V4L2_CID_CAMERA_SENSOR_LOCATION control.\n> \n> This patch should be temporary applied waiting for the newly added\n> control to land in the mainline kernel version.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nAcked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  include/linux/v4l2-controls.h | 7 +++++++\n>  1 file changed, 7 insertions(+)\n> \n> diff --git a/include/linux/v4l2-controls.h b/include/linux/v4l2-controls.h\n> index 06479f2fb3ae..28061cde5303 100644\n> --- a/include/linux/v4l2-controls.h\n> +++ b/include/linux/v4l2-controls.h\n> @@ -881,6 +881,13 @@ enum v4l2_auto_focus_range {\n>  #define V4L2_CID_PAN_SPEED\t\t\t(V4L2_CID_CAMERA_CLASS_BASE+32)\n>  #define V4L2_CID_TILT_SPEED\t\t\t(V4L2_CID_CAMERA_CLASS_BASE+33)\n>  \n> +#define V4L2_CID_CAMERA_SENSOR_LOCATION\t\t(V4L2_CID_CAMERA_CLASS_BASE+34)\n> +#define V4L2_LOCATION_FRONT\t\t\t0\n> +#define V4L2_LOCATION_BACK\t\t\t1\n> +#define V4L2_LOCATION_EXTERNAL\t\t\t2\n> +\n> +#define V4L2_CID_CAMERA_SENSOR_ROTATION\t\t(V4L2_CID_CAMERA_CLASS_BASE+35)\n> +\n>  /* FM Modulator class control IDs */\n>  \n>  #define V4L2_CID_FM_TX_CLASS_BASE\t\t(V4L2_CTRL_CLASS_FM_TX | 0x900)","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EC0460BCF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  3 Sep 2019 22:17:04 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-18-41-nat.elisa-mobile.fi\n\t[85.76.18.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C733542;\n\tTue,  3 Sep 2019 22:17:03 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567541823;\n\tbh=rjACnPS0u4Ca6RKt6bc8iAVEvDB6t2o4ALvZfEhRBto=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vIca0V44UqcdaWb8UwMKATAX77V+3KtRmLrC4KVSV6pbyELvBNUgLimRnT8AeyRl/\n\tfzDgy9DrcZWsrCxV9r61ndjgxjCGvCy3uQhTUomtxJ9qHWVHO9td1DJ8evAkeVEJgp\n\t9FxHH+7oEUaOJ5MkUwsskOQ6kW3P8eEu/E9SJqj8=","Date":"Tue, 3 Sep 2019 23:16:56 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190903201656.GA4788@pendragon.ideasonboard.com>","References":"<20190827095008.11405-1-jacopo@jmondi.org>\n\t<20190827095008.11405-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190827095008.11405-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 1/7] [TEMP] include: linux: Update\n\tv4l2-controls.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 03 Sep 2019 20:17:04 -0000"}}]