[{"id":2504,"web_url":"https://patchwork.libcamera.org/comment/2504/","msgid":"<20190822092929.3flzicukan3xfppm@uno.localdomain>","date":"2019-08-22T09:29:29","subject":"Re: [libcamera-devel] [PATCH] meson: Rename 'tests' option to 'test'","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Aug 22, 2019 at 12:09:50PM +0300, Laurent Pinchart wrote:\n> The 'tests' option enables compilation of tests. On Gentoo and Chrome\n> OS, the corresponding package USE flag is named 'test'. Rename the\n> option to 'test' to bring it in line.\n\nSeems reasonable to me to have the two flag names in sync.\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n> We could also handle this in the libcamera ebuilds, but I think bringing\n> the option name in line with common practices is a good idea. Any\n> preference from anyone ?\n>\n>  meson.build       | 2 +-\n>  meson_options.txt | 2 +-\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/meson.build b/meson.build\n> index 5201a2f5d78b..72ad7c8b493b 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -73,7 +73,7 @@ if get_option('documentation')\n>      subdir('Documentation')\n>  endif\n>\n> -if get_option('tests')\n> +if get_option('test')\n>      subdir('test')\n>  endif\n>\n> diff --git a/meson_options.txt b/meson_options.txt\n> index 2d78b8d91f9c..1a328045306c 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -7,6 +7,6 @@ option('documentation',\n>          type : 'boolean',\n>          description : 'Generate the project documentation')\n>\n> -option('tests',\n> +option('test',\n>          type : 'boolean',\n>          description: 'Compile and include the tests')\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29FF560C05\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Aug 2019 11:28:02 +0200 (CEST)","from uno.localdomain (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 90197C0007;\n\tThu, 22 Aug 2019 09:28:01 +0000 (UTC)"],"X-Originating-IP":"87.18.63.98","Date":"Thu, 22 Aug 2019 11:29:29 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190822092929.3flzicukan3xfppm@uno.localdomain>","References":"<20190822090950.7632-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"npyj3lgcemndrar6\"","Content-Disposition":"inline","In-Reply-To":"<20190822090950.7632-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] meson: Rename 'tests' option to 'test'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 22 Aug 2019 09:28:02 -0000"}}]