[{"id":26922,"web_url":"https://patchwork.libcamera.org/comment/26922/","msgid":"<20230424005822.GO21943@pendragon.ideasonboard.com>","date":"2023-04-24T00:58:22","subject":"Re: [libcamera-devel] [PATCH 2/3] apps: cam: kms_sink: Drop\n\tunique_ptr<> from DRM::AtomicRequest","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Mon, Apr 24, 2023 at 02:09:30AM +0530, Umang Jain via libcamera-devel wrote:\n> There is no need to wrap DRM::AtomicRequest in std::unique_ptr<>\n> in KMSSink::start(). Remove it so that the syntax becomes similar to\n> what we have in KMSSink::stop().\n> \n> No functional changes intended.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/apps/cam/kms_sink.cpp | 12 +++++-------\n> 1 file changed, 5 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\n> index a508977d..2aefec06 100644\n> --- a/src/apps/cam/kms_sink.cpp\n> +++ b/src/apps/cam/kms_sink.cpp\n> @@ -302,24 +302,22 @@ int KMSSink::configurePipeline(const libcamera::PixelFormat &format)\n> \n> int KMSSink::start()\n> {\n> -\tstd::unique_ptr request;\n> +\tDRM::AtomicRequest request(&dev_);\n\nWhile at it, I would move this..\n\n> \n> \tint ret = FrameSink::start();\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> \t/* Disable all CRTCs and planes to start from a known valid state. */\n> -\trequest = std::make_unique(&dev_);\n\n... here.\n\nReviewed-by: Laurent Pinchart \n\n> -\n> \tfor (const DRM::Crtc &crtc : dev_.crtcs())\n> -\t\trequest->addProperty(&crtc, \"ACTIVE\", 0);\n> +\t\trequest.addProperty(&crtc, \"ACTIVE\", 0);\n> \n> \tfor (const DRM::Plane &plane : dev_.planes()) {\n> -\t\trequest->addProperty(&plane, \"CRTC_ID\", 0);\n> -\t\trequest->addProperty(&plane, \"FB_ID\", 0);\n> +\t\trequest.addProperty(&plane, \"CRTC_ID\", 0);\n> +\t\trequest.addProperty(&plane, \"FB_ID\", 0);\n> \t}\n> \n> -\tret = request->commit(DRM::AtomicRequest::FlagAllowModeset);\n> +\tret = request.commit(DRM::AtomicRequest::FlagAllowModeset);\n> \tif (ret < 0) {\n> \t\tstd::cerr\n> \t\t\t<< \"Failed to disable CRTCs and planes: \"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB199C3272\n\tfor ;\n\tMon, 24 Apr 2023 00:58:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D8B0627D5;\n\tMon, 24 Apr 2023 02:58:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08B36603A0\n\tfor ;\n\tMon, 24 Apr 2023 02:58:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 055B0A1A;\n\tMon, 24 Apr 2023 02:57:58 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682297893;\n\tbh=dvmuuF4nx7eyqOY6ZdignNb2dkwmrFM1BoH9UhzFqzU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cOnEzXudsfEevm66PD4UCaiLi/4gx3Ly9+V42WVOxRqwrHpm3Z7gjKvvReYXTz1rM\n\taFISZ7SQcrv8eUaA7GtWbdH4WA7aNl/gNG0yu8oD7N9wr2HQBg/OJXgsgXq5qWUKLG\n\tREKeJ+Qgta/39JwB9MGP1z+KpkT3F6cquvgZTdHDehh/nEFP13xGigRMl2RwwRvs4l\n\tyGnXsJqpiUfdsb220VbFUJ+5hyLqOx64aHyq/id+L0N/SwOVdNYKMWoalApTr/m/Xc\n\tXVetV8H0eXQQUt9akKb7IPZQg1nvRgPtlxiIxxu88IBSngExvIpQvL6nrQlJF8AQdp\n\tg8Lyp2skSYLZA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682297880;\n\tbh=dvmuuF4nx7eyqOY6ZdignNb2dkwmrFM1BoH9UhzFqzU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Pxhj6x+lYcPxmoa+HMW0joJaWlGxL8QdUxVrpLM1ye8WzutwI3fXKscbumGbs1tcV\n\tfE2DBzw72ZytMCX3co5wSBW9BSrHhESE/BCl9XoWKWF2H52B58kTC97oQXlKQmtmuq\n\trBw4TfhPX4boktYKoCyTP/5jCO2LXxGWC4e7veys="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Pxhj6x+l\"; dkim-atps=neutral","Date":"Mon, 24 Apr 2023 03:58:22 +0300","To":"Umang Jain ","Message-ID":"<20230424005822.GO21943@pendragon.ideasonboard.com>","References":"<20230423203931.108022-1-umang.jain@ideasonboard.com>\n\t<20230423203931.108022-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230423203931.108022-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] apps: cam: kms_sink: Drop\n\tunique_ptr<> from DRM::AtomicRequest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26931,"web_url":"https://patchwork.libcamera.org/comment/26931/","msgid":"<168232809675.2445904.17728547070761228420@Monstersaurus>","date":"2023-04-24T09:21:36","subject":"Re: [libcamera-devel] [PATCH 2/3] apps: cam: kms_sink: Drop\n\tunique_ptr<> from DRM::AtomicRequest","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-04-24 01:58:22)\n> Hi Umang,\n> \n> Thank you for the patch.\n> \n> On Mon, Apr 24, 2023 at 02:09:30AM +0530, Umang Jain via libcamera-devel wrote:\n> > There is no need to wrap DRM::AtomicRequest in std::unique_ptr<>\n> > in KMSSink::start(). Remove it so that the syntax becomes similar to\n> > what we have in KMSSink::stop().\n> > \n> > No functional changes intended.\n> > \n> > Signed-off-by: Umang Jain \n> > ---\n> > src/apps/cam/kms_sink.cpp | 12 +++++-------\n> > 1 file changed, 5 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\n> > index a508977d..2aefec06 100644\n> > --- a/src/apps/cam/kms_sink.cpp\n> > +++ b/src/apps/cam/kms_sink.cpp\n> > @@ -302,24 +302,22 @@ int KMSSink::configurePipeline(const libcamera::PixelFormat &format)\n> > \n> > int KMSSink::start()\n> > {\n> > - std::unique_ptr request;\n> > + DRM::AtomicRequest request(&dev_);\n> \n> While at it, I would move this..\n> \n> > \n> > int ret = FrameSink::start();\n> > if (ret < 0)\n> > return ret;\n> > \n> > /* Disable all CRTCs and planes to start from a known valid state. */\n> > - request = std::make_unique(&dev_);\n> \n> ... here.\n> \n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\nIt looks like this patch could be merged independently too.\n\n--\nKieran\n\n\n\n> \n> > -\n> > for (const DRM::Crtc &crtc : dev_.crtcs())\n> > - request->addProperty(&crtc, \"ACTIVE\", 0);\n> > + request.addProperty(&crtc, \"ACTIVE\", 0);\n> > \n> > for (const DRM::Plane &plane : dev_.planes()) {\n> > - request->addProperty(&plane, \"CRTC_ID\", 0);\n> > - request->addProperty(&plane, \"FB_ID\", 0);\n> > + request.addProperty(&plane, \"CRTC_ID\", 0);\n> > + request.addProperty(&plane, \"FB_ID\", 0);\n> > }\n> > \n> > - ret = request->commit(DRM::AtomicRequest::FlagAllowModeset);\n> > + ret = request.commit(DRM::AtomicRequest::FlagAllowModeset);\n> > if (ret < 0) {\n> > std::cerr\n> > << \"Failed to disable CRTCs and planes: \"\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B90CEBE173\n\tfor ;\n\tMon, 24 Apr 2023 09:21:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24742627D1;\n\tMon, 24 Apr 2023 11:21:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 141BF627C4\n\tfor ;\n\tMon, 24 Apr 2023 11:21:40 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB1389DE;\n\tMon, 24 Apr 2023 11:21:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682328102;\n\tbh=dM04aASIchOmLHVj/NeOk6Ay4OimmKQDpmX5MJSaFh8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vpJFAYh7YVOiW/KYw49bnyx7SkGwgQUXofi5ZFD8yv81C1++fAYC06EoatG6CmDg3\n\tUoYKhZ/LYFOrhKJLHcxed66D43s7SxsQ2/GXwgyYObH7P2uEWwEMkVYPJNWP4ZGu4e\n\tM0fEcaVPSltRoLLqMwbqd/Ri6dAbAWjAn93AJ04FKz2k20bykg8+JN3JbF2pDWIxDG\n\tKhaMIf0dErO0EwcZ8qNJC6fR1PzNRugQm9gwwtghygF8HW6pMsLtR3BlmgfVek/r7M\n\t8XWZ2e/Hdh9jvRWXZj0JOqDdqPkeu9n0xXWQRf6Yx/6qsD7SRmtqu4zucAYGxrEFWU\n\tB2QKeIrI/KNbA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682328090;\n\tbh=dM04aASIchOmLHVj/NeOk6Ay4OimmKQDpmX5MJSaFh8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=auOaEqEajb1WYHp4rSxSUoTLAE2UIN1JHIVcDGug3IpMv9c/iv4RmnA/ef+NvaCeE\n\te21m6+yw3TFNLeWTQB62rytzAREVBIZFkoRb8gh6Tj+F71Y9XwxaFeFW2SlkmXh/oX\n\tJ9NesFKceb/pxMll3zNFpF44tue0OZu16KDVxi18="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"auOaEqEa\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230424005822.GO21943@pendragon.ideasonboard.com>","References":"<20230423203931.108022-1-umang.jain@ideasonboard.com>\n\t<20230423203931.108022-3-umang.jain@ideasonboard.com>\n\t<20230424005822.GO21943@pendragon.ideasonboard.com>","To":"Laurent Pinchart ,\n\tLaurent Pinchart via libcamera-devel\n\t, \n\tUmang Jain ","Date":"Mon, 24 Apr 2023 10:21:36 +0100","Message-ID":"<168232809675.2445904.17728547070761228420@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/3] apps: cam: kms_sink: Drop\n\tunique_ptr<> from DRM::AtomicRequest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]