[{"id":27031,"web_url":"https://patchwork.libcamera.org/comment/27031/","msgid":"","date":"2023-05-03T13:58:58","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register\n\tdevice numbers with camera","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2023. április 19., szerda 10:58 keltezéssel, Kieran Bingham via libcamera-devel írta:\n\n> Register the identified device numbers with each camera as the Devices\n> property.\n> \n> This facilitates camera daemons or other systems to identify which\n> devices are being managed by libcamera, and can prevent duplication of\n> camera resources.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline_handler.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index f72613b8e515..66e7def51cd1 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -18,6 +18,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> @@ -624,6 +625,13 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> \t\t}\n> \t}\n> \n> +\t/*\n> +\t * Store the associated devices as a property of the camera to allow\n> +\t * systems to identify which devices are managed by libcamera.\n> +\t */\n> +\tCamera::Private *data = camera->_d();\n> +\tdata->properties_.set(properties::Devices, devnums);\n\nI am getting an assertion failure while testing https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1611\n\n ASSERT(elementSize == ControlValueSize[type]);\n\nin `controls.cpp:ControlValue::set()` fails because `sizeof(dev_t) != 4`.\n\n\n> +\n> \tmanager_->addCamera(std::move(camera), devnums);\n> }\n> \n> --\n> 2.34.1\n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0AEDC0DA4\n\tfor ;\n\tWed, 3 May 2023 13:59:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6AD27633B4;\n\tWed, 3 May 2023 15:59:12 +0200 (CEST)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7C3F61EAF\n\tfor ;\n\tWed, 3 May 2023 15:59:09 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683122352;\n\tbh=yTygdUSFVT5+Ac6JPCJN/aU2R0nkt9fImwyjO2N+GvY=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XlcexpSx4cpTOr0IY6LVuHnHrVyKo7yZj7kslhTVB0rYptDBWXwYI3vh5UXtZTD8S\n\tjQmoMG6Th+YW1mE3f9o1PY2Gpwgexku7gKhLWxBmUW+Cj6GVlJfgujtgO8EUN65h/F\n\t3gGmspHVy3imbvcoOJb3gKNldTXy7gZfrb3RI94q/HhTrxgq3u4BViCOiN0IE1lsfT\n\tedTMPRtWOGQGzDi1+2iS8VAHMuPtwEPD3poR7y8/FjkdPuLSlRiXNq1p3TL23lQoj+\n\ttE/FU0ozX5mN1PzoIKkGc2UL13OXJ7OFCPfc1sGjnh8k5uvM9NtoMehdoL9SDPW/u2\n\tgwFvyVUYuAfDA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1683122349; x=1683381549;\n\tbh=pxANYKh5HUchofMquqinOntvHsxi+whhPGR0Gs9cwNM=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=t5aooJG8zFS7nQ+77ynKgp0cLVBGzWUMV4pA4aMinZ1uAe43LGar1tTwPOWL67AVu\n\t5RvMOt5r/zsjMb/4j/JfsNkRqJoVekuOtW/4J/XFhm/GLeQ79IkCiVOyatZC6XaN1C\n\tv4htIW7OGnyHoCaHO54JT6aZ9sryUX29rmCJqGHsvsGO2YOQ1hKTOVUOQ6oZEQ42Fb\n\tgL3LqlB8Ly/2DLB9kVBub0OgMJA0VbFhLMISgzFYAQ9kcdIcL4HX3SRw0vd50klc50\n\tg73QfGmdFm2Po15Sla+uhXIC2AJ1L+2ty5agBEPXAUGPS36lrKWwU3mxZHQ2ookdEs\n\tZRidqNvN7jpZg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"t5aooJG8\"; dkim-atps=neutral","Date":"Wed, 03 May 2023 13:58:58 +0000","To":"Kieran Bingham ","Message-ID":"","In-Reply-To":"<20230419085821.2682901-4-kieran.bingham@ideasonboard.com>","References":"<20230419085821.2682901-1-kieran.bingham@ideasonboard.com>\n\t<20230419085821.2682901-4-kieran.bingham@ideasonboard.com>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register\n\tdevice numbers with camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27032,"web_url":"https://patchwork.libcamera.org/comment/27032/","msgid":"<168312255978.30031.6567726247388293871@Monstersaurus>","date":"2023-05-03T14:02:39","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register\n\tdevice numbers with camera","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2023-05-03 14:58:58)\n> Hi\n> \n> \n> 2023. április 19., szerda 10:58 keltezéssel, Kieran Bingham via libcamera-devel írta:\n> \n> > Register the identified device numbers with each camera as the Devices\n> > property.\n> > \n> > This facilitates camera daemons or other systems to identify which\n> > devices are being managed by libcamera, and can prevent duplication of\n> > camera resources.\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/pipeline_handler.cpp | 8 ++++++++\n> > 1 file changed, 8 insertions(+)\n> > \n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index f72613b8e515..66e7def51cd1 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -18,6 +18,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > \n> > #include \"libcamera/internal/camera.h\"\n> > #include \"libcamera/internal/device_enumerator.h\"\n> > @@ -624,6 +625,13 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> > }\n> > }\n> > \n> > + /*\n> > + * Store the associated devices as a property of the camera to allow\n> > + * systems to identify which devices are managed by libcamera.\n> > + */\n> > + Camera::Private *data = camera->_d();\n> > + data->properties_.set(properties::Devices, devnums);\n> \n> I am getting an assertion failure while testing https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1611\n> \n> ASSERT(elementSize == ControlValueSize[type]);\n> \n> in `controls.cpp:ControlValue::set()` fails because `sizeof(dev_t) != 4`.\n\nYes, this is fixed ready for a V2 ... but the first patch needs to use a\n64 bit integer, not a 32 bit.\n\n> \n> \n> > +\n> > manager_->addCamera(std::move(camera), devnums);\n> > }\n> > \n> > --\n> > 2.34.1\n> \n> \n> Regards,\n> Barnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2CA2BD16B\n\tfor ;\n\tWed, 3 May 2023 14:02:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40CAC627DE;\n\tWed, 3 May 2023 16:02:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F00F61EAF\n\tfor ;\n\tWed, 3 May 2023 16:02:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 09DE8BC;\n\tWed, 3 May 2023 16:02:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683122565;\n\tbh=penbNLI4wf6I+7VhcO9Y383qzbVlyevJZdockmxHCzA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Pud3EPVmer2oDcs3a3Ks6zpUBZck4wrCgbZkQKOj5JLG8bct0r9bG8TJmz8tcIW12\n\t7NPdVp7Yf5WcC5+VgiuoBS9dXk5v/7eHyZ7UXmNLB2tioQluy5h1hKMKuUN7mceJO1\n\tGVdsbr2jZrfG6Ffgg1Au4Ptt8maq5K2XSQhr4WH1SYquwWAdOLSYpMOCQ+ZCnhnw4x\n\tW41zPXR5vsBCpvH9QQuiaotLNSVLo0BQl8TlbYA21aIgLvCPdsq15RVFhia4I835rw\n\tsGTxD96zkjv48zIzO914f1k4SF6KwFB/VvXN6Exr4GRFlKdHAahu7oniVqgzOFnbfV\n\tNk/9MF+2c1/Pw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683122560;\n\tbh=penbNLI4wf6I+7VhcO9Y383qzbVlyevJZdockmxHCzA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=NLII201UaFfB2586edU05yBhmhwvMYYTE5SAElpppL57yTAFpSxscBPaYM+R76gtx\n\t2R39Dv7MM/+L8OC35oJKA3aFr7n54zHsbBCrwv7Y2qZWTwf+zOvAbPWHGdOYkaIeT1\n\tlSxOzPSoogfN28a5NDVeO+l65KtvQBQl3znJscUU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NLII201U\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20230419085821.2682901-1-kieran.bingham@ideasonboard.com>\n\t<20230419085821.2682901-4-kieran.bingham@ideasonboard.com>\n\t","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Date":"Wed, 03 May 2023 15:02:39 +0100","Message-ID":"<168312255978.30031.6567726247388293871@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register\n\tdevice numbers with camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27036,"web_url":"https://patchwork.libcamera.org/comment/27036/","msgid":"<1rJDTFp_a4oqRuHVpAphvehQCl91dT8dmuYu0uThITZeObj_IIEwARSkOZ0sLVk4A1fF7N5DkuI4tbbVnh_cULpow-rme_fbvpnPAHlunX0=@protonmail.com>","date":"2023-05-03T15:12:30","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register\n\tdevice numbers with camera","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2023. május 3., szerda 16:02 keltezéssel, Kieran Bingham írta:\n\n> [...]\n> > > + /*\n> > > + * Store the associated devices as a property of the camera to allow\n> > > + * systems to identify which devices are managed by libcamera.\n> > > + */\n> > > + Camera::Private *data = camera->_d();\n> > > + data->properties_.set(properties::Devices, devnums);\n> >\n> > I am getting an assertion failure while testing https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1611\n> >\n> > ASSERT(elementSize == ControlValueSize[type]);\n> >\n> > in `controls.cpp:ControlValue::set()` fails because `sizeof(dev_t) != 4`.\n> \n> Yes, this is fixed ready for a V2 ... but the first patch needs to use a\n> 64 bit integer, not a 32 bit.\n\nI see, thanks for the clarification. These patches were linked in the pipewire MR\nand I couldn't find a newer version. I presume it is not posted yet? As far as I\nam aware `dev_t` is 64-bit on most(?) Linux platforms, so I don't understand\nthe remark regarding the first patch.\n\n\n> [...]\n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5965BD16B\n\tfor ;\n\tWed, 3 May 2023 15:12:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 312E9633B4;\n\tWed, 3 May 2023 17:12:44 +0200 (CEST)","from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3630A61EAF\n\tfor ;\n\tWed, 3 May 2023 17:12:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683126764;\n\tbh=GbtH+RqjnzW/NlC+x95do4htMnDWNExKtZ29TXW+B2U=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PUaCxQjY2C4jTeaCS3LPzdkt8iLuXfykapUV04pTJc9Hs4nGTax0jS5+9qTUK22Z+\n\tb/Y9NGjYoBhIJMm6VCmtSz2k7djWsI5TtXO5F6mAh5O9e2L2enuOkynJinBo6EsanY\n\t3vYCD5WY5MpLfE+BrfdZkHvXV/xVfwkKkxyuUhHRNzY1T59Y/VnjFW4zjKrzcez+QT\n\tMXziFZJlL3XCPPipdpW0Bo6w9SYIdmgS1NnqX/T+0riFylN2V6DdQTZdtSmtTN4gYz\n\teX1x4OuEfifwpDWbSUEbwc9kTc1PCz52DWDXpX7xcmeZzuKv4jzlELz0lg7oppoz60\n\tkv8P1J1SBsO/w==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1683126762; x=1683385962;\n\tbh=KwUZ9evxd7htB7dUQjJTPgibsLQCh3gYKj3RkQZEPZk=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=zJgishOnKOd4T9fP98Ux9l9rffzfplVgzUfwYoTPBxNXH3hXGFkQzsXNyXxRFpYyd\n\tSrhVgE5bYBn7xRqRITn8nHNZZZCM1SIYmZVxCeeA0r6xHve5rNX1IzDqKbsH0jaO9I\n\t+yxhj9Vi01px5oF/ia/jSfdcM1MB2rJRioOcRouRckLy8l8Z9TOTBEhEDAuE0wNiSU\n\tGsSxF2L0q5kvy3HwZzUey/yoepXEQlWQL47aR7VgKUiGc4KFTTaVWZ0zkdaCz1mi/z\n\tN0A7E5TdOAsh4PVKf2XJKhEyqbzOPlhBtDCRoK2uSbCE4oL5FAsAltDa7Q8EXFfv1g\n\tE4ouMw3FeUhFg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"zJgishOn\"; dkim-atps=neutral","Date":"Wed, 03 May 2023 15:12:30 +0000","To":"Kieran Bingham ","Message-ID":"<1rJDTFp_a4oqRuHVpAphvehQCl91dT8dmuYu0uThITZeObj_IIEwARSkOZ0sLVk4A1fF7N5DkuI4tbbVnh_cULpow-rme_fbvpnPAHlunX0=@protonmail.com>","In-Reply-To":"<168312255978.30031.6567726247388293871@Monstersaurus>","References":"<20230419085821.2682901-1-kieran.bingham@ideasonboard.com>\n\t<20230419085821.2682901-4-kieran.bingham@ideasonboard.com>\n\t\n\t<168312255978.30031.6567726247388293871@Monstersaurus>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register\n\tdevice numbers with camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27038,"web_url":"https://patchwork.libcamera.org/comment/27038/","msgid":"<168313210172.30031.10228007352120140937@Monstersaurus>","date":"2023-05-03T16:41:41","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register\n\tdevice numbers with camera","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2023-05-03 16:12:30)\n> Hi\n> \n> \n> 2023. május 3., szerda 16:02 keltezéssel, Kieran Bingham írta:\n> \n> > [...]\n> > > > + /*\n> > > > + * Store the associated devices as a property of the camera to allow\n> > > > + * systems to identify which devices are managed by libcamera.\n> > > > + */\n> > > > + Camera::Private *data = camera->_d();\n> > > > + data->properties_.set(properties::Devices, devnums);\n> > >\n> > > I am getting an assertion failure while testing https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1611\n> > >\n> > > ASSERT(elementSize == ControlValueSize[type]);\n> > >\n> > > in `controls.cpp:ControlValue::set()` fails because `sizeof(dev_t) != 4`.\n> > \n> > Yes, this is fixed ready for a V2 ... but the first patch needs to use a\n> > 64 bit integer, not a 32 bit.\n> \n> I see, thanks for the clarification. These patches were linked in the pipewire MR\n> and I couldn't find a newer version. I presume it is not posted yet? As far as I\n> am aware `dev_t` is 64-bit on most(?) Linux platforms, so I don't understand\n> the remark regarding the first patch.\n\nCorrect, I have a new version here but haven't posted yet. It's on my\ntodo as soon as I can get to it!\n\nI was referring to \"libcamera: controls: Support dev_t in an Integer32 type.\"\n\nWhen I looked up dev_t 'man makedev' I think I was confused by the\nreferences to unsigned int on the parameters of makedev, and return\ntypes of major() and minor() ... but dev_t is separate. Anyway, I\nclearly have sent untested patches which I'm sorry for.\n\nI wish we had a system where automated tests ran as soon as things are\npushed/posted that would have highlighted it immediately!\n\nV2 will resolve it.\n\n> \n> \n> > [...]\n> \n> \n> Regards,\n> Barnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDBA5BD16B\n\tfor ;\n\tWed, 3 May 2023 16:41:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71845633B4;\n\tWed, 3 May 2023 18:41:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 753B561EAF\n\tfor ;\n\tWed, 3 May 2023 18:41:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83F39BC;\n\tWed, 3 May 2023 18:41:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1683132105;\n\tbh=DZA4NvOb/2r+XC519NrTkKuNVKjZLLjcYU4hic5H8zQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CU8hAtcFYzt78WlG6IgK2whbTkzQy65r2fFA55PnniXFx1pySByQWAG6SdkpEPDqx\n\tVrbFMxyaSV6heOXhgymUnWBEf/Xhg1llJpKMMJWegrn4jMhaJVUP6tRAWFsD6oiJAQ\n\tLyYky7qLfXHtlgaDhDmPHLziJ8pK2pNsMHPy2qZcdXIy8PmNZZRGAvelc6Lcw+0If5\n\tLuygueiKcu+gWVHcK+PKDNbULVD1swXcWC66NfuNNKTYjud4ZTII9a8Q15j+sgL9g3\n\t2Ej7jVfsrMBz12Ij9wtomf5aNR20VMDNUf5x1ytZJWc9S44i39g1xu0n7YTQzF+ETM\n\t38tgr+4Z8CkPw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1683132101;\n\tbh=DZA4NvOb/2r+XC519NrTkKuNVKjZLLjcYU4hic5H8zQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vunbbx3e0bSDN/DLfBlknm8mQMK1TCJdynFi2eL1fx0pDfmoVUnhRRslRx1hkL0Cr\n\tVHtToz1fWc/TskebPFBU2x1MQKNiJeKym5MYjXvENm5rCOv3d078B8gTPQIj6CxSnE\n\t73+3RcTSa+fSoDVkRJithtCL4KjcxXba8INbW8X4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vunbbx3e\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<1rJDTFp_a4oqRuHVpAphvehQCl91dT8dmuYu0uThITZeObj_IIEwARSkOZ0sLVk4A1fF7N5DkuI4tbbVnh_cULpow-rme_fbvpnPAHlunX0=@protonmail.com>","References":"<20230419085821.2682901-1-kieran.bingham@ideasonboard.com>\n\t<20230419085821.2682901-4-kieran.bingham@ideasonboard.com>\n\t\n\t<168312255978.30031.6567726247388293871@Monstersaurus>\n\t<1rJDTFp_a4oqRuHVpAphvehQCl91dT8dmuYu0uThITZeObj_IIEwARSkOZ0sLVk4A1fF7N5DkuI4tbbVnh_cULpow-rme_fbvpnPAHlunX0=@protonmail.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Date":"Wed, 03 May 2023 17:41:41 +0100","Message-ID":"<168313210172.30031.10228007352120140937@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register\n\tdevice numbers with camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]