{"id":18535,"url":"https://patchwork.libcamera.org/api/patches/18535/?format=json","web_url":"https://patchwork.libcamera.org/patch/18535/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230415205742.268255-1-pobrn@protonmail.com>","date":"2023-04-15T21:03:40","name":"[libcamera-devel,RFC,v1] libcamera: device_enumerator_udev: remove devnum from dependency map","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d7b017e9857d499544830b11cf3f9c52280ca546","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18535/mbox/","series":[{"id":3840,"url":"https://patchwork.libcamera.org/api/series/3840/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3840","date":"2023-04-15T21:03:40","name":"[libcamera-devel,RFC,v1] libcamera: device_enumerator_udev: remove devnum from dependency map","version":1,"mbox":"https://patchwork.libcamera.org/series/3840/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18535/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18535/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E788BE173\n\tfor ;\n\tSat, 15 Apr 2023 21:03:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB84C627B8;\n\tSat, 15 Apr 2023 23:03:53 +0200 (CEST)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C33D4627B2\n\tfor ;\n\tSat, 15 Apr 2023 23:03:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1681592633;\n\tbh=yreNef4YxR2dxJGWClW019xCueNnCI5G7J9OlIALz0s=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=xkzSCaXT55RFebparj2NiS5qG0xbIIUPIS9+S98zSCIgBQLXt38xt57RaowQXhLS1\n\te1nrolcs0YebGs+IhV+d7MVtOkMBh83F5pAWg6S82D32qo+/XJ203aFJJ7Kt+nJG+H\n\tveMQv35/Mvlevh/IOZj36KXUre+Nw3un7bV86AR++MLG1s1/apGJt1u4sx+JyUmaV9\n\tSNlKQsrLwTItCfjK6bU7OABaI0X7z01t+hjXqThfKfDDadsHHCbxgIhvAuwio2G+hn\n\tAsg9fV9sujL52rvYup8qltMwnH+rCutvejxtI98HSO5ra+l5t0DmAb0udtvPQK13ml\n\tcD9b5DasAOCMg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1681592631; x=1681851831;\n\tbh=yreNef4YxR2dxJGWClW019xCueNnCI5G7J9OlIALz0s=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=MDb/ihS/3ot1X8dDSbn31cSS1U+pw6MMGZ0EGuP++b4xh5oD0IL06235gmI4gh3/V\n\t9SgOsfHEHSE+pqpDsZLP1Cr8LFfUxEAZ9lU0fq3fq690blz2X89mXAFynC5BY4MlVC\n\tI79fvj3hPruGJ1oyphRnPM7ds8tD8b4iOQl/+llA22IhQKc8EEVAe6BxUERTljhQFi\n\tQjeZEaaVdxa9T5A2bbDv0o2iwD5fl4wOdE3z6eqDPT+5rccXpqpl/9/dcZNyO4A/5Y\n\tm+Fg7XVW5sKPCgg7701cUUqxrOC9GQDy8XrSt5YhcjGrL6bWvfHr7ekbckoSKZDkMl\n\tCOOIYKhHXRMfQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"MDb/ihS/\"; dkim-atps=neutral","Date":"Sat, 15 Apr 2023 21:03:40 +0000","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20230415205742.268255-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"[libcamera-devel] [RFC PATCH v1] libcamera: device_enumerator_udev:\n\tremove devnum from dependency map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Previously, after `addV4L2Device()` had seen all dependecies, it would\nremove the `MediaDeviceDeps` object from the `pending_` list, which\nwould result in it being destroyed. However, there would still be\n(dangling) pointers to this object in `devMap_` that were added in\n`addUdevDevice()` (line 103). So remove the entry with the given\ndevnum when it is removed from the corresponding `MediaDeviceDeps`\nobject.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/device_enumerator_udev.cpp | 1 +\n 1 file changed, 1 insertion(+)\n\n--\n2.40.0","diff":"diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\nindex 5317afbd..a63cd360 100644\n--- a/src/libcamera/device_enumerator_udev.cpp\n+++ b/src/libcamera/device_enumerator_udev.cpp\n@@ -315,6 +315,7 @@ int DeviceEnumeratorUdev::addV4L2Device(dev_t devnum)\n \t * enumerator.\n \t */\n \tdeps->deps_.erase(devnum);\n+\tdevMap_.erase(it);\n\n \tif (deps->deps_.empty()) {\n \t\tLOG(DeviceEnumerator, Debug)\n","prefixes":["libcamera-devel","RFC","v1"]}