[{"id":26864,"web_url":"https://patchwork.libcamera.org/comment/26864/","msgid":"<168122390613.2373830.11516323679029638381@Monstersaurus>","date":"2023-04-11T14:38:26","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: agc: Add \"shadows\"\n\tconstraint mode","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting David Plowman via libcamera-devel (2023-04-11 10:47:57)\n> The \"shadows\" constraint mode actually exists in a number of tuning\n> files, but had been omitted from the list of supported modes.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9f3f3ac3..9c29fa9a 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -778,6 +778,7 @@ static const std::map MeteringModeTable = {\n> static const std::map ConstraintModeTable = {\n> { controls::ConstraintNormal, \"normal\" },\n> { controls::ConstraintHighlight, \"highlight\" },\n> + { controls::ConstraintShadows, \"shadows\" },\n> { controls::ConstraintCustom, \"custom\" },\n> };\n> \n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C3BEBD1F1\n\tfor ;\n\tTue, 11 Apr 2023 14:38:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9D1C627B8;\n\tTue, 11 Apr 2023 16:38:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1172861EC1\n\tfor ;\n\tTue, 11 Apr 2023 16:38:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 872D6128D;\n\tTue, 11 Apr 2023 16:38:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1681223910;\n\tbh=ZNqVtahBvigxqr4hTnqn6epncCwuEIpNEzTqJRlcCyo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Dcuo7X3JboJjjq+eApXbznFtRkBu8HPRwcjChi8jEP4n+Qi4Gb4pWVz0BRM5UkcZi\n\t7xVmHFthK2dZOoz5vJVa2BDtAlicADyB4G9VchHfpQW+IKl/TSmQSmf3WwUpCrQx7X\n\tYYVQC0nnFdiu/afPdEcBikP2p8OxQM1wNO6TqAFvw+TCxV2UshdpIbRWIZX01olCzR\n\tAHVLdXXg01DRBrI9fPq+EwYqOGUTxPNMrSvLtTRUyvNRyd32MG0gbSh5SjiLdaTV5J\n\tIOXbNagvS9OI6T7gJH9QLI3XaUJjy0VBG80h+cMkrndYIwS4rCiP79KGr0MdJeWMFU\n\t5qtUC6hOON6xA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1681223907;\n\tbh=ZNqVtahBvigxqr4hTnqn6epncCwuEIpNEzTqJRlcCyo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=bNnCw7BbA4xcUJGiZji3qK3UsKmcFPa6soshY1wWPRyRG4QGJwJC/BDf5LO0CmQH7\n\ta5yGNCmgdG89cgtVgAWSE9oH5OYU19cJLjeOBBrSzZhusL+j0qIzPM05u4bsb9PD62\n\tv6Qik+QPR9yt85CrY/YBTUBcGmA7l11JEFv6no9U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bNnCw7Bb\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230411094757.29143-1-david.plowman@raspberrypi.com>","References":"<20230411094757.29143-1-david.plowman@raspberrypi.com>","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 11 Apr 2023 15:38:26 +0100","Message-ID":"<168122390613.2373830.11516323679029638381@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: agc: Add \"shadows\"\n\tconstraint mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26868,"web_url":"https://patchwork.libcamera.org/comment/26868/","msgid":"<20230412085601.GQ11253@pendragon.ideasonboard.com>","date":"2023-04-12T08:56:01","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: agc: Add \"shadows\"\n\tconstraint mode","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Tue, Apr 11, 2023 at 10:47:57AM +0100, David Plowman via libcamera-devel wrote:\n> The \"shadows\" constraint mode actually exists in a number of tuning\n> files, but had been omitted from the list of supported modes.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 9f3f3ac3..9c29fa9a 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -778,6 +778,7 @@ static const std::map MeteringModeTable = {\n> static const std::map ConstraintModeTable = {\n> \t{ controls::ConstraintNormal, \"normal\" },\n> \t{ controls::ConstraintHighlight, \"highlight\" },\n> +\t{ controls::ConstraintShadows, \"shadows\" },\n> \t{ controls::ConstraintCustom, \"custom\" },\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 960EFBD1F1\n\tfor ;\n\tWed, 12 Apr 2023 08:55:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01506627B2;\n\tWed, 12 Apr 2023 10:55:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70873627B1\n\tfor ;\n\tWed, 12 Apr 2023 10:55:51 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A5D526195;\n\tWed, 12 Apr 2023 10:55:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1681289753;\n\tbh=bVaDlhUZGhmRzqayWrGX6YgQ+2i7z9OQyn4BVXHU70I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XupXDQkTTHP9WNNwnk+ANJsZwYX/rwc5v/ZabE0rQfu+OHypzsmjoi9U3/1/gXNWd\n\ttQhbJLPEIJ4mrFr9pwcawLGV2SlqzEbvgI8yZgJWv2uj4Oyhn8tsBHbaRyQupo1nne\n\tYHb0pVDydtGqpGh1USnKdvJrtGjUAi3mn0ZAikuHJSOyth96NeH0RZRFZ1JRCcpixY\n\tjcb+LGIV9j5TyGKH2EpfyO/baJLKmAIVg+bG3cDz2CGLZZa9S2X2XFeh+V7PKa6zEB\n\tvtIcVD0N8CdbnaL/3Iqwi7TIvldul5vndbwbRSXyRm1IiuTpEBJ0YMFJf3yYvax404\n\to2nhSs+A4zCXQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1681289749;\n\tbh=bVaDlhUZGhmRzqayWrGX6YgQ+2i7z9OQyn4BVXHU70I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dtHJLPojyUbsmSgra5tUIzHHYRGOhEpgbJPduNw65G83oOjJ1FA5FRixd8vNq9eyb\n\t/bj0rQg+SnlRF+Y5PBPVk6RXkR/yaDb6uCoXnQxQe27oTNRxaEBFKWvhbuoXemdGsp\n\tpQPEY8pcZZPq7SbJ8inW9SrYBoN26MShiu0RVbiU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dtHJLPoj\"; dkim-atps=neutral","Date":"Wed, 12 Apr 2023 11:56:01 +0300","To":"David Plowman ","Message-ID":"<20230412085601.GQ11253@pendragon.ideasonboard.com>","References":"<20230411094757.29143-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230411094757.29143-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: agc: Add \"shadows\"\n\tconstraint mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]