{"id":18534,"url":"https://patchwork.libcamera.org/api/patches/18534/?format=json","web_url":"https://patchwork.libcamera.org/patch/18534/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230411094757.29143-1-david.plowman@raspberrypi.com>","date":"2023-04-11T09:47:57","name":"[libcamera-devel] ipa: raspberrypi: agc: Add \"shadows\" constraint mode","commit_ref":"98fc381c68a372b78260b2940411a64ea9e5011c","pull_url":null,"state":"accepted","archived":false,"hash":"b6207010606d84e396c62efb8de82774dc1672fc","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18534/mbox/","series":[{"id":3839,"url":"https://patchwork.libcamera.org/api/series/3839/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3839","date":"2023-04-11T09:47:57","name":"[libcamera-devel] ipa: raspberrypi: agc: Add \"shadows\" constraint mode","version":1,"mbox":"https://patchwork.libcamera.org/series/3839/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18534/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18534/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4150DC0F2A\n\tfor ;\n\tTue, 11 Apr 2023 09:48:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E374627B8;\n\tTue, 11 Apr 2023 11:48:04 +0200 (CEST)","from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com\n\t[IPv6:2607:f8b0:4864:20::22a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AA2261EC0\n\tfor ;\n\tTue, 11 Apr 2023 11:48:01 +0200 (CEST)","by mail-oi1-x22a.google.com with SMTP id e9so4971911oig.7\n\tfor ;\n\tTue, 11 Apr 2023 02:48:01 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:2bce:64d6:1a5c:49a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tbj22-20020a056808199600b0038733b00a5fsm5323371oib.10.2023.04.11.02.47.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 11 Apr 2023 02:48:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1681206484;\n\tbh=8XEDCXQfOjPgOWLBPfggNSbRwR+Aq62wqhQnb0YJhKk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=ZVAZm5ABS+e0dldh734MvWY1ZG5bQXU/n2Eu0vL3fX3x2PVxXahS7rBQKxVJu8SFX\n\taE53w3u25bs8xEF5wQbjOMt/7OeZxR3k7K957NaMk8JlzNteXorFYMg2/ZHTib0Q+A\n\t2Tpvmji4AUQYRifiJA2TfjbxH3Jtlgs1pP1zycSF9uDXoKr0FSyCNWSeKF3H3AVTZB\n\t+F/HGQ5qkwz2+Pl1ehiQugZD9HUuSP0SZTYq8/bJRMkMOwO37wQStOo54nVr6acMNe\n\tLjEmIfP9YDCyMccOZMJ+zBqhUeykGbniDJhD9wpHtmMx/MAgpU4QOigpPQp7sbTIpA\n\tON6rUmPzVH0iA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1681206480;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=NtMLchH6b0RINrQnDbnIFD/hD6pC01Y6NwJRR5Cqbkg=;\n\tb=I1S/pENG5LFvCJ723SDZJCoU8U7hSe9lUFB4t55XhpRQlvQIburyy2b4uxppEEnCWf\n\tksmZ/PCx/FRSHZvhxWszscDslb/tLGTQ8fm9Rdhl+Vud/61g9UOYloqOALMdm6NPMhOg\n\tSNdN8nzC3GjNGwM03XxQbQQkfQfAMha6cFDb+fvb5bci23v2RoElIcH35aIvCdDrtMXU\n\tC8i31bIGDyhHNpkUrfjX8k0jzNo9UJ6A2s1edaK0IOzYywk26YdjEr0YOH+NPM4VjLa5\n\tXnDmFj3sBOrBOVW9Ry54GN/3daLUpwp3dmtGuqHDa2dvOvcmFIBhpFKRXZYRXGfHthdS\n\tchgg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"I1S/pENG\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1681206480;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=NtMLchH6b0RINrQnDbnIFD/hD6pC01Y6NwJRR5Cqbkg=;\n\tb=ghtc2k49TfNH6rPB3Q7dUpej9sfHUuhzu1XjNCdUk5oS+AGnMXWk/e+0Ps0ICpg3Bv\n\toMUXNVRT59bNk/PeKBRYWZZzqATRjhGis0OSbTnoZWUeHqR9c+kZO9IEyL77YSaOvQYj\n\tRXvaBeh9zfSJQXpMpptnRhDM75zZkRinztJhuXu2CWqebyRHwnSE+OHcaRPoou/LrSxm\n\tlNeC6pATodhAWin1KkIqVI7E09H3+Ijj37+hcu3KtsQ89c3o2I7KbauvKQWEWeAqfrB4\n\t1F34Se7xhAiWFgpCVuvtvA3x98I8m6D6x0a4EEVlwckjzqPqKM7rNxnJDb7049LMK5my\n\tqucQ==","X-Gm-Message-State":"AAQBX9cxymKWhrNHwnap3McG/tIUj6x8z2IlmdlrLlRyPLE4FD13UGy3\n\tTwVu/O0CZpiQ0ZDyfNQnn44+yCL6r9sKK/9JY5Y=","X-Google-Smtp-Source":"AKy350Zh8IpaJDoVYl/MYMpGHhj5jOcIFyDXTwnl3n6ZZyqEQH7srz2OHeTBawXtNUgbSOLYoAZyqw==","X-Received":"by 2002:a54:460d:0:b0:389:21:9483 with SMTP id\n\tp13-20020a54460d000000b0038900219483mr6444617oip.59.1681206480443; \n\tTue, 11 Apr 2023 02:48:00 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 11 Apr 2023 10:47:57 +0100","Message-Id":"<20230411094757.29143-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: agc: Add \"shadows\"\n\tconstraint mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The \"shadows\" constraint mode actually exists in a number of tuning\nfiles, but had been omitted from the list of supported modes.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 9f3f3ac3..9c29fa9a 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -778,6 +778,7 @@ static const std::map MeteringModeTable = {\n static const std::map ConstraintModeTable = {\n \t{ controls::ConstraintNormal, \"normal\" },\n \t{ controls::ConstraintHighlight, \"highlight\" },\n+\t{ controls::ConstraintShadows, \"shadows\" },\n \t{ controls::ConstraintCustom, \"custom\" },\n };\n \n","prefixes":["libcamera-devel"]}