[{"id":2503,"web_url":"https://patchwork.libcamera.org/comment/2503/","msgid":"<20190822034240.GA4818@localhost.localdomain>","date":"2019-08-22T03:42:40","subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: process: Properly\n\tignore unused result with gcc","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Mon, Aug 19, 2019 at 08:02:48PM +0300, Laurent Pinchart wrote:\n> Casting the return value of a function to (void) doesn't ignore the\n> unused result warning with gcc. Use a #pragma to fix this properly, to\n> fix compilation with _FORTIFY_SOURCE.\n> \n> Fixes: df23ab95f3d7 (\"libcamera: process: fix compilation on Chromium OS\")\n> Signed-off-by: Laurent Pinchart \n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/process.cpp | 11 ++++++++---\n> 1 file changed, 8 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index ab716a9cd57f..3b4d0f10da67 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -68,10 +68,15 @@ namespace {\n> \n> void sigact(int signal, siginfo_t *info, void *ucontext)\n> {\n> +#pragma GCC diagnostic push\n> +#pragma GCC diagnostic ignored \"-Wunused-result\"\n> +\t/*\n> +\t * We're in a signal handler so we can't log any message, and we need\n> +\t * to continue anyway.\n> +\t */\n> \tchar data = 0;\n> -\t/* We're in a signal handler so we can't log any message,\n> -\t * and we need to continue anyway. */\n> -\t(void)write(ProcessManager::instance()->writePipe(), &data, sizeof(data));\n> +\twrite(ProcessManager::instance()->writePipe(), &data, sizeof(data));\n> +#pragma GCC diagnostic pop\n> \n> \tconst struct sigaction &oldsa = ProcessManager::instance()->oldsa();\n> \tif (oldsa.sa_flags & SA_SIGINFO) {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 710CA60C37\n\tfor ;\n\tThu, 22 Aug 2019 05:42:47 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.247])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8DB092DF;\n\tThu, 22 Aug 2019 05:42:46 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566445366;\n\tbh=91rgSziVeO4J0Ym+aQWu/GWCDF07xIgbCIRJOqM/uWc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dcKcaqJmqyHT00yOYIdt89t0BxoQV/HLGO6s0UH7ZytMFucAQLLI2oyRKjz2M1qtH\n\tGav5l0/ln7WCymYa9yfuQzDJVQtluT0w38ep1o9yCPaNwrOGr/zTccHcOGojg4SuHV\n\tY0iVwVtwYNDfp5Tkna5IokyaJ9FZo9RXUh83nn5Y=","Date":"Wed, 21 Aug 2019 22:42:40 -0500","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190822034240.GA4818@localhost.localdomain>","References":"<20190819170249.11177-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190819170249.11177-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: process: Properly\n\tignore unused result with gcc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 22 Aug 2019 03:42:47 -0000"}}]