{"id":18503,"url":"https://patchwork.libcamera.org/api/patches/18503/?format=json","web_url":"https://patchwork.libcamera.org/patch/18503/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230331072341.24851-8-naush@raspberrypi.com>","date":"2023-03-31T07:23:38","name":"[libcamera-devel,v3,07/10] ipa: raspberrypi: Make RegionStats::get() always return a Region struct","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"842e21d8cfb2d6952a1793bc4bcd91153d11ca4f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18503/mbox/","series":[{"id":3830,"url":"https://patchwork.libcamera.org/api/series/3830/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3830","date":"2023-03-31T07:23:31","name":"Raspberry Pi: Generalised algorithms","version":3,"mbox":"https://patchwork.libcamera.org/series/3830/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18503/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18503/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE437C0F2A\n\tfor ;\n\tFri, 31 Mar 2023 07:40:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 666C5627A9;\n\tFri, 31 Mar 2023 09:40:59 +0200 (CEST)","from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com\n\t[IPv6:2607:f8b0:4864:20::d2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84D6062769\n\tfor ;\n\tFri, 31 Mar 2023 09:40:56 +0200 (CEST)","by mail-io1-xd2c.google.com with SMTP id o10so1231212iou.5\n\tfor ;\n\tFri, 31 Mar 2023 00:40:56 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ti17-20020a6bf411000000b0074555814e73sm421943iog.32.2023.03.31.00.40.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 31 Mar 2023 00:40:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680248459;\n\tbh=aRIc5B+sTvytGlTffgEhxKt6BpAyCyw6+uqLU6iJiI8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ASJMENd2Us13D6WNRD/flt85Q5LlVRWju0bw06xS3O0uDLdiXDhvAEzLtVZZrC3IK\n\t6U4aff3bHDJ3HV4HOtzDdlqxdTCKY5ClhKaBPuCxJTLkGxowKTlTAoGQoc3K8cFIgp\n\tsXaxregnGLPhp7YgBvBs9RsslUScNfls18KyBkue7igELVmhXQ4J7OdiA8AG/5el5S\n\tOE2nZMCPFuiShZrMENP4Rn9ngYo98f+o7ZYvqQr0st3tKFvKCyE5siY93EX5BjE5jp\n\t4SYOQX2FQFQ35Yi+1XrvUMXqZ0dssaP3pvGXKb6hJZuM4jMk38oob93urR4KZ63sZU\n\tKU3TjCDsbPKJA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1680248455;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=quqiaExFAgBviDMcf8Asfps18bCBmhdSNFsVml+XS2A=;\n\tb=UCP/xSWfbrbAC9mFZ65jEjzT3b5Q0PRWpBfFNWWEBTYvc5ufKV1pLHOVA9INugRdyC\n\tlLYrMCs5hCByYTjjUBgn34fP9BmOQpwNmoCJkzqDJXNONrfAFeVhlYnd3zgeIJysN2lm\n\tuodClJ62zVaxsLwb4ZPbEYD8UmPwvxce8A3Lu+v9WPZWjXArSvd5+KwLtrQSFKzpbqN+\n\tIRb/qRbtfMfwu9lvAq77GlHbgX8smr/lZYduJ/snuavlafnOUK+6k6HoitCU8QmgSCah\n\t8WltIqfiAS3HhlDVmzsQotELQvet9fvaZLP5G8+nUHr97EFIpSnV0AVhDkw3JT77rAqD\n\tP1wg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"UCP/xSWf\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1680248455;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=quqiaExFAgBviDMcf8Asfps18bCBmhdSNFsVml+XS2A=;\n\tb=Dzp/OpUo6fAUZSLeDC6chkeHafmm37j4MhtxRG0TcvjzA/6vE2LZozz+DdbibxhYBw\n\ths/viM10BXXNrfMGQnFost3FSn4ORjdD8GQ5FAS6AZ0bp7GyZDUp4klWv/Kyk5TKGXiL\n\tIkpT0Kd/k3/TflgRyYXrAvUJmCfa6hoq/BQGWUsiJ99hDIAqQyxHpXjEwUm6f74w3HKI\n\t3/eVi/rvHr/qJpNBuVHRkrYp065b6lPfGkECqFBiTxXid+BJY5QICNrGU6gR7X3Y8p2i\n\tS5bqWYwf8R+YyXQFMoGyo8X55R3w0NCuSq/8xqEYweFDl2Fe0FKdF9s++pkrRXwMEcXI\n\tTDZg==","X-Gm-Message-State":"AAQBX9dyPszE2811nc1FbDCU3M+nZbJQU+qiy5Y8i7O/rsu2T4EmFrJS\n\tBKM/3rVUUS8af7s/dJvGnp58yNZybtbYzoqp6e2EvQ==","X-Google-Smtp-Source":"AKy350YgAvyT+X1lyT6RoIpFou1ecFSKAwdWV69HlqV6+FVErvnxfjrjBzJk/8pqFRyvjNd4WMbjEQ==","X-Received":"by 2002:a05:6602:3806:b0:758:7246:c0f2 with SMTP id\n\tbb6-20020a056602380600b007587246c0f2mr5436867iob.1.1680248454855; \n\tFri, 31 Mar 2023 00:40:54 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 31 Mar 2023 08:23:38 +0100","Message-Id":"<20230331072341.24851-8-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230331072341.24851-1-naush@raspberrypi.com>","References":"<20230331072341.24851-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 07/10] ipa: raspberrypi: Make\n\tRegionStats::get() always return a Region struct","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update the overloaded RegionStats::get() and RegionStats::getFloating()\nmember functions to return a Region struct for consistency.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Jacopo Mondi \n---\n src/ipa/raspberrypi/controller/region_stats.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/region_stats.h b/src/ipa/raspberrypi/controller/region_stats.h\nindex 9aaf3a58a6f7..a8860dc8dba2 100644\n--- a/src/ipa/raspberrypi/controller/region_stats.h\n+++ b/src/ipa/raspberrypi/controller/region_stats.h\n@@ -86,12 +86,12 @@ public:\n \t\treturn get_(index);\n \t}\n \n-\tconst T &get(const libcamera::Point &pos) const\n+\tconst Region &get(const libcamera::Point &pos) const\n \t{\n \t\treturn get(pos.y * size_.width + pos.x);\n \t}\n \n-\tconst T &getFloating(unsigned int index) const\n+\tconst Region &getFloating(unsigned int index) const\n \t{\n \t\tif (index >= numFloatingRegions())\n \t\t\treturn default_;\n","prefixes":["libcamera-devel","v3","07/10"]}