[{"id":26852,"web_url":"https://patchwork.libcamera.org/comment/26852/","msgid":"<20230405045103.GR9915@pendragon.ideasonboard.com>","date":"2023-04-05T04:51:03","subject":"Re: [libcamera-devel] [PATCH] py: Fix CameraManager.version property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, Mar 30, 2023 at 08:39:56PM +0300, Tomi Valkeinen via libcamera-devel wrote:\n> The current CameraManager.version doesn't work at all (raises a\n> TypeError), as that's not how you use expose C++ static methods as\n> Python class methods.\n> \n> Fix it.\n> \n> Signed-off-by: Tomi Valkeinen \n> Reported-by: @meawoppl:matrix.org\n\nWe can't include people without an e-mail address into the conversation,\ndefeating the point of the Reported-by tag a bit. I'm inclined to drop\nit.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/py_main.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index d14e18e2..c55495cc 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -105,7 +105,7 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t\treturn cm;\n> \t\t})\n> \n> -\t\t.def_property_readonly(\"version\", &PyCameraManager::version)\n> +\t\t.def_property_readonly_static(\"version\", [](py::object /* self */) { return PyCameraManager::version(); })\n> \t\t.def(\"get\", &PyCameraManager::get, py::keep_alive<0, 1>())\n> \t\t.def_property_readonly(\"cameras\", &PyCameraManager::cameras)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79D2FC0F2A\n\tfor ;\n\tWed, 5 Apr 2023 04:50:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6CAA62761;\n\tWed, 5 Apr 2023 06:50:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AFB261EC2\n\tfor ;\n\tWed, 5 Apr 2023 06:50:57 +0200 (CEST)","from pendragon.ideasonboard.com (fp76f193f3.tkyc206.ap.nuro.jp\n\t[118.241.147.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A75F4308;\n\tWed, 5 Apr 2023 06:50:55 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680670257;\n\tbh=vvQ7rE4jOazFsDY+wAC+HY/HdwMdsE/6Ch9fWdwIe5s=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=M+jbsYqWBbSeF+cyq0RA+eXALb7UR/7CA5ATcS/XYOEy7bXw4oez6fu6ZMizvdCmr\n\taCtRAs3VWkdXRpxZYmh6zPUbxQzQZRpLo9/k+fbhKBjlvuWTFdEvF8pkvEBzkg5udI\n\twbWnvnV9PfbONqRrqjVgt24M5LP6vGvfTDgeMO+fZMUlwdwJDnQq2V6wp/ZGAo4WV5\n\tPejmaf0n71KwNZWM4dGjJ/aMLpVtCODPVzCx4ol17CPua/u6cWoVQPIVhkDjvobbbu\n\t7mlkUVScu28zgveeO78vrwJrZqPoXJuYDnUAqXa0XAG9aWepN2w5wiKPOSY/LGMl6h\n\tfAoJrcL+jfR8g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1680670256;\n\tbh=vvQ7rE4jOazFsDY+wAC+HY/HdwMdsE/6Ch9fWdwIe5s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k5vr/7AhAnuCdFgKRy5VIt4lJ35c9NR8QMgoEUpeglfwMzvSpwK/lQAimCQmOcby1\n\tJbKDKoUNCLPA3KGBu3nUE4B8K0Tdp6y+tDiEocvXVIPx+OuC6r/oqmNX7BaSnp+J+R\n\tIT1VHlNUTZoX2IOwK6RrDvWTmRXRDGWpjA/Nn7L4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"k5vr/7Ah\"; dkim-atps=neutral","Date":"Wed, 5 Apr 2023 07:51:03 +0300","To":"Tomi Valkeinen ","Message-ID":"<20230405045103.GR9915@pendragon.ideasonboard.com>","References":"<20230330173956.417714-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230330173956.417714-1-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] py: Fix CameraManager.version property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26853,"web_url":"https://patchwork.libcamera.org/comment/26853/","msgid":"<20230405045309.GS9915@pendragon.ideasonboard.com>","date":"2023-04-05T04:53:09","subject":"Re: [libcamera-devel] [PATCH] py: Fix CameraManager.version property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Apr 05, 2023 at 07:51:03AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Hi Tomi,\n> \n> Thank you for the patch.\n> \n> On Thu, Mar 30, 2023 at 08:39:56PM +0300, Tomi Valkeinen via libcamera-devel wrote:\n> > The current CameraManager.version doesn't work at all (raises a\n> > TypeError), as that's not how you use expose C++ static methods as\n> > Python class methods.\n> > \n> > Fix it.\n> > \n> > Signed-off-by: Tomi Valkeinen \n> > Reported-by: @meawoppl:matrix.org\n> \n> We can't include people without an e-mail address into the conversation,\n> defeating the point of the Reported-by tag a bit. I'm inclined to drop\n> it.\n> \n> Reviewed-by: Laurent Pinchart \n\nAlso, could you extend the python bindings unit test to access\nCameraManager.verion ?\n\n> > ---\n> > src/py/libcamera/py_main.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> > index d14e18e2..c55495cc 100644\n> > --- a/src/py/libcamera/py_main.cpp\n> > +++ b/src/py/libcamera/py_main.cpp\n> > @@ -105,7 +105,7 @@ PYBIND11_MODULE(_libcamera, m)\n> > \t\t\treturn cm;\n> > \t\t})\n> > \n> > -\t\t.def_property_readonly(\"version\", &PyCameraManager::version)\n> > +\t\t.def_property_readonly_static(\"version\", [](py::object /* self */) { return PyCameraManager::version(); })\n> > \t\t.def(\"get\", &PyCameraManager::get, py::keep_alive<0, 1>())\n> > \t\t.def_property_readonly(\"cameras\", &PyCameraManager::cameras)\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26AF2C0F2A\n\tfor ;\n\tWed, 5 Apr 2023 04:53:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8500462761;\n\tWed, 5 Apr 2023 06:53:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46A7B61EC2\n\tfor ;\n\tWed, 5 Apr 2023 06:53:02 +0200 (CEST)","from pendragon.ideasonboard.com (fp76f193f3.tkyc206.ap.nuro.jp\n\t[118.241.147.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCA7C5B8;\n\tWed, 5 Apr 2023 06:53:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680670383;\n\tbh=CYBHqPxaQXmP1412Iymx+FNpGsXD8KXFA4OenJIqS98=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=y8TMDP5cZiCIHcS6QY3f/U4qMb1YY+bg1IsIWG7vP+bGNCyztEvw0uWlLLIafrwGI\n\tGH1GD0833LZtrXs2HA9sTTT8dBCtzbEhVyHCgWHbGDcPHpoBGfEHELGhEdPhFO5SqL\n\twMEfltq4HrQow+5zKStOVYApIWJ0N8Mg4lMBJ2/UjWxJ1BofLWgAWEh4bXNkkSStaF\n\t5L4P0H6/mETUDMXy42HI+xvlKYEPgO1dEkz3URHn5BrUcx32FQlLgWmD5V6MVawQxK\n\tF2SYSjnwgnmi5nTwWOnjX696rt8bg55ObRk7808ymg074axSAv8+OglSEjOxpw8xVu\n\tM0fiIJ9EtwFkA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1680670382;\n\tbh=CYBHqPxaQXmP1412Iymx+FNpGsXD8KXFA4OenJIqS98=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=buuQC2P70+mQaGfjvNW4JY0ft5/XwQdsQ5phjRA+TO/dSrM8Edo7GJqVVAy/DLQC4\n\tkLmSslodAzfNKIq4ef6Z9f1Lr7KECJjv8SvWs5t9YxRblw2TBLDUVYE8b/GZrEh1Jf\n\tNfdhwLjCCH+EdKAR/wvcyF/DznsxlJRxbIyDHe4A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"buuQC2P7\"; dkim-atps=neutral","Date":"Wed, 5 Apr 2023 07:53:09 +0300","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20230405045309.GS9915@pendragon.ideasonboard.com>","References":"<20230330173956.417714-1-tomi.valkeinen@ideasonboard.com>\n\t<20230405045103.GR9915@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230405045103.GR9915@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] py: Fix CameraManager.version property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]