{"id":18495,"url":"https://patchwork.libcamera.org/api/patches/18495/?format=json","web_url":"https://patchwork.libcamera.org/patch/18495/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230330173956.417714-1-tomi.valkeinen@ideasonboard.com>","date":"2023-03-30T17:39:56","name":"[libcamera-devel] py: Fix CameraManager.version property","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e7bfd3ce70a086b4470d83b351c15ea60fdfe147","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18495/mbox/","series":[{"id":3829,"url":"https://patchwork.libcamera.org/api/series/3829/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3829","date":"2023-03-30T17:39:56","name":"[libcamera-devel] py: Fix CameraManager.version property","version":1,"mbox":"https://patchwork.libcamera.org/series/3829/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18495/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18495/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60282C0F2A\n\tfor ;\n\tThu, 30 Mar 2023 17:41:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7EC361EC7;\n\tThu, 30 Mar 2023 19:41:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13AAC603A6\n\tfor ;\n\tThu, 30 Mar 2023 19:41:20 +0200 (CEST)","from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51E4A6E1;\n\tThu, 30 Mar 2023 19:41:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680198081;\n\tbh=CujWuRgvypGCrHrnfGRtkdyPYPHMbCLBek9PHHn2QrA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=XeZKhVut1bvpmEiUp1uV1djyPRLpDRC868G/+xkrn43J6hWlZr2olxR8T6hnaOeJl\n\tUUnL/uokxT2hTQFImYbqm04AtogLD9g/0BNkJMEkNUJzLTzJxMna75SZy/KtppdQEr\n\tI2+8Y1PBByVhDTYDGOzcjB8RRvym0KT9QEHNTGolG4lQ2PN7ltFCx9QU4CqMq7QMYO\n\tGL9MstBZezRJufmiUqvgGS9V1PFqm+pITIkBsS1e/fN6Fv7wdRv8gw2PYwmD5fMWWy\n\tHYR7g1WFKJ9B/PjVLpFX08viJQQc7aWkU6skHsaVsrDOfmXaz4FF7mmplaifzFU67M\n\tJ+CNtYCucRPdA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1680198079;\n\tbh=CujWuRgvypGCrHrnfGRtkdyPYPHMbCLBek9PHHn2QrA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=X2mJOhjxdYZb9FHmL909rxTHINfvMMZVnitvSAjpOkdVQkvYlWyhCQ70yDE2e3a71\n\tzDrV8UNAwXgs/weKVQO6/VtuX4/NFNqKKsX5mXWWmIh+0nRn8Jr7KN/08ZP7D3vQop\n\tiUC77qSzER9y9Pv80YYaUrav2FLt3fD5yhbs+BZo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X2mJOhjx\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Mar 2023 20:39:56 +0300","Message-Id":"<20230330173956.417714-1-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] py: Fix CameraManager.version property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The current CameraManager.version doesn't work at all (raises a\nTypeError), as that's not how you use expose C++ static methods as\nPython class methods.\n\nFix it.\n\nSigned-off-by: Tomi Valkeinen \nReported-by: @meawoppl:matrix.org\n---\n src/py/libcamera/py_main.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex d14e18e2..c55495cc 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -105,7 +105,7 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t\treturn cm;\n \t\t})\n \n-\t\t.def_property_readonly(\"version\", &PyCameraManager::version)\n+\t\t.def_property_readonly_static(\"version\", [](py::object /* self */) { return PyCameraManager::version(); })\n \t\t.def(\"get\", &PyCameraManager::get, py::keep_alive<0, 1>())\n \t\t.def_property_readonly(\"cameras\", &PyCameraManager::cameras)\n \n","prefixes":["libcamera-devel"]}