[{"id":26796,"web_url":"https://patchwork.libcamera.org/comment/26796/","msgid":"<168017330784.765114.11689492927181280270@Monstersaurus>","date":"2023-03-30T10:48:27","subject":"Re: [libcamera-devel] [PATCH v2] doc: ipa: Clarify IPA acronym in\n\tits namespace description","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Gabby George via libcamera-devel (2023-03-29 04:13:45)\n> Clarifies IPA's acronym by specifying what \"IPA\" stands for as part of the ipa namespaces' \"brief\" doxygen-generated description. This allows visitors to the docs to immediately have an idea of the purpose of the IPA namespace at a glance. Because of the prevalence and importance of the IPA namespace and functionality, the fact that it stands for \"Image Processing Algorithm\" should be accessible to even casual perusers of the docs.\n> \n\nThat's a much more reasonable message, thanks.\n\nPoint 6 at https://cbea.ms/git-commit/#wrap-72 highlights that commits\nshould usually be wrapped at 72 characters. Your commit is all written\nas a single line presently. It can be wrapped when applying so it's not\na blocker, but please consider this for future patches.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Gabby George \n> ---\n> src/ipa/libipa/module.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp\n> index 77352104..ee01f12a 100644\n> --- a/src/ipa/libipa/module.cpp\n> +++ b/src/ipa/libipa/module.cpp\n> @@ -17,7 +17,7 @@ namespace libcamera {\n> LOG_DEFINE_CATEGORY(IPAModuleAlgo)\n> \n> /**\n> - * \\brief The IPA namespace\n> + * \\brief The IPA (Image Processing Algorithm) namespace\n> *\n> * The IPA namespace groups all types specific to IPA modules. It serves as the\n> * top-level namespace for the IPA library libipa, and also contains\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99D7FC326B\n\tfor ;\n\tThu, 30 Mar 2023 10:48:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0053E6274E;\n\tThu, 30 Mar 2023 12:48:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ECE2626E2\n\tfor ;\n\tThu, 30 Mar 2023 12:48:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84D16576;\n\tThu, 30 Mar 2023 12:48:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680173312;\n\tbh=zWqHtUtDcPnYhvTc3XIPkIUOuRuBTWfztMSTde3KPZs=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1u92p7ETMFLND+MuiFZXyN4rKVacpRuGS+Jf0QZnlTjmQ6u/gjUTVKIp1ausevZLa\n\tSgowOylMIFRqN36IJcT7I6sAOyTvDBSa8hxGCYbYRWStp1M9FzANDFmpKR1JxvRuQz\n\tZqscnCgN7dTgRUTInCtATNQB4dLDRAMSgFlmJ/l3YqRnHDNkRy0tUXLlypcR2vXSup\n\tPnSsvqcpZGW4xss8hIU/StM+zieyqYSZhpKgNgHF8Ef137+6IfrEVUOlK0q9Fbx3Um\n\tSl3ozcOCqJWkLus7qt6K3PPG3XqKSGjRatUI76dg3qotWC44mNgVa/42gZ+SM2/oCH\n\t9Wr0QlyATn7mw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1680173310;\n\tbh=zWqHtUtDcPnYhvTc3XIPkIUOuRuBTWfztMSTde3KPZs=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=gTkvtzi59lzk8OZiBAeUa/+r7XoSClmnBgvm+khZC7G2JHid3CT4sEfQOvR7Qn+gA\n\t1O0iVsyUr7vPvBSrssbdkXyu5oQdBnM4pIWqEYY+Uq/QMVpYnMMyg3AoiMVfUmafmJ\n\t9pDqLC6bBlkZYinYqMXfa0bqF2zj5mxu20ynpoJ4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gTkvtzi5\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230329031345.42867-1-gabbymg94@gmail.com>","References":"<20230329031345.42867-1-gabbymg94@gmail.com>","To":"Gabby George , libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Mar 2023 11:48:27 +0100","Message-ID":"<168017330784.765114.11689492927181280270@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2] doc: ipa: Clarify IPA acronym in\n\tits namespace description","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26854,"web_url":"https://patchwork.libcamera.org/comment/26854/","msgid":"<20230405052308.GU9915@pendragon.ideasonboard.com>","date":"2023-04-05T05:23:08","subject":"Re: [libcamera-devel] [PATCH v2] doc: ipa: Clarify IPA acronym in\n\tits namespace description","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Mar 30, 2023 at 11:48:27AM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Gabby George via libcamera-devel (2023-03-29 04:13:45)\n> > Clarifies IPA's acronym by specifying what \"IPA\" stands for as part of the ipa namespaces' \"brief\" doxygen-generated description. This allows visitors to the docs to immediately have an idea of the purpose of the IPA namespace at a glance. Because of the prevalence and importance of the IPA namespace and functionality, the fact that it stands for \"Image Processing Algorithm\" should be accessible to even casual perusers of the docs.\n> > \n> \n> That's a much more reasonable message, thanks.\n> \n> Point 6 at https://cbea.ms/git-commit/#wrap-72 highlights that commits\n> should usually be wrapped at 72 characters. Your commit is all written\n> as a single line presently. It can be wrapped when applying so it's not\n> a blocker, but please consider this for future patches.\n> \n> Reviewed-by: Kieran Bingham \n\nNo need to resend for this indeed, I'll wrap the commit message when\napplying the patch.\n\nReviewed-by: Laurent Pinchart \n\n> > Signed-off-by: Gabby George \n> > ---\n> > src/ipa/libipa/module.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp\n> > index 77352104..ee01f12a 100644\n> > --- a/src/ipa/libipa/module.cpp\n> > +++ b/src/ipa/libipa/module.cpp\n> > @@ -17,7 +17,7 @@ namespace libcamera {\n> > LOG_DEFINE_CATEGORY(IPAModuleAlgo)\n> > \n> > /**\n> > - * \\brief The IPA namespace\n> > + * \\brief The IPA (Image Processing Algorithm) namespace\n> > *\n> > * The IPA namespace groups all types specific to IPA modules. It serves as the\n> > * top-level namespace for the IPA library libipa, and also contains\n> > -- \n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0936BD808\n\tfor ;\n\tWed, 5 Apr 2023 05:23:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2358662761;\n\tWed, 5 Apr 2023 07:23:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76A2E61EC2\n\tfor ;\n\tWed, 5 Apr 2023 07:23:01 +0200 (CEST)","from pendragon.ideasonboard.com (fp76f193f3.tkyc206.ap.nuro.jp\n\t[118.241.147.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 118758C6;\n\tWed, 5 Apr 2023 07:22:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680672183;\n\tbh=mEJOeKQnze6HfFoEv16Ukwe0S0q8dsaalXFDwONJs9s=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yp04wbaufgHKXOszQzlJXevcDT6XtO/sZPdBcSl4uGIK2gFFGEcB6cAnrcrLY0e9/\n\tWkzlH0dG+GqPWq3HWUXiPmecFbgj/idI/+ECzDupYA40gjdpMJmzFRl4RJisWltaug\n\truxanVqY5PWa4vsQjCDhRs+Ma3wG6EE/jJU0mfAhln7UNi0e3/v+7WA4QTdbzhMLAJ\n\tOfzxPgBlBUr/98KCTunWLcqVr/evu5zJp7p7FJ5qeqSXpwstHb/mCBvlvxtCVN6M8G\n\tmZqhP8d1O6RY8QO5dB4SyFuMboQTed0HrIlrIQLeFiprQIPCOnMVoZJhYd32mj0bas\n\tvge69rnD97Geg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1680672181;\n\tbh=mEJOeKQnze6HfFoEv16Ukwe0S0q8dsaalXFDwONJs9s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IwmuNceqPvqCr7vFXPX30iauE2Oou2qr7KswX/Us+nWXtB0WgDIZgTx9uEbmSogp3\n\t4GPLx/Z0r+BcWJFZjmEZDSZnWOQ6YBTX5gt+9jMg+oa2aXAkxzGAxRc5E+v2qgPuf4\n\tFBP1jaCc/HRVmm/MP3Qxg1bPMQr6kyCB2ZAglA3U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IwmuNceq\"; dkim-atps=neutral","Date":"Wed, 5 Apr 2023 08:23:08 +0300","To":"Kieran Bingham ","Message-ID":"<20230405052308.GU9915@pendragon.ideasonboard.com>","References":"<20230329031345.42867-1-gabbymg94@gmail.com>\n\t<168017330784.765114.11689492927181280270@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<168017330784.765114.11689492927181280270@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v2] doc: ipa: Clarify IPA acronym in\n\tits namespace description","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]